Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add ControllerTests to OIS unit-tests #23747

Open
ATmobica opened this issue Nov 24, 2022 · 4 comments
Open

[Feature] Add ControllerTests to OIS unit-tests #23747

ATmobica opened this issue Nov 24, 2022 · 4 comments
Assignees
@ATmobica

Comments

@ATmobica
Copy link
Contributor

ATmobica commented Nov 24, 2022 •
edited
Loading

Feature description

Building ControllerTest fails for OIS unit tests.
The python environment for generating the data model is wrong, not contain the required packages.

FAILED: gen/src/controller/data_model/app/PluginApplicationCallbacks.h gen/src/controller/data_model/app/callback-stub.cpp 
/workspaces/CHIP/.environment/pigweed-venv/bin/python3.9 ../../../../../../third_party/pigweed/repo/pw_build/py/pw_build/python_runner.py --gn-root ../../../../../../ --current-path ../../../../../controller/data_model --default-toolchain=//config/openiotsdk/chip-gn/toolchain:openiotsdk --current-toolchain=//config/openiotsdk/chip-gn/toolchain:openiotsdk --capture-output --python-virtualenv-config python/gen/third_party/pigweed/repo/pw_env_setup/pigweed_build_venv/venv_metadata.json --python-dep-list-files gen/src/controller/data_model/data_model_codegen_metadata_path_list.txt -- ../../../../../../scripts/codegen.py --generator cpp-app --output-dir gen/src/controller/data_model --expected-outputs gen/src/controller/data_model/data_model_codegen.expected.outputs ../../../../../controller/data_model/controller-clusters.matter
Traceback (most recent call last):
  File "/workspaces/CHIP/src/test_driver/openiotsdk/unit-tests/build/chip_build/../../../../../../scripts/codegen.py", line 16, in <module>
    import click
ModuleNotFoundError: No module named 'click'

There are also issues with TestReadChunking and TestWriteChunking which fail in specific use cases.
For now, the ControllerTest is skipped. We need to investigate and fix all issues.
@ATmobica
Copy link
Contributor Author

@pan-
@andreilitvin Please, assign this issue to me. I'll deal with it soon.

ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Nov 24, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
d48a6c5 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
@ATmobica ATmobica mentioned this issue Nov 24, 2022
Merged
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Nov 24, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
9af7169 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Nov 24, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
ccfc9e4 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Nov 30, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
c7954d1 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Nov 30, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
0bbc1f7 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Dec 2, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
644ae1a 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Dec 2, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
f05ef12 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Dec 2, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
27ad02f 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Dec 5, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
abcaebe 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
ATmobica added a commit to ARM-software/connectedhomeip that referenced this issue Dec 5, 2022
@ATmobica
[OIS] Add Open IoT SDK unit-tests
c12681c 
Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - project-chip#23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>
andy31415 pushed a commit that referenced this issue Dec 5, 2022
@ATmobica
[OIS] Platform and examples implementation (#23382)
0efd318 
* [OIS] Open IoT SDK build system integration

Add Open IoT SDK build system configuration directory.
Create GN project to build CHIP library for Open IoT SDK port.
Implement CMake file to build and expose CHIP library.
Create python script to build GN arguments file.
Provide mbedtls and LwIP default configuration.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Open IoT SDK platform layer implementation

Add platform layer adaptation files
Open IoT SKD platform layer GN build integration

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Open IoT SDK system layer adaptation

Add cmsis-rtos locking option.
Implement cmsis-rtos system mutex.
Open IoT SDK system layer GN build integration.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Add Open IoT SDK platform to common GN build settings

Propagate Open IoT SDK platform settings in build system
of Matter components.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Open IoT SDK streamer implementation

Add Open IoT SDK shell streamer based on SDK retarget.
Use default shell main loop.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Open IoT SDK examples common

Add Open IoT SDK example platform target that contains source code
shared between examples.
Create common Cmake settings - sdk, chip and linker common cmake files.
Create custome Corstone 300 GCC linker scripts.
Create Corstone 300 FVP configuraiton file.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Open IoT SDK shell example

Implement Open IoT SDK shell example.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Open IoT SDK lock-app example

Implement Open IoT SDK lock-app example.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Open IoT SDK examples helper tools

Add Open IoT SDK example script which allows build and run
supported examples.
Implement OpenIotSdkBuilder Python class with generating and building
examples support.
Add Open IoT SDK targets to Python builder.
Add Open IoT SDK memory configuration to memory script tool.
Add Open IoT SDK VSCode tasks integration - build, run and debug OIS
examples tasks.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Add Open IoT SDK examples workflow

Github workflow to validate Open IoT SDK examples

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Add integration tests for Open IoT SDK examples

Add network setup script to enable/disable the TAP/TUN network
environment. Create TAP/TUN device and bridge interface to connect it
with the ethernet network interface.

Create Pytest implementation of Open IoT SDK examples integration tests.
Implement lock-app and shell examples tests cases.
Add test command to Open IoT SDK example script.
Add integrations tests to CI workflow.
Add Open IoT SDK examples testing to Vscode tasks.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Add Open IoT SDK platform documentation

Create Open IoT SDK platform overview, commissioning approach
description and common examples guide.
Add README files to shell and lock-app examples.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

* [OIS] Add Open IoT SDK unit-tests

Adaptation changes:
Exclude LwIP initialization for Open IoT SDK platform in unit tests
implementation.
Skip read/write chunking tests in controller component.
Skip CommissionerDUTVectors test in credentials component.
Skip ControllerTests - #23747 issue
Skip CHIP stack initialization in FailSafeContext test.

Add Open IoT SDK platform unit-tests application in
src/test_driver/openiotsdk/unit-tests directory.
Add unit tests to Open IoT SDK example script, CI workflow
and VScode tasks.
Add unit-tests application documentation.

Signed-off-by: ATmobica <artur.tynecki@arm.com>

Signed-off-by: ATmobica <artur.tynecki@arm.com>
@stale
Copy link

stale bot commented May 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label May 24, 2023
@stale
Copy link

stale bot commented Jun 10, 2023

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Jun 10, 2023
@andy31415 andy31415 mentioned this issue May 8, 2024
Merged
@andy31415
Copy link
Contributor

This issue still exists.

@andy31415 andy31415 reopened this May 8, 2024
@stale stale bot removed stale Stale issue or PR labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ATmobica ATmobica

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andy31415 @ATmobica