Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform][Silabs][WIFI] Security types still do not match spec #25500

Open
bzbarsky-apple opened this issue Mar 6, 2023 · 4 comments
Open
Assignees
Labels
efr32 spec Mismatch between spec and implementation

Comments

@bzbarsky-apple
Copy link
Contributor

The fix for #25118 wasn't right, as far as I can tell. It's mixing up the scan result security type (which is a bitmap) and the wifi diagnostic security type (which is an enum). See #25458 (review)

@rosahay-silabs @jmartinez-silabs

@bzbarsky-apple bzbarsky-apple added efr32 spec Mismatch between spec and implementation labels Mar 6, 2023
@bzbarsky-apple
Copy link
Contributor Author

@jmeg-sfy

@rosahay-silabs
Copy link
Contributor

@bzbarsky-apple I have replied to your comments, let's take this conversation on slack and once concluded we can post the outcome here and open a PR if required.

@jmeg-sfy
Copy link
Contributor

jmeg-sfy commented Mar 7, 2023

@bzbarsky-apple thanks for catching this up!

rosahay-silabs added a commit to rosahay-silabs/connectedhomeip that referenced this issue Mar 7, 2023
rosahay-silabs added a commit to rosahay-silabs/connectedhomeip that referenced this issue Mar 8, 2023
jepenven-silabs pushed a commit that referenced this issue Mar 9, 2023
* Adds fix for #25500

* Adds missed code change in header of function

* Adds build fix for SiWx917
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
* Adds fix for project-chip#25500

* Adds missed code change in header of function

* Adds build fix for SiWx917
mwswartwout pushed a commit to mwswartwout/connectedhomeip that referenced this issue Mar 27, 2023
* Adds fix for project-chip#25500

* Adds missed code change in header of function

* Adds build fix for SiWx917
@stale
Copy link

stale bot commented Oct 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efr32 spec Mismatch between spec and implementation
Projects
Development

No branches or pull requests

4 participants