Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Address review issues on PR 28836 #29033

Closed
bzbarsky-apple opened this issue Sep 2, 2023 · 2 comments · Fixed by #30554
Closed

[BUG] Address review issues on PR 28836 #29033

bzbarsky-apple opened this issue Sep 2, 2023 · 2 comments · Fixed by #30554
Assignees
@lpbeliveau-silabs
Labels
bug Something isn't working needs triage scenes

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

See #28836 (review) @lpbeliveau-silabs

Bug prevalence

Always

GitHub hash of the SDK that was being used

1ed3897

Platform

core

Platform Version(s)

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple added bug Something isn't working needs triage scenes labels Sep 2, 2023
@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue Sep 5, 2023
Merged
@bzbarsky-apple
Copy link
Contributor Author

Note: #29033 did not fully address this, both because it ignored #28836 (comment) and because of #29076 (comment) @andy31415 @jmartinez-silabs

@lpbeliveau-silabs
Copy link
Contributor

Linking the spec issue opened here: https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/7536
as well as the null level specific issue opened here: #29185

@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue Nov 17, 2023
Merged
@mergify mergify bot closed this as completed in #30554 Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in [Feature] Scenes Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpbeliveau-silabs lpbeliveau-silabs

Labels
bug Something isn't working needs triage scenes
Projects
[Feature] Scenes
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[LevelControl] Level Control Recall null level behavior lpbeliveau-silabs/connectedhomeip
2 participants
@bzbarsky-apple @lpbeliveau-silabs