Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] config-data.yaml uses different formats for cluster names #29186

Closed
rochaferraz opened this issue Sep 12, 2023 · 1 comment · Fixed by #29192
Closed

[Feature] config-data.yaml uses different formats for cluster names #29186

rochaferraz opened this issue Sep 12, 2023 · 1 comment · Fixed by #29192
Labels
feature request feature work needs triage

Comments

@rochaferraz
Copy link
Contributor

Feature description

connectedhome/src/app/common/templates/config-data.yaml has a few top-level tags.

The format of cluster names used by CommandHandlerInterfaceOnlyClusters, DefineBitmaps, WeakEnums seems to be the cluster name with no spaces, converted to CamelCase.

The format used by ClustersWithInitFunctions, ClustersWithAttributeChangedFunctions, ClustersWithShutdownFunctions, and ClustersWithPreAttributeChangeFunctions is the cluster name with spaces and no case conversion: as defined in the cluster XML file.

Current status is quite confusing, and formats should converge

Originally filed as project-chip/zap#1134 @bzbarsky-apple

Platform

all

Platform Version(s)

No response

Anything else?

No response
This was referenced Sep 12, 2023
Closed
Merged
@bzbarsky-apple
Copy link
Contributor

DefineBitmaps and WeakEnums are not cluster names.

Looks like I was somewhat wrong in the ZAP issue; ClustersWith*Functions is handled on the ZAP side. But ClustersWithAttributeChangedFunctions is handled on the Matter side, and we can easily change it to match the others.

bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 12, 2023
@bzbarsky-apple
Be consistent about how we handle cluster names in config-data.yaml.
eb6f8e8 
Use the cluster name as it appears in the XML.

Fixes project-chip#29186
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 12, 2023
@bzbarsky-apple
Be consistent about how we handle cluster names in config-data.yaml.
15e8841 
Use the cluster name as it appears in the XML.

Fixes project-chip#29186
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 12, 2023
Merged
@mergify mergify bot closed this as completed in #29192 Sep 14, 2023
mergify bot pushed a commit that referenced this issue Sep 14, 2023
@bzbarsky-apple
Be consistent about how we handle cluster names in config-data.yaml. (#…
f9d5fa7 
…29192)

Use the cluster name as it appears in the XML.

Fixes #29186
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Be consistent about how we handle cluster names in config-data.yaml. (p…
81dd25a 
…roject-chip#29192)

Use the cluster name as it appears in the XML.

Fixes project-chip#29186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request feature work needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Be consistent about how we handle cluster names in config-data.yaml. bzbarsky-apple/connectedhomeip
2 participants
@rochaferraz @bzbarsky-apple