Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Configuration for CHIP_MINMDNS_HIGH_VERBOSITY looks broken #29215

Closed
bzbarsky-apple opened this issue Sep 13, 2023 · 0 comments · Fixed by #29333
Closed

[BUG] Configuration for CHIP_MINMDNS_HIGH_VERBOSITY looks broken #29215

bzbarsky-apple opened this issue Sep 13, 2023 · 0 comments · Fixed by #29333
Labels
bug Something isn't working linux needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

When compiling with -Wundef, I get:

../../../examples/all-clusters-app/linux/third_party/connectedhomeip/src/lib/address_resolve/AddressResolve_DefaultImpl.cpp:403:5: error: 'CHIP_MINMDNS_HIGH_VERBOSITY' is not defined, evaluates to 0 [-Werror,-Wundef]
#if CHIP_MINMDNS_HIGH_VERBOSITY
    ^

Bug prevalence

Always

GitHub hash of the SDK that was being used

b02c984

Platform

core

Platform Version(s)

No response

Anything else?

No response
@bzbarsky-apple bzbarsky-apple added bug Something isn't working needs triage labels Sep 13, 2023
@github-actions github-actions bot added the linux label Sep 13, 2023
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 13, 2023
Open
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 19, 2023
@bzbarsky-apple
Remove use of CHIP_MINMDNS_HIGH_VERBOSITY from shared resolve code.
cbad6f2 
That define is only available when doing minmdns.

Fixes project-chip#29215
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 19, 2023
Merged
@mergify mergify bot closed this as completed in #29333 Sep 20, 2023
mergify bot pushed a commit that referenced this issue Sep 20, 2023
@bzbarsky-apple
Remove use of CHIP_MINMDNS_HIGH_VERBOSITY from shared resolve code. (#…
b516ff4 
…29333)

That define is only available when doing minmdns.

Fixes #29215
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@bzbarsky-apple @HunsupJung
Remove use of CHIP_MINMDNS_HIGH_VERBOSITY from shared resolve code. (p…
e6c3e4d 
…roject-chip#29333)

That define is only available when doing minmdns.

Fixes project-chip#29215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working linux needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of CHIP_MINMDNS_HIGH_VERBOSITY from shared resolve code. bzbarsky-apple/connectedhomeip
1 participant
@bzbarsky-apple