Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Group Cluster AddGroupCommand does not throw CONSTRAINT ERROR for invalid GroupName #29576

Closed
sumaky opened this issue Oct 5, 2023 · 0 comments · Fixed by #29604
Closed
Assignees
Labels
bug Something isn't working needs triage

Comments

@sumaky
Copy link
Contributor

sumaky commented Oct 5, 2023

Reproduction steps

Specification Groups Cluster
7.1.3. Effect on Receipt

If the server does not support group names, the GroupName field SHALL be ignored.

On receipt of the AddGroup command, the server SHALL perform the following procedure:

**If the command fields are not within constraints, the status SHALL be CONSTRAINT_ERROR, and the server continues from step 6.**

Below Comands to reproduce the issue:

./chip-tool groups add-group 0x0001 Gp1234567891234567 1 0
Response:
AddGroupResponse: {
[1696485836.140742][7733:7736] CHIP:TOO: status: 0
[1696485836.140744][7733:7736] CHIP:TOO: groupID: 1
[1696485836.140746][7733:7736] CHIP:TOO: }

./chip-tool groupkeymanagement read group-table 1 0
OO: GroupTable: 2 entries
[1696485914.486558][7766:7769] CHIP:TOO: [1]: {
[1696485914.486573][7766:7769] CHIP:TOO: GroupId: 1
[1696485914.486591][7766:7769] CHIP:TOO: Endpoints: 1 entries
[1696485914.486601][7766:7769] CHIP:TOO: [1]: 0
[1696485914.486617][7766:7769] CHIP:TOO: GroupName: Gp12345678912345
[1696485914.486632][7766:7769] CHIP:TOO: FabricIndex: 1
[1696485914.486639][7766:7769] CHIP:TOO: }

[1696485914.486652][7766:7769] CHIP:TOO: [2]: {
[1696485914.486659][7766:7769] CHIP:TOO: GroupId: 6
[1696485914.486667][7766:7769] CHIP:TOO: Endpoints: 1 entries
[1696485914.486675][7766:7769] CHIP:TOO: [1]: 0
[1696485914.486685][7766:7769] CHIP:TOO: GroupName: Gp6
[1696485914.486695][7766:7769] CHIP:TOO: FabricIndex: 1
[1696485914.486701][7766:7769] CHIP:TOO: }

Bug prevalence

Always

GitHub hash of the SDK that was being used

NA

Platform

other

Platform Version(s)

NA

Type

Spec Compliance Issue

Anything else?

This bug was identified while updating the test plan for the below issue:
https://github.com/CHIP-Specifications/chip-test-plans/issues/3450

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants