Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QPG] OPENTHREAD_ENABLE_VENDOR_EXTENSION is tested without being defined #29591

Open
bzbarsky-apple opened this issue Oct 5, 2023 · 0 comments
Open

[QPG] OPENTHREAD_ENABLE_VENDOR_EXTENSION is tested without being defined #29591

bzbarsky-apple opened this issue Oct 5, 2023 · 0 comments
Assignees
@tima-q
Labels
needs triage platform

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

Enable -Wundef. https://github.com/project-chip/connectedhomeip/actions/runs/6419947027/job/17430922975?pr=29582

INFO    ../../examples/persistent-storage/qpg/third_party/connectedhomeip/third_party/openthread/repo/src/core/common/extension.hpp:39:5: error: "OPENTHREAD_ENABLE_VENDOR_EXTENSION" is not defined, evaluates to 0 [-Werror=undef]
INFO       39 | #if OPENTHREAD_ENABLE_VENDOR_EXTENSION
INFO          |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@tima-q

Platform

other

Platform Version(s)

No response

Type

CI tested

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response
@tima-q tima-q self-assigned this Oct 5, 2023
tima-q added a commit to tima-q/connectedhomeip that referenced this issue Oct 6, 2023
@tima-q
fix(QPG): Fix any -Wundef errors for qpg based builds (Addresses proj…
c537fd3 
…ect-chip#29591)
tima-q added a commit to tima-q/connectedhomeip that referenced this issue Oct 6, 2023
@tima-q
fix(QPG): Enable -Wundef and fix any errors for qpg based builds (Add…
018f560 
…resses project-chip#29591)
@tima-q tima-q mentioned this issue Oct 6, 2023
Merged
tima-q added a commit to tima-q/connectedhomeip that referenced this issue Oct 6, 2023
@tima-q
fix(QPG): Enable -Wundef and fix any errors for qpg based builds (Add…
671e28f 
…resses project-chip#29591)
tima-q added a commit to tima-q/connectedhomeip that referenced this issue Oct 6, 2023
@tima-q
fix(QPG): Enable -Wundef and fix any errors for qpg based builds (Add…
1ac9b5b 
…resses project-chip#29591)
mergify bot pushed a commit that referenced this issue Oct 6, 2023
@tima-q @restyled-commits
fix(QPG): Enable -Wundef and fix any errors for qpg based builds (#29617
cff70e1 
)

* fix(QPG): Enable -Wundef and fix any errors for qpg based builds (Addresses #29591)

* Restyled by gn

---------

Co-authored-by: Restyled.io <commits@restyled.io>
HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this issue Oct 23, 2023
@tima-q @restyled-commits @HunsupJung
fix(QPG): Enable -Wundef and fix any errors for qpg based builds (pro…
c47abc0 
…ject-chip#29617)

* fix(QPG): Enable -Wundef and fix any errors for qpg based builds (Addresses project-chip#29591)

* Restyled by gn

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tima-q tima-q

Labels
needs triage platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bzbarsky-apple @tima-q