Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Incorrect error returned when attempting to write global attributes #31448

Closed
cecille opened this issue Jan 16, 2024 · 1 comment · Fixed by #31454
Closed

[BUG] Incorrect error returned when attempting to write global attributes #31448

cecille opened this issue Jan 16, 2024 · 1 comment · Fixed by #31454
Assignees
@bzbarsky-apple
Labels
bug Something isn't working needs triage

Comments

@cecille
Copy link
Contributor

cecille commented Jan 16, 2024

Reproduction steps

  • attempt to write a global attribute on a cluster
  • check error code - it should be "UnsupportedWrite", but is actually "UnsupportedAttribute"

Bug prevalence

always

GitHub hash of the SDK that was being used

7ef397e

Platform

core

Platform Version(s)

No response

Anything else?

No response
@cecille cecille added bug Something isn't working needs triage labels Jan 16, 2024
@cecille
Copy link
Contributor Author

cecille commented Jan 16, 2024

Note - fix access checker test once this is addressed.

@bzbarsky-apple bzbarsky-apple self-assigned this Jan 16, 2024
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 16, 2024
@bzbarsky-apple
Fix the error code returned when writing global list attributes.
2f96124 
It should be UNSUPPORTED_WRITE, not UNSUPPORTED_ATTRIBUTE.

Fixes project-chip#31448
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 16, 2024
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 16, 2024
@bzbarsky-apple
Fix the error code returned when writing global list attributes.
c78029a 
It should be UNSUPPORTED_WRITE, not UNSUPPORTED_ATTRIBUTE.

Fixes project-chip#31448
@mergify mergify bot closed this as completed in #31454 Jan 17, 2024
mergify bot pushed a commit that referenced this issue Jan 17, 2024
@bzbarsky-apple
Fix the error code returned when writing global list attributes. (#31454
87e6da0 
)

* Fix the error code returned when writing global list attributes.

It should be UNSUPPORTED_WRITE, not UNSUPPORTED_ATTRIBUTE.

Fixes #31448

* Address review comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the error code returned when writing global list attributes. bzbarsky-apple/connectedhomeip
2 participants
@cecille @bzbarsky-apple