Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After Issue #300 Is Addressed, Move TestInetLayerDNS from noinst_PROGRAMS Back to check_PROGRAMS #329

Closed
gerickson opened this issue Apr 10, 2020 · 8 comments · Fixed by #2644
Closed

After Issue #300 Is Addressed, Move TestInetLayerDNS from noinst_PROGRAMS Back to check_PROGRAMS #329

gerickson opened this issue Apr 10, 2020 · 8 comments · Fixed by #2644
Assignees
@andy31415 @yunhanw-google
Labels
bug Something isn't working build issue testing
Milestone
V1.0

Comments

@gerickson
Copy link
Contributor

After GitHub issue #300 is addressed, move the Inet layer unit and functional test, TestInetLayerDNS from noinst_PROGRAMS back to check_PROGRAMS in src/inet/tests/Makefile.am.
@gerickson gerickson added bug Something isn't working build issue testing labels Apr 10, 2020
@gerickson gerickson self-assigned this Apr 10, 2020
@rwalker-apple rwalker-apple added this to the Morrow milestone Apr 10, 2020
@gerickson gerickson mentioned this issue Apr 24, 2020
Closed
@gerickson gerickson mentioned this issue May 21, 2020
Closed
@woody-apple woody-apple modified the milestones: Not sure when, V1.0 May 26, 2020
@gerickson
Copy link
Contributor Author

We have gone way too long (two-plus months) with out this working.

@gerickson gerickson assigned andy31415 and unassigned gerickson Jun 24, 2020
@gerickson gerickson mentioned this issue Jun 24, 2020
Closed
@gerickson gerickson mentioned this issue Jul 9, 2020
Closed
@gerickson
Copy link
Contributor Author

@yunhanw-google, any updates on this?

@yunhanw-google
Copy link
Contributor

Hi, Grant

The initial happy PR is in #2319 with test_inet_multicast

@yunhanw-google
Copy link
Contributor

It seems we are moving to gn build only for CHIP.

@gerickson
Copy link
Contributor Author

Yes, those are functional tests; however, what about the standalone unit tests that are still broken and have been broken for 5+ months?

@gerickson
Copy link
Contributor Author

Sure, we need to figure out the equivalent action in GN; regardless, the tests need to run.

yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 14, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
ab605a0 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS

Fix project-chip#329
@yunhanw-google yunhanw-google mentioned this issue Sep 14, 2020
Merged
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 15, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
b559982 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add priviledge and host network to enable IPv6 in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 15, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
7bca5a1 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add priviledge and host network to enable IPv6 in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 15, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
68392c1 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add priviledge and host network to enable IPv6 in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
527a952 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add priviledge and host network to enable IPv6 in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
001d238 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add priviledge and host network to enable IPv6 in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
e39ded1 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add priviledge and host network to enable IPv6 in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
1b8c67c 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add IPv6 support in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
203a528 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add IPv6 support in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
9e260c0 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add IPv6 support in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
43d7988 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add IPv6 support in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
1b3d536 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add IPv6 support in docker

Fix project-chip#329
yunhanw-google added a commit to yunhanw-google/connectedhomeip that referenced this issue Sep 16, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS
ba083c1 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add IPv6 support in docker

Fix project-chip#329
woody-apple pushed a commit that referenced this issue Sep 17, 2020
@yunhanw-google
Enable TestInetEndPoint and TestInetLayerDNS (#2644)
15b4c2d 
Problem
Missing TestInetEndPoint and TestInetLayerDNS for Inet layer

Summary of Changes
Add TestInetEndPoint and TestInetLayerDNS
Add IPv6 support in docker

Fix #329
@yunhanw-google
Copy link
Contributor

Sure, we need to figure out the equivalent action in GN; regardless, the tests need to run.

Thanks for the reply, yep, i have enabled the tests in both automake and build gn successfully.

@gerickson
Copy link
Contributor Author

This has been deprecated through the deprecation of autotools-based builds and has been resolved in the GN-based build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andy31415 andy31415

@yunhanw-google yunhanw-google

Labels
bug Something isn't working build issue testing
Projects
None yet
Milestone
V1.0
5 participants
@gerickson @andy31415 @yunhanw-google @woody-apple @rwalker-apple