Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ActionSwitch feature in all-clusters-ap #34304

Closed
tcarmelveilleux opened this issue Jul 11, 2024 · 0 comments · Fixed by #34655
Closed

Implement ActionSwitch feature in all-clusters-ap #34304

tcarmelveilleux opened this issue Jul 11, 2024 · 0 comments · Fixed by #34655
Assignees
@tcarmelveilleux
Labels
TCR

Comments

@tcarmelveilleux
Copy link
Contributor

  • Add new named pipe commands to generate sequence of events properly for AS
  • Add action switch feature to matter file
@tcarmelveilleux tcarmelveilleux self-assigned this Jul 11, 2024
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jul 16, 2024
@tcarmelveilleux
Add an Action Switch endpoint to all-clusters-app
f7a5d43 
- Action Switch is a new feature for a TCR
- Need to have the ZAP files updated before adding the logic to
  reduce review burden.
- Re-ran zap_convert_all.py (some of the changes are due to that)

Issue project-chip#34304

Testing done:

- No regressions of integration tests
@tcarmelveilleux tcarmelveilleux mentioned this issue Jul 16, 2024
Merged
mergify bot pushed a commit that referenced this issue Jul 17, 2024
@tcarmelveilleux @restyled-commits @bzbarsky-apple
Add an Action Switch endpoint to all-clusters-app (#34355)
a690ff0 
* Add an Action Switch endpoint to all-clusters-app

- Action Switch is a new feature for a TCR
- Need to have the ZAP files updated before adding the logic to
  reduce review burden.
- Re-ran zap_convert_all.py (some of the changes are due to that)

Issue #34304

Testing done:

- No regressions of integration tests

* Fix integration test

* Try to fix Darwin tests

* Attempt to fix tests some more

* Fix Darwin tests

* Restyled by clang-format

* Fix the Darwin tests to actually pass.

* Fix typos

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
j-ororke pushed a commit to j-ororke/connectedhomeip that referenced this issue Jul 31, 2024
@tcarmelveilleux @restyled-commits
@bzbarsky-apple @j-ororke
Add an Action Switch endpoint to all-clusters-app (project-chip#34355)
34e4810 
* Add an Action Switch endpoint to all-clusters-app

- Action Switch is a new feature for a TCR
- Need to have the ZAP files updated before adding the logic to
  reduce review burden.
- Re-ran zap_convert_all.py (some of the changes are due to that)

Issue project-chip#34304

Testing done:

- No regressions of integration tests

* Fix integration test

* Try to fix Darwin tests

* Attempt to fix tests some more

* Fix Darwin tests

* Restyled by clang-format

* Fix the Darwin tests to actually pass.

* Fix typos

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this issue Jul 31, 2024
@tcarmelveilleux
Fix test TC-SWTCH-2.2
0e61d3f 
- TC-SWTCH-2.2 is updated from YAML to Python by this PR
- TC-SWTCH-2.2 latest test plan steps implemented
- Added latching switch simulation to all clusters app
- All switch cluster simulation features are now done in all-clusters-app

Fixes project-chip#34304
Fixes project-chip#34305

Testing done:
- New test passes with all-clusters
- Existing tests also pass
@tcarmelveilleux tcarmelveilleux mentioned this issue Jul 31, 2024
Merged
@mergify mergify bot closed this as completed in #34655 Jul 31, 2024
@mergify mergify bot closed this as completed in 8601109 Jul 31, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [TCR] 1.3 TCRs Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcarmelveilleux tcarmelveilleux

Labels
TCR
Projects
[TCR] 1.3 TCRs
Archived in project
[TCR][Fall 2024] ActionSwitch feature for Switch cluster
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test TC-SWTCH-2.2 tcarmelveilleux/connectedhomeip
1 participant
@tcarmelveilleux