[ota-provider-app] Set device attestation credentials provider #10003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple,
tcarmelveilleux,
vivien-apple,
woody-apple and
yufengwangca
holbrookt
approved these changes
Sep 27, 2021
Damian-Nordic
approved these changes
Sep 27, 2021
woody-apple
approved these changes
Sep 28, 2021
|
@carol-apple Note, there's a conflict here |
LuDuda
approved these changes
Sep 28, 2021
tcarmelveilleux
approved these changes
Sep 28, 2021
* When device attestation config is not initialized, the OTA provider app cannot be commissioned
carol-apple
force-pushed
the
ota-provider-init-device-attestation
branch
from
67fb321 to
58b172e
Compare
msandstedt
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OTA provider app currently does not set the device attestation credentials provider. This results in a failure when the app is being commissioned.
Change overview
Set the device attestation credentials provider to
ExampleDACProviderTesting
Tested manually with the following steps:
scripts/examples/gn_build_example.sh examples/ota-provider-app/linux/ out/apps chip_config_network_layer_ble=falseout/apps/chip-ota-provider-appout/host/chip-tool pairing onnetwork 0 20202021 3840 ::1 5540