Remove unnecessary includes of AttributeDataElement.h #10388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need these, because the AttributeValueEncoder handles the tagging for us.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple,
turon,
vivien-apple,
woody-apple and
yunhanw-google
yufengwangca
approved these changes
Oct 11, 2021
Damian-Nordic
approved these changes
Oct 11, 2021
saurabhst
approved these changes
Oct 11, 2021
mrjerryjohns
pushed a commit
to mrjerryjohns/connectedhomeip
that referenced
this pull request
Oct 11, 2021
…0388) We no longer need these, because the AttributeValueEncoder handles the tagging for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need these, because the AttributeValueEncoder handles the
tagging for us.
Problem
Unnecessary includes.
Change overview
Remove them.
Testing
Grepping for "AttributeDataElement" in the relevant files shows no uses.