Attribute Type Information in Cluster Objects #10398

mrjerryjohns · 2021-10-11T21:53:04Z

Emit a TypeInfo struct for each attribute in the generated cluster objects that contains both the type of the attribute as well as its Attribute and Cluster ID. This will be useful later when implementing Reads/Writes that utilize this information during template specialization to avoid the caller/application having to provide this information.

Create a 'TypeInfo' struct for each attribute in the generated cluster objects that contains both the type of the attribute as well as its Attribute and Cluster ID. This will be useful later when implementing Reads/Writes that utilize this information during template specialization to avoid the caller/application having to provide this information.

woody-apple · 2021-10-11T22:26:28Z

@saurabhst @andy31415 @Damian-Nordic @jelderton @jepenven-silabs @jmartinez-silabs ?

src/app/zap-templates/templates/app/cluster-objects.zapt

src/app/zap-templates/templates/app/helper.js

src/app/zap-templates/templates/app/cluster-objects.zapt

src/app/zap-templates/templates/app/helper.js

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

github-actions · 2021-10-14T16:18:57Z

PR #10398: Size comparison from 24ad104 to b8a56dd

34 builds

platform	target	config	section	`24ad104`	`b8a56dd`
efr32	lighting-app	BRD4161A	.bss	118012	118012
			.data	1800	1800
			.text	780980	780980
	lock-app	BRD4161A	.bss	115884	115884
			.data	1760	1760
			.text	760236	760236
	window-app	BRD4161A	.bss	116204	116204
			.data	1764	1764
			.text	761136	761136
	lighting-app	BRD4161A+rpc	.bss	131340	131340
			.data	1852	1852
			.text	760728	760728
esp32	all-clusters-app	c3devkit	.dram0.bss	60248	60248
			.dram0.data	16232	16232
			.flash.rodata	198144	198144
			.flash.text	868918	868918
			.iram0.text	57330	57330
		m5stack	.dram0.bss	62752	62752
			.dram0.data	32084	32084
			.flash.rodata	206732	206732
			.flash.text	900007	900007
			.iram0.text	125115	125115
k32w	lock-app	k32w061+debug	.bss	69044	69044
			.data	1864	1864
			.text	514132	514132
	shell	k32w061+debug	.bss	55088	55088
			.data	672	672
			.text	356884	356884
	lighting-app	k32w061+se05x+release	.bss	78560	78560
			.data	1900	1900
			.text	612808	612808
linux	all-clusters-app	debug	.bss	52144	52144
			.data	978	978
			.data.rel.ro	58352	58352
			.dynamic	592	592
			.got	4080	4080
			.init	27	27
			.init_array	512	512
			.rodata	134485	134485
			.text	`1317778`	`1317778`
	chip-tool	debug	.bss	17584	17584
			.data	1584	1584
			.data.rel.ro	77392	77392
			.dynamic	592	592
			.got	4336	4336
			.init	27	27
			.init_array	416	416
			.rodata	173408	173408
			.text	2424789	2424789
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	23112	23112
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	108568	108568
			.text	`1004786`	`1004786`
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	24408	24408
			.dynamic	592	592
			.got	4144	4144
			.init	27	27
			.init_array	520	520
			.rodata	126576	126576
			.text	1124594	1124594
	shell	debug	.bss	16104	16104
			.data	242	242
			.data.rel.ro	35192	35192
			.dynamic	592	592
			.got	3512	3512
			.init	27	27
			.init_array	344	344
			.rodata	70639	70639
			.text	573842	573842
	tv-app	debug	.bss	216368	216368
			.data	2032	2032
			.data.rel.ro	55536	55536
			.dynamic	592	592
			.got	4416	4416
			.init	27	27
			.init_array	616	616
			.rodata	150280	150280
			.text	1463282	1463282
	bridge-app	debug+rpc	.bss	52880	52880
			.data	976	976
			.data.rel.ro	25480	25480
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	408	408
			.rodata	109244	109244
			.text	1047045	1047045
	lighting-app	debug+rpc	.bss	42200	42200
			.data	1106	1106
			.data.rel.ro	52192	52192
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	536	536
			.rodata	126353	126353
			.text	`1248194`	`1248194`
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172132	172132
			.data	5464	5464
			.heap	858848	858848
			.text	1218656	1218656
	lock-app	CY8CPROTO_062_4343W+release	.bss	171068	171068
			.data	5432	5432
			.heap	859944	859944
			.text	`1196648`	`1196648`
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	112312	112312
			rodata	97160	97160
			text	576936	576936
	lock-app	nrf52840dk_nrf52840	bss	111344	111344
			rodata	93656	93656
			text	558380	558380
	pigweed-app	nrf52840dk_nrf52840	bss	51772	51772
			rodata	45772	45772
			text	339392	339392
	pump-app	nrf52840dk_nrf52840	bss	111412	111412
			rodata	94640	94640
			text	561548	561548
	pump-controller-app	nrf52840dk_nrf52840	bss	111352	111352
			rodata	93716	93716
			text	558156	558156
	shell	nrf52840dk_nrf52840	bss	107328	107328
			rodata	71336	71336
			text	519020	519020
	lighting-app	nrf52840dk_nrf52840+rpc	bss	108552	108552
			rodata	87940	87940
			text	550140	550140
		nrf5340dk_nrf5340_cpuapp	bss	113684	113684
			rodata	92400	92400
			text	506396	506396
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	112716	112716
			rodata	88916	88916
			text	487832	487832
	shell	nrf5340dk_nrf5340_cpuapp	bss	108312	108312
			rodata	65980	65980
			text	439620	439620
p6	lock-app	default	.bss	68208	68208
			.data	2416	2416
			.heap	962720	962720
			.text	1124776	1124776
qpg	lighting-app	qpg6100+debug	.bss	53528	53528
			.data	996	996
			.text	485332	485332
	lock-app	qpg6100+debug	.bss	52480	52480
			.data	952	952
			.text	461508	461508
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	70972	70972
			noinit	33216	33216
			text	457580	457580

github-actions · 2021-10-14T16:19:04Z

PR #10398: Size comparison from aeca9b0 to 1a5be31

8 builds

platform	target	config	section	`aeca9b0`	`1a5be31`
k32w	lock-app	k32w061+debug	.bss	69044	69044
			.data	1864	1864
			.text	514132	514132
	shell	k32w061+debug	.bss	55088	55088
			.data	672	672
			.text	356884	356884
	lighting-app	k32w061+se05x+release	.bss	78560	78560
			.data	1900	1900
			.text	612808	612808
p6	lock-app	default	.bss	68208	68208
			.data	2416	2416
			.heap	962720	962720
			.text	1124776	1124776
qpg	lighting-app	qpg6100+debug	.bss	53528	53528
			.data	996	996
			.text	485332	485332
	lock-app	qpg6100+debug	.bss	52480	52480
			.data	952	952
			.text	461508	461508
	persistent-storage-app	qpg6100+debug	.bss	17778	17778
			.data	280	280
			.text	102704	102704
telink	lighting-app	tlsr9518adk80d	bss	70972	70972
			noinit	33216	33216
			text	457580	457580

github-actions · 2021-10-14T16:19:07Z

PR #10398: Size comparison from aeca9b0 to 9142fd2

24 builds

platform	target	config	section	`aeca9b0`	`9142fd2`	change	% change
efr32	lighting-app	BRD4161A	.bss	118012	118012	0	0.0
			.data	1800	1800	0	0.0
			.text	780980	780980	0	0.0
	lock-app	BRD4161A	.bss	115884	115884	0	0.0
			.data	1760	1760	0	0.0
			.text	760236	760236	0	0.0
	window-app	BRD4161A	.bss	116204	116204	0	0.0
			.data	1764	1764	0	0.0
			.text	761136	761136	0	0.0
	lighting-app	BRD4161A+rpc	.bss	131340	131340	0	0.0
			.data	1852	1852	0	0.0
			.text	760728	760728	0	0.0
esp32	all-clusters-app	c3devkit	.dram0.bss	60248	60248	0	0.0
			.dram0.data	16232	16232	0	0.0
			.flash.rodata	198144	198144	0	0.0
			.flash.text	868918	868918	0	0.0
			.iram0.text	57330	57330	0	0.0
		m5stack	.dram0.bss	62752	62752	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	206732	206732	0	0.0
			.flash.text	900003	899911	-92	-0.0
			.iram0.text	125115	125115	0	0.0
k32w	lock-app	k32w061+debug	.bss	69044	69044	0	0.0
			.data	1864	1864	0	0.0
			.text	514132	514132	0	0.0
	shell	k32w061+debug	.bss	55088	55088	0	0.0
			.data	672	672	0	0.0
			.text	356884	356884	0	0.0
	lighting-app	k32w061+se05x+release	.bss	78560	78560	0	0.0
			.data	1900	1900	0	0.0
			.text	612808	612808	0	0.0
linux	all-clusters-app	debug	.bss	52144	52144	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	58352	58352	0	0.0
			.dynamic	592	592	0	0.0
			.got	4080	4080	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	134453	134453	0	0.0
			.text	`1317778`	`1317778`	0	0.0
	chip-tool	debug	.bss	17584	17584	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	77392	77392	0	0.0
			.dynamic	592	592	0	0.0
			.got	4328	4328	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	173408	173408	0	0.0
			.text	2424437	2424437	0	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	23112	23112	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	108536	108536	0	0.0
			.text	`1004786`	`1004786`	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24408	24408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	126576	126576	0	0.0
			.text	1124594	1124594	0	0.0
	shell	debug	.bss	16104	16104	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	35192	35192	0	0.0
			.dynamic	592	592	0	0.0
			.got	3512	3512	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	70639	70639	0	0.0
			.text	573842	573842	0	0.0
	tv-app	debug	.bss	216368	216368	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	55536	55536	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	150248	150248	0	0.0
			.text	1462946	1462946	0	0.0
	bridge-app	debug+rpc	.bss	52880	52880	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	25480	25480	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	109212	109212	0	0.0
			.text	1047045	1047045	0	0.0
	lighting-app	debug+rpc	.bss	42200	42200	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	52192	52192	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	126353	126353	0	0.0
			.text	`1248194`	`1248194`	0	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172132	172132	0	0.0
			.data	5464	5464	0	0.0
			.heap	858848	858848	0	0.0
			.text	1218656	1218656	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171068	171068	0	0.0
			.data	5432	5432	0	0.0
			.heap	859944	859944	0	0.0
			.text	`1196648`	`1196648`	0	0.0
p6	lock-app	default	.bss	68208	68208	0	0.0
			.data	2416	2416	0	0.0
			.heap	962720	962720	0	0.0
			.text	1124776	1124776	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53528	53528	0	0.0
			.data	996	996	0	0.0
			.text	485332	485332	0	0.0
	lock-app	qpg6100+debug	.bss	52480	52480	0	0.0
			.data	952	952	0	0.0
			.text	461508	461508	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	17778	17778	0	0.0
			.data	280	280	0	0.0
			.text	102704	102704	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	70972	70972	0	0.0
			noinit	33216	33216	0	0.0
			text	457580	457580	0	0.0

boring-cyborg bot added android config examples integrations scripts labels Oct 11, 2021

restyled-io bot mentioned this pull request Oct 11, 2021

Restyle Attribute Type Information in Cluster Objects #10399

Closed

woody-apple approved these changes Oct 11, 2021

View reviewed changes

mrjerryjohns force-pushed the attribute-types branch from 83f2556 to ab48324 Compare October 11, 2021 22:23

boring-cyborg bot added the app label Oct 11, 2021

mrjerryjohns force-pushed the attribute-types branch from ab48324 to 23b8e02 Compare October 11, 2021 22:24

pullapprove bot added the review - pending label Oct 11, 2021

bzbarsky-apple approved these changes Oct 11, 2021

View reviewed changes

src/app/zap-templates/templates/app/cluster-objects.zapt Outdated Show resolved Hide resolved

src/app/zap-templates/templates/app/cluster-objects.zapt Outdated Show resolved Hide resolved

src/app/zap-templates/templates/app/cluster-objects.zapt Show resolved Hide resolved

erjiaqing reviewed Oct 12, 2021

View reviewed changes

src/app/zap-templates/templates/app/cluster-objects.zapt Outdated Show resolved Hide resolved

yunhanw-google approved these changes Oct 12, 2021

View reviewed changes

LuDuda approved these changes Oct 12, 2021

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Oct 12, 2021

Merge branch 'master' into attribute-types

74effb7

pullapprove bot requested review from chulspro and wbschiller October 13, 2021 07:32

erjiaqing reviewed Oct 13, 2021

View reviewed changes

src/app/zap-templates/templates/app/helper.js Outdated Show resolved Hide resolved

src/app/zap-templates/templates/app/helper.js Outdated Show resolved Hide resolved

mrjerryjohns added 2 commits October 13, 2021 14:32

WIP

9986a10

Merge branch 'master' into attribute-types

7a1623c

restyled-io bot mentioned this pull request Oct 13, 2021

Restyle Attribute Type Information in Cluster Objects #10467

Closed

Fixed up as per review feedback

9142fd2

mrjerryjohns force-pushed the attribute-types branch from 11eb59d to 9142fd2 Compare October 13, 2021 22:17

bzbarsky-apple approved these changes Oct 13, 2021

View reviewed changes

src/app/zap-templates/templates/app/cluster-objects.zapt Outdated Show resolved Hide resolved

src/app/zap-templates/templates/app/helper.js Outdated Show resolved Hide resolved

Apply suggestions from code review

2dafbf1

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

restyled-io bot mentioned this pull request Oct 13, 2021

Restyle Attribute Type Information in Cluster Objects #10469

Closed

Re-gen cluster-objects

b8a56dd

mrjerryjohns force-pushed the attribute-types branch from 1a5be31 to b8a56dd Compare October 13, 2021 23:38

mrjerryjohns merged commit f0cc672 into project-chip:master Oct 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Attribute Type Information in Cluster Objects #10398

Attribute Type Information in Cluster Objects #10398

mrjerryjohns commented Oct 11, 2021

woody-apple commented Oct 11, 2021

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

Attribute Type Information in Cluster Objects #10398

Attribute Type Information in Cluster Objects #10398

Conversation

mrjerryjohns commented Oct 11, 2021

woody-apple commented Oct 11, 2021

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 14, 2021

github-actions bot commented Oct 14, 2021