[Ameba] Support BLE & IP commissioning functions #10841

pankore · 2021-10-22T11:51:43Z

Problem

Support BLE commissioning function
Support IP commissioning function

Change overview

Add BLEManagerImpl
Add ConnectivityManagerImpl
Add MdnsImpl
Add KeyValueStoreManagerImpl

Testing

Tested BLE commissioning and cluster control using python controller
Tested IP commissioning and cluster control using python controller

todo · 2021-10-22T11:51:45Z

Initialize the Chip Addressing and Routing Module.

connectedhomeip/src/platform/Ameba/ConnectivityManagerImpl.cpp

Lines 351 to 361 in 9b3d01e

    
           // TODO Initialize the Chip Addressing and Routing Module. 
        
           // Ensure that station mode is enabled. 
        
           wifi_on(RTW_MODE_STA); 
        
           // Ensure that station mode is enabled in the WiFi layer. 
        
           wifi_set_mode(RTW_MODE_STA);; 
        
           // If there is no persistent station provision... 
        
           if (!IsWiFiStationProvisioned()) 
        
           {

This comment was generated by todo based on a `TODO` comment in `9b3d01e` in #10841. cc @pankore.

todo · 2021-10-22T11:51:48Z

Invoke WARM to perform actions that occur when the WiFi station interface comes up.

connectedhomeip/src/platform/Ameba/ConnectivityManagerImpl.cpp

Lines 551 to 561 in 9b3d01e

    
               // TODO Invoke WARM to perform actions that occur when the WiFi station interface comes up. 
        
               // Alert other components of the new state. 
        
               ChipDeviceEvent event; 
        
               event.Type                          = DeviceEventType::kWiFiConnectivityChange; 
        
               event.WiFiConnectivityChange.Result = kConnectivity_Established; 
        
               PlatformMgr().PostEventOrDie(&event); 
        
               UpdateInternetConnectivityState(); 
        
           }

This comment was generated by todo based on a `TODO` comment in `9b3d01e` in #10841. cc @pankore.

todo · 2021-10-22T11:51:51Z

Invoke WARM to perform actions that occur when the WiFi station interface goes down.

connectedhomeip/src/platform/Ameba/ConnectivityManagerImpl.cpp

Lines 564 to 574 in 9b3d01e

    
               // TODO Invoke WARM to perform actions that occur when the WiFi station interface goes down. 
        
               // Alert other components of the new state. 
        
               ChipDeviceEvent event; 
        
               event.Type                          = DeviceEventType::kWiFiConnectivityChange; 
        
               event.WiFiConnectivityChange.Result = kConnectivity_Lost; 
        
               PlatformMgr().PostEventOrDie(&event); 
        
               UpdateInternetConnectivityState(); 
        
           }

This comment was generated by todo based on a `TODO` comment in `9b3d01e` in #10841. cc @pankore.

todo · 2021-10-22T11:51:54Z

change the code to using IPv6 address

connectedhomeip/src/platform/Ameba/ConnectivityManagerImpl.cpp

Lines 642 to 652 in 9b3d01e

    
               // ToDo: change the code to using IPv6 address 
        
               ip4addr_ntoa_r((const ip4_addr_t *)LwIP_GetIP(&xnetif[0]), addrStr, sizeof(addrStr)); 
        
               IPAddress::FromString(addrStr, addr); 
        
           } 
        
           // Search among the IPv6 addresses assigned to the interface for a Global Unicast 
        
           // address (2000::/3) that is in the valid state.  If such an address is found... 
        
           for (uint8_t i = 0; i < LWIP_IPV6_NUM_ADDRESSES; i++) 
        
           { 
        
               if (ip6_addr_isglobal(netif_ip6_addr(netif, i)) && ip6_addr_isvalid(netif_ip6_addr_state(netif, i))) 
        
               {

This comment was generated by todo based on a `ToDo` comment in `9b3d01e` in #10841. cc @pankore.

github-actions · 2021-10-22T12:35:44Z

PR #10841: Size comparison from 0c16976 to 85f9070

20 builds (for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`0c16976`	`85f9070`
efr32	lighting-app	BRD4161A	.bss	118028	118028
			.data	1800	1800
			.text	784328	784328
	lock-app	BRD4161A	.bss	115884	115884
			.data	1760	1760
			.text	763456	763456
	window-app	BRD4161A	.bss	116204	116204
			.data	1764	1764
			.text	764380	764380
	lighting-app	BRD4161A+rpc	.bss	131356	131356
			.data	1852	1852
			.text	764028	764028
k32w	lock-app	k32w061+debug	.bss	69060	69060
			.data	1864	1864
			.text	516068	516068
	shell	k32w061+debug	.bss	55080	55080
			.data	672	672
			.text	359544	359544
	lighting-app	k32w061+se05x+release	.bss	78592	78592
			.data	1900	1900
			.text	614836	614836
linux	all-clusters-app	debug	.bss	52208	52208
			.data	978	978
			.data.rel.ro	60384	60384
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	512	512
			.rodata	136405	136405
			.text	1352290	1352290
	chip-tool	debug	.bss	17712	17712
			.data	1584	1584
			.data.rel.ro	93504	93504
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	416	416
			.rodata	193860	193860
			.text	3502693	3502693
	ota-provider-app	debug	.bss	37472	37472
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	440	440
			.rodata	110248	110248
			.text	`1022226`	`1022226`
	ota-requestor-app	debug	.bss	205728	205728
			.data	752	752
			.data.rel.ro	25800	25800
			.dynamic	592	592
			.got	4144	4144
			.init	27	27
			.init_array	512	512
			.rodata	128392	128392
			.text	1140786	1140786
	shell	debug	.bss	16136	16136
			.data	242	242
			.data.rel.ro	36496	36496
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	336	336
			.rodata	76463	76463
			.text	597346	597346
	tv-app	debug	.bss	216592	216592
			.data	2032	2032
			.data.rel.ro	57408	57408
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	608	608
			.rodata	152904	152904
			.text	1452706	1452706
	bridge-app	debug+rpc	.bss	52912	52912
			.data	976	976
			.data.rel.ro	27112	27112
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	400	400
			.rodata	110748	110748
			.text	1063173	1063173
	lighting-app	debug+rpc	.bss	42232	42232
			.data	1106	1106
			.data.rel.ro	53808	53808
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	127921	127921
			.text	1261170	1261170
p6	lock-app	default	.bss	68216	68216
			.data	2416	2416
			.heap	962712	962712
			.text	`1126688`	`1126688`
qpg	lighting-app	qpg6100+debug	.bss	53552	53552
			.data	1004	1004
			.text	485972	485972
	lock-app	qpg6100+debug	.bss	52496	52496
			.data	960	960
			.text	462060	462060
	persistent-storage-app	qpg6100+debug	.bss	27840	27840
			.data	372	372
			.text	149896	149896
telink	lighting-app	tlsr9518adk80d	bss	70996	70996
			noinit	33216	33216
			text	457630	457630

woody-apple · 2021-10-27T06:37:46Z

/rebase

github-actions · 2021-10-27T10:27:13Z

PR #10841: Size comparison from 3249310 to ced48fc

Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`3249310`	`ced48fc`
efr32	lighting-app	BRD4161A	(read only)	737104	737104
			(read/write)	115444	115444
			.bss	113692	113692
			.data	1752	1752
			.text	737096	737096
		BRD4161A+rpc	(read only)	724536	724536
			(read/write)	132052	132052
			.bss	130196	130196
			.data	1852	1852
			.text	724528	724528
	lock-app	BRD4161A	(read only)	716368	716368
			(read/write)	113260	113260
			.bss	111548	111548
			.data	1712	1712
			.text	716360	716360
	window-app	BRD4161A	(read only)	717276	717276
			(read/write)	113584	113584
			.bss	111868	111868
			.data	1716	1716
			.text	717268	717268
esp32	all-clusters-app	c3devkit	(read only)	875790	875790
			(read/write)	`1306456`	`1306456`
			.dram0.bss	58240	58240
			.dram0.data	16464	16464
			.flash.rodata	198520	198520
			.flash.text	875790	875790
			.iram0.text	57564	57564
		m5stack	(read only)	906891	906891
			(read/write)	426264	426264
			.dram0.bss	60752	60752
			.dram0.data	32084	32084
			.flash.rodata	207264	207264
			.flash.text	906891	906891
			.iram0.text	125115	125115
k32w	lighting-app	k32w061+se05x+release	(read/write)	701096	701096
			.bss	78720	78720
			.data	1900	1900
			.text	614676	614676
	lock-app	k32w061+debug	(read/write)	592900	592900
			.bss	69196	69196
			.data	1864	1864
			.text	516040	516040
	shell	k32w061+debug	(read/write)	425236	425236
			.bss	63256	63256
			.data	672	672
			.text	359604	359604
linux	all-clusters-app	debug	(read only)	1634209	1634209
			(read/write)	117408	117408
			.bss	50320	50320
			.data	978	978
			.data.rel.ro	60864	60864
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	520	520
			.rodata	135541	135541
			.text	`1366930`	`1366930`
	bridge-app	debug+rpc	(read only)	1275693	1275693
			(read/write)	85096	85096
			.bss	51856	51856
			.data	976	976
			.data.rel.ro	27272	27272
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	400	400
			.rodata	110684	110684
			.text	1069669	1069669
	chip-tool	debug	(read only)	4146325	4146325
			(read/write)	120184	120184
			.bss	17680	17680
			.data	1584	1584
			.data.rel.ro	95520	95520
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	416	416
			.rodata	210224	210224
			.text	3677813	3677813
	lighting-app	debug+rpc	(read only)	1527209	1527209
			(read/write)	101520	101520
			.bss	41176	41176
			.data	1106	1106
			.data.rel.ro	53968	53968
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	528	528
			.rodata	127889	127889
			.text	1267298	1267298
	ota-provider-app	debug	(read only)	`1234753`	`1234753`
			(read/write)	67776	67776
			.bss	37440	37440
			.data	752	752
			.data.rel.ro	24488	24488
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	440	440
			.rodata	110984	110984
			.text	1027810	1027810
	ota-requestor-app	debug	(read only)	1292033	1292033
			(read/write)	76264	76264
			.bss	44960	44960
			.data	816	816
			.data.rel.ro	25352	25352
			.dynamic	592	592
			.got	3984	3984
			.init	27	27
			.init_array	512	512
			.rodata	127904	127904
			.text	1066530	1066530
	shell	debug	(read only)	778361	778361
			(read/write)	57376	57376
			.bss	16136	16136
			.data	242	242
			.data.rel.ro	36496	36496
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	336	336
			.rodata	76527	76527
			.text	600706	600706
	tv-app	debug	(read only)	1753753	1753753
			(read/write)	281432	281432
			.bss	215568	215568
			.data	2032	2032
			.data.rel.ro	58192	58192
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	608	608
			.rodata	152984	152984
			.text	1459058	1459058
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2288664	2288664
			.bss	179612	179612
			.data	5192	5192
			.heap	851640	851640
			.text	1251264	1251264
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2255896	2255896
			.bss	171060	171060
			.data	5464	5464
			.heap	859920	859920
			.text	1218496	1218496
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2233928	2233928
			.bss	169988	169988
			.data	5432	5432
			.heap	861024	861024
			.text	1196528	1196528
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`1139680`	`1139680`
			.bss	11760	11760
			.data	4360	4360
			.heap	1020328	1020328
			.text	103064	103064
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862967	862967
			bss	112136	112136
			rodata	97504	97504
			text	577704	577704
		nrf52840dk_nrf52840+rpc	(read/write)	823807	823807
			bss	108380	108380
			rodata	88280	88280
			text	550896	550896
		nrf5340dk_nrf5340_cpuapp	(read/write)	788006	788006
			bss	113512	113512
			rodata	92744	92744
			text	507176	507176
	lock-app	nrf52840dk_nrf52840	(read/write)	839911	839911
			bss	111208	111208
			rodata	93904	93904
			text	559264	559264
		nrf5340dk_nrf5340_cpuapp	(read/write)	764954	764954
			bss	112584	112584
			rodata	89164	89164
			text	488728	488728
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497339	497339
			bss	51824	51824
			rodata	45776	45776
			text	339456	339456
	pump-app	nrf52840dk_nrf52840	(read/write)	844311	844311
			bss	111308	111308
			rodata	95104	95104
			text	562368	562368
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	839631	839631
			bss	111208	111208
			rodata	93880	93880
			text	559008	559008
	shell	nrf52840dk_nrf52840	(read/write)	776579	776579
			bss	109072	109072
			rodata	72536	72536
			text	520368	520368
		nrf5340dk_nrf5340_cpuapp	(read/write)	691634	691634
			bss	110056	110056
			rodata	67180	67180
			text	440980	440980
p6	lock-app	default	(read/write)	2169104	2169104
			.bss	67184	67184
			.data	2416	2416
			.heap	963744	963744
			.text	1127368	1127368
qpg	lighting-app	qpg6100+debug	(read only)	491272	491272
			(read/write)	114144	114144
			.bss	52416	52416
			.data	1000	1000
			.text	485952	485952
	lock-app	qpg6100+debug	(read only)	467492	467492
			(read/write)	114140	114140
			.bss	51368	51368
			.data	956	956
			.text	462172	462172
	persistent-storage-app	qpg6100+debug	(read only)	155220	155220
			(read/write)	114140	114140
			.bss	27752	27752
			.data	372	372
			.text	149900	149900
telink	lighting-app	tlsr9518adk80d	(read/write)	664678	664678
			bss	69944	69944
			noinit	33216	33216
			text	458278	458278

andy31415 · 2021-10-27T13:29:32Z

@pankore still some conflicts (we have high change rate just before TE branch)

github-actions · 2021-10-27T15:52:59Z

PR #10841: Size comparison from 73bd219 to cc6ee34

Decreases (1 build for esp32)

platform	target	config	section	`73bd219`	`cc6ee34`	change	% change
esp32	all-clusters-app	m5stack	(read only)	907223	907147	-76	-0.0
			.flash.text	907223	907147	-76	-0.0

Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`73bd219`	`cc6ee34`	change	% change
efr32	lighting-app	BRD4161A	(read only)	737280	737280	0	0.0
			(read/write)	115444	115444	0	0.0
			.bss	113692	113692	0	0.0
			.data	1752	1752	0	0.0
			.text	737272	737272	0	0.0
		BRD4161A+rpc	(read only)	724712	724712	0	0.0
			(read/write)	132052	132052	0	0.0
			.bss	130196	130196	0	0.0
			.data	1852	1852	0	0.0
			.text	724704	724704	0	0.0
	lock-app	BRD4161A	(read only)	716544	716544	0	0.0
			(read/write)	113260	113260	0	0.0
			.bss	111548	111548	0	0.0
			.data	1712	1712	0	0.0
			.text	716536	716536	0	0.0
	window-app	BRD4161A	(read only)	717468	717468	0	0.0
			(read/write)	113584	113584	0	0.0
			.bss	111868	111868	0	0.0
			.data	1716	1716	0	0.0
			.text	717460	717460	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	876062	876062	0	0.0
			(read/write)	1306520	1306520	0	0.0
			.dram0.bss	58248	58248	0	0.0
			.dram0.data	16464	16464	0	0.0
			.flash.rodata	198568	198568	0	0.0
			.flash.text	876062	876062	0	0.0
			.iram0.text	57564	57564	0	0.0
		m5stack	(read only)	907223	907147	-76	-0.0
			(read/write)	426312	426312	0	0.0
			.dram0.bss	60752	60752	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	207312	207312	0	0.0
			.flash.text	907223	907147	-76	-0.0
			.iram0.text	125115	125115	0	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	701256	701256	0	0.0
			.bss	78720	78720	0	0.0
			.data	1900	1900	0	0.0
			.text	614836	614836	0	0.0
	lock-app	k32w061+debug	(read/write)	593060	593060	0	0.0
			.bss	69196	69196	0	0.0
			.data	1864	1864	0	0.0
			.text	516200	516200	0	0.0
	shell	k32w061+debug	(read/write)	425348	425348	0	0.0
			.bss	63256	63256	0	0.0
			.data	672	672	0	0.0
			.text	359716	359716	0	0.0
linux	all-clusters-app	debug	(read only)	1636385	1636385	0	0.0
			(read/write)	117472	117472	0	0.0
			.bss	50320	50320	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	60928	60928	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	135541	135541	0	0.0
			.text	1369106	1369106	0	0.0
	bridge-app	debug+rpc	(read only)	1277645	1277645	0	0.0
			(read/write)	85096	85096	0	0.0
			.bss	51856	51856	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27272	27272	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110684	110684	0	0.0
			.text	1071621	1071621	0	0.0
	chip-tool	debug	(read only)	4174429	4174429	0	0.0
			(read/write)	120896	120896	0	0.0
			.bss	17680	17680	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	96208	96208	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	424	424	0	0.0
			.rodata	212496	212496	0	0.0
			.text	3702037	3702037	0	0.0
	lighting-app	debug+rpc	(read only)	`1529385`	`1529385`	0	0.0
			(read/write)	101520	101520	0	0.0
			.bss	41176	41176	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53968	53968	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127889	127889	0	0.0
			.text	1269474	1269474	0	0.0
	ota-provider-app	debug	(read only)	1236913	1236913	0	0.0
			(read/write)	67776	67776	0	0.0
			.bss	37440	37440	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110984	110984	0	0.0
			.text	`1029970`	`1029970`	0	0.0
	ota-requestor-app	debug	(read only)	1294321	1294321	0	0.0
			(read/write)	76264	76264	0	0.0
			.bss	44960	44960	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25352	25352	0	0.0
			.dynamic	592	592	0	0.0
			.got	3984	3984	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	127904	127904	0	0.0
			.text	1068818	1068818	0	0.0
	shell	debug	(read only)	780809	780809	0	0.0
			(read/write)	57376	57376	0	0.0
			.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76527	76527	0	0.0
			.text	603154	603154	0	0.0
	tv-app	debug	(read only)	`1756201`	`1756201`	0	0.0
			(read/write)	281432	281432	0	0.0
			.bss	215568	215568	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	58192	58192	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152984	152984	0	0.0
			.text	1461506	1461506	0	0.0
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2288904	2288904	0	0.0
			.bss	179612	179612	0	0.0
			.data	5192	5192	0	0.0
			.heap	851640	851640	0	0.0
			.text	`1251504`	`1251504`	0	0.0
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2256088`	`2256088`	0	0.0
			.bss	171060	171060	0	0.0
			.data	5464	5464	0	0.0
			.heap	859920	859920	0	0.0
			.text	1218688	1218688	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`2234120`	`2234120`	0	0.0
			.bss	169988	169988	0	0.0
			.data	5432	5432	0	0.0
			.heap	861024	861024	0	0.0
			.text	1196720	1196720	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	`1139680`	`1139680`	0	0.0
			.bss	11760	11760	0	0.0
			.data	4360	4360	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103064	103064	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	862983	862983	0	0.0
			bss	112136	112136	0	0.0
			rodata	97504	97504	0	0.0
			text	577724	577724	0	0.0
		nrf52840dk_nrf52840+rpc	(read/write)	823823	823823	0	0.0
			bss	108380	108380	0	0.0
			rodata	88280	88280	0	0.0
			text	550916	550916	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	788022	788022	0	0.0
			bss	113512	113512	0	0.0
			rodata	92744	92744	0	0.0
			text	507196	507196	0	0.0
	lock-app	nrf52840dk_nrf52840	(read/write)	839927	839927	0	0.0
			bss	111208	111208	0	0.0
			rodata	93904	93904	0	0.0
			text	559284	559284	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	764970	764970	0	0.0
			bss	112584	112584	0	0.0
			rodata	89164	89164	0	0.0
			text	488748	488748	0	0.0
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497339	497339	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844327	844327	0	0.0
			bss	111308	111308	0	0.0
			rodata	95104	95104	0	0.0
			text	562388	562388	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	839647	839647	0	0.0
			bss	111208	111208	0	0.0
			rodata	93880	93880	0	0.0
			text	559028	559028	0	0.0
	shell	nrf52840dk_nrf52840	(read/write)	776531	776531	0	0.0
			bss	109072	109072	0	0.0
			rodata	72536	72536	0	0.0
			text	520324	520324	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691586	691586	0	0.0
			bss	110056	110056	0	0.0
			rodata	67180	67180	0	0.0
			text	440936	440936	0	0.0
p6	lock-app	default	(read/write)	2169360	2169360	0	0.0
			.bss	67184	67184	0	0.0
			.data	2416	2416	0	0.0
			.heap	963744	963744	0	0.0
			.text	1127624	1127624	0	0.0
qpg	lighting-app	qpg6100+debug	(read only)	491416	491416	0	0.0
			(read/write)	114144	114144	0	0.0
			.bss	52416	52416	0	0.0
			.data	1000	1000	0	0.0
			.text	486096	486096	0	0.0
	lock-app	qpg6100+debug	(read only)	467636	467636	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	51368	51368	0	0.0
			.data	956	956	0	0.0
			.text	462316	462316	0	0.0
	persistent-storage-app	qpg6100+debug	(read only)	155244	155244	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	27752	27752	0	0.0
			.data	372	372	0	0.0
			.text	149924	149924	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	664718	664718	0	0.0
			bss	69944	69944	0	0.0
			noinit	33216	33216	0	0.0
			text	458320	458320	0	0.0

pankore · 2021-10-27T16:03:15Z

Dear reviewers @anush-apple, @austinh0, @balducci-apple, @bzbarsky-apple, @carol-apple, @chrisdecenzo, @chulspro, @Damian-Nordic, @emargolis, @franck-apple, @hawk248, @holbrookt, @jelderton, @jepenven-silabs, @jmartinez-silabs, @kpschoedel, @LuDuda, @mlepage-google, @mrjerryjohns, @msandstedt, @pan-apple, @robszewczyk, @sagar-apple, @saurabhst, @tcarmelveilleux, @vivien-apple, @wbschiller, @yunhanw-google,
May I ask your help to review this PR? Wish to get your opinion soon!
Many thanks!

src/platform/Ameba/KeyValueStoreManagerImpl.cpp

src/platform/Ameba/BLEManagerImpl.cpp

pankore · 2021-10-28T11:59:04Z

Dear reviewers,
I noticed that the TE7 branch has been created just now.
Since this PR is ready to be merged, is it possible to cherry-pick this PR to TE7 branch after the merger?
Many thanks!

* Support commissioning over BLE * Revise files * Update files to match B1021 * Fix restyled errors * Remove outdated comments * Update README.md and wordlist * Rename mDNS abstract layer to DNS-SD for Ameba * Minor fixes on the typos * Update for the review questions

boring-cyborg bot added app config examples platform labels Oct 22, 2021

restyled-io bot mentioned this pull request Oct 22, 2021

Restyle [Ameba] Support BLE & IP commissioning functions #10842

Closed

pankore force-pushed the ble_support branch from 9b3d01e to 85f9070 Compare October 22, 2021 12:02

boring-cyborg bot added the integrations label Oct 22, 2021

pullapprove bot requested review from andy31415, anush-apple, austinh0, balducci-apple, bzbarsky-apple, carol-apple, chrisdecenzo, chulspro, Damian-Nordic, emargolis, franck-apple, hawk248, holbrookt, jelderton, jepenven-silabs, jmartinez-silabs, kpschoedel and LuDuda October 22, 2021 12:43

woody-apple force-pushed the ble_support branch from 2b0461f to 277280e Compare October 27, 2021 06:38

pankore force-pushed the ble_support branch from 277280e to ced48fc Compare October 27, 2021 10:07

andy31415 approved these changes Oct 27, 2021

View reviewed changes

pankore force-pushed the ble_support branch from ced48fc to cc6ee34 Compare October 27, 2021 15:30

jmartinez-silabs approved these changes Oct 27, 2021

View reviewed changes

LuDuda approved these changes Oct 27, 2021

View reviewed changes

pankore added 9 commits October 28, 2021 15:42

Support commissioning over BLE

8da71a2

Revise files

4d09e30

Update files to match B1021

38614f5

Fix restyled errors

18f2fd5

Remove outdated comments

96b1be7

Update README.md and wordlist

3fd1794

Rename mDNS abstract layer to DNS-SD for Ameba

62a0bea

Minor fixes on the typos

034d646

Update for the review questions

098d454

pankore force-pushed the ble_support branch from cc6ee34 to 098d454 Compare October 28, 2021 07:43

andy31415 merged commit bab75e6 into project-chip:master Oct 28, 2021

franck-apple added the TE7 cherrypick label Oct 29, 2021

andy31415 added TE7 cherrypick DONE and removed TE7 cherrypick labels Nov 3, 2021

pankore deleted the ble_support branch November 22, 2021 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Ameba] Support BLE & IP commissioning functions #10841

[Ameba] Support BLE & IP commissioning functions #10841

pankore commented Oct 22, 2021

todo bot commented Oct 22, 2021

todo bot commented Oct 22, 2021

todo bot commented Oct 22, 2021

todo bot commented Oct 22, 2021

github-actions bot commented Oct 22, 2021

woody-apple commented Oct 27, 2021

github-actions bot commented Oct 27, 2021 •

edited

Loading

andy31415 commented Oct 27, 2021

github-actions bot commented Oct 27, 2021 •

edited

Loading

pankore commented Oct 27, 2021

pankore commented Oct 28, 2021

[Ameba] Support BLE & IP commissioning functions #10841

[Ameba] Support BLE & IP commissioning functions #10841

Conversation

pankore commented Oct 22, 2021

Problem

Change overview

Testing

todo bot commented Oct 22, 2021

Initialize the Chip Addressing and Routing Module.

This comment was generated by todo based on a TODO comment in 9b3d01e in #10841. cc @pankore.

todo bot commented Oct 22, 2021

Invoke WARM to perform actions that occur when the WiFi station interface comes up.

This comment was generated by todo based on a TODO comment in 9b3d01e in #10841. cc @pankore.

todo bot commented Oct 22, 2021

Invoke WARM to perform actions that occur when the WiFi station interface goes down.

This comment was generated by todo based on a TODO comment in 9b3d01e in #10841. cc @pankore.

todo bot commented Oct 22, 2021

change the code to using IPv6 address

This comment was generated by todo based on a ToDo comment in 9b3d01e in #10841. cc @pankore.

github-actions bot commented Oct 22, 2021

woody-apple commented Oct 27, 2021

github-actions bot commented Oct 27, 2021 • edited Loading

andy31415 commented Oct 27, 2021

github-actions bot commented Oct 27, 2021 • edited Loading

pankore commented Oct 27, 2021

pankore commented Oct 28, 2021

This comment was generated by todo based on a `TODO` comment in `9b3d01e` in #10841. cc @pankore.

This comment was generated by todo based on a `TODO` comment in `9b3d01e` in #10841. cc @pankore.

This comment was generated by todo based on a `TODO` comment in `9b3d01e` in #10841. cc @pankore.

This comment was generated by todo based on a `ToDo` comment in `9b3d01e` in #10841. cc @pankore.

github-actions bot commented Oct 27, 2021 •

edited

Loading

github-actions bot commented Oct 27, 2021 •

edited

Loading