chip::app::Clusters::OnOff::Attributes::OnOff accessors does not work…

[vivien-apple]

… because it is confused by the cluster and the attribute having the same name

Problem

The OnOff accessors for the OnOff attribute does not work because there is some namespace confusion.

EmberAfStatus Get(chip::EndpointId endpoint, bool * onOff)
{
    return emberAfReadServerAttribute(endpoint, OnOff::Id, OnOff::Id, (uint8_t *) onOff, sizeof(*onOff));
}
EmberAfStatus Set(chip::EndpointId endpoint, bool onOff)
{
    return emberAfWriteServerAttribute(endpoint, OnOff::Id, OnOff::Id, (uint8_t *) &onOff, ZCL_BOOLEAN_ATTRIBUTE_TYPE);
}

Change overview

• Make what is used clearer in terms on namespace

Testing

I did try by using the OnOff getter/setter and observing that it does not work without this change.

[github-actions]

PR #10877: Size comparison from 10dc447 to 740b6d7

35 builds (for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	10dc447	740b6d7	change	% change
efr32	lighting-app	BRD4161A	.bss	114732	114732	0	0.0
			.data	1752	1752	0	0.0
			.text	736764	736764	0	0.0
	lock-app	BRD4161A	.bss	112588	112588	0	0.0
			.data	1712	1712	0	0.0
			.text	715964	715964	0	0.0
	window-app	BRD4161A	.bss	112900	112900	0	0.0
			.data	1716	1716	0	0.0
			.text	716808	716808	0	0.0
	lighting-app	BRD4161A+rpc	.bss	131236	131236	0	0.0
			.data	1852	1852	0	0.0
			.text	724188	724188	0	0.0
esp32	all-clusters-app	c3devkit	.dram0.bss	60304	60304	0	0.0
			.dram0.data	16440	16440	0	0.0
			.flash.rodata	199968	199968	0	0.0
			.flash.text	874294	874294	0	0.0
			.iram0.text	57564	57564	0	0.0
		m5stack	.dram0.bss	62808	62808	0	0.0
			.dram0.data	32084	32084	0	0.0
			.flash.rodata	208704	208704	0	0.0
			.flash.text	905411	905411	0	0.0
			.iram0.text	125115	125115	0	0.0
k32w	lock-app	k32w061+debug	.bss	70244	70244	0	0.0
			.data	1864	1864	0	0.0
			.text	516076	516076	0	0.0
	shell	k32w061+debug	.bss	63256	63256	0	0.0
			.data	672	672	0	0.0
			.text	359528	359528	0	0.0
	lighting-app	k32w061+se05x+release	.bss	79760	79760	0	0.0
			.data	1900	1900	0	0.0
			.text	614776	614776	0	0.0
linux	all-clusters-app	debug	.bss	52208	52208	0	0.0
			.data	978	978	0	0.0
			.data.rel.ro	60448	60448	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	136469	136469	0	0.0
			.text	1353122	1353122	0	0.0
	chip-tool	debug	.bss	17712	17712	0	0.0
			.data	1584	1584	0	0.0
			.data.rel.ro	93888	93888	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	416	416	0	0.0
			.rodata	194308	194308	0	0.0
			.text	3510757	3510757	0	0.0
	ota-provider-app	debug	.bss	37472	37472	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24488	24488	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	440	440	0	0.0
			.rodata	110312	110312	0	0.0
			.text	1023042	1023042	0	0.0
	ota-requestor-app	debug	.bss	205728	205728	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	25800	25800	0	0.0
			.dynamic	592	592	0	0.0
			.got	4144	4144	0	0.0
			.init	27	27	0	0.0
			.init_array	512	512	0	0.0
			.rodata	128360	128360	0	0.0
			.text	1141650	1141650	0	0.0
	shell	debug	.bss	16136	16136	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36496	36496	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	336	336	0	0.0
			.rodata	76463	76463	0	0.0
			.text	598722	598722	0	0.0
	tv-app	debug	.bss	216592	216592	0	0.0
			.data	2032	2032	0	0.0
			.data.rel.ro	57408	57408	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	608	608	0	0.0
			.rodata	152936	152936	0	0.0
			.text	1453538	1453538	0	0.0
	bridge-app	debug+rpc	.bss	52912	52912	0	0.0
			.data	976	976	0	0.0
			.data.rel.ro	27112	27112	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	400	400	0	0.0
			.rodata	110748	110748	0	0.0
			.text	1063925	1063925	0	0.0
	lighting-app	debug+rpc	.bss	42232	42232	0	0.0
			.data	1106	1106	0	0.0
			.data.rel.ro	53808	53808	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	528	528	0	0.0
			.rodata	127921	127921	0	0.0
			.text	1261874	1261874	0	0.0
mbed	lighting-app	CY8CPROTO_062_4343W+release	.bss	172108	172108	0	0.0
			.data	5464	5464	0	0.0
			.heap	858872	858872	0	0.0
			.text	1220112	1220112	0	0.0
	lock-app	CY8CPROTO_062_4343W+release	.bss	171028	171028	0	0.0
			.data	5432	5432	0	0.0
			.heap	859984	859984	0	0.0
			.text	1198008	1198008	0	0.0
	pigweed-app	CY8CPROTO_062_4343W+release	.bss	11760	11760	0	0.0
			.data	4360	4360	0	0.0
			.heap	1020328	1020328	0	0.0
			.text	103064	103064	0	0.0
nrfconnect	lighting-app	nrf52840dk_nrf52840	bss	113184	113184	0	0.0
			rodata	98100	98100	0	0.0
			text	577196	577196	0	0.0
	lock-app	nrf52840dk_nrf52840	bss	112256	112256	0	0.0
			rodata	94500	94500	0	0.0
			text	558684	558684	0	0.0
	pigweed-app	nrf52840dk_nrf52840	bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339456	339456	0	0.0
	pump-app	nrf52840dk_nrf52840	bss	112316	112316	0	0.0
			rodata	95396	95396	0	0.0
			text	561836	561836	0	0.0
	pump-controller-app	nrf52840dk_nrf52840	bss	112252	112252	0	0.0
			rodata	94476	94476	0	0.0
			text	558476	558476	0	0.0
	shell	nrf52840dk_nrf52840	bss	109072	109072	0	0.0
			rodata	72524	72524	0	0.0
			text	520300	520300	0	0.0
	lighting-app	nrf52840dk_nrf52840+rpc	bss	109424	109424	0	0.0
			rodata	88876	88876	0	0.0
			text	550388	550388	0	0.0
		nrf5340dk_nrf5340_cpuapp	bss	114556	114556	0	0.0
			rodata	93340	93340	0	0.0
			text	506664	506664	0	0.0
	lock-app	nrf5340dk_nrf5340_cpuapp	bss	113628	113628	0	0.0
			rodata	89760	89760	0	0.0
			text	488148	488148	0	0.0
	shell	nrf5340dk_nrf5340_cpuapp	bss	110056	110056	0	0.0
			rodata	67168	67168	0	0.0
			text	440908	440908	0	0.0
p6	lock-app	default	.bss	68224	68224	0	0.0
			.data	2416	2416	0	0.0
			.heap	962704	962704	0	0.0
			.text	1127000	1127000	0	0.0
qpg	lighting-app	qpg6100+debug	.bss	53472	53472	0	0.0
			.data	1004	1004	0	0.0
			.text	486024	486024	0	0.0
	lock-app	qpg6100+debug	.bss	52416	52416	0	0.0
			.data	960	960	0	0.0
			.text	462180	462180	0	0.0
	persistent-storage-app	qpg6100+debug	.bss	27752	27752	0	0.0
			.data	372	372	0	0.0
			.text	149896	149896	0	0.0
telink	lighting-app	tlsr9518adk80d	bss	71004	71004	0	0.0
			noinit	33216	33216	0	0.0
			text	457664	457664	0	0.0