Display endpoint list #10942
Merged
Display endpoint list #10942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
tcarmelveilleux,
tecimovic,
turon and
vivien-apple
JasonLiuZhuoCheng
force-pushed
the
display-endpoint
branch
from
22af85e to
1c859a5
Compare
fill out parameter types }}connectedhomeip/src/controller/java/templates/ClusterInfo-java.zapt Lines 93 to 96 in 1c859a5 This comment was generated by todo based on a
|
|
@chrisdecenzo @Damian-Nordic @jelderton @jmartinez-silabs @saurabhst can you help review? Thanks! |
saurabhst
approved these changes
Oct 29, 2021
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 30, 2021
project-chip#10752 added a generated line based on a template that project-chip#10942 had removed.
bzbarsky-apple
added a commit
that referenced
this pull request
Oct 30, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* basic code generation template, but not able to import to tool app create new public class under chip/clusterinfo * change package * no error code generation * new design solution * need to wait for cast-helper * callback generation done * on/off commands working * revert .idea changes * one more .idea change revert * remove outline.java * Restyled by whitespace * Restyled by google-java-format * Restyled by gn * Restyled by google-java-format * fix merge * merge conflict * fix comments * Restyled by gn * resolve type, nullable and format comments * resolve build issues * Restyled by gn * update zap generated file * add descriptive documentation on each new class * Restyled by google-java-format * modify description of each new added class * Restyled by google-java-format * add . at the end of class description * Restyled by google-java-format * add recycler view to display endpoint * recycler view for endpoint display and test cluster detail screen done * change number of hard-coded enpoint to 2 * endpoint first draft done * resolve conflict * remove duplicate todo * fix comments * Restyled by whitespace * resolve comments * fix comments Co-authored-by: Restyled.io <commits@restyled.io>
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
project-chip#10752 added a generated line based on a template that project-chip#10942 had removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change overview
Display a list of endpoints on cluster-interaction screen. Now it is hard-coded to be 0 and 1. The endpoint list is implemented using recycler view. Also implemented customized onClickListener to go to cluster detail page after clicking on the endpoint list item.
Testing
manually tested.