Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use safer System::Clock types in dnssd #11062

Merged
merged 2 commits into from
Oct 27, 2021
Merged

Use safer System::Clock types in dnssd #11062

merged 2 commits into from
Oct 27, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Code uses plain integers to represent time values and relies on
users to get the unit scale correct.

Part of #10062 Some operations on System::Clock types are not safe

Change overview

Convert src/lib/dnssd to use the safer Clock types.

Testing

CI; no change to functionality intended.

Conversion includes TestActiveResolveAttempts.cpp.

@kpschoedel
Use safer System::Clock types in dnssd
1b0fda0 
#### Problem

Code uses plain integers to represent time values and relies on
users to get the unit scale correct.

Part of project-chip#10062 _Some operations on System::Clock types are not safe_

#### Change overview

Convert `src/lib/dnssd` to use the safer `Clock` types.

#### Testing

CI; no change to functionality intended.

Conversion includes `TestActiveResolveAttempts.cpp`.
@boring-cyborg boring-cyborg bot added the lib label Oct 27, 2021
@restyled-io restyled-io bot mentioned this pull request Oct 27, 2021
Closed
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #11062: Size comparison from b03b897 to 2c78c1b

Increases (10 builds for esp32, linux, p6)
platform target config section b03b897 2c78c1b change % change
esp32 all-clusters-app m5stack (read only) 907047 907135 88 0.0
.flash.text 907047 907135 88 0.0
linux all-clusters-app debug (read only) 1635553 1637393 1840 0.1
.text 1368338 1370178 1840 0.1
bridge-app debug+rpc (read only) 1276829 1277693 864 0.1
.text 1070869 1071733 864 0.1
chip-tool debug (read only) 4173517 4174525 1008 0.0
.text 3701221 3702229 1008 0.0
lighting-app debug+rpc (read only) 1528521 1530393 1872 0.1
.text 1268706 1270578 1872 0.1
ota-provider-app debug (read only) 1236097 1237969 1872 0.2
.text 1029218 1031090 1872 0.2
ota-requestor-app debug (read only) 1293249 1295089 1840 0.1
.text 1067906 1069746 1840 0.2
shell debug (read only) 779929 780953 1024 0.1
.text 602338 603362 1024 0.2
tv-app debug (read only) 1755353 1757225 1872 0.1
.text 1460754 1462626 1872 0.1
p6 lock-app default (read/write) 2169160 2169192 32 0.0
.text 1127424 1127456 32 0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b03b897 2c78c1b change % change
efr32 lighting-app BRD4161A (read only) 737080 737080 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737072 737072 0 0.0
BRD4161A+rpc (read only) 724508 724508 0 0.0
(read/write) 132048 132048 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724500 724500 0 0.0
lock-app BRD4161A (read only) 716344 716344 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716336 716336 0 0.0
window-app BRD4161A (read only) 717264 717264 0 0.0
(read/write) 113588 113588 0 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717256 717256 0 0.0
esp32 all-clusters-app c3devkit (read only) 875950 875950 0 0.0
(read/write) 1306520 1306520 0 0.0
.dram0.bss 58248 58248 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198568 198568 0 0.0
.flash.text 875950 875950 0 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 907047 907135 88 0.0
(read/write) 426312 426312 0 0.0
.dram0.bss 60752 60752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207312 207312 0 0.0
.flash.text 907047 907135 88 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701160 701160 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614740 614740 0 0.0
lock-app k32w061+debug (read/write) 592964 592964 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516104 516104 0 0.0
shell k32w061+debug (read/write) 425252 425252 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359620 359620 0 0.0
linux all-clusters-app debug (read only) 1635553 1637393 1840 0.1
(read/write) 117472 117472 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60928 60928 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135477 135477 0 0.0
.text 1368338 1370178 1840 0.1
bridge-app debug+rpc (read only) 1276829 1277693 864 0.1
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110620 110620 0 0.0
.text 1070869 1071733 864 0.1
chip-tool debug (read only) 4173517 4174525 1008 0.0
(read/write) 120896 120896 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 96208 96208 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 212400 212400 0 0.0
.text 3701221 3702229 1008 0.0
lighting-app debug+rpc (read only) 1528521 1530393 1872 0.1
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127793 127793 0 0.0
.text 1268706 1270578 1872 0.1
ota-provider-app debug (read only) 1236097 1237969 1872 0.2
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110920 110920 0 0.0
.text 1029218 1031090 1872 0.2
ota-requestor-app debug (read only) 1293249 1295089 1840 0.1
(read/write) 76296 76296 0 0.0
.bss 44992 44992 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127744 127744 0 0.0
.text 1067906 1069746 1840 0.2
shell debug (read only) 779929 780953 1024 0.1
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76463 76463 0 0.0
.text 602338 603362 1024 0.2
tv-app debug (read only) 1755353 1757225 1872 0.1
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152888 152888 0 0.0
.text 1460754 1462626 1872 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288776 2288776 0 0.0
.bss 179612 179612 0 0.0
.data 5192 5192 0 0.0
.heap 851640 851640 0 0.0
.text 1251376 1251376 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255960 2255960 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218560 1218560 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233992 2233992 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196592 1196592 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862903 862903 0 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577632 577632 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823743 823743 0 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550824 550824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787926 787926 0 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507104 507104 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839847 839847 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559192 559192 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764874 764874 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488656 488656 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844247 844247 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562296 562296 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839567 839567 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 558936 558936 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776435 776435 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520232 520232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691490 691490 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440844 440844 0 0.0
p6 lock-app default (read/write) 2169160 2169192 32 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127424 1127456 32 0.0
qpg lighting-app qpg6100+debug (read only) 491328 491328 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 486008 486008 0 0.0
lock-app qpg6100+debug (read only) 467548 467548 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462228 462228 0 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664606 664606 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458202 458202 0 0.0

@andy31415 andy31415 merged commit b31501f into project-chip:master Oct 27, 2021
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@kpschoedel @JasonLiuZhuoCheng
Use safer System::Clock types in dnssd (project-chip#11062)
d8ae450 
* Use safer System::Clock types in dnssd

#### Problem

Code uses plain integers to represent time values and relies on
users to get the unit scale correct.

Part of project-chip#10062 _Some operations on System::Clock types are not safe_

#### Change overview

Convert `src/lib/dnssd` to use the safer `Clock` types.

#### Testing

CI; no change to functionality intended.

Conversion includes `TestActiveResolveAttempts.cpp`.

* restyle
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@kpschoedel @carol-apple
Use safer System::Clock types in dnssd (project-chip#11062)
539c562 
* Use safer System::Clock types in dnssd

#### Problem

Code uses plain integers to represent time values and relies on
users to get the unit scale correct.

Part of project-chip#10062 _Some operations on System::Clock types are not safe_

#### Change overview

Convert `src/lib/dnssd` to use the safer `Clock` types.

#### Testing

CI; no change to functionality intended.

Conversion includes `TestActiveResolveAttempts.cpp`.

* restyle
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kpschoedel
Use safer System::Clock types in dnssd (project-chip#11062)
c1e0dd9 
* Use safer System::Clock types in dnssd

#### Problem

Code uses plain integers to represent time values and relies on
users to get the unit scale correct.

Part of project-chip#10062 _Some operations on System::Clock types are not safe_

#### Change overview

Convert `src/lib/dnssd` to use the safer `Clock` types.

#### Testing

CI; no change to functionality intended.

Conversion includes `TestActiveResolveAttempts.cpp`.

* restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
fast track lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpschoedel @andy31415 @woody-apple