Split CHIPClusters.cpp to speed up compilation. #11091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller and
woody-apple
LuDuda
approved these changes
Oct 27, 2021
mrjerryjohns
changed the title
|
PR #11091: Size comparison from 4b6486f to d3e2f1e Full report (27 builds for efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 27, 2021
src/app/zap-templates/templates/app/CHIPClustersInvoke-src.zapt
Outdated
Show resolved
Hide resolved
src/app/zap-templates/templates/app/CHIPClustersInvoke-src.zapt
Outdated
Show resolved
Hide resolved
yunhanw-google
approved these changes
Oct 27, 2021
woody-apple
approved these changes
Oct 28, 2021
|
PR #11091: Size comparison from 4b6486f to 932f364 Increases (21 builds for efr32, k32w, mbed, nrfconnect, qpg, telink)
Decreases (3 builds for efr32, nrfconnect, p6)
Full report (27 builds for efr32, k32w, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Oct 28, 2021
|
/rebase |
andy31415
approved these changes
Oct 28, 2021
This splits up CHIPClusters.cpp into a couple of different files:
- CHIPClusters.cpp contains no template specialized methods.
- CHIPClustersInvoke.cpp contains all template specialized
methods for invoking commands.
- CHIPClustersWrite.cpp contains all template specialized
methods for doing writes.
This resulted in a speed-up of about 30s (from 1m50s to 1m20s) when
doing an incremental compilation of chip-tool after touching CHIPClusters.cpp.
It does this by better leveraging -jX builds to parallelize compilation.
More importantly, this might also provide a pattern for others (like
Android) that is running into OOM issues with clang compiling
CHIPClusters.cpp.
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
woody-apple
force-pushed
the
split-chipclusters
branch
from
932f364
to
09131e1
Compare
|
PR #11091: Size comparison from 149e582 to ee570cb Increases (2 builds for linux, telink)
Decreases (11 builds for efr32, linux, qpg)
Full report (20 builds for efr32, k32w, linux, p6, qpg, telink)
|
|
PR #11091: Size comparison from 149e582 to 91dad09 Increases above 0.2%:
Increases (27 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (10 builds for linux, mbed, qpg)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* Split CHIPClusters.cpp
This splits up CHIPClusters.cpp into a couple of different files:
- CHIPClusters.cpp contains no template specialized methods.
- CHIPClustersInvoke.cpp contains all template specialized
methods for invoking commands.
- CHIPClustersWrite.cpp contains all template specialized
methods for doing writes.
This resulted in a speed-up of about 30s (from 1m50s to 1m20s) when
doing an incremental compilation of chip-tool after touching CHIPClusters.cpp.
It does this by better leveraging -jX builds to parallelize compilation.
More importantly, this might also provide a pattern for others (like
Android) that is running into OOM issues with clang compiling
CHIPClusters.cpp.
* Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
* Fix regen breakaga
* Address review feedback
Co-authored-by: Justin Wood <woody@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits up
CHIPClusters.cppinto a couple of different files:CHIPClusters.cppcontains no template specialized methods.CHIPClustersInvoke.cppcontains all template specialized methods for invoking commands.CHIPClustersWrite.cppcontains all template specialized methods for doing writes.This resulted in a speed-up of about 30s (from 1m50s to 1m20s) when
doing an incremental compilation of chip-tool after touching
CHIPClusters*.cpp.It does this by better leveraging
-jXbuilds to parallelize compilation.More importantly, this might also provide a pattern for others (like
Android) that is running into OOM issues with clang compiling
CHIPClusters.cpp.