-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for null in yaml tests. #11139
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:support-null-in-yaml
Oct 28, 2021
Merged
Add support for null in yaml tests. #11139
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:support-null-in-yaml
Oct 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for sending null as a command argument and for null in the expected value.
bzbarsky-apple
force-pushed
the
support-null-in-yaml
branch
from
October 28, 2021 16:55
c797dda
to
af99537
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple and
sagar-apple
October 28, 2021 16:57
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
October 28, 2021 16:57
PR #11139: Size comparison from 149e582 to af99537 Increases (5 builds for esp32, linux, mbed)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Oct 28, 2021
woody-apple
approved these changes
Oct 28, 2021
Fast tracking this to unblock testing. |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Adds support for sending null as a command argument and for null in the expected value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for sending null as a command argument and for null in
the expected value.
Problem
Can't test things involving null values in yaml.
Change overview
Add support for it.
Testing
Tests are modified to exercise this functionality in a simple case.