-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K32W0][THREADIP-3658] Fix lighting app #11192
Merged
andy31415
merged 2 commits into
project-chip:master
from
doru91:integrate/fix_lighting_app
Oct 29, 2021
Merged
[K32W0][THREADIP-3658] Fix lighting app #11192
andy31415
merged 2 commits into
project-chip:master
from
doru91:integrate/fix_lighting_app
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
October 29, 2021 14:16
pullapprove
bot
requested review from
tecimovic,
turon,
vivien-apple,
wbschiller and
woody-apple
October 29, 2021 14:16
PR #11192: Size comparison from 06f9a38 to 9a5d38f Decreases (1 build for k32w)
Full report (16 builds for k32w, linux, p6, qpg, telink)
|
/rebase |
* remove dead code * fix bug where the cluster state was not in sync with the physical button state * add stubs for ColorControl/LevelControl clusters. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
woody-apple
force-pushed
the
integrate/fix_lighting_app
branch
from
October 29, 2021 16:40
9a5d38f
to
687e631
Compare
andy31415
approved these changes
Oct 29, 2021
fast track: platform specific app change performed by platform owner |
saurabhst
approved these changes
Oct 29, 2021
doru91
added a commit
to doru91/connectedhomeip
that referenced
this pull request
Nov 12, 2021
* remove dead code * fix bug where the cluster state was not in sync with the physical button state * add stubs for ColorControl/LevelControl clusters. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
doru91
added a commit
to doru91/connectedhomeip
that referenced
this pull request
Nov 12, 2021
* remove dead code * fix bug where the cluster state was not in sync with the physical button state * add stubs for ColorControl/LevelControl clusters. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
andy31415
pushed a commit
that referenced
this pull request
Nov 12, 2021
* [K32W0][THREADIP-3658] Fix lighting app * remove dead code * fix bug where the cluster state was not in sync with the physical button state * add stubs for ColorControl/LevelControl clusters. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
andy31415
pushed a commit
that referenced
this pull request
Nov 12, 2021
* remove dead code * fix bug where the cluster state was not in sync with the physical button state * add stubs for ColorControl/LevelControl clusters. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
pankore
pushed a commit
to pankore/connectedhomeip
that referenced
this pull request
Nov 24, 2021
* remove dead code * fix bug where the cluster state was not in sync with the physical button state * add stubs for ColorControl/LevelControl clusters. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io> Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* [K32W0][THREADIP-3658] Fix lighting app * remove dead code * fix bug where the cluster state was not in sync with the physical button state * add stubs for ColorControl/LevelControl clusters. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lighting app had several problems.
Change overview
Testing
Manual testing using chip-device-ctrl and TE6 branch.