[app] Forget exchange context when SubscribeResponse is received #11211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vivien-apple and
wbschiller
pullapprove
bot
requested review from
woody-apple,
yufengwangca and
yunhanw-google
Damian-Nordic
force-pushed
the
susbcribe-assert
branch
from
0f5c6d3 to
f332c1f
Compare
|
PR #11211: Size comparison from 69423bc to f332c1f Increases (19 builds for esp32, k32w, linux, nrfconnect, qpg, telink)
Decreases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Oct 29, 2021
andy31415
approved these changes
Nov 1, 2021
LuDuda
approved these changes
Nov 1, 2021
msandstedt
approved these changes
Nov 1, 2021
SubscribeResponse is the last action in the Subscribe transaction and ExchangeContext::HandleMessage automatically closes exchanges that have no pending requests nor responses. ReadClient still kept the pointer to the exchange after receiving SubscribeResponse, so it would attempt to abort already closed exchange if the subscription was cancelled after receiving the SubscribeResponse and before receving a subsequent Report message.
Damian-Nordic
force-pushed
the
susbcribe-assert
branch
from
f332c1f to
e6ef7e9
Compare
|
PR #11211: Size comparison from 12ec702 to e6ef7e9 Increases (18 builds for efr32, esp32, linux, nrfconnect, qpg, telink)
Decreases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…ject-chip#11211) SubscribeResponse is the last action in the Subscribe transaction and ExchangeContext::HandleMessage automatically closes exchanges that have no pending requests nor responses. ReadClient still kept the pointer to the exchange after receiving SubscribeResponse, so it would attempt to abort already closed exchange if the subscription was cancelled after receiving the SubscribeResponse and before receving a subsequent Report message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SubscribeResponse is the last action in the Subscribe transaction and ExchangeContext::HandleMessage
automatically closes exchanges that have no pending requests nor responses.
ReadClient still kept the pointer to the exchange after receiving SubscribeResponse, so it would attempt to abort
already closed exchange if the subscription was cancelled after receiving the SubscribeResponse and before receving
a subsequent Report message.
Change overview
Let ReadClient forget the exchange context when SubscribeResponse is received.
Testing
Tested on hardware using Android CHIPTool and trying to unsubscribe from an attribute in random moments.
Also, added UT.