-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: OTA Requestor and OTA Provider example applications #11320
Conversation
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-provider-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in 70e6874
This comment was generated by todo based on a
|
handle this callback in switch statement
This comment was generated by todo based on a
|
this should probably be done dynamicallyconnectedhomeip/examples/ota-provider-app/esp32/main/main.cpp Lines 62 to 72 in 70e6874
This comment was generated by todo based on a
|
Use the OTA image header specified in specificationsconnectedhomeip/examples/ota-provider-app/esp32/main/main.cpp Lines 200 to 210 in 70e6874
This comment was generated by todo based on a
|
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-requestor-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in 70e6874
This comment was generated by todo based on a
|
handle this callback in switch statement
This comment was generated by todo based on a
|
support this as a list once ember adds list supportconnectedhomeip/examples/ota-requestor-app/esp32/main/OTARequesterImpl.cpp Lines 169 to 179 in 70e6874
This comment was generated by todo based on a
|
Encapsulate these globals and the callbacks in some classconnectedhomeip/examples/ota-requestor-app/esp32/main/OTARequesterImpl.cpp Lines 62 to 72 in 70e6874
This comment was generated by todo based on a
|
Apply update after delayed action timeconnectedhomeip/examples/ota-requestor-app/esp32/main/OTAUpdater.cpp Lines 123 to 133 in 70e6874
This comment was generated by todo based on a
|
Handle applying update after rebootconnectedhomeip/examples/ota-requestor-app/esp32/main/OTAUpdater.cpp Lines 124 to 134 in 70e6874
This comment was generated by todo based on a
|
With this approach we might end up adding callback for every bdx event/message.connectedhomeip/examples/ota-requestor-app/ota-requestor-common/BDXDownloader.h Lines 30 to 40 in 70e6874
This comment was generated by todo based on a
|
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-provider-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in d42865d
This comment was generated by todo based on a
|
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-requestor-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in d42865d
This comment was generated by todo based on a
|
Can we merge this? |
Needs to pass CI... |
AbortTransfer() needs to support GeneralStatusCode failures as well as BDX specific errors.connectedhomeip/examples/ota-provider-app/esp32/main/BdxOtaSender.cpp Lines 89 to 99 in 2e892ef
This comment was generated by todo based on a
|
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-provider-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in 2e892ef
This comment was generated by todo based on a
|
while convenient, we should not do a synchronous block write in our example application - this is bad practice
This comment was generated by todo based on a
|
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-requestor-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in 2e892ef
This comment was generated by todo based on a
|
Handle image URI for protocol other than bdxconnectedhomeip/examples/ota-requestor-app/esp32/main/OTARequesterImpl.cpp Lines 109 to 119 in 2e892ef
This comment was generated by todo based on a
|
Determine where this should be instantiatedconnectedhomeip/examples/ota-requestor-app/esp32/main/OTARequesterImpl.cpp Lines 291 to 301 in 2e892ef
This comment was generated by todo based on a
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Carol Yang <clyang@apple.com>
2e892ef
to
5b6c900
Compare
AbortTransfer() needs to support GeneralStatusCode failures as well as BDX specific errors.connectedhomeip/examples/ota-provider-app/esp32/main/BdxOtaSender.cpp Lines 89 to 99 in 5b6c900
This comment was generated by todo based on a
|
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-provider-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in 5b6c900
This comment was generated by todo based on a
|
while convenient, we should not do a synchronous block write in our example application - this is bad practice
This comment was generated by todo based on a
|
(cecille): Fix for the case where BLE and SoftAP are both enabled.`connectedhomeip/examples/ota-requestor-app/esp32/main/CHIPDeviceManager.cpp Lines 68 to 78 in 5b6c900
This comment was generated by todo based on a
|
Handle image URI for protocol other than bdxconnectedhomeip/examples/ota-requestor-app/esp32/main/OTARequesterImpl.cpp Lines 109 to 119 in 5b6c900
This comment was generated by todo based on a
|
Determine where this should be instantiatedconnectedhomeip/examples/ota-requestor-app/esp32/main/OTARequesterImpl.cpp Lines 291 to 301 in 5b6c900
This comment was generated by todo based on a
|
PR #11320: Size comparison from 5623978 to 5b6c900 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
All the CI checks passed, can we merge now? |
…hip#11320) * Added OTA requester and provider app for esp32 * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Addressed review comments * Addressed review comments * Apply suggestions from code review Co-authored-by: Carol Yang <clyang@apple.com> * Restyled by clang-format * Addressed review comments * Added few words to spellcheck dictionary * Added .gitignore files to esp32 ota apps Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> Co-authored-by: Carol Yang <clyang@apple.com> Co-authored-by: Restyled.io <commits@restyled.io>
Problem
Adding OTA Requestor and OTA Provider example applications for ESP32
Change overview
Testing
TODO