-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull up LayerLwIP::ScheduleLambda to SystemLayer #11361
Conversation
PR #11361: Size comparison from d5810e5 to 003a94b Increases (8 builds for linux)
Decreases (2 builds for p6)
Full report (16 builds for linux, mbed, p6, telink)
|
003a94b
to
77fe1ad
Compare
PR #11361: Size comparison from 4947759 to 77fe1ad Increases (8 builds for linux)
Decreases (11 builds for efr32, k32w, p6, qpg)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
77fe1ad
to
a934966
Compare
0f2bbda
to
178cffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not need ProcessDeviceEvents. RunEventLoop should work.
178cffb
to
a5ebd02
Compare
a5ebd02
to
6ea8928
Compare
PR #11361: Size comparison from ee7682d to 6ea8928 Increases above 0.2%:
Increases (8 builds for linux)
Decreases (13 builds for efr32, esp32, k32w, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
PR #11361: Size comparison from ee7682d to 6a8c1f4 Increases above 0.2%:
Increases (9 builds for esp32, linux)
Decreases (12 builds for efr32, esp32, k32w, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
6a8c1f4
to
3aae4e8
Compare
PR #11361: Size comparison from 6290269 to 3aae4e8 Decreases (2 builds for qpg)
Full report (4 builds for qpg, telink)
|
3aae4e8
to
8174144
Compare
PR #11361: Size comparison from 1538bbb to 8174144 Increases (9 builds for esp32, linux)
Decreases (12 builds for efr32, esp32, k32w, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
1f1e63b
to
dc7374a
Compare
dc7374a
to
8b264ef
Compare
8b264ef
to
c7b37bf
Compare
PR #11361: Size comparison from 29747a2 to c7b37bf Increases (31 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* Pull up LayerLwIP::ScheduleLambda to SystemLayer (project-chip#11187) * Fix ScheduleLambda and Add unit-tests
Problem
Re-post of #11187
Change overview
Pull up
LayerLwIP::ScheduleLambda
toSystemLayer
Implement
ScheduleLambdaBridge
forLayerImplLibevent
andLayerImplSelect
#11187 fails because
std::aligned_storage
is being used as a container, but it is actually a type traits.Fixed by using
std::aligned_storage<...>::type
instead ofstd::aligned_storage<...>
Add unit-tests to test
ScheduleLambda
Testing
Verified by unit-tests