-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPv6 multicast build method added to PeerAddress #11368
Merged
andy31415
merged 2 commits into
project-chip:master
from
rcasallas-silabs:group_address
Nov 12, 2021
Merged
IPv6 multicast build method added to PeerAddress #11368
andy31415
merged 2 commits into
project-chip:master
from
rcasallas-silabs:group_address
Nov 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
November 3, 2021 13:12
@andy31415 @bzbarsky-apple Looks like your comments are resolved? |
msandstedt
approved these changes
Nov 9, 2021
jepenven-silabs
approved these changes
Nov 9, 2021
bzbarsky-apple
approved these changes
Nov 10, 2021
rcasallas-silabs
changed the title
Group IPv6 address class added.
IPv6 multicast build method added to PeerAddress
Nov 10, 2021
rcasallas-silabs
force-pushed
the
group_address
branch
from
November 10, 2021 16:39
98094ad
to
e330694
Compare
PR #11368: Size comparison from 125ad20 to e330694 Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
group_address
branch
3 times, most recently
from
November 11, 2021 09:04
59ec113
to
219b9c6
Compare
PR #11368: Size comparison from d45cfaa to 219b9c6 Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
group_address
branch
2 times, most recently
from
November 11, 2021 11:56
0ea7b69
to
9ae9d50
Compare
PR #11368: Size comparison from d45cfaa to 9ae9d50 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
rcasallas-silabs
force-pushed
the
group_address
branch
from
November 11, 2021 18:48
9ae9d50
to
d4cb282
Compare
PR #11368: Size comparison from a7d17ac to d4cb282 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 12, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* PeerAddress: Added methods to construct the IPv6 Multicast Address. * PeerAddress: Code review comments applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Testing