-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable WiFi/BT for qemu_esp32 #11395
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #11395: Size comparison from 38fe11e to b8a60f0 Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
@sweetymhaiske could you take a look? |
bzbarsky-apple
approved these changes
Nov 4, 2021
msandstedt
approved these changes
Nov 4, 2021
PR #11395: Size comparison from ee7682d to 9c1a271 Increases above 0.2%:
Increases (9 builds for esp32, linux)
Decreases (2 builds for p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
gjc13
approved these changes
Nov 4, 2021
andy31415
approved these changes
Nov 4, 2021
fast track: platform specific change approved by a platform owner |
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
WiFi/BT crashes qemu_esp32 when loaded by
PlatformManager
Change overview
src/test_driver/esp32/main/main_app.cpp
(dup withPlatformManager::InitChipStack
)mInitialized
to false, when shutting downPlatformManager
, it is a hacky way to makeInitChipStack
reentrant, in order to run multiple test-cases in a batchTesting
Verified using unit-tests