Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log BDX messages #11510

Merged
merged 3 commits into from
Nov 9, 2021
Merged

Log BDX messages #11510

merged 3 commits into from
Nov 9, 2021

Conversation

carol-apple
Copy link
Contributor

Problem

Fixes: #11074

BDX messages are not logged

Change overview

Added logging of all supported BDX messages and the message parameters

Testing

Manually tested by initiating an OTA QueryImage command and see that BDX messages are logged to terminal

@restyled-io restyled-io bot mentioned this pull request Nov 6, 2021
Closed
bzbarsky-apple
bzbarsky-apple reviewed Nov 6, 2021
View reviewed changes
0001-Test-CASE-session-estabslishement-with-all-clusters-.patch Outdated Show resolved Hide resolved
test.bin Outdated Show resolved Hide resolved
@carol-apple carol-apple force-pushed the test_add_bdx_logging_te7 branch 2 times, most recently from bb15cbd to 3b2c6c2 Compare November 6, 2021 03:13
@carol-apple
Create a new macro ChipLogAutomation
a8b972d 
- This macro is to be used only for test validation purpose
@carol-apple carol-apple force-pushed the test_add_bdx_logging_te7 branch from 1933a0b to a8b972d Compare November 8, 2021 19:47
@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #11510: Size comparison from ced0520 to a8b972d

Increases above 0.2%:

platform target config section ced0520 a8b972d change % change
linux ota-provider-app debug .rodata 112488 112960 472 0.4
ota-requestor-app debug .rodata 124464 124936 472 0.4
Increases (23 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section ced0520 a8b972d change % change
efr32 lighting-app BRD4161A+rpc (read only) 729864 729872 8 0.0
.text 729856 729864 8 0.0
lock-app BRD4161A (read only) 721600 721608 8 0.0
.text 721592 721600 8 0.0
window-app BRD4161A (read only) 722496 722504 8 0.0
.text 722488 722496 8 0.0
esp32 all-clusters-app m5stack (read only) 911395 911411 16 0.0
.flash.text 911395 911411 16 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699132 4 0.0
.text 613440 613444 4 0.0
lock-app k32w061+debug (read/write) 591952 591956 4 0.0
.text 515764 515768 4 0.0
shell k32w061+debug (read/write) 657608 657612 4 0.0
.text 570652 570656 4 0.0
linux ota-provider-app debug (read only) 1251785 1254129 2344 0.2
(read/write) 74632 74696 64 0.1
.data.rel.ro 24440 24488 48 0.2
.rodata 112488 112960 472 0.4
.text 1043362 1045090 1728 0.2
ota-requestor-app debug (read only) 1330305 1332617 2312 0.2
(read/write) 83920 83952 32 0.0
.data.rel.ro 25448 25496 48 0.2
.rodata 124464 124936 472 0.4
.text 1107954 1109650 1696 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861779 861783 4 0.0
rodata 96932 96936 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 824127 824131 4 0.0
rodata 88112 88116 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786822 786826 4 0.0
rodata 92192 92196 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838487 838491 4 0.0
rodata 93304 93308 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763798 763802 4 0.0
rodata 88608 88612 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497327 4 0.0
rodata 45776 45780 4 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844579 844583 4 0.0
rodata 95012 95016 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838343 838347 4 0.0
rodata 93304 93308 4 0.0
shell nrf52840dk_nrf52840 (read/write) 776375 776379 4 0.0
rodata 72540 72544 4 0.0
p6 lock-app default (read/write) 2211592 2211600 8 0.0
.text 1169856 1169864 8 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490280 4 0.0
.text 484956 484960 4 0.0
lock-app qpg6100+debug (read only) 466616 466620 4 0.0
.text 461296 461300 4 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153400 4 0.0
.text 148076 148080 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663422 4 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ced0520 a8b972d change % change
efr32 lighting-app BRD4161A (read only) 742336 742336 0 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742328 742328 0 0.0
BRD4161A+rpc (read only) 729864 729872 8 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 729856 729864 8 0.0
lock-app BRD4161A (read only) 721600 721608 8 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721592 721600 8 0.0
window-app BRD4161A (read only) 722496 722504 8 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722488 722496 8 0.0
esp32 all-clusters-app c3devkit (read only) 880266 880266 0 0.0
(read/write) 1306488 1306488 0 0.0
.dram0.bss 58400 58400 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198376 198376 0 0.0
.flash.text 880266 880266 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911395 911411 16 0.0
(read/write) 423808 423808 0 0.0
.dram0.bss 60904 60904 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204632 204632 0 0.0
.flash.text 911395 911411 16 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699132 4 0.0
.bss 77976 77976 0 0.0
.data 1912 1912 0 0.0
.text 613440 613444 4 0.0
lock-app k32w061+debug (read/write) 591952 591956 4 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 515764 515768 4 0.0
shell k32w061+debug (read/write) 657608 657612 4 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570652 570656 4 0.0
linux all-clusters-app debug (read only) 1704545 1704545 0 0.0
(read/write) 125888 125888 0 0.0
.bss 57360 57360 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62208 62208 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139477 139477 0 0.0
.text 1431794 1431794 0 0.0
bridge-app debug+rpc (read only) 1292549 1292549 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111252 111252 0 0.0
.text 1085573 1085573 0 0.0
chip-tool debug (read only) 4921613 4921613 0 0.0
(read/write) 133160 133160 0 0.0
.bss 25328 25328 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100192 100192 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 233712 233712 0 0.0
.text 4419125 4419125 0 0.0
lighting-app debug+rpc (read only) 1553545 1553545 0 0.0
(read/write) 109432 109432 0 0.0
.bss 47928 47928 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129873 129873 0 0.0
.text 1290258 1290258 0 0.0
ota-provider-app debug (read only) 1251785 1254129 2344 0.2
(read/write) 74632 74696 64 0.1
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24440 24488 48 0.2
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112488 112960 472 0.4
.text 1043362 1045090 1728 0.2
ota-requestor-app debug (read only) 1330305 1332617 2312 0.2
(read/write) 83920 83952 32 0.0
.bss 52512 52512 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25448 25496 48 0.2
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124464 124936 472 0.4
.text 1107954 1109650 1696 0.2
shell debug (read only) 788153 788153 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78127 78127 0 0.0
.text 608754 608754 0 0.0
tv-app debug (read only) 1818705 1818705 0 0.0
(read/write) 297568 297568 0 0.0
.bss 230512 230512 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155528 155528 0 0.0
.text 1521058 1521058 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291552 2291552 0 0.0
.bss 179404 179404 0 0.0
.data 5232 5232 0 0.0
.heap 851808 851808 0 0.0
.text 1254152 1254152 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271648 2271648 0 0.0
.bss 172460 172460 0 0.0
.data 5584 5584 0 0.0
.heap 858400 858400 0 0.0
.text 1234248 1234248 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249368 2249368 0 0.0
.bss 171356 171356 0 0.0
.data 5568 5568 0 0.0
.heap 859520 859520 0 0.0
.text 1211968 1211968 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861779 861783 4 0.0
bss 111444 111444 0 0.0
rodata 96932 96936 4 0.0
text 577776 577776 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824127 824131 4 0.0
bss 107796 107796 0 0.0
rodata 88112 88116 4 0.0
text 551924 551924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786822 786826 4 0.0
bss 112816 112816 0 0.0
rodata 92192 92196 4 0.0
text 507248 507248 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838487 838491 4 0.0
bss 110476 110476 0 0.0
rodata 93304 93308 4 0.0
text 559256 559256 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763798 763802 4 0.0
bss 111888 111888 0 0.0
rodata 88608 88612 4 0.0
text 488820 488820 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497327 4 0.0
bss 51824 51824 0 0.0
rodata 45776 45780 4 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844579 844583 4 0.0
bss 110616 110616 0 0.0
rodata 95012 95016 4 0.0
text 563420 563420 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838343 838347 4 0.0
bss 110512 110512 0 0.0
rodata 93304 93308 4 0.0
text 558992 558992 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776375 776379 4 0.0
bss 109264 109264 0 0.0
rodata 72540 72544 4 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2298888 2298888 0 0.0
.bss 111936 111936 0 0.0
.data 2536 2536 0 0.0
.heap 918872 918872 0 0.0
.text 1257152 1257152 0 0.0
lock-app default (read/write) 2211592 2211600 8 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1169856 1169864 8 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490280 4 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 484956 484960 4 0.0
lock-app qpg6100+debug (read only) 466616 466620 4 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461296 461300 4 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153400 4 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148080 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663422 4 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458266 458266 0 0.0

@carol-apple carol-apple mentioned this pull request Nov 8, 2021
Closed
@carol-apple carol-apple force-pushed the test_add_bdx_logging_te7 branch from 4aaba2d to ff3c6de Compare November 8, 2021 21:09
@restyled-io restyled-io bot mentioned this pull request Nov 8, 2021
Closed
@carol-apple carol-apple force-pushed the test_add_bdx_logging_te7 branch from ff3c6de to da70575 Compare November 8, 2021 21:10
@andy31415 andy31415 dismissed their stale review November 8, 2021 21:14

Removed change requested after latest updates

@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #11510: Size comparison from 86511a1 to da70575

Increases above 0.2%:

platform target config section 86511a1 da70575 change % change
linux ota-provider-app debug .rodata 112488 112960 472 0.4
ota-requestor-app debug .rodata 124464 124936 472 0.4
Increases (13 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 86511a1 da70575 change % change
efr32 lighting-app BRD4161A+rpc (read only) 729864 729872 8 0.0
.text 729856 729864 8 0.0
lock-app BRD4161A (read only) 721600 721608 8 0.0
.text 721592 721600 8 0.0
window-app BRD4161A (read only) 722496 722504 8 0.0
.text 722488 722496 8 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699132 4 0.0
.text 613440 613444 4 0.0
lock-app k32w061+debug (read/write) 591952 591956 4 0.0
.text 515764 515768 4 0.0
shell k32w061+debug (read/write) 657608 657612 4 0.0
.text 570652 570656 4 0.0
linux ota-provider-app debug (read only) 1251785 1254033 2248 0.2
(read/write) 74632 74696 64 0.1
.data.rel.ro 24440 24488 48 0.2
.rodata 112488 112960 472 0.4
.text 1043362 1044994 1632 0.2
ota-requestor-app debug (read only) 1330305 1332569 2264 0.2
(read/write) 83920 83952 32 0.0
.data.rel.ro 25448 25496 48 0.2
.rodata 124464 124936 472 0.4
.text 1107954 1109602 1648 0.1
p6 lock-app default (read/write) 2211592 2211600 8 0.0
.text 1169856 1169864 8 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490280 4 0.0
.text 484956 484960 4 0.0
lock-app qpg6100+debug (read only) 466616 466620 4 0.0
.text 461296 461300 4 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153400 4 0.0
.text 148076 148080 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663422 4 0.0
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 86511a1 da70575 change % change
efr32 lighting-app BRD4161A (read only) 742336 742336 0 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742328 742328 0 0.0
BRD4161A+rpc (read only) 729864 729872 8 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 729856 729864 8 0.0
lock-app BRD4161A (read only) 721600 721608 8 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721592 721600 8 0.0
window-app BRD4161A (read only) 722496 722504 8 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722488 722496 8 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699128 699132 4 0.0
.bss 77976 77976 0 0.0
.data 1912 1912 0 0.0
.text 613440 613444 4 0.0
lock-app k32w061+debug (read/write) 591952 591956 4 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 515764 515768 4 0.0
shell k32w061+debug (read/write) 657608 657612 4 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570652 570656 4 0.0
linux all-clusters-app debug (read only) 1704545 1704545 0 0.0
(read/write) 125888 125888 0 0.0
.bss 57360 57360 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62208 62208 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139477 139477 0 0.0
.text 1431794 1431794 0 0.0
bridge-app debug+rpc (read only) 1292549 1292549 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111252 111252 0 0.0
.text 1085573 1085573 0 0.0
chip-tool debug (read only) 4921613 4921613 0 0.0
(read/write) 133160 133160 0 0.0
.bss 25328 25328 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100192 100192 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 233712 233712 0 0.0
.text 4419125 4419125 0 0.0
lighting-app debug+rpc (read only) 1553545 1553545 0 0.0
(read/write) 109432 109432 0 0.0
.bss 47928 47928 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129873 129873 0 0.0
.text 1290258 1290258 0 0.0
ota-provider-app debug (read only) 1251785 1254033 2248 0.2
(read/write) 74632 74696 64 0.1
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24440 24488 48 0.2
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112488 112960 472 0.4
.text 1043362 1044994 1632 0.2
ota-requestor-app debug (read only) 1330305 1332569 2264 0.2
(read/write) 83920 83952 32 0.0
.bss 52512 52512 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25448 25496 48 0.2
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124464 124936 472 0.4
.text 1107954 1109602 1648 0.1
shell debug (read only) 788153 788153 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78127 78127 0 0.0
.text 608754 608754 0 0.0
tv-app debug (read only) 1818705 1818705 0 0.0
(read/write) 297568 297568 0 0.0
.bss 230512 230512 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155528 155528 0 0.0
.text 1521058 1521058 0 0.0
p6 all-clusters-app default (read/write) 2298888 2298888 0 0.0
.bss 111936 111936 0 0.0
.data 2536 2536 0 0.0
.heap 918872 918872 0 0.0
.text 1257152 1257152 0 0.0
lock-app default (read/write) 2211592 2211600 8 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1169856 1169864 8 0.0
qpg lighting-app qpg6100+debug (read only) 490276 490280 4 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 484956 484960 4 0.0
lock-app qpg6100+debug (read only) 466616 466620 4 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461296 461300 4 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153400 4 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148080 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 663418 663422 4 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458266 458266 0 0.0

@carol-apple
Remove private struct members from BdxMessage types
d9dfb5a 
- Pass in the message type directly during logging
@carol-apple carol-apple force-pushed the test_add_bdx_logging_te7 branch from da70575 to d9dfb5a Compare November 8, 2021 21:47
@github-actions
Copy link

github-actions bot commented Nov 8, 2021 •
edited
Loading

PR #11510: Size comparison from b717b36 to d9dfb5a

Increases above 0.2%:

platform target config section b717b36 d9dfb5a change % change
linux ota-provider-app debug .rodata 112776 113216 440 0.4
ota-requestor-app debug .rodata 124784 125256 472 0.4
Increases (20 builds for efr32, esp32, k32w, linux, nrfconnect, p6, qpg, telink)
platform target config section b717b36 d9dfb5a change % change
efr32 lighting-app BRD4161A (read only) 742648 742656 8 0.0
.text 742640 742648 8 0.0
esp32 all-clusters-app c3devkit (read/write) 1306448 1306456 8 0.0
.flash.rodata 198336 198344 8 0.0
m5stack (read/write) 423768 423776 8 0.0
.flash.rodata 204592 204600 8 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699460 699464 4 0.0
.text 613772 613776 4 0.0
lock-app k32w061+debug (read/write) 592268 592272 4 0.0
.text 516080 516084 4 0.0
shell k32w061+debug (read/write) 657940 657944 4 0.0
.text 570984 570988 4 0.0
linux ota-provider-app debug (read only) 1256905 1259121 2216 0.2
(read/write) 74632 74696 64 0.1
.data.rel.ro 24440 24488 48 0.2
.rodata 112776 113216 440 0.4
.text 1048194 1049826 1632 0.2
ota-requestor-app debug (read only) 1335521 1337785 2264 0.2
(read/write) 83920 83952 32 0.0
.data.rel.ro 25448 25496 48 0.2
.rodata 124784 125256 472 0.4
.text 1112850 1114498 1648 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862067 862071 4 0.0
rodata 96900 96904 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 824415 824419 4 0.0
rodata 88080 88084 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838775 838779 4 0.0
rodata 93272 93276 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764086 764090 4 0.0
rodata 88576 88580 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497327 4 0.0
rodata 45776 45780 4 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844867 844871 4 0.0
rodata 94980 94984 4 0.0
shell nrf52840dk_nrf52840 (read/write) 776375 776379 4 0.0
rodata 72540 72544 4 0.0
p6 all-clusters-app default (read/write) 2299200 2299208 8 0.0
.text 1257464 1257472 8 0.0
qpg lighting-app qpg6100+debug (read only) 490588 490592 4 0.0
.text 485268 485272 4 0.0
lock-app qpg6100+debug (read only) 466928 466932 4 0.0
.text 461608 461612 4 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153400 4 0.0
.text 148076 148080 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 663678 663682 4 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b717b36 d9dfb5a change % change
efr32 lighting-app BRD4161A (read only) 742648 742656 8 0.0
(read/write) 116236 116236 0 0.0
.bss 114452 114452 0 0.0
.data 1784 1784 0 0.0
.text 742640 742648 8 0.0
BRD4161A+rpc (read only) 730184 730184 0 0.0
(read/write) 132860 132860 0 0.0
.bss 130956 130956 0 0.0
.data 1900 1900 0 0.0
.text 730176 730176 0 0.0
lock-app BRD4161A (read only) 721920 721920 0 0.0
(read/write) 114052 114052 0 0.0
.bss 112308 112308 0 0.0
.data 1744 1744 0 0.0
.text 721912 721912 0 0.0
window-app BRD4161A (read only) 722816 722816 0 0.0
(read/write) 114380 114380 0 0.0
.bss 112628 112628 0 0.0
.data 1748 1748 0 0.0
.text 722808 722808 0 0.0
esp32 all-clusters-app c3devkit (read only) 880598 880598 0 0.0
(read/write) 1306448 1306456 8 0.0
.dram0.bss 58400 58400 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198336 198344 8 0.0
.flash.text 880598 880598 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911763 911763 0 0.0
(read/write) 423768 423776 8 0.0
.dram0.bss 60904 60904 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204592 204600 8 0.0
.flash.text 911763 911763 0 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699460 699464 4 0.0
.bss 77976 77976 0 0.0
.data 1912 1912 0 0.0
.text 613772 613776 4 0.0
lock-app k32w061+debug (read/write) 592268 592272 4 0.0
.bss 68508 68508 0 0.0
.data 1880 1880 0 0.0
.text 516080 516084 4 0.0
shell k32w061+debug (read/write) 657940 657944 4 0.0
.bss 79308 79308 0 0.0
.data 1848 1848 0 0.0
.text 570984 570988 4 0.0
linux all-clusters-app debug (read only) 1709665 1709665 0 0.0
(read/write) 125888 125888 0 0.0
.bss 57360 57360 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62208 62208 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139765 0 0.0
.text 1436626 1436626 0 0.0
bridge-app debug+rpc (read only) 1297669 1297669 0 0.0
(read/write) 76432 76432 0 0.0
.bss 42256 42256 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27640 27640 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090405 1090405 0 0.0
chip-tool debug (read only) 4926973 4926973 0 0.0
(read/write) 133160 133160 0 0.0
.bss 25328 25328 0 0.0
.data 2224 2224 0 0.0
.data.rel.ro 100192 100192 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 234000 234000 0 0.0
.text 4424197 4424197 0 0.0
lighting-app debug+rpc (read only) 1558633 1558633 0 0.0
(read/write) 109432 109432 0 0.0
.bss 47928 47928 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 55040 55040 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 130129 130129 0 0.0
.text 1295090 1295090 0 0.0
ota-provider-app debug (read only) 1256905 1259121 2216 0.2
(read/write) 74632 74696 64 0.1
.bss 44352 44352 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24440 24488 48 0.2
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112776 113216 440 0.4
.text 1048194 1049826 1632 0.2
ota-requestor-app debug (read only) 1335521 1337785 2264 0.2
(read/write) 83920 83952 32 0.0
.bss 52512 52512 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25448 25496 48 0.2
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 124784 125256 472 0.4
.text 1112850 1114498 1648 0.1
shell debug (read only) 788233 788233 0 0.0
(read/write) 64808 64808 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36656 36656 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 608770 608770 0 0.0
tv-app debug (read only) 1823889 1823889 0 0.0
(read/write) 297568 297568 0 0.0
.bss 230512 230512 0 0.0
.data 2704 2704 0 0.0
.data.rel.ro 58696 58696 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155816 155816 0 0.0
.text 1525954 1525954 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290768 2290768 0 0.0
.bss 179404 179404 0 0.0
.data 5232 5232 0 0.0
.heap 851808 851808 0 0.0
.text 1253368 1253368 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270864 2270864 0 0.0
.bss 172460 172460 0 0.0
.data 5584 5584 0 0.0
.heap 858400 858400 0 0.0
.text 1233464 1233464 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248584 2248584 0 0.0
.bss 171356 171356 0 0.0
.data 5568 5568 0 0.0
.heap 859520 859520 0 0.0
.text 1211184 1211184 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048760 2048760 0 0.0
.bss 156424 156424 0 0.0
.data 4976 4976 0 0.0
.heap 875048 875048 0 0.0
.text 1011360 1011360 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862067 862071 4 0.0
bss 111444 111444 0 0.0
rodata 96900 96904 4 0.0
text 578096 578096 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824415 824419 4 0.0
bss 107796 107796 0 0.0
rodata 88080 88084 4 0.0
text 552244 552244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787110 787110 0 0.0
bss 112816 112816 0 0.0
rodata 92160 92160 0 0.0
text 507568 507568 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838775 838779 4 0.0
bss 110476 110476 0 0.0
rodata 93272 93276 4 0.0
text 559580 559580 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764086 764090 4 0.0
bss 111888 111888 0 0.0
rodata 88576 88580 4 0.0
text 489144 489144 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497327 4 0.0
bss 51824 51824 0 0.0
rodata 45776 45780 4 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844867 844871 4 0.0
bss 110616 110616 0 0.0
rodata 94980 94984 4 0.0
text 563740 563740 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838647 838647 0 0.0
bss 110512 110512 0 0.0
rodata 93272 93272 0 0.0
text 559316 559316 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776375 776379 4 0.0
bss 109264 109264 0 0.0
rodata 72540 72544 4 0.0
text 519972 519972 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691430 691430 0 0.0
bss 110248 110248 0 0.0
rodata 67184 67184 0 0.0
text 440580 440580 0 0.0
p6 all-clusters-app default (read/write) 2299200 2299208 8 0.0
.bss 111936 111936 0 0.0
.data 2536 2536 0 0.0
.heap 918872 918872 0 0.0
.text 1257464 1257472 8 0.0
lock-app default (read/write) 2211912 2211912 0 0.0
.bss 100744 100744 0 0.0
.data 2408 2408 0 0.0
.heap 930192 930192 0 0.0
.text 1170176 1170176 0 0.0
qpg lighting-app qpg6100+debug (read only) 490588 490592 4 0.0
(read/write) 114140 114140 0 0.0
.bss 51136 51136 0 0.0
.data 1012 1012 0 0.0
.text 485268 485272 4 0.0
lock-app qpg6100+debug (read only) 466928 466932 4 0.0
(read/write) 114144 114144 0 0.0
.bss 50080 50080 0 0.0
.data 968 968 0 0.0
.text 461608 461612 4 0.0
persistent-storage-app qpg6100+debug (read only) 153396 153400 4 0.0
(read/write) 114140 114140 0 0.0
.bss 19600 19600 0 0.0
.data 364 364 0 0.0
.text 148076 148080 4 0.0
telink lighting-app tlsr9518adk80d (read/write) 663678 663682 4 0.0
bss 69256 69256 0 0.0
noinit 33216 33216 0 0.0
text 458558 458558 0 0.0

@carol-apple
Copy link
Contributor Author

@carol-apple - could you explain what feature this is for and how?

I am trying to understand the referenced issue - it seems to ask for parsing output logs for testing purposes. Are these logs expected in production apps or only in test apps. Are there other ways beside 'parse logs'? I have concerns about asking 3rd party developers to expose their logs for validation purposes - small devices may maybe even remove some logs to save flash.

For posterity's sake, we've spoken offline and this change is temporary until TH can process the BDX message. #11553 will be used to track the changes needed to revert this PR.

holbrookt
holbrookt previously requested changes Nov 8, 2021
View reviewed changes
src/protocols/bdx/BdxMessages.h Show resolved Hide resolved
src/protocols/bdx/BdxMessages.cpp Show resolved Hide resolved
@carol-apple carol-apple requested a review from holbrookt November 9, 2021 01:13
@woody-apple woody-apple dismissed holbrookt’s stale review November 9, 2021 01:29

Comments addressed

@woody-apple woody-apple merged commit fde6a17 into project-chip:master Nov 9, 2021
woody-apple pushed a commit that referenced this pull request Nov 9, 2021
@carol-apple @woody-apple
Log BDX messages (#11510)
50460f4 
* Log BDX messages

* Create a new macro ChipLogAutomation

- This macro is to be used only for test validation purpose

* Remove private struct members from BdxMessage types

- Pass in the message type directly during logging
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@carol-apple
Log BDX messages (project-chip#11510)
eeb163d 
* Log BDX messages

* Create a new macro ChipLogAutomation

- This macro is to be used only for test validation purpose

* Remove private struct members from BdxMessage types

- Pass in the message type directly during logging
@rgoliver rgoliver mentioned this pull request Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@msandstedt msandstedt msandstedt approved these changes

@woody-apple woody-apple woody-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 andy31415 left review comments

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@holbrookt holbrookt Awaiting requested review from holbrookt

Assignees
No one assigned
Labels
lib platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTA transfer logs using reference apps does not include parsed QueryImage command and BDX messages
8 participants
@carol-apple @andy31415 @tcarmelveilleux @msandstedt @holbrookt @woody-apple @bzbarsky-apple @franck-apple