Add example implementation of access control #11550

mlepage-google · 2021-11-08T20:33:15Z

New interface (issue #10249) and new implementation (issue #10250).

Implementation is all in-memory and uses only static storage and stack
(no heap).

Some details missing (e.g. CAT support) but most is here, though not yet
hooked up to other code.

Comes with unit tests.

New interface (issue project-chip#10249) and new implementation (issue project-chip#10250). Implementation is all in-memory and uses only static storage and stack (no heap). Some details missing (e.g. CAT support) but most is here, though not yet hooked up to other code. Comes with unit tests.

todo · 2021-11-08T20:33:17Z

check against CATs in subject descriptor

connectedhomeip/src/access/AccessControl.cpp

Lines 116 to 126 in 4008c6b

    
                   // TODO: check against CATs in subject descriptor 
        
               } 
        
               continue; 
        
           } 
        
           subjectMatched: 
        
           size_t targetCount; 
        
           Entry::Target target; 
        
           ReturnErrorOnFailure(entry.GetTargetCount(targetCount)); 
        
           if (targetCount > 0) 
        
           {

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

todo · 2021-11-08T20:33:20Z

check against target.deviceType (requires lookup)

connectedhomeip/src/access/AccessControl.cpp

Lines 138 to 148 in 4008c6b

    
                       // TODO: check against target.deviceType (requires lookup) 
        
                       goto targetMatched; 
        
                   } 
        
                   continue; 
        
               } 
        
               targetMatched: 
        
               return CHIP_NO_ERROR; 
        
           } 
        
           return CHIP_ERROR_ACCESS_DENIED;

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

todo · 2021-11-08T20:33:23Z

implement extension

connectedhomeip/src/access/AccessControl.h

Lines 207 to 217 in 4008c6b

    
               // TODO: implement extension 
        
           }; 
        
           class ExtensionIterator 
        
           { 
        
               // TODO: implement extension iterator 
        
           }; 
        
           class Listener 
        
           { 
        
           public:

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

todo · 2021-11-08T20:33:26Z

implement extension iterator

connectedhomeip/src/access/AccessControl.h

Lines 212 to 222 in 4008c6b

    
               // TODO: implement extension iterator 
        
           }; 
        
           class Listener 
        
           { 
        
           public: 
        
               virtual ~Listener() = default; 
        
               // TODO: add entry/extension to listener interface 
        
               virtual void OnEntryChanged() = 0; 
        
               virtual void OnExtensionChanged() = 0;

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

todo · 2021-11-08T20:33:29Z

add entry/extension to listener interface

connectedhomeip/src/access/AccessControl.h

Lines 220 to 230 in 4008c6b

    
               // TODO: add entry/extension to listener interface 
        
               virtual void OnEntryChanged() = 0; 
        
               virtual void OnExtensionChanged() = 0; 
        
           }; 
        
           class Delegate 
        
           { 
        
           public: 
        
               Delegate() = default; 
        
               Delegate(const Delegate &) = delete;

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

todo · 2021-11-08T20:33:32Z

more capabilities

connectedhomeip/src/access/AccessControl.h

Lines 242 to 252 in 4008c6b

    
           // TODO: more capabilities 
        
           // Preparation 
        
           virtual CHIP_ERROR PrepareEntry(Entry & entry) { return CHIP_ERROR_NOT_IMPLEMENTED; } 
        
           // CRUD 
        
           virtual CHIP_ERROR CreateEntry(size_t * index, const Entry & entry, const FabricIndex * fabricIndex) { return CHIP_ERROR_NOT_IMPLEMENTED; } 
        
           virtual CHIP_ERROR ReadEntry(size_t index, Entry & entry, const FabricIndex * fabricIndex) const { return CHIP_ERROR_NOT_IMPLEMENTED; } 
        
           virtual CHIP_ERROR UpdateEntry(size_t index, const Entry & entry, const FabricIndex * fabricIndex) { return CHIP_ERROR_NOT_IMPLEMENTED; } 
        
           virtual CHIP_ERROR DeleteEntry(size_t index, const FabricIndex * fabricIndex) { return CHIP_ERROR_NOT_IMPLEMENTED; }

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

todo · 2021-11-08T20:33:35Z

get from config

connectedhomeip/src/access/examples/ExampleAccessControlDelegate.cpp

Lines 44 to 54 in 4008c6b

    
           constexpr int kNumberOfFabrics = 4; // TODO: get from config 
        
           constexpr int kEntriesPerFabric = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_ENTRIES_PER_FABRIC; 
        
           constexpr int kSubjectsPerEntry = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_SUBJECTS_PER_ENTRY; 
        
           constexpr int kTargetsPerEntry = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_MAX_TARGETS_PER_ENTRY; 
        
           // Pool sizes 
        
           constexpr int kEntryStoragePoolSize = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_ENTRY_STORGAGE_POOL_SIZE; 
        
           constexpr int kEntryDelegatePoolSize = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_ENTRY_DELEGATE_POOL_SIZE; 
        
           constexpr int kEntryIteratorDelegatePoolSize = CHIP_CONFIG_EXAMPLE_ACCESS_CONTROL_ENTRY_ITERATOR_DELEGATE_POOL_SIZE; 
        
           /*

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

src/access/AccessControl.cpp

github-actions · 2021-11-08T20:51:51Z

PR #11550: Size comparison from 86511a1 to 4008c6b

Full report (36 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`86511a1`	`4008c6b`
efr32	lighting-app	BRD4161A	(read only)	742336	742336
			(read/write)	116236	116236
			.bss	114452	114452
			.data	1784	1784
			.text	742328	742328
		BRD4161A+rpc	(read only)	729864	729864
			(read/write)	132860	132860
			.bss	130956	130956
			.data	1900	1900
			.text	729856	729856
	lock-app	BRD4161A	(read only)	721600	721600
			(read/write)	114052	114052
			.bss	112308	112308
			.data	1744	1744
			.text	721592	721592
	window-app	BRD4161A	(read only)	722496	722496
			(read/write)	114380	114380
			.bss	112628	112628
			.data	1748	1748
			.text	722488	722488
k32w	lighting-app	k32w061+se05x+release	(read/write)	699128	699128
			.bss	77976	77976
			.data	1912	1912
			.text	613440	613440
	lock-app	k32w061+debug	(read/write)	591952	591952
			.bss	68508	68508
			.data	1880	1880
			.text	515764	515764
	shell	k32w061+debug	(read/write)	657608	657608
			.bss	79308	79308
			.data	1848	1848
			.text	570652	570652
linux	all-clusters-app	debug	(read only)	`1704545`	`1704545`
			(read/write)	125888	125888
			.bss	57360	57360
			.data	1042	1042
			.data.rel.ro	62208	62208
			.dynamic	592	592
			.got	4088	4088
			.init	27	27
			.init_array	552	552
			.rodata	139477	139477
			.text	1431794	1431794
	bridge-app	debug+rpc	(read only)	1292549	1292549
			(read/write)	76432	76432
			.bss	42256	42256
			.data	1568	1568
			.data.rel.ro	27640	27640
			.dynamic	592	592
			.got	3952	3952
			.init	27	27
			.init_array	408	408
			.rodata	111252	111252
			.text	1085573	1085573
	chip-tool	debug	(read only)	4921613	4921613
			(read/write)	133160	133160
			.bss	25328	25328
			.data	2224	2224
			.data.rel.ro	100192	100192
			.dynamic	592	592
			.got	4368	4368
			.init	27	27
			.init_array	432	432
			.rodata	233712	233712
			.text	4419125	4419125
	lighting-app	debug+rpc	(read only)	1553545	1553545
			(read/write)	109432	109432
			.bss	47928	47928
			.data	1170	1170
			.data.rel.ro	55040	55040
			.dynamic	608	608
			.got	4112	4112
			.init	27	27
			.init_array	536	536
			.rodata	129873	129873
			.text	1290258	1290258
	ota-provider-app	debug	(read only)	1251785	1251785
			(read/write)	74632	74632
			.bss	44352	44352
			.data	752	752
			.data.rel.ro	24440	24440
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	112488	112488
			.text	1043362	1043362
	ota-requestor-app	debug	(read only)	1330305	1330305
			(read/write)	83920	83920
			.bss	52512	52512
			.data	816	816
			.data.rel.ro	25448	25448
			.dynamic	592	592
			.got	3992	3992
			.init	27	27
			.init_array	520	520
			.rodata	124464	124464
			.text	1107954	1107954
	shell	debug	(read only)	788153	788153
			(read/write)	64808	64808
			.bss	23400	23400
			.data	242	242
			.data.rel.ro	36656	36656
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	344	344
			.rodata	78127	78127
			.text	608754	608754
	tv-app	debug	(read only)	`1818705`	`1818705`
			(read/write)	297568	297568
			.bss	230512	230512
			.data	2704	2704
			.data.rel.ro	58696	58696
			.dynamic	592	592
			.got	4408	4408
			.init	27	27
			.init_array	616	616
			.rodata	155528	155528
			.text	1521058	1521058
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2291552`	`2291552`
			.bss	179404	179404
			.data	5232	5232
			.heap	851808	851808
			.text	1254152	1254152
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2271648	2271648
			.bss	172460	172460
			.data	5584	5584
			.heap	858400	858400
			.text	1234248	1234248
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2249368	2249368
			.bss	171356	171356
			.data	5568	5568
			.heap	859520	859520
			.text	1211968	1211968
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139744	1139744
			.bss	11752	11752
			.data	4368	4368
			.heap	1020328	1020328
			.text	103128	103128
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2048760	2048760
			.bss	156424	156424
			.data	4976	4976
			.heap	875048	875048
			.text	1011360	1011360
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861779	861779
			bss	111444	111444
			rodata	96932	96932
			text	577776	577776
		nrf52840dk_nrf52840+rpc	(read/write)	824127	824127
			bss	107796	107796
			rodata	88112	88112
			text	551924	551924
		nrf5340dk_nrf5340_cpuapp	(read/write)	786822	786822
			bss	112816	112816
			rodata	92192	92192
			text	507248	507248
	lock-app	nrf52840dk_nrf52840	(read/write)	838487	838487
			bss	110476	110476
			rodata	93304	93304
			text	559256	559256
		nrf5340dk_nrf5340_cpuapp	(read/write)	763798	763798
			bss	111888	111888
			rodata	88608	88608
			text	488820	488820
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323
			bss	51824	51824
			rodata	45776	45776
			text	339436	339436
	pump-app	nrf52840dk_nrf52840	(read/write)	844579	844579
			bss	110616	110616
			rodata	95012	95012
			text	563420	563420
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838343	838343
			bss	110512	110512
			rodata	93304	93304
			text	558992	558992
	shell	nrf52840dk_nrf52840	(read/write)	776375	776375
			bss	109264	109264
			rodata	72540	72540
			text	519972	519972
		nrf5340dk_nrf5340_cpuapp	(read/write)	691430	691430
			bss	110248	110248
			rodata	67184	67184
			text	440580	440580
p6	all-clusters-app	default	(read/write)	2298888	2298888
			.bss	111936	111936
			.data	2536	2536
			.heap	918872	918872
			.text	1257152	1257152
	lock-app	default	(read/write)	2211592	2211592
			.bss	100744	100744
			.data	2408	2408
			.heap	930192	930192
			.text	`1169856`	`1169856`
qpg	lighting-app	qpg6100+debug	(read only)	490276	490276
			(read/write)	114140	114140
			.bss	51136	51136
			.data	1012	1012
			.text	484956	484956
	lock-app	qpg6100+debug	(read only)	466616	466616
			(read/write)	114144	114144
			.bss	50080	50080
			.data	968	968
			.text	461296	461296
	persistent-storage-app	qpg6100+debug	(read only)	153396	153396
			(read/write)	114140	114140
			.bss	19600	19600
			.data	364	364
			.text	148076	148076
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663418
			bss	69256	69256
			noinit	33216	33216
			text	458266	458266

src/access/AccessControl.cpp

src/access/examples/ExampleAccessControlDelegate.cpp

src/access/tests/TestAccessControl.cpp

src/lib/core/CHIPConfig.h

Was added at last minute, missed this spot.

github-actions · 2021-11-08T22:48:50Z

PR #11550: Size comparison from 86511a1 to ba57c95

Increases above 0.2%:

platform	target	config	section	`86511a1`	`ba57c95`	change	% change
linux	all-clusters-app	debug	(read only)	`1704545`	1709665	5120	0.3
			.text	1431794	1436626	4832	0.3
	bridge-app	debug+rpc	(read only)	1292549	1297669	5120	0.4
			.rodata	111252	111540	288	0.3
			.text	1085573	1090405	4832	0.4
	lighting-app	debug+rpc	(read only)	1553545	1558633	5088	0.3
			.text	1290258	`1295090`	4832	0.4
	ota-provider-app	debug	(read only)	1251785	1256905	5120	0.4
			.rodata	112488	112776	288	0.3
			.text	1043362	1048194	4832	0.5
	ota-requestor-app	debug	(read only)	1330305	1335521	5216	0.4
			.rodata	124464	124784	320	0.3
			.text	1107954	`1112850`	4896	0.4
	tv-app	debug	(read only)	`1818705`	1823889	5184	0.3
			.text	1521058	1525954	4896	0.3

Increases (27 builds for efr32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`86511a1`	`ba57c95`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742336	742648	312	0.0
			.text	742328	742640	312	0.0
		BRD4161A+rpc	(read only)	729864	730184	320	0.0
			.text	729856	730176	320	0.0
	lock-app	BRD4161A	(read only)	721600	721920	320	0.0
			.text	721592	721912	320	0.0
	window-app	BRD4161A	(read only)	722496	722816	320	0.0
			.text	722488	722808	320	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699128	699460	332	0.0
			.text	613440	613772	332	0.1
	lock-app	k32w061+debug	(read/write)	591952	592268	316	0.1
			.text	515764	516080	316	0.1
	shell	k32w061+debug	(read/write)	657608	657940	332	0.1
			.text	570652	570984	332	0.1
linux	all-clusters-app	debug	(read only)	`1704545`	1709665	5120	0.3
			.rodata	139477	139765	288	0.2
			.text	1431794	1436626	4832	0.3
	bridge-app	debug+rpc	(read only)	1292549	1297669	5120	0.4
			.rodata	111252	111540	288	0.3
			.text	1085573	1090405	4832	0.4
	chip-tool	debug	(read only)	4921613	4926973	5360	0.1
			.rodata	233712	234000	288	0.1
			.text	4419125	4424197	5072	0.1
	lighting-app	debug+rpc	(read only)	1553545	1558633	5088	0.3
			.rodata	129873	130129	256	0.2
			.text	1290258	`1295090`	4832	0.4
	ota-provider-app	debug	(read only)	1251785	1256905	5120	0.4
			.rodata	112488	112776	288	0.3
			.text	1043362	1048194	4832	0.5
	ota-requestor-app	debug	(read only)	1330305	1335521	5216	0.4
			.rodata	124464	124784	320	0.3
			.text	1107954	`1112850`	4896	0.4
	shell	debug	(read only)	788153	788233	80	0.0
			.rodata	78127	78191	64	0.1
			.text	608754	608770	16	0.0
	tv-app	debug	(read only)	`1818705`	1823889	5184	0.3
			.rodata	155528	155816	288	0.2
			.text	1521058	1525954	4896	0.3
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861779	862067	288	0.0
			text	577776	578096	320	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	824127	824415	288	0.0
			text	551924	552244	320	0.1
		nrf5340dk_nrf5340_cpuapp	(read/write)	786822	787110	288	0.0
			text	507248	507568	320	0.1
	lock-app	nrf52840dk_nrf52840	(read/write)	838487	838775	288	0.0
			text	559256	559580	324	0.1
		nrf5340dk_nrf5340_cpuapp	(read/write)	763798	764086	288	0.0
			text	488820	489144	324	0.1
	pump-app	nrf52840dk_nrf52840	(read/write)	844579	844867	288	0.0
			text	563420	563740	320	0.1
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838343	838647	304	0.0
			text	558992	559316	324	0.1
p6	all-clusters-app	default	(read/write)	2298888	`2299200`	312	0.0
			.text	1257152	`1257464`	312	0.0
	lock-app	default	(read/write)	2211592	2211912	320	0.0
			.text	`1169856`	1170176	320	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490276	490588	312	0.1
			.text	484956	485268	312	0.1
	lock-app	qpg6100+debug	(read only)	466616	466928	312	0.1
			.text	461296	461608	312	0.1
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663678	260	0.0
			text	458266	458558	292	0.1

Decreases (7 builds for nrfconnect)

platform	target	config	section	`86511a1`	`ba57c95`	change	% change
nrfconnect	lighting-app	nrf52840dk_nrf52840	rodata	96932	96900	-32	-0.0
		nrf52840dk_nrf52840+rpc	rodata	88112	88080	-32	-0.0
		nrf5340dk_nrf5340_cpuapp	rodata	92192	92160	-32	-0.0
	lock-app	nrf52840dk_nrf52840	rodata	93304	93272	-32	-0.0
		nrf5340dk_nrf5340_cpuapp	rodata	88608	88576	-32	-0.0
	pump-app	nrf52840dk_nrf52840	rodata	95012	94980	-32	-0.0
	pump-controller-app	nrf52840dk_nrf52840	rodata	93304	93272	-32	-0.0

Full report (31 builds for efr32, k32w, linux, nrfconnect, p6, qpg, telink)

platform	target	config	section	`86511a1`	`ba57c95`	change	% change
efr32	lighting-app	BRD4161A	(read only)	742336	742648	312	0.0
			(read/write)	116236	116236	0	0.0
			.bss	114452	114452	0	0.0
			.data	1784	1784	0	0.0
			.text	742328	742640	312	0.0
		BRD4161A+rpc	(read only)	729864	730184	320	0.0
			(read/write)	132860	132860	0	0.0
			.bss	130956	130956	0	0.0
			.data	1900	1900	0	0.0
			.text	729856	730176	320	0.0
	lock-app	BRD4161A	(read only)	721600	721920	320	0.0
			(read/write)	114052	114052	0	0.0
			.bss	112308	112308	0	0.0
			.data	1744	1744	0	0.0
			.text	721592	721912	320	0.0
	window-app	BRD4161A	(read only)	722496	722816	320	0.0
			(read/write)	114380	114380	0	0.0
			.bss	112628	112628	0	0.0
			.data	1748	1748	0	0.0
			.text	722488	722808	320	0.0
k32w	lighting-app	k32w061+se05x+release	(read/write)	699128	699460	332	0.0
			.bss	77976	77976	0	0.0
			.data	1912	1912	0	0.0
			.text	613440	613772	332	0.1
	lock-app	k32w061+debug	(read/write)	591952	592268	316	0.1
			.bss	68508	68508	0	0.0
			.data	1880	1880	0	0.0
			.text	515764	516080	316	0.1
	shell	k32w061+debug	(read/write)	657608	657940	332	0.1
			.bss	79308	79308	0	0.0
			.data	1848	1848	0	0.0
			.text	570652	570984	332	0.1
linux	all-clusters-app	debug	(read only)	`1704545`	1709665	5120	0.3
			(read/write)	125888	125888	0	0.0
			.bss	57360	57360	0	0.0
			.data	1042	1042	0	0.0
			.data.rel.ro	62208	62208	0	0.0
			.dynamic	592	592	0	0.0
			.got	4088	4088	0	0.0
			.init	27	27	0	0.0
			.init_array	552	552	0	0.0
			.rodata	139477	139765	288	0.2
			.text	1431794	1436626	4832	0.3
	bridge-app	debug+rpc	(read only)	1292549	1297669	5120	0.4
			(read/write)	76432	76432	0	0.0
			.bss	42256	42256	0	0.0
			.data	1568	1568	0	0.0
			.data.rel.ro	27640	27640	0	0.0
			.dynamic	592	592	0	0.0
			.got	3952	3952	0	0.0
			.init	27	27	0	0.0
			.init_array	408	408	0	0.0
			.rodata	111252	111540	288	0.3
			.text	1085573	1090405	4832	0.4
	chip-tool	debug	(read only)	4921613	4926973	5360	0.1
			(read/write)	133160	133160	0	0.0
			.bss	25328	25328	0	0.0
			.data	2224	2224	0	0.0
			.data.rel.ro	100192	100192	0	0.0
			.dynamic	592	592	0	0.0
			.got	4368	4368	0	0.0
			.init	27	27	0	0.0
			.init_array	432	432	0	0.0
			.rodata	233712	234000	288	0.1
			.text	4419125	4424197	5072	0.1
	lighting-app	debug+rpc	(read only)	1553545	1558633	5088	0.3
			(read/write)	109432	109432	0	0.0
			.bss	47928	47928	0	0.0
			.data	1170	1170	0	0.0
			.data.rel.ro	55040	55040	0	0.0
			.dynamic	608	608	0	0.0
			.got	4112	4112	0	0.0
			.init	27	27	0	0.0
			.init_array	536	536	0	0.0
			.rodata	129873	130129	256	0.2
			.text	1290258	`1295090`	4832	0.4
	ota-provider-app	debug	(read only)	1251785	1256905	5120	0.4
			(read/write)	74632	74632	0	0.0
			.bss	44352	44352	0	0.0
			.data	752	752	0	0.0
			.data.rel.ro	24440	24440	0	0.0
			.dynamic	592	592	0	0.0
			.got	4016	4016	0	0.0
			.init	27	27	0	0.0
			.init_array	448	448	0	0.0
			.rodata	112488	112776	288	0.3
			.text	1043362	1048194	4832	0.5
	ota-requestor-app	debug	(read only)	1330305	1335521	5216	0.4
			(read/write)	83920	83920	0	0.0
			.bss	52512	52512	0	0.0
			.data	816	816	0	0.0
			.data.rel.ro	25448	25448	0	0.0
			.dynamic	592	592	0	0.0
			.got	3992	3992	0	0.0
			.init	27	27	0	0.0
			.init_array	520	520	0	0.0
			.rodata	124464	124784	320	0.3
			.text	1107954	`1112850`	4896	0.4
	shell	debug	(read only)	788153	788233	80	0.0
			(read/write)	64808	64808	0	0.0
			.bss	23400	23400	0	0.0
			.data	242	242	0	0.0
			.data.rel.ro	36656	36656	0	0.0
			.dynamic	592	592	0	0.0
			.got	3528	3528	0	0.0
			.init	27	27	0	0.0
			.init_array	344	344	0	0.0
			.rodata	78127	78191	64	0.1
			.text	608754	608770	16	0.0
	tv-app	debug	(read only)	`1818705`	1823889	5184	0.3
			(read/write)	297568	297568	0	0.0
			.bss	230512	230512	0	0.0
			.data	2704	2704	0	0.0
			.data.rel.ro	58696	58696	0	0.0
			.dynamic	592	592	0	0.0
			.got	4408	4408	0	0.0
			.init	27	27	0	0.0
			.init_array	616	616	0	0.0
			.rodata	155528	155816	288	0.2
			.text	1521058	1525954	4896	0.3
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	861779	862067	288	0.0
			bss	111444	111444	0	0.0
			rodata	96932	96900	-32	-0.0
			text	577776	578096	320	0.1
		nrf52840dk_nrf52840+rpc	(read/write)	824127	824415	288	0.0
			bss	107796	107796	0	0.0
			rodata	88112	88080	-32	-0.0
			text	551924	552244	320	0.1
		nrf5340dk_nrf5340_cpuapp	(read/write)	786822	787110	288	0.0
			bss	112816	112816	0	0.0
			rodata	92192	92160	-32	-0.0
			text	507248	507568	320	0.1
	lock-app	nrf52840dk_nrf52840	(read/write)	838487	838775	288	0.0
			bss	110476	110476	0	0.0
			rodata	93304	93272	-32	-0.0
			text	559256	559580	324	0.1
		nrf5340dk_nrf5340_cpuapp	(read/write)	763798	764086	288	0.0
			bss	111888	111888	0	0.0
			rodata	88608	88576	-32	-0.0
			text	488820	489144	324	0.1
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497323	497323	0	0.0
			bss	51824	51824	0	0.0
			rodata	45776	45776	0	0.0
			text	339436	339436	0	0.0
	pump-app	nrf52840dk_nrf52840	(read/write)	844579	844867	288	0.0
			bss	110616	110616	0	0.0
			rodata	95012	94980	-32	-0.0
			text	563420	563740	320	0.1
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	838343	838647	304	0.0
			bss	110512	110512	0	0.0
			rodata	93304	93272	-32	-0.0
			text	558992	559316	324	0.1
	shell	nrf52840dk_nrf52840	(read/write)	776375	776375	0	0.0
			bss	109264	109264	0	0.0
			rodata	72540	72540	0	0.0
			text	519972	519972	0	0.0
		nrf5340dk_nrf5340_cpuapp	(read/write)	691430	691430	0	0.0
			bss	110248	110248	0	0.0
			rodata	67184	67184	0	0.0
			text	440580	440580	0	0.0
p6	all-clusters-app	default	(read/write)	2298888	`2299200`	312	0.0
			.bss	111936	111936	0	0.0
			.data	2536	2536	0	0.0
			.heap	918872	918872	0	0.0
			.text	1257152	`1257464`	312	0.0
	lock-app	default	(read/write)	2211592	2211912	320	0.0
			.bss	100744	100744	0	0.0
			.data	2408	2408	0	0.0
			.heap	930192	930192	0	0.0
			.text	`1169856`	1170176	320	0.0
qpg	lighting-app	qpg6100+debug	(read only)	490276	490588	312	0.1
			(read/write)	114140	114140	0	0.0
			.bss	51136	51136	0	0.0
			.data	1012	1012	0	0.0
			.text	484956	485268	312	0.1
	lock-app	qpg6100+debug	(read only)	466616	466928	312	0.1
			(read/write)	114144	114144	0	0.0
			.bss	50080	50080	0	0.0
			.data	968	968	0	0.0
			.text	461296	461608	312	0.1
	persistent-storage-app	qpg6100+debug	(read only)	153396	153396	0	0.0
			(read/write)	114140	114140	0	0.0
			.bss	19600	19600	0	0.0
			.data	364	364	0	0.0
			.text	148076	148076	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	663418	663678	260	0.0
			bss	69256	69256	0	0.0
			noinit	33216	33216	0	0.0
			text	458266	458558	292	0.1

src/access/AccessControl.cpp

- rewrite portions of the check loop to use boolean instead of goto - refactor privilege checking to make it clearer - ensure storage classes are POD types (with static_assert) - remove memsets on storage classes (for now, can re-add later) - clarify some comments - remove debug log statement

mlepage-google

One set of changes. Will restyle, rebase, and do another pass.

src/access/examples/ExampleAccessControlDelegate.cpp

src/access/AccessControl.cpp

src/access/examples/ExampleAccessControlDelegate.cpp

src/access/AccessControl.cpp

github-actions · 2021-11-12T20:01:43Z

PR #11550: Size comparison from 0fcdb28 to 06b8834

Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`0fcdb28`	`06b8834`
efr32	lighting-app	BRD4161A	(read only)	748808	748808
			(read/write)	115940	115940
			.bss	114140	114140
			.data	1800	1800
			.text	748800	748800
		BRD4161A+rpc	(read only)	736372	736372
			(read/write)	132568	132568
			.bss	130644	130644
			.data	1924	1924
			.text	736364	736364
	lock-app	BRD4161A	(read only)	725648	725648
			(read/write)	113724	113724
			.bss	111964	111964
			.data	1756	1756
			.text	725640	725640
	window-app	BRD4161A	(read only)	726560	726560
			(read/write)	114044	114044
			.bss	112284	112284
			.data	1760	1760
			.text	726552	726552
k32w	lighting-app	k32w061+se05x+release	(read/write)	701740	701740
			.bss	77508	77508
			.data	1908	1908
			.text	616524	616524
	lock-app	k32w061+debug	(read/write)	592956	592956
			.bss	68028	68028
			.data	1876	1876
			.text	517252	517252
	shell	k32w061+debug	(read/write)	658640	658640
			.bss	78820	78820
			.data	1844	1844
			.text	572176	572176
linux	all-clusters-app	debug	(read only)	`1713393`	`1713393`
			(read/write)	126304	126304
			.bss	57680	57680
			.data	1042	1042
			.data.rel.ro	62304	62304
			.dynamic	592	592
			.got	4112	4112
			.init	27	27
			.init_array	552	552
			.rodata	140117	140117
			.text	1439250	1439250
	bridge-app	debug+rpc	(read only)	1307461	1307461
			(read/write)	77424	77424
			.bss	42896	42896
			.data	1568	1568
			.data.rel.ro	27960	27960
			.dynamic	592	592
			.got	3984	3984
			.init	27	27
			.init_array	408	408
			.rodata	111764	111764
			.text	1098725	1098725
	chip-tool	debug	(read only)	4662317	4662317
			(read/write)	163976	163976
			.bss	41192	41192
			.data	2272	2272
			.data.rel.ro	115024	115024
			.dynamic	592	592
			.got	4416	4416
			.init	27	27
			.init_array	472	472
			.rodata	259730	259730
			.text	4100501	4100501
	lighting-app	debug+rpc	(read only)	1574201	1574201
			(read/write)	110192	110192
			.bss	48080	48080
			.data	1234	1234
			.data.rel.ro	55552	55552
			.dynamic	608	608
			.got	4136	4136
			.init	27	27
			.init_array	536	536
			.rodata	129745	129745
			.text	1309762	1309762
	ota-provider-app	debug	(read only)	1262729	1262729
			(read/write)	75176	75176
			.bss	44512	44512
			.data	784	784
			.data.rel.ro	24776	24776
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	113255	113255
			.text	`1052626`	`1052626`
	ota-requestor-app	debug	(read only)	1347545	1347545
			(read/write)	78944	78944
			.bss	46976	46976
			.data	848	848
			.data.rel.ro	26040	26040
			.dynamic	592	592
			.got	3992	3992
			.init	27	27
			.init_array	472	472
			.rodata	124112	124112
			.text	1124034	1124034
	shell	debug	(read only)	788969	788969
			(read/write)	65064	65064
			.bss	23400	23400
			.data	242	242
			.data.rel.ro	36928	36928
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	344	344
			.rodata	77903	77903
			.text	609170	609170
	tv-app	debug	(read only)	`1853257`	`1853257`
			(read/write)	407896	407896
			.bss	339752	339752
			.data	2768	2768
			.data.rel.ro	59696	59696
			.dynamic	592	592
			.got	4432	4432
			.init	27	27
			.init_array	616	616
			.rodata	156973	156973
			.text	1551202	1551202
p6	all-clusters-app	default	(read/write)	2299576	2299576
			.bss	112608	112608
			.data	2520	2520
			.heap	918216	918216
			.text	`1257840`	`1257840`
	lock-app	default	(read/write)	2213616	2213616
			.bss	101296	101296
			.data	2400	2400
			.heap	929648	929648
			.text	1171880	1171880
qpg	lighting-app	qpg6100+debug	(read only)	493352	493352
			(read/write)	114144	114144
			.bss	50640	50640
			.data	1008	1008
			.text	488032	488032
	lock-app	qpg6100+debug	(read only)	468096	468096
			(read/write)	114140	114140
			.bss	49576	49576
			.data	964	964
			.text	462776	462776
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408
			(read/write)	114142	114142
			.bss	8978	8978
			.data	272	272
			.text	100088	100088
telink	lighting-app	tlsr9518adk80d	(read/write)	666566	666566
			bss	69320	69320
			noinit	33216	33216
			text	461088	461088

github-actions · 2021-11-12T20:57:03Z

PR #11550: Size comparison from 0fcdb28 to df20d99

Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)

platform	target	config	section	`0fcdb28`	`df20d99`
efr32	lighting-app	BRD4161A	(read only)	748808	748808
			(read/write)	115940	115940
			.bss	114140	114140
			.data	1800	1800
			.text	748800	748800
		BRD4161A+rpc	(read only)	736372	736372
			(read/write)	132568	132568
			.bss	130644	130644
			.data	1924	1924
			.text	736364	736364
	lock-app	BRD4161A	(read only)	725648	725648
			(read/write)	113724	113724
			.bss	111964	111964
			.data	1756	1756
			.text	725640	725640
	window-app	BRD4161A	(read only)	726560	726560
			(read/write)	114044	114044
			.bss	112284	112284
			.data	1760	1760
			.text	726552	726552
k32w	lighting-app	k32w061+se05x+release	(read/write)	701740	701740
			.bss	77508	77508
			.data	1908	1908
			.text	616524	616524
	lock-app	k32w061+debug	(read/write)	592956	592956
			.bss	68028	68028
			.data	1876	1876
			.text	517252	517252
	shell	k32w061+debug	(read/write)	658640	658640
			.bss	78820	78820
			.data	1844	1844
			.text	572176	572176
linux	all-clusters-app	debug	(read only)	`1713393`	`1713393`
			(read/write)	126304	126304
			.bss	57680	57680
			.data	1042	1042
			.data.rel.ro	62304	62304
			.dynamic	592	592
			.got	4112	4112
			.init	27	27
			.init_array	552	552
			.rodata	140117	140117
			.text	1439250	1439250
	bridge-app	debug+rpc	(read only)	1307461	1307461
			(read/write)	77424	77424
			.bss	42896	42896
			.data	1568	1568
			.data.rel.ro	27960	27960
			.dynamic	592	592
			.got	3984	3984
			.init	27	27
			.init_array	408	408
			.rodata	111764	111764
			.text	1098725	1098725
	chip-tool	debug	(read only)	4662317	4662317
			(read/write)	163976	163976
			.bss	41192	41192
			.data	2272	2272
			.data.rel.ro	115024	115024
			.dynamic	592	592
			.got	4416	4416
			.init	27	27
			.init_array	472	472
			.rodata	259730	259730
			.text	4100501	4100501
	lighting-app	debug+rpc	(read only)	1574201	1574201
			(read/write)	110192	110192
			.bss	48080	48080
			.data	1234	1234
			.data.rel.ro	55552	55552
			.dynamic	608	608
			.got	4136	4136
			.init	27	27
			.init_array	536	536
			.rodata	129745	129745
			.text	1309762	1309762
	ota-provider-app	debug	(read only)	1262729	1262729
			(read/write)	75176	75176
			.bss	44512	44512
			.data	784	784
			.data.rel.ro	24776	24776
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	113255	113255
			.text	`1052626`	`1052626`
	ota-requestor-app	debug	(read only)	1347545	1347545
			(read/write)	78944	78944
			.bss	46976	46976
			.data	848	848
			.data.rel.ro	26040	26040
			.dynamic	592	592
			.got	3992	3992
			.init	27	27
			.init_array	472	472
			.rodata	124112	124112
			.text	1124034	1124034
	shell	debug	(read only)	788969	788969
			(read/write)	65064	65064
			.bss	23400	23400
			.data	242	242
			.data.rel.ro	36928	36928
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	344	344
			.rodata	77903	77903
			.text	609170	609170
	tv-app	debug	(read only)	`1853257`	`1853257`
			(read/write)	407896	407896
			.bss	339752	339752
			.data	2768	2768
			.data.rel.ro	59696	59696
			.dynamic	592	592
			.got	4432	4432
			.init	27	27
			.init_array	616	616
			.rodata	156973	156973
			.text	1551202	1551202
p6	all-clusters-app	default	(read/write)	2299576	2299576
			.bss	112608	112608
			.data	2520	2520
			.heap	918216	918216
			.text	`1257840`	`1257840`
	lock-app	default	(read/write)	2213616	2213616
			.bss	101296	101296
			.data	2400	2400
			.heap	929648	929648
			.text	1171880	1171880
qpg	lighting-app	qpg6100+debug	(read only)	493352	493352
			(read/write)	114144	114144
			.bss	50640	50640
			.data	1008	1008
			.text	488032	488032
	lock-app	qpg6100+debug	(read only)	468096	468096
			(read/write)	114140	114140
			.bss	49576	49576
			.data	964	964
			.text	462776	462776
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408
			(read/write)	114142	114142
			.bss	8978	8978
			.data	272	272
			.text	100088	100088
telink	lighting-app	tlsr9518adk80d	(read/write)	666566	666566
			bss	69320	69320
			noinit	33216	33216
			text	461088	461088

src/lib/core/CHIPConfig.h

src/access/AccessControl.cpp

github-actions · 2021-11-12T21:57:04Z

PR #11550: Size comparison from c7694b4 to 3cc4171

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	`c7694b4`	`3cc4171`
efr32	lighting-app	BRD4161A	(read only)	748824	748824
			(read/write)	115940	115940
			.bss	114140	114140
			.data	1800	1800
			.text	748816	748816
		BRD4161A+rpc	(read only)	736388	736388
			(read/write)	132568	132568
			.bss	130644	130644
			.data	1924	1924
			.text	736380	736380
	lock-app	BRD4161A	(read only)	725680	725680
			(read/write)	113724	113724
			.bss	111964	111964
			.data	1756	1756
			.text	725672	725672
	window-app	BRD4161A	(read only)	726576	726576
			(read/write)	114044	114044
			.bss	112284	112284
			.data	1760	1760
			.text	726568	726568
esp32	all-clusters-app	c3devkit	(read only)	825678	825678
			(read/write)	1224066	1224066
			.dram0.bss	57016	57016
			.dram0.data	14092	14092
			.flash.rodata	167704	167704
			.flash.text	825678	825678
			.iram0.text	61394	61394
		m5stack	(read only)	896471	896471
			(read/write)	422224	422224
			.dram0.bss	62112	62112
			.dram0.data	34056	34056
			.flash.rodata	194732	194732
			.flash.text	891087	891087
			.iram0.text	122987	122987
k32w	lighting-app	k32w061+se05x+release	(read/write)	701756	701756
			.bss	77508	77508
			.data	1908	1908
			.text	616540	616540
	lock-app	k32w061+debug	(read/write)	592972	592972
			.bss	68028	68028
			.data	1876	1876
			.text	517268	517268
	shell	k32w061+debug	(read/write)	658656	658656
			.bss	78820	78820
			.data	1844	1844
			.text	572192	572192
linux	all-clusters-app	debug	(read only)	`1713521`	`1713521`
			(read/write)	126304	126304
			.bss	57680	57680
			.data	1042	1042
			.data.rel.ro	62304	62304
			.dynamic	592	592
			.got	4112	4112
			.init	27	27
			.init_array	552	552
			.rodata	140117	140117
			.text	1439378	1439378
	bridge-app	debug+rpc	(read only)	`1307573`	`1307573`
			(read/write)	77424	77424
			.bss	42896	42896
			.data	1568	1568
			.data.rel.ro	27960	27960
			.dynamic	592	592
			.got	3984	3984
			.init	27	27
			.init_array	408	408
			.rodata	111764	111764
			.text	`1098837`	`1098837`
	chip-tool	debug	(read only)	4662317	4662317
			(read/write)	163976	163976
			.bss	41192	41192
			.data	2272	2272
			.data.rel.ro	115024	115024
			.dynamic	592	592
			.got	4416	4416
			.init	27	27
			.init_array	472	472
			.rodata	259730	259730
			.text	4100501	4100501
	lighting-app	debug+rpc	(read only)	1574313	1574313
			(read/write)	110192	110192
			.bss	48080	48080
			.data	1234	1234
			.data.rel.ro	55552	55552
			.dynamic	608	608
			.got	4136	4136
			.init	27	27
			.init_array	536	536
			.rodata	129745	129745
			.text	`1309874`	`1309874`
	ota-provider-app	debug	(read only)	`1262857`	`1262857`
			(read/write)	75176	75176
			.bss	44512	44512
			.data	784	784
			.data.rel.ro	24776	24776
			.dynamic	592	592
			.got	4016	4016
			.init	27	27
			.init_array	448	448
			.rodata	113255	113255
			.text	1052754	1052754
	ota-requestor-app	debug	(read only)	1347545	1347545
			(read/write)	78944	78944
			.bss	46976	46976
			.data	848	848
			.data.rel.ro	26040	26040
			.dynamic	592	592
			.got	3992	3992
			.init	27	27
			.init_array	472	472
			.rodata	124112	124112
			.text	1124034	1124034
	shell	debug	(read only)	789081	789081
			(read/write)	65064	65064
			.bss	23400	23400
			.data	242	242
			.data.rel.ro	36928	36928
			.dynamic	592	592
			.got	3528	3528
			.init	27	27
			.init_array	344	344
			.rodata	77903	77903
			.text	609282	609282
	tv-app	debug	(read only)	1853241	1853241
			(read/write)	407896	407896
			.bss	339752	339752
			.data	2768	2768
			.data.rel.ro	59696	59696
			.dynamic	592	592
			.got	4432	4432
			.init	27	27
			.init_array	616	616
			.rodata	156973	156973
			.text	1551186	1551186
mbed	all-clusters-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2291104	2291104
			.bss	179612	179612
			.data	5216	5216
			.heap	851616	851616
			.text	1253704	1253704
	lighting-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2273856	2273856
			.bss	172556	172556
			.data	5576	5576
			.heap	858312	858312
			.text	`1236456`	`1236456`
	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2249552	2249552
			.bss	171436	171436
			.data	5568	5568
			.heap	859440	859440
			.text	1212152	1212152
	pigweed-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	1139744	1139744
			.bss	11752	11752
			.data	4368	4368
			.heap	1020328	1020328
			.text	103128	103128
	shell	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2048376	2048376
			.bss	155912	155912
			.data	4968	4968
			.heap	875568	875568
			.text	1010976	1010976
nrfconnect	lighting-app	nrf52840dk_nrf52840	(read/write)	864263	864263
			bss	110964	110964
			rodata	97080	97080
			text	580592	580592
		nrf52840dk_nrf52840+rpc	(read/write)	826635	826635
			bss	107316	107316
			rodata	88268	88268
			text	554764	554764
		nrf5340dk_nrf5340_cpuapp	(read/write)	789302	789302
			bss	112336	112336
			rodata	92336	92336
			text	510060	510060
	lock-app	nrf52840dk_nrf52840	(read/write)	839479	839479
			bss	109988	109988
			rodata	93144	93144
			text	560892	560892
		nrf5340dk_nrf5340_cpuapp	(read/write)	764794	764794
			bss	111400	111400
			rodata	88452	88452
			text	490452	490452
	pigweed-app	nrf52840dk_nrf52840	(read/write)	497327	497327
			bss	51824	51824
			rodata	45780	45780
			text	339436	339436
	pump-app	nrf52840dk_nrf52840	(read/write)	845575	845575
			bss	110128	110128
			rodata	94856	94856
			text	565056	565056
	pump-controller-app	nrf52840dk_nrf52840	(read/write)	839335	839335
			bss	110024	110024
			rodata	93144	93144
			text	560628	560628
	shell	nrf52840dk_nrf52840	(read/write)	775499	775499
			bss	108736	108736
			rodata	72160	72160
			text	520020	520020
		nrf5340dk_nrf5340_cpuapp	(read/write)	690554	690554
			bss	109720	109720
			rodata	66804	66804
			text	440628	440628
p6	all-clusters-app	default	(read/write)	2299592	2299592
			.bss	112608	112608
			.data	2520	2520
			.heap	918216	918216
			.text	1257856	1257856
	lock-app	default	(read/write)	2213648	2213648
			.bss	101296	101296
			.data	2400	2400
			.heap	929648	929648
			.text	1171912	1171912
qpg	lighting-app	qpg6100+debug	(read only)	493368	493368
			(read/write)	114144	114144
			.bss	50640	50640
			.data	1008	1008
			.text	488048	488048
	lock-app	qpg6100+debug	(read only)	468112	468112
			(read/write)	114140	114140
			.bss	49576	49576
			.data	964	964
			.text	462792	462792
	persistent-storage-app	qpg6100+debug	(read only)	105408	105408
			(read/write)	114142	114142
			.bss	8978	8978
			.data	272	272
			.text	100088	100088
telink	lighting-app	tlsr9518adk80d	(read/write)	666582	666582
			bss	69320	69320
			noinit	33216	33216
			text	461100	461100

andy31415 · 2021-11-16T16:14:45Z

Fast track: change made by domain owner, had significant feedback that was addressed, has several checkmarks

boring-cyborg bot added the lib label Nov 8, 2021

restyled-io bot mentioned this pull request Nov 8, 2021

Restyle Add example implementation of access control #11551

Closed

tcarmelveilleux reviewed Nov 8, 2021

View reviewed changes

src/access/AccessControl.cpp Show resolved Hide resolved

tcarmelveilleux reviewed Nov 8, 2021

View reviewed changes

Fix configuration

ba57c95

Was added at last minute, missed this spot.

tcarmelveilleux reviewed Nov 9, 2021

View reviewed changes

src/access/AccessControl.cpp Outdated Show resolved Hide resolved

mlepage-google and others added 2 commits November 9, 2021 15:45

Restyled by clang-format

77130a4

mlepage-google commented Nov 9, 2021

View reviewed changes

Merge branch 'master' into access-control-delegate

efbc851

pullapprove bot requested review from anush-apple, austinh0, balducci-apple, bzbarsky-apple, carol-apple, cecille, chrisdecenzo, chulspro, Damian-Nordic and electrocucaracha November 9, 2021 22:19

mlepage-google added 2 commits November 12, 2021 14:29

Merge branch 'master' into access-control-delegate

057b27c

Fix more build errors on other compilers

06b8834

tcarmelveilleux reviewed Nov 12, 2021

View reviewed changes

src/access/AccessControl.cpp Show resolved Hide resolved

tcarmelveilleux approved these changes Nov 12, 2021

View reviewed changes

mlepage-google and others added 2 commits November 12, 2021 15:34

More code review suggestions

df20d99

Restyled by clang-format

b9cf23b

harimau-qirex reviewed Nov 12, 2021

View reviewed changes

src/lib/core/CHIPConfig.h Outdated Show resolved Hide resolved

mlepage-google added 2 commits November 12, 2021 16:33

Merge branch 'master' into access-control-delegate

e877fc9

Fix typo in config flag

3cc4171

electrocucaracha reviewed Nov 12, 2021

View reviewed changes

src/access/AccessControl.cpp Show resolved Hide resolved

bzbarsky-apple approved these changes Nov 16, 2021

View reviewed changes

andy31415 added the fast track label Nov 16, 2021

andy31415 merged commit 09f9837 into project-chip:master Nov 16, 2021

mlepage-google deleted the access-control-delegate branch November 16, 2021 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add example implementation of access control #11550

Add example implementation of access control #11550

mlepage-google commented Nov 8, 2021

todo bot commented Nov 8, 2021

todo bot commented Nov 8, 2021

todo bot commented Nov 8, 2021

todo bot commented Nov 8, 2021

todo bot commented Nov 8, 2021

todo bot commented Nov 8, 2021

todo bot commented Nov 8, 2021

github-actions bot commented Nov 8, 2021 •

edited

Loading

github-actions bot commented Nov 8, 2021 •

edited

Loading

mlepage-google left a comment

github-actions bot commented Nov 12, 2021 •

edited

Loading

github-actions bot commented Nov 12, 2021 •

edited

Loading

github-actions bot commented Nov 12, 2021 •

edited

Loading

andy31415 commented Nov 16, 2021

Add example implementation of access control #11550

Add example implementation of access control #11550

Conversation

mlepage-google commented Nov 8, 2021

todo bot commented Nov 8, 2021

check against CATs in subject descriptor

This comment was generated by todo based on a TODO comment in 4008c6b in #11550. cc @mlepage-google.

todo bot commented Nov 8, 2021

check against target.deviceType (requires lookup)

This comment was generated by todo based on a TODO comment in 4008c6b in #11550. cc @mlepage-google.

todo bot commented Nov 8, 2021

implement extension

This comment was generated by todo based on a TODO comment in 4008c6b in #11550. cc @mlepage-google.

todo bot commented Nov 8, 2021

implement extension iterator

This comment was generated by todo based on a TODO comment in 4008c6b in #11550. cc @mlepage-google.

todo bot commented Nov 8, 2021

add entry/extension to listener interface

This comment was generated by todo based on a TODO comment in 4008c6b in #11550. cc @mlepage-google.

todo bot commented Nov 8, 2021

more capabilities

This comment was generated by todo based on a TODO comment in 4008c6b in #11550. cc @mlepage-google.

todo bot commented Nov 8, 2021

get from config

This comment was generated by todo based on a TODO comment in 4008c6b in #11550. cc @mlepage-google.

github-actions bot commented Nov 8, 2021 • edited Loading

github-actions bot commented Nov 8, 2021 • edited Loading

mlepage-google left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 12, 2021 • edited Loading

github-actions bot commented Nov 12, 2021 • edited Loading

github-actions bot commented Nov 12, 2021 • edited Loading

andy31415 commented Nov 16, 2021

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

This comment was generated by todo based on a `TODO` comment in `4008c6b` in #11550. cc @mlepage-google.

github-actions bot commented Nov 8, 2021 •

edited

Loading

github-actions bot commented Nov 8, 2021 •

edited

Loading

github-actions bot commented Nov 12, 2021 •

edited

Loading

github-actions bot commented Nov 12, 2021 •

edited

Loading

github-actions bot commented Nov 12, 2021 •

edited

Loading