Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mbed] Unit tests improvements #11589

Merged
merged 8 commits into from
Nov 15, 2021
Merged

[Mbed] Unit tests improvements #11589

merged 8 commits into from
Nov 15, 2021

Conversation

ATmobica
Copy link
Contributor

@ATmobica ATmobica commented Nov 9, 2021

Problem

Mbed unit tests implementation needs improvement. Not all tests passed. We verified and fix all issues.

Change overview

Reduce Mbed unit test coverage (due to flash memory size limitations) - remove dnssd testing.
Fix TestConfigurationMgr_GetPrimaryMACAddress for Mbed platform - skip comparing with default address - Mbed implementation always return MAC address.
Add TestKeyValueStoreMgr for Mbed platform
Fix ReadConfigValueBin function for Mbed platform - check buffer size
Fix InetInterface.cpp - move CloseIOCTLSocket() function to the right place
Fix InetEndPoint test - skip InterfaceNameToId checking for Mbed

Testing

Build and run Mbed unit test on the device. The result should be CHIP test status: 0, which means all tests passed.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11589: Size comparison from 613f27f to d5d4a52

Increases (4 builds for esp32, mbed)
platform target config section 613f27f d5d4a52 change % change
esp32 all-clusters-app m5stack (read only) 911847 911863 16 0.0
.flash.text 911847 911863 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290856 2290920 64 0.0
.text 1253456 1253520 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270952 2271016 64 0.0
.text 1233552 1233616 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048864 2048928 64 0.0
.text 1011464 1011528 64 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 613f27f d5d4a52 change % change
efr32 lighting-app BRD4161A (read only) 742904 742904 0 0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742896 742896 0 0.0
BRD4161A+rpc (read only) 730440 730440 0 0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 730432 730432 0 0.0
lock-app BRD4161A (read only) 722192 722192 0 0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 722184 722184 0 0.0
window-app BRD4161A (read only) 723088 723088 0 0.0
(read/write) 114412 114412 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 723080 723080 0 0.0
esp32 all-clusters-app c3devkit (read only) 880694 880694 0 0.0
(read/write) 1306536 1306536 0 0.0
.dram0.bss 58464 58464 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198360 198360 0 0.0
.flash.text 880694 880694 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911847 911863 16 0.0
(read/write) 423864 423864 0 0.0
.dram0.bss 60968 60968 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204624 204624 0 0.0
.flash.text 911847 911863 16 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699648 0 0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613940 613940 0 0.0
lock-app k32w061+debug (read/write) 592360 592360 0 0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 516156 516156 0 0.0
shell k32w061+debug (read/write) 658016 658016 0 0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 571044 571044 0 0.0
linux all-clusters-app debug (read only) 1710601 1710601 0 0.0
(read/write) 126528 126528 0 0.0
.bss 57872 57872 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62352 62352 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139765 0 0.0
.text 1437346 1437346 0 0.0
bridge-app debug+rpc (read only) 1298253 1298253 0 0.0
(read/write) 77072 77072 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27760 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090821 1090821 0 0.0
chip-tool debug (read only) 4982309 4982309 0 0.0
(read/write) 134688 134688 0 0.0
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101184 101184 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 239760 239760 0 0.0
.text 4471397 4471397 0 0.0
lighting-app debug+rpc (read only) 1557945 1557945 0 0.0
(read/write) 110088 110088 0 0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55168 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1295410 1295410 0 0.0
ota-provider-app debug (read only) 1259721 1259721 0 0.0
(read/write) 75336 75336 0 0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1050258 1050258 0 0.0
ota-requestor-app debug (read only) 1344281 1344281 0 0.0
(read/write) 79104 79104 0 0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25880 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1121250 1121250 0 0.0
shell debug (read only) 789065 789065 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 609362 609362 0 0.0
tv-app debug (read only) 1842217 1842217 0 0.0
(read/write) 407936 407936 0 0.0
.bss 340112 340112 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59448 59448 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156456 0 0.0
.text 1541842 1541842 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290856 2290920 64 0.0
.bss 179436 179436 0 0.0
.data 5232 5232 0 0.0
.heap 851776 851776 0 0.0
.text 1253456 1253520 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270952 2271016 64 0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1233552 1233616 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248672 2248672 0 0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1211272 1211272 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048864 2048928 64 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1011464 1011528 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862155 862155 0 0.0
bss 111460 111460 0 0.0
rodata 96924 96924 0 0.0
text 578128 578128 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 824503 824503 0 0.0
bss 107812 107812 0 0.0
rodata 88104 88104 0 0.0
text 552276 552276 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787162 787162 0 0.0
bss 112832 112832 0 0.0
rodata 92180 92180 0 0.0
text 507600 507600 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838831 838831 0 0.0
bss 110492 110492 0 0.0
rodata 93296 93296 0 0.0
text 559612 559612 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764142 764142 0 0.0
bss 111904 111904 0 0.0
rodata 88600 88600 0 0.0
text 489176 489176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844955 844955 0 0.0
bss 110632 110632 0 0.0
rodata 95004 95004 0 0.0
text 563772 563772 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838699 838699 0 0.0
bss 110528 110528 0 0.0
rodata 93292 93292 0 0.0
text 559348 559348 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776431 776431 0 0.0
bss 109280 109280 0 0.0
rodata 72564 72564 0 0.0
text 520004 520004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691482 691482 0 0.0
bss 110264 110264 0 0.0
rodata 67204 67204 0 0.0
text 440612 440612 0 0.0
p6 all-clusters-app default (read/write) 2299528 2299528 0 0.0
.bss 112448 112448 0 0.0
.data 2536 2536 0 0.0
.heap 918360 918360 0 0.0
.text 1257792 1257792 0 0.0
lock-app default (read/write) 2212184 2212184 0 0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1170448 1170448 0 0.0
qpg lighting-app qpg6100+debug (read only) 490776 490776 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 485456 485456 0 0.0
lock-app qpg6100+debug (read only) 466988 466988 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461668 461668 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663750 0 0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458596 458596 0 0.0

andy31415
andy31415 requested changes Nov 9, 2021
View reviewed changes
src/BUILD.gn Show resolved Hide resolved
@woody-apple
Copy link
Contributor

Fast tracking, as this is a platform maintainer making platform changes.

@ATmobica ATmobica force-pushed the mbed-fix-unit-tests branch from d5d4a52 to a5ec7e6 Compare November 10, 2021 08:14
@github-actions
Copy link

github-actions bot commented Nov 10, 2021 •
edited
Loading

PR #11589: Size comparison from 30e1b97 to a5ec7e6

Increases (4 builds for esp32, mbed)
platform target config section 30e1b97 a5ec7e6 change % change
esp32 all-clusters-app m5stack (read only) 910299 910363 64 0.0
.flash.text 910299 910363 64 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288952 2289016 64 0.0
.text 1251552 1251616 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270384 2270448 64 0.0
.text 1232984 1233048 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048152 2048216 64 0.0
.text 1010752 1010816 64 0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 30e1b97 a5ec7e6 change % change
efr32 lighting-app BRD4161A (read only) 742308 742308 0 0.0
(read/write) 116276 116276 0 0.0
.bss 114492 114492 0 0.0
.data 1784 1784 0 0.0
.text 742300 742300 0 0.0
BRD4161A+rpc (read only) 729832 729832 0 0.0
(read/write) 132900 132900 0 0.0
.bss 130996 130996 0 0.0
.data 1900 1900 0 0.0
.text 729824 729824 0 0.0
lock-app BRD4161A (read only) 721588 721588 0 0.0
(read/write) 114092 114092 0 0.0
.bss 112348 112348 0 0.0
.data 1744 1744 0 0.0
.text 721580 721580 0 0.0
window-app BRD4161A (read only) 722500 722500 0 0.0
(read/write) 114416 114416 0 0.0
.bss 112668 112668 0 0.0
.data 1748 1748 0 0.0
.text 722492 722492 0 0.0
esp32 all-clusters-app c3devkit (read only) 878906 878906 0 0.0
(read/write) 1305920 1305920 0 0.0
.dram0.bss 58432 58432 0 0.0
.dram0.data 16456 16456 0 0.0
.flash.rodata 197792 197792 0 0.0
.flash.text 878906 878906 0 0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 910299 910363 64 0.0
(read/write) 423252 423252 0 0.0
.dram0.bss 60936 60936 0 0.0
.dram0.data 32092 32092 0 0.0
.flash.rodata 204060 204060 0 0.0
.flash.text 910299 910363 64 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699104 699104 0 0.0
.bss 78004 78004 0 0.0
.data 1912 1912 0 0.0
.text 613388 613388 0 0.0
lock-app k32w061+debug (read/write) 591832 591832 0 0.0
.bss 68532 68532 0 0.0
.data 1880 1880 0 0.0
.text 515620 515620 0 0.0
shell k32w061+debug (read/write) 657472 657472 0 0.0
.bss 79332 79332 0 0.0
.data 1848 1848 0 0.0
.text 570492 570492 0 0.0
linux all-clusters-app debug (read only) 1697777 1697777 0 0.0
(read/write) 126304 126304 0 0.0
.bss 57872 57872 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62144 62144 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 138901 138901 0 0.0
.text 1425794 1425794 0 0.0
bridge-app debug+rpc (read only) 1297565 1297565 0 0.0
(read/write) 77104 77104 0 0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27808 27808 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110740 110740 0 0.0
.text 1090789 1090789 0 0.0
chip-tool debug (read only) 4615109 4615109 0 0.0
(read/write) 134888 134888 0 0.0
.bss 25936 25936 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101280 101280 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 240592 240592 0 0.0
.text 4103125 4103125 0 0.0
lighting-app debug+rpc (read only) 1556953 1556953 0 0.0
(read/write) 110216 110216 0 0.0
.bss 48528 48528 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55216 55216 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128177 128177 0 0.0
.text 1295074 1295074 0 0.0
ota-provider-app debug (read only) 1258729 1258729 0 0.0
(read/write) 75464 75464 0 0.0
.bss 44960 44960 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24664 24664 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112416 112416 0 0.0
.text 1049922 1049922 0 0.0
ota-requestor-app debug (read only) 1343289 1343289 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47424 47424 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123432 123432 0 0.0
.text 1120914 1120914 0 0.0
shell debug (read only) 787161 787161 0 0.0
(read/write) 65480 65480 0 0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36816 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77327 77327 0 0.0
.text 608322 608322 0 0.0
tv-app debug (read only) 1841641 1841641 0 0.0
(read/write) 408064 408064 0 0.0
.bss 340208 340208 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 59480 59480 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155624 155624 0 0.0
.text 1541954 1541954 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288952 2289016 64 0.0
.bss 179404 179404 0 0.0
.data 5216 5216 0 0.0
.heap 851824 851824 0 0.0
.text 1251552 1251616 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270384 2270448 64 0.0
.bss 172500 172500 0 0.0
.data 5584 5584 0 0.0
.heap 858360 858360 0 0.0
.text 1232984 1233048 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248104 2248104 0 0.0
.bss 171396 171396 0 0.0
.data 5568 5568 0 0.0
.heap 859480 859480 0 0.0
.text 1210704 1210704 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048152 2048216 64 0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1010752 1010816 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 861607 861607 0 0.0
bss 111468 111468 0 0.0
rodata 96488 96488 0 0.0
text 578012 578012 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823935 823935 0 0.0
bss 107820 107820 0 0.0
rodata 87664 87664 0 0.0
text 552160 552160 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 786646 786646 0 0.0
bss 112840 112840 0 0.0
rodata 91744 91744 0 0.0
text 507484 507484 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 838315 838315 0 0.0
bss 110500 110500 0 0.0
rodata 92860 92860 0 0.0
text 559496 559496 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 763626 763626 0 0.0
bss 111912 111912 0 0.0
rodata 88164 88164 0 0.0
text 489060 489060 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844407 844407 0 0.0
bss 110640 110640 0 0.0
rodata 94568 94568 0 0.0
text 563656 563656 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838167 838167 0 0.0
bss 110536 110536 0 0.0
rodata 92856 92856 0 0.0
text 559232 559232 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775719 775719 0 0.0
bss 109280 109280 0 0.0
rodata 72108 72108 0 0.0
text 519752 519752 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690774 690774 0 0.0
bss 110264 110264 0 0.0
rodata 66752 66752 0 0.0
text 440360 440360 0 0.0
p6 all-clusters-app default (read/write) 2296968 2296968 0 0.0
.bss 112416 112416 0 0.0
.data 2520 2520 0 0.0
.heap 918408 918408 0 0.0
.text 1255232 1255232 0 0.0
lock-app default (read/write) 2211568 2211568 0 0.0
.bss 101264 101264 0 0.0
.data 2408 2408 0 0.0
.heap 929672 929672 0 0.0
.text 1169832 1169832 0 0.0
qpg lighting-app qpg6100+debug (read only) 490396 490396 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51160 51160 0 0.0
.data 1012 1012 0 0.0
.text 485076 485076 0 0.0
lock-app qpg6100+debug (read only) 466608 466608 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50104 50104 0 0.0
.data 968 968 0 0.0
.text 461288 461288 0 0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663174 663174 0 0.0
bss 69280 69280 0 0.0
noinit 33216 33216 0 0.0
text 458464 458464 0 0.0

@ATmobica ATmobica force-pushed the mbed-fix-unit-tests branch from a5ec7e6 to def57ed Compare November 15, 2021 08:59
@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11589: Size comparison from 5623978 to def57ed

Increases (3 builds for mbed)
platform target config section 5623978 def57ed change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292200 2292264 64 0.0
.text 1254800 1254864 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250128 2250192 64 0.0
.text 1212728 1212792 64 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048376 2048440 64 0.0
.text 1010976 1011040 64 0.0
Full report (36 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5623978 def57ed change % change
efr32 lighting-app BRD4161A (read only) 750088 750088 0 0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 750080 750080 0 0.0
BRD4161A+rpc (read only) 737636 737636 0 0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 737628 737628 0 0.0
lock-app BRD4161A (read only) 726752 726752 0 0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 726744 726744 0 0.0
window-app BRD4161A (read only) 727744 727744 0 0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 727736 727736 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 702540 702540 0 0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 617324 617324 0 0.0
lock-app k32w061+debug (read/write) 593548 593548 0 0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 517844 517844 0 0.0
shell k32w061+debug (read/write) 659232 659232 0 0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 572768 572768 0 0.0
linux all-clusters-app debug (read only) 1722337 1722337 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62720 62720 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140277 140277 0 0.0
.text 1447842 1447842 0 0.0
bridge-app debug+rpc (read only) 1312741 1312741 0 0.0
(read/write) 77424 77424 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27960 27960 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111860 111860 0 0.0
.text 1103909 1103909 0 0.0
chip-tool debug (read only) 4921493 4921493 0 0.0
(read/write) 167208 167208 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118256 118256 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268242 268242 0 0.0
.text 4343605 4343605 0 0.0
lighting-app debug+rpc (read only) 1582281 1582281 0 0.0
(read/write) 110192 110192 0 0.0
.bss 48080 48080 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129841 129841 0 0.0
.text 1317746 1317746 0 0.0
ota-provider-app debug (read only) 1267337 1267337 0 0.0
(read/write) 75176 75176 0 0.0
.bss 44512 44512 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113383 0 0.0
.text 1057106 1057106 0 0.0
ota-requestor-app debug (read only) 1352009 1352009 0 0.0
(read/write) 78944 78944 0 0.0
.bss 46976 46976 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124208 124208 0 0.0
.text 1128402 1128402 0 0.0
shell debug (read only) 789081 789081 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 609282 609282 0 0.0
tv-app debug (read only) 1858569 1858569 0 0.0
(read/write) 407896 407896 0 0.0
.bss 339752 339752 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59696 59696 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157069 157069 0 0.0
.text 1556418 1556418 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292200 2292264 64 0.0
.bss 179692 179692 0 0.0
.data 5216 5216 0 0.0
.heap 851536 851536 0 0.0
.text 1254800 1254864 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274688 2274688 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1237288 1237288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250128 2250192 64 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1212728 1212792 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048440 64 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1011040 64 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865175 865175 0 0.0
bss 110964 110964 0 0.0
rodata 97080 97080 0 0.0
text 581516 581516 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827567 827567 0 0.0
bss 107320 107320 0 0.0
rodata 88272 88272 0 0.0
text 555688 555688 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790234 790234 0 0.0
bss 112340 112340 0 0.0
rodata 92340 92340 0 0.0
text 510984 510984 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840199 840199 0 0.0
bss 109988 109988 0 0.0
rodata 93144 93144 0 0.0
text 561616 561616 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765514 765514 0 0.0
bss 111400 111400 0 0.0
rodata 88452 88452 0 0.0
text 491176 491176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846327 846327 0 0.0
bss 110128 110128 0 0.0
rodata 94856 94856 0 0.0
text 565800 565800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839903 839903 0 0.0
bss 110024 110024 0 0.0
rodata 93104 93104 0 0.0
text 561236 561236 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775499 775499 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520020 520020 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690554 690554 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440628 440628 0 0.0
p6 all-clusters-app default (read/write) 2301232 2301232 0 0.0
.bss 112680 112680 0 0.0
.data 2520 2520 0 0.0
.heap 918144 918144 0 0.0
.text 1259496 1259496 0 0.0
lock-app default (read/write) 2214704 2214704 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1172968 1172968 0 0.0
qpg lighting-app qpg6100+debug (read only) 494216 494216 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 488896 488896 0 0.0
lock-app qpg6100+debug (read only) 468752 468752 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 463432 463432 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667854 667854 0 0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 462372 462372 0 0.0

@andy31415 andy31415 merged commit 1903401 into project-chip:master Nov 15, 2021
@ATmobica ATmobica deleted the mbed-fix-unit-tests branch November 23, 2021 09:05
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@ATmobica
[Mbed] Unit tests improvements (project-chip#11589)
41c25da 
* Reduce unit test coverage for mbed - remove dnssd testing

* Fix TestConfigurationMgr_GetPrimaryMACAddress for Mbed platform

* Add TestKeyValueStoreMgr for Mbed platform
Fix ReadConfigValueBin function for Mbed platform - check buffer size

* Move CloseIOCTLSocket() function to the right place

* Fix InetEndPoint test - skip InterfaceNameToId checking for Mbed

* Fix condtion in TestKeyValueStoreMgr

* Changes restyle

* Add note to skip tests for Mbed platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- left review comments

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
fast track inet platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ATmobica @woody-apple @pan- @andy31415