Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SetCounter for local counter #11590

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Remove SetCounter for local counter #11590

merged 1 commit into from
Nov 15, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Nov 9, 2021

Problem

After #10808, there is no need to set local counter any more

Change overview

Remove SetCounter API and all its calls

Testing

Running unit-tests

@restyled-io restyled-io bot mentioned this pull request Nov 9, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11590: Size comparison from 0e4bc51 to 6419885

Decreases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0e4bc51 6419885 change % change
efr32 lighting-app BRD4161A (read only) 742904 742872 -32 -0.0
.text 742896 742864 -32 -0.0
BRD4161A+rpc (read only) 730440 730408 -32 -0.0
.text 730432 730400 -32 -0.0
lock-app BRD4161A (read only) 722192 722160 -32 -0.0
.text 722184 722152 -32 -0.0
window-app BRD4161A (read only) 723088 723056 -32 -0.0
.text 723080 723048 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 880694 880678 -16 -0.0
(read/write) 1306536 1306528 -8 -0.0
.flash.rodata 198360 198352 -8 -0.0
.flash.text 880694 880678 -16 -0.0
m5stack (read only) 911847 911815 -32 -0.0
(read/write) 423864 423856 -8 -0.0
.flash.rodata 204624 204616 -8 -0.0
.flash.text 911847 911815 -32 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699620 -28 -0.0
.text 613940 613912 -28 -0.0
lock-app k32w061+debug (read/write) 592360 592332 -28 -0.0
.text 516156 516128 -28 -0.0
shell k32w061+debug (read/write) 658016 657988 -28 -0.0
.text 571044 571016 -28 -0.0
linux all-clusters-app debug (read only) 1710601 1710313 -288 -0.0
(read/write) 126528 126496 -32 -0.0
.data.rel.ro 62352 62320 -32 -0.1
.text 1437346 1437154 -192 -0.0
bridge-app debug+rpc (read only) 1298253 1297965 -288 -0.0
(read/write) 77072 77040 -32 -0.0
.data.rel.ro 27760 27728 -32 -0.1
.text 1090821 1090629 -192 -0.0
chip-tool debug (read only) 4982309 4981557 -752 -0.0
(read/write) 134688 134656 -32 -0.0
.data.rel.ro 101184 101152 -32 -0.0
.rodata 239760 239696 -64 -0.0
.text 4471397 4470805 -592 -0.0
lighting-app debug+rpc (read only) 1557945 1557657 -288 -0.0
(read/write) 110088 110056 -32 -0.0
.data.rel.ro 55168 55136 -32 -0.1
.text 1295410 1295218 -192 -0.0
ota-provider-app debug (read only) 1259721 1259433 -288 -0.0
(read/write) 75336 75304 -32 -0.0
.data.rel.ro 24616 24584 -32 -0.1
.text 1050258 1050066 -192 -0.0
ota-requestor-app debug (read only) 1344281 1343993 -288 -0.0
(read/write) 79104 79072 -32 -0.0
.data.rel.ro 25880 25848 -32 -0.1
.text 1121250 1121058 -192 -0.0
shell debug (read only) 789065 788777 -288 -0.0
(read/write) 65480 65448 -32 -0.0
.data.rel.ro 36816 36784 -32 -0.1
.text 609362 609170 -192 -0.0
tv-app debug (read only) 1842217 1841497 -720 -0.0
(read/write) 407936 407392 -544 -0.1
.bss 340112 339600 -512 -0.2
.data.rel.ro 59448 59416 -32 -0.1
.rodata 156456 156424 -32 -0.0
.text 1541842 1541250 -592 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290856 2290840 -16 -0.0
.text 1253456 1253440 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270952 2270936 -16 -0.0
.text 1233552 1233536 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248672 2248592 -80 -0.0
.text 1211272 1211192 -80 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048864 2048856 -8 -0.0
.text 1011464 1011456 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862155 862127 -28 -0.0
rodata 96924 96912 -12 -0.0
text 578128 578112 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824503 824475 -28 -0.0
rodata 88104 88092 -12 -0.0
text 552276 552260 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787162 787134 -28 -0.0
rodata 92180 92168 -12 -0.0
text 507600 507584 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838831 838803 -28 -0.0
rodata 93296 93284 -12 -0.0
text 559612 559596 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764142 764114 -28 -0.0
rodata 88600 88588 -12 -0.0
text 489176 489160 -16 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844955 844927 -28 -0.0
rodata 95004 94992 -12 -0.0
text 563772 563756 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838699 838671 -28 -0.0
rodata 93292 93280 -12 -0.0
text 559348 559332 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 776431 776403 -28 -0.0
rodata 72564 72552 -12 -0.0
text 520004 519988 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691482 691454 -28 -0.0
rodata 67204 67192 -12 -0.0
text 440612 440596 -16 -0.0
p6 all-clusters-app default (read/write) 2299528 2299496 -32 -0.0
.text 1257792 1257760 -32 -0.0
lock-app default (read/write) 2212184 2212152 -32 -0.0
.text 1170448 1170416 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 490776 490748 -28 -0.0
.text 485456 485428 -28 -0.0
lock-app qpg6100+debug (read only) 466988 466960 -28 -0.0
.text 461668 461640 -28 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663722 -28 -0.0
text 458596 458578 -18 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 0e4bc51 6419885 change % change
efr32 lighting-app BRD4161A (read only) 742904 742872 -32 -0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742896 742864 -32 -0.0
BRD4161A+rpc (read only) 730440 730408 -32 -0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 730432 730400 -32 -0.0
lock-app BRD4161A (read only) 722192 722160 -32 -0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 722184 722152 -32 -0.0
window-app BRD4161A (read only) 723088 723056 -32 -0.0
(read/write) 114412 114412 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 723080 723048 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 880694 880678 -16 -0.0
(read/write) 1306536 1306528 -8 -0.0
.dram0.bss 58464 58464 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198360 198352 -8 -0.0
.flash.text 880694 880678 -16 -0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911847 911815 -32 -0.0
(read/write) 423864 423856 -8 -0.0
.dram0.bss 60968 60968 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204624 204616 -8 -0.0
.flash.text 911847 911815 -32 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699620 -28 -0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613940 613912 -28 -0.0
lock-app k32w061+debug (read/write) 592360 592332 -28 -0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 516156 516128 -28 -0.0
shell k32w061+debug (read/write) 658016 657988 -28 -0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 571044 571016 -28 -0.0
linux all-clusters-app debug (read only) 1710601 1710313 -288 -0.0
(read/write) 126528 126496 -32 -0.0
.bss 57872 57872 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62352 62320 -32 -0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139765 0 0.0
.text 1437346 1437154 -192 -0.0
bridge-app debug+rpc (read only) 1298253 1297965 -288 -0.0
(read/write) 77072 77040 -32 -0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27728 -32 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090821 1090629 -192 -0.0
chip-tool debug (read only) 4982309 4981557 -752 -0.0
(read/write) 134688 134656 -32 -0.0
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101184 101152 -32 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 239760 239696 -64 -0.0
.text 4471397 4470805 -592 -0.0
lighting-app debug+rpc (read only) 1557945 1557657 -288 -0.0
(read/write) 110088 110056 -32 -0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55136 -32 -0.1
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1295410 1295218 -192 -0.0
ota-provider-app debug (read only) 1259721 1259433 -288 -0.0
(read/write) 75336 75304 -32 -0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24584 -32 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1050258 1050066 -192 -0.0
ota-requestor-app debug (read only) 1344281 1343993 -288 -0.0
(read/write) 79104 79072 -32 -0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25848 -32 -0.1
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1121250 1121058 -192 -0.0
shell debug (read only) 789065 788777 -288 -0.0
(read/write) 65480 65448 -32 -0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36784 -32 -0.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 609362 609170 -192 -0.0
tv-app debug (read only) 1842217 1841497 -720 -0.0
(read/write) 407936 407392 -544 -0.1
.bss 340112 339600 -512 -0.2
.data 2736 2736 0 0.0
.data.rel.ro 59448 59416 -32 -0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156424 -32 -0.0
.text 1541842 1541250 -592 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290856 2290840 -16 -0.0
.bss 179436 179436 0 0.0
.data 5232 5232 0 0.0
.heap 851776 851776 0 0.0
.text 1253456 1253440 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270952 2270936 -16 -0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1233552 1233536 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248672 2248592 -80 -0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1211272 1211192 -80 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048864 2048856 -8 -0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1011464 1011456 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862155 862127 -28 -0.0
bss 111460 111460 0 0.0
rodata 96924 96912 -12 -0.0
text 578128 578112 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824503 824475 -28 -0.0
bss 107812 107812 0 0.0
rodata 88104 88092 -12 -0.0
text 552276 552260 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787162 787134 -28 -0.0
bss 112832 112832 0 0.0
rodata 92180 92168 -12 -0.0
text 507600 507584 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838831 838803 -28 -0.0
bss 110492 110492 0 0.0
rodata 93296 93284 -12 -0.0
text 559612 559596 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764142 764114 -28 -0.0
bss 111904 111904 0 0.0
rodata 88600 88588 -12 -0.0
text 489176 489160 -16 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844955 844927 -28 -0.0
bss 110632 110632 0 0.0
rodata 95004 94992 -12 -0.0
text 563772 563756 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838699 838671 -28 -0.0
bss 110528 110528 0 0.0
rodata 93292 93280 -12 -0.0
text 559348 559332 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 776431 776403 -28 -0.0
bss 109280 109280 0 0.0
rodata 72564 72552 -12 -0.0
text 520004 519988 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691482 691454 -28 -0.0
bss 110264 110264 0 0.0
rodata 67204 67192 -12 -0.0
text 440612 440596 -16 -0.0
p6 all-clusters-app default (read/write) 2299528 2299496 -32 -0.0
.bss 112448 112448 0 0.0
.data 2536 2536 0 0.0
.heap 918360 918360 0 0.0
.text 1257792 1257760 -32 -0.0
lock-app default (read/write) 2212184 2212152 -32 -0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1170448 1170416 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 490776 490748 -28 -0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 485456 485428 -28 -0.0
lock-app qpg6100+debug (read only) 466988 466960 -28 -0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461668 461640 -28 -0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663722 -28 -0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458596 458578 -18 -0.0

@pullapprove pullapprove bot requested a review from yunhanw-google November 9, 2021 20:27
@github-actions
Copy link

github-actions bot commented Nov 9, 2021 •
edited
Loading

PR #11590: Size comparison from e6dab37 to 2f08c04

Decreases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e6dab37 2f08c04 change % change
efr32 lighting-app BRD4161A (read only) 742904 742872 -32 -0.0
.text 742896 742864 -32 -0.0
BRD4161A+rpc (read only) 730440 730408 -32 -0.0
.text 730432 730400 -32 -0.0
lock-app BRD4161A (read only) 722192 722160 -32 -0.0
.text 722184 722152 -32 -0.0
window-app BRD4161A (read only) 723088 723056 -32 -0.0
.text 723080 723048 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 880694 880678 -16 -0.0
(read/write) 1306536 1306528 -8 -0.0
.flash.rodata 198360 198352 -8 -0.0
.flash.text 880694 880678 -16 -0.0
m5stack (read only) 911867 911835 -32 -0.0
(read/write) 423864 423856 -8 -0.0
.flash.rodata 204624 204616 -8 -0.0
.flash.text 911867 911835 -32 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699620 -28 -0.0
.text 613940 613912 -28 -0.0
lock-app k32w061+debug (read/write) 592360 592332 -28 -0.0
.text 516156 516128 -28 -0.0
shell k32w061+debug (read/write) 658016 657988 -28 -0.0
.text 571044 571016 -28 -0.0
linux all-clusters-app debug (read only) 1710601 1710313 -288 -0.0
(read/write) 126528 126496 -32 -0.0
.data.rel.ro 62352 62320 -32 -0.1
.text 1437346 1437154 -192 -0.0
bridge-app debug+rpc (read only) 1298253 1297965 -288 -0.0
(read/write) 77072 77040 -32 -0.0
.data.rel.ro 27760 27728 -32 -0.1
.text 1090821 1090629 -192 -0.0
chip-tool debug (read only) 4995029 4994277 -752 -0.0
(read/write) 134760 134728 -32 -0.0
.data.rel.ro 101232 101200 -32 -0.0
.rodata 242064 242000 -64 -0.0
.text 4481717 4481125 -592 -0.0
lighting-app debug+rpc (read only) 1557945 1557657 -288 -0.0
(read/write) 110088 110056 -32 -0.0
.data.rel.ro 55168 55136 -32 -0.1
.text 1295410 1295218 -192 -0.0
ota-provider-app debug (read only) 1259721 1259433 -288 -0.0
(read/write) 75336 75304 -32 -0.0
.data.rel.ro 24616 24584 -32 -0.1
.text 1050258 1050066 -192 -0.0
ota-requestor-app debug (read only) 1344281 1343993 -288 -0.0
(read/write) 79104 79072 -32 -0.0
.data.rel.ro 25880 25848 -32 -0.1
.text 1121250 1121058 -192 -0.0
shell debug (read only) 789065 788777 -288 -0.0
(read/write) 65480 65448 -32 -0.0
.data.rel.ro 36816 36784 -32 -0.1
.text 609362 609170 -192 -0.0
tv-app debug (read only) 1842281 1841561 -720 -0.0
(read/write) 407936 407392 -544 -0.1
.bss 340112 339600 -512 -0.2
.data.rel.ro 59448 59416 -32 -0.1
.rodata 156456 156424 -32 -0.0
.text 1541906 1541314 -592 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2290856 2290840 -16 -0.0
.text 1253456 1253440 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270952 2270936 -16 -0.0
.text 1233552 1233536 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248672 2248592 -80 -0.0
.text 1211272 1211192 -80 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2048864 2048856 -8 -0.0
.text 1011464 1011456 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862155 862127 -28 -0.0
rodata 96924 96912 -12 -0.0
text 578128 578112 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824503 824475 -28 -0.0
rodata 88104 88092 -12 -0.0
text 552276 552260 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787162 787134 -28 -0.0
rodata 92180 92168 -12 -0.0
text 507600 507584 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838831 838803 -28 -0.0
rodata 93296 93284 -12 -0.0
text 559612 559596 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764142 764114 -28 -0.0
rodata 88600 88588 -12 -0.0
text 489176 489160 -16 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844955 844927 -28 -0.0
rodata 95004 94992 -12 -0.0
text 563772 563756 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838699 838671 -28 -0.0
rodata 93292 93280 -12 -0.0
text 559348 559332 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 776431 776403 -28 -0.0
rodata 72564 72552 -12 -0.0
text 520004 519988 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691482 691454 -28 -0.0
rodata 67204 67192 -12 -0.0
text 440612 440596 -16 -0.0
p6 all-clusters-app default (read/write) 2299528 2299496 -32 -0.0
.text 1257792 1257760 -32 -0.0
lock-app default (read/write) 2212184 2212152 -32 -0.0
.text 1170448 1170416 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 490776 490748 -28 -0.0
.text 485456 485428 -28 -0.0
lock-app qpg6100+debug (read only) 466988 466960 -28 -0.0
.text 461668 461640 -28 -0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663722 -28 -0.0
text 458596 458578 -18 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e6dab37 2f08c04 change % change
efr32 lighting-app BRD4161A (read only) 742904 742872 -32 -0.0
(read/write) 116268 116268 0 0.0
.bss 114484 114484 0 0.0
.data 1784 1784 0 0.0
.text 742896 742864 -32 -0.0
BRD4161A+rpc (read only) 730440 730408 -32 -0.0
(read/write) 132892 132892 0 0.0
.bss 130988 130988 0 0.0
.data 1900 1900 0 0.0
.text 730432 730400 -32 -0.0
lock-app BRD4161A (read only) 722192 722160 -32 -0.0
(read/write) 114084 114084 0 0.0
.bss 112340 112340 0 0.0
.data 1744 1744 0 0.0
.text 722184 722152 -32 -0.0
window-app BRD4161A (read only) 723088 723056 -32 -0.0
(read/write) 114412 114412 0 0.0
.bss 112660 112660 0 0.0
.data 1748 1748 0 0.0
.text 723080 723048 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 880694 880678 -16 -0.0
(read/write) 1306536 1306528 -8 -0.0
.dram0.bss 58464 58464 0 0.0
.dram0.data 16472 16472 0 0.0
.flash.rodata 198360 198352 -8 -0.0
.flash.text 880694 880678 -16 -0.0
.iram0.text 57526 57526 0 0.0
m5stack (read only) 911867 911835 -32 -0.0
(read/write) 423864 423856 -8 -0.0
.dram0.bss 60968 60968 0 0.0
.dram0.data 32108 32108 0 0.0
.flash.rodata 204624 204616 -8 -0.0
.flash.text 911867 911835 -32 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 699648 699620 -28 -0.0
.bss 77996 77996 0 0.0
.data 1912 1912 0 0.0
.text 613940 613912 -28 -0.0
lock-app k32w061+debug (read/write) 592360 592332 -28 -0.0
.bss 68524 68524 0 0.0
.data 1880 1880 0 0.0
.text 516156 516128 -28 -0.0
shell k32w061+debug (read/write) 658016 657988 -28 -0.0
.bss 79324 79324 0 0.0
.data 1848 1848 0 0.0
.text 571044 571016 -28 -0.0
linux all-clusters-app debug (read only) 1710601 1710313 -288 -0.0
(read/write) 126528 126496 -32 -0.0
.bss 57872 57872 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62352 62320 -32 -0.1
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 139765 139765 0 0.0
.text 1437346 1437154 -192 -0.0
bridge-app debug+rpc (read only) 1298253 1297965 -288 -0.0
(read/write) 77072 77040 -32 -0.0
.bss 42768 42768 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27760 27728 -32 -0.1
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111540 111540 0 0.0
.text 1090821 1090629 -192 -0.0
chip-tool debug (read only) 4995029 4994277 -752 -0.0
(read/write) 134760 134728 -32 -0.0
.bss 25840 25840 0 0.0
.data 2256 2256 0 0.0
.data.rel.ro 101232 101200 -32 -0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 432 432 0 0.0
.rodata 242064 242000 -64 -0.0
.text 4481717 4481125 -592 -0.0
lighting-app debug+rpc (read only) 1557945 1557657 -288 -0.0
(read/write) 110088 110056 -32 -0.0
.bss 48432 48432 0 0.0
.data 1202 1202 0 0.0
.data.rel.ro 55168 55136 -32 -0.1
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 128977 128977 0 0.0
.text 1295410 1295218 -192 -0.0
ota-provider-app debug (read only) 1259721 1259433 -288 -0.0
(read/write) 75336 75304 -32 -0.0
.bss 44864 44864 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24584 -32 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113216 113216 0 0.0
.text 1050258 1050066 -192 -0.0
ota-requestor-app debug (read only) 1344281 1343993 -288 -0.0
(read/write) 79104 79072 -32 -0.0
.bss 47328 47328 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25880 25848 -32 -0.1
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124232 124232 0 0.0
.text 1121250 1121058 -192 -0.0
shell debug (read only) 789065 788777 -288 -0.0
(read/write) 65480 65448 -32 -0.0
.bss 23912 23912 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36816 36784 -32 -0.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78191 78191 0 0.0
.text 609362 609170 -192 -0.0
tv-app debug (read only) 1842281 1841561 -720 -0.0
(read/write) 407936 407392 -544 -0.1
.bss 340112 339600 -512 -0.2
.data 2736 2736 0 0.0
.data.rel.ro 59448 59416 -32 -0.1
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156456 156424 -32 -0.0
.text 1541906 1541314 -592 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290856 2290840 -16 -0.0
.bss 179436 179436 0 0.0
.data 5232 5232 0 0.0
.heap 851776 851776 0 0.0
.text 1253456 1253440 -16 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270952 2270936 -16 -0.0
.bss 172492 172492 0 0.0
.data 5584 5584 0 0.0
.heap 858368 858368 0 0.0
.text 1233552 1233536 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248672 2248592 -80 -0.0
.bss 171388 171388 0 0.0
.data 5568 5568 0 0.0
.heap 859488 859488 0 0.0
.text 1211272 1211192 -80 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048864 2048856 -8 -0.0
.bss 156456 156456 0 0.0
.data 4976 4976 0 0.0
.heap 875016 875016 0 0.0
.text 1011464 1011456 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862155 862127 -28 -0.0
bss 111460 111460 0 0.0
rodata 96924 96912 -12 -0.0
text 578128 578112 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 824503 824475 -28 -0.0
bss 107812 107812 0 0.0
rodata 88104 88092 -12 -0.0
text 552276 552260 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 787162 787134 -28 -0.0
bss 112832 112832 0 0.0
rodata 92180 92168 -12 -0.0
text 507600 507584 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 838831 838803 -28 -0.0
bss 110492 110492 0 0.0
rodata 93296 93284 -12 -0.0
text 559612 559596 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764142 764114 -28 -0.0
bss 111904 111904 0 0.0
rodata 88600 88588 -12 -0.0
text 489176 489160 -16 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844955 844927 -28 -0.0
bss 110632 110632 0 0.0
rodata 95004 94992 -12 -0.0
text 563772 563756 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838699 838671 -28 -0.0
bss 110528 110528 0 0.0
rodata 93292 93280 -12 -0.0
text 559348 559332 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 776431 776403 -28 -0.0
bss 109280 109280 0 0.0
rodata 72564 72552 -12 -0.0
text 520004 519988 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691482 691454 -28 -0.0
bss 110264 110264 0 0.0
rodata 67204 67192 -12 -0.0
text 440612 440596 -16 -0.0
p6 all-clusters-app default (read/write) 2299528 2299496 -32 -0.0
.bss 112448 112448 0 0.0
.data 2536 2536 0 0.0
.heap 918360 918360 0 0.0
.text 1257792 1257760 -32 -0.0
lock-app default (read/write) 2212184 2212152 -32 -0.0
.bss 101256 101256 0 0.0
.data 2408 2408 0 0.0
.heap 929680 929680 0 0.0
.text 1170448 1170416 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 490776 490748 -28 -0.0
(read/write) 114140 114140 0 0.0
.bss 51152 51152 0 0.0
.data 1012 1012 0 0.0
.text 485456 485428 -28 -0.0
lock-app qpg6100+debug (read only) 466988 466960 -28 -0.0
(read/write) 114144 114144 0 0.0
.bss 50096 50096 0 0.0
.data 968 968 0 0.0
.text 461668 461640 -28 -0.0
persistent-storage-app qpg6100+debug (read only) 153400 153400 0 0.0
(read/write) 114140 114140 0 0.0
.bss 19616 19616 0 0.0
.data 364 364 0 0.0
.text 148080 148080 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 663750 663722 -28 -0.0
bss 69272 69272 0 0.0
noinit 33216 33216 0 0.0
text 458596 458578 -18 -0.0

@andy31415
Copy link
Contributor

fast track: PR up sufficient time for cross timezone review, has several checkmarks without any open comments. cleanup PR.

@andy31415 andy31415 merged commit a4607d3 into project-chip:master Nov 15, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kghost
Remove SetCounter for local counter (project-chip#11590)
97abede
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@pan-apple pan-apple Awaiting requested review from pan-apple

Assignees
No one assigned
Labels
controller fast track review - pending transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kghost @andy31415 @woody-apple