-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZAP to tip. #11768
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:smaller-default-values
Nov 15, 2021
Merged
Update ZAP to tip. #11768
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:smaller-default-values
Nov 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulls in changes to make the default attribute storage for strings depend on the actual string value, not the maximum size of the value. Fixes project-chip#5927
PR #11768: Size comparison from 507ba15 to afa85cc Decreases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 15, 2021
vivien-apple
approved these changes
Nov 15, 2021
andy31415
approved these changes
Nov 15, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Pulls in changes to make the default attribute storage for strings depend on the actual string value, not the maximum size of the value. Fixes project-chip#5927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in changes to make the default attribute storage for strings
depend on the actual string value, not the maximum size of the value.
Fixes #5927
Problem
Strings default values are huge.
Change overview
Make them be only as big as they need to be.
Testing
Verified by code inspection that we only read a length equal to the actual string length, so this change is safe.