esp32: fix different NDEBUG definitions in the examples and the library #11775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug level was not correctly synchronized between ESP-IDF and the connectedhomeip library.
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #11775: Size comparison from 5623978 to b3c9879 Increases above 0.2%:
Increases (2 builds for esp32)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 15, 2021
dhrishi
approved these changes
Nov 15, 2021
andy31415
approved these changes
Nov 15, 2021
|
fast track: platform specific change made & approved by platform owner. |
Damian-Nordic
added a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Nov 15, 2021
Now that ConfigurationManager is pure virtual it's no longer safe to include or exclude its interface methods using pre-compiler directives as building the ConfigurationManager header using different settings may lead to vtable index mismatch and hard to debug crashes. In fact, the crashes occurred on platforms that use several build systems, e.g. ESP32 (see project-chip#11775) or nRF Connect, as GN sets NDEBUG for release builds while nRF Connect examples are by default built with release configuration AND enabled assertions, too.
andy31415
pushed a commit
that referenced
this pull request
Nov 15, 2021
Now that ConfigurationManager is pure virtual it's no longer safe to include or exclude its interface methods using pre-compiler directives as building the ConfigurationManager header using different settings may lead to vtable index mismatch and hard to debug crashes. In fact, the crashes occurred on platforms that use several build systems, e.g. ESP32 (see #11775) or nRF Connect, as GN sets NDEBUG for release builds while nRF Connect examples are by default built with release configuration AND enabled assertions, too.
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
project-chip#11775) The debug level was not correctly synchronized between ESP-IDF and the connectedhomeip library.
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
Now that ConfigurationManager is pure virtual it's no longer safe to include or exclude its interface methods using pre-compiler directives as building the ConfigurationManager header using different settings may lead to vtable index mismatch and hard to debug crashes. In fact, the crashes occurred on platforms that use several build systems, e.g. ESP32 (see project-chip#11775) or nRF Connect, as GN sets NDEBUG for release builds while nRF Connect examples are by default built with release configuration AND enabled assertions, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The debug level was not correctly synchronized between ESP-IDF and the
connectedhomeip library.
The different
NDEBUGdefinitions are causing wrongvtableoffest in ConfigurationManager.Change overview
Set the gn
is_debugoption based on the IDF debug level.Testing
Build & run. The
ConfigurationManageris calling the correct functions now.