-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not dispatch packet to Device/DeviceController #11776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tecimovic
November 15, 2021 10:42
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 15, 2021 10:42
@mrjerryjohns @vivien-apple @erjiaqing @yunhanw-google Please take a look, I'm not sure |
PR #11776: Size comparison from 5623978 to 3a120b5 Increases (2 builds for p6)
Decreases (19 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
kghost
force-pushed
the
remove-dead-3
branch
from
November 15, 2021 11:41
3a120b5
to
a504821
Compare
PR #11776: Size comparison from 5623978 to a504821 Increases (5 builds for mbed, p6)
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 15, 2021
Damian-Nordic
approved these changes
Nov 15, 2021
woody-apple
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
All messages should be handled by protocols via exchange manager. But legacy codes routes message to device controller.
Change overview
Do not dispatch packet to Device/DeviceController
Testing
Verified using unit-tests.