Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telink]: Add posibility to configure CHIP shell over Kconfig #11787

Merged
merged 1 commit into from
Nov 15, 2021
Merged

[Telink]: Add posibility to configure CHIP shell over Kconfig #11787

merged 1 commit into from
Nov 15, 2021

Conversation

rikorsev
Copy link
Contributor

Problem

  • Absence of possibility to configure CHIP shell for Telink devices

Change overview

  • Modify config/telink/chip-module/CMakeLists.txt with proper management of CONFIG_CHIP_LIB_SHELL
  • Modify examples/lighting-app/telink/prj.conf with CONFIG_CHIP_LIB_SHELL=y

Testing

Manually. Steps:

  1. Build and Flash lighting-app example
  2. Connect to Matter device via uart
  3. Check if shell appeaser
  4. Try several shell commands

@andy31415
Copy link
Contributor

fast track: platform specific change

@github-actions
Copy link

github-actions bot commented Nov 15, 2021

PR #11787: Size comparison from 7c47bed to ea237e0

Increases above 0.2%:

platform target config section 7c47bed ea237e0 change % change
telink lighting-app tlsr9518adk80d (read/write) 667290 767402 100112 15.0
bss 69320 79216 9896 14.3
noinit 33216 37160 3944 11.9
text 462450 532250 69800 15.1
Increases (1 build for telink)
platform target config section 7c47bed ea237e0 change % change
telink lighting-app tlsr9518adk80d (read/write) 667290 767402 100112 15.0
bss 69320 79216 9896 14.3
noinit 33216 37160 3944 11.9
text 462450 532250 69800 15.1
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7c47bed ea237e0 change % change
efr32 lighting-app BRD4161A (read only) 749456 749456 0 0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 749448 749448 0 0.0
BRD4161A+rpc (read only) 737012 737012 0 0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 737004 737004 0 0.0
lock-app BRD4161A (read only) 726520 726520 0 0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 726512 726512 0 0.0
window-app BRD4161A (read only) 727512 727512 0 0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 727504 727504 0 0.0
esp32 all-clusters-app c3devkit (read only) 828266 828266 0 0.0
(read/write) 1221922 1221922 0 0.0
.dram0.bss 57096 57096 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 165480 165480 0 0.0
.flash.text 828266 828266 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 898639 898639 0 0.0
(read/write) 420704 420704 0 0.0
.dram0.bss 62184 62184 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 193140 193140 0 0.0
.flash.text 893255 893255 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701988 701988 0 0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 616772 616772 0 0.0
lock-app k32w061+debug (read/write) 593400 593400 0 0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 517696 517696 0 0.0
shell k32w061+debug (read/write) 659072 659072 0 0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 572608 572608 0 0.0
linux all-clusters-app debug (read only) 1717657 1717657 0 0.0
(read/write) 126944 126944 0 0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62848 62848 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136181 136181 0 0.0
.text 1447762 1447762 0 0.0
bridge-app debug+rpc (read only) 1312597 1312597 0 0.0
(read/write) 77552 77552 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28088 28088 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111604 111604 0 0.0
.text 1103829 1103829 0 0.0
chip-tool debug (read only) 4921333 4921333 0 0.0
(read/write) 167336 167336 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118384 118384 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268178 268178 0 0.0
.text 4343125 4343125 0 0.0
lighting-app debug+rpc (read only) 1581633 1581633 0 0.0
(read/write) 110320 110320 0 0.0
.bss 48080 48080 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55680 55680 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129201 129201 0 0.0
.text 1317666 1317666 0 0.0
ota-provider-app debug (read only) 1267641 1267641 0 0.0
(read/write) 75304 75304 0 0.0
.bss 44512 44512 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24904 24904 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113383 0 0.0
.text 1057026 1057026 0 0.0
ota-requestor-app debug (read only) 1352257 1352257 0 0.0
(read/write) 79072 79072 0 0.0
.bss 46976 46976 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26168 26168 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124176 124176 0 0.0
.text 1128322 1128322 0 0.0
shell debug (read only) 793417 793417 0 0.0
(read/write) 65512 65512 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37360 37360 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 612434 612434 0 0.0
tv-app debug (read only) 1856769 1856769 0 0.0
(read/write) 407512 407512 0 0.0
.bss 339240 339240 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59824 59824 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155949 155949 0 0.0
.text 1555954 1555954 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288384 2288384 0 0.0
.bss 179692 179692 0 0.0
.data 5216 5216 0 0.0
.heap 851536 851536 0 0.0
.text 1250984 1250984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274240 2274240 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1236840 1236840 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250080 2250080 0 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1212680 1212680 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049136 2049136 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1011736 1011736 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864611 864611 0 0.0
bss 110964 110964 0 0.0
rodata 96436 96436 0 0.0
text 581596 581596 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827003 827003 0 0.0
bss 107320 107320 0 0.0
rodata 87628 87628 0 0.0
text 555768 555768 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789670 789670 0 0.0
bss 112340 112340 0 0.0
rodata 91696 91696 0 0.0
text 511064 511064 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840059 840059 0 0.0
bss 109988 109988 0 0.0
rodata 92908 92908 0 0.0
text 561700 561700 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765354 765354 0 0.0
bss 111400 111400 0 0.0
rodata 88212 88212 0 0.0
text 491260 491260 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846167 846167 0 0.0
bss 110128 110128 0 0.0
rodata 94616 94616 0 0.0
text 565880 565880 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839759 839759 0 0.0
bss 110024 110024 0 0.0
rodata 92864 92864 0 0.0
text 561320 561320 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775643 775643 0 0.0
bss 108744 108744 0 0.0
rodata 72192 72192 0 0.0
text 520104 520104 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690666 690666 0 0.0
bss 109728 109728 0 0.0
rodata 66836 66836 0 0.0
text 440712 440712 0 0.0
p6 all-clusters-app default (read/write) 2297136 2297136 0 0.0
.bss 112680 112680 0 0.0
.data 2520 2520 0 0.0
.heap 918144 918144 0 0.0
.text 1255400 1255400 0 0.0
lock-app default (read/write) 2214464 2214464 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1172728 1172728 0 0.0
qpg lighting-app qpg6100+debug (read only) 493664 493664 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 488344 488344 0 0.0
lock-app qpg6100+debug (read only) 468596 468596 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 463276 463276 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667290 767402 100112 15.0
bss 69320 79216 9896 14.3
noinit 33216 37160 3944 11.9
text 462450 532250 69800 15.1

@andy31415 andy31415 merged commit d9c9053 into project-chip:master Nov 15, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants