Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate TCP::mPendingPackets to Pool interface #11834

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Migrate TCP::mPendingPackets to Pool interface #11834

merged 1 commit into from
Dec 1, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Nov 16, 2021

Problem

Pool interface should be used instead of a static array

Change overview

Migrate TCP::mPendingPackets to Pool interface

TcpBase class uses the TCP::mPendingPackets field w/o knowing the actual size of the pool. Add a PoolInterface class to cover this scenario.

Testing

Verified by unit-tests

@restyled-io restyled-io bot mentioned this pull request Nov 16, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 16, 2021 •
edited
Loading

PR #11834: Size comparison from 40320ad to 2e36f42

Increases above 0.2%:

platform target config section 40320ad 2e36f42 change % change
linux shell debug (read only) 794665 797785 3120 0.4
(read/write) 66088 66312 224 0.3
.data.rel.ro 37520 37728 208 0.6
.text 612674 615538 2864 0.5
Increases (14 builds for k32w, linux, qpg, telink)
platform target config section 40320ad 2e36f42 change % change
k32w lighting-app k32w061+se05x+release (read/write) 703576 703640 64 0.0
.text 618876 618940 64 0.0
lock-app k32w061+debug (read/write) 595020 595084 64 0.0
.text 519840 519904 64 0.0
shell k32w061+debug (read/write) 660252 660316 64 0.0
.text 574040 574104 64 0.0
linux all-clusters-app debug (read only) 1701841 1701873 32 0.0
.text 1433138 1433298 160 0.0
bridge-app debug+rpc .text 1089445 1089605 160 0.0
chip-tool debug (read only) 4892293 4892325 32 0.0
.text 4317765 4317957 192 0.0
lighting-app debug+rpc .text 1303298 1303458 160 0.0
ota-provider-app debug .text 1042386 1042546 160 0.0
ota-requestor-app debug .text 1112178 1112338 160 0.0
shell debug (read only) 794665 797785 3120 0.4
(read/write) 66088 66312 224 0.3
.bss 23816 23848 32 0.1
.data.rel.ro 37520 37728 208 0.6
.text 612674 615538 2864 0.5
tv-app debug (read only) 1838569 1838633 64 0.0
.text 1539154 1539346 192 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489784 48 0.0
.text 484416 484464 48 0.0
lock-app qpg6100+debug (read only) 464692 464740 48 0.0
.text 459372 459420 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763078 64 0.0
text 529210 529280 70 0.0
Decreases (14 builds for efr32, linux, p6)
platform target config section 40320ad 2e36f42 change % change
efr32 lighting-app BRD4161A (read only) 745208 744880 -328 -0.0
.text 745200 744872 -328 -0.0
BRD4161A+rpc (read only) 732724 732404 -320 -0.0
.text 732716 732396 -320 -0.0
lock-app BRD4161A (read only) 722296 721976 -320 -0.0
.text 722288 721968 -320 -0.0
window-app BRD4161A (read only) 723272 722952 -320 -0.0
.text 723264 722944 -320 -0.0
linux all-clusters-app debug .rodata 135253 135125 -128 -0.1
bridge-app debug+rpc .rodata 110668 110508 -160 -0.1
chip-tool debug .rodata 265554 265394 -160 -0.1
lighting-app debug+rpc .rodata 128273 128113 -160 -0.1
ota-provider-app debug .rodata 112999 112839 -160 -0.1
ota-requestor-app debug .rodata 123792 123632 -160 -0.1
shell debug .rodata 78479 78351 -128 -0.2
tv-app debug .rodata 155149 155021 -128 -0.1
p6 all-clusters-app default (read/write) 2292608 2292272 -336 -0.0
.text 1250872 1250536 -336 -0.0
lock-app default (read/write) 2210080 2209752 -328 -0.0
.text 1168344 1168016 -328 -0.0
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 40320ad 2e36f42 change % change
efr32 lighting-app BRD4161A (read only) 745208 744880 -328 -0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745200 744872 -328 -0.0
BRD4161A+rpc (read only) 732724 732404 -320 -0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732716 732396 -320 -0.0
lock-app BRD4161A (read only) 722296 721976 -320 -0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722288 721968 -320 -0.0
window-app BRD4161A (read only) 723272 722952 -320 -0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723264 722944 -320 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 703576 703640 64 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 618876 618940 64 0.0
lock-app k32w061+debug (read/write) 595020 595084 64 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 519840 519904 64 0.0
shell k32w061+debug (read/write) 660252 660316 64 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574040 574104 64 0.0
linux all-clusters-app debug (read only) 1701841 1701873 32 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135125 -128 -0.1
.text 1433138 1433298 160 0.0
bridge-app debug+rpc (read only) 1297013 1297013 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110508 -160 -0.1
.text 1089445 1089605 160 0.0
chip-tool debug (read only) 4892293 4892325 32 0.0
(read/write) 166280 166280 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 117936 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 265394 -160 -0.1
.text 4317765 4317957 192 0.0
lighting-app debug+rpc (read only) 1566073 1566073 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128113 -160 -0.1
.text 1303298 1303458 160 0.0
ota-provider-app debug (read only) 1252473 1252473 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112839 -160 -0.1
.text 1042386 1042546 160 0.0
ota-requestor-app debug (read only) 1335393 1335393 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 123632 -160 -0.1
.text 1112178 1112338 160 0.0
shell debug (read only) 794665 797785 3120 0.4
(read/write) 66088 66312 224 0.3
.bss 23816 23848 32 0.1
.data 242 242 0 0.0
.data.rel.ro 37520 37728 208 0.6
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78351 -128 -0.2
.text 612674 615538 2864 0.5
tv-app debug (read only) 1838569 1838633 64 0.0
(read/write) 405016 405016 0 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155021 -128 -0.1
.text 1539154 1539346 192 0.0
p6 all-clusters-app default (read/write) 2292608 2292272 -336 -0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1250872 1250536 -336 -0.0
lock-app default (read/write) 2210080 2209752 -328 -0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168344 1168016 -328 -0.0
qpg lighting-app qpg6100+debug (read only) 489736 489784 48 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484416 484464 48 0.0
lock-app qpg6100+debug (read only) 464692 464740 48 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459372 459420 48 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763078 64 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529210 529280 70 0.0

@kghost kghost force-pushed the pool-tcp-pending-packets branch from 2e36f42 to f69be4c Compare November 16, 2021 15:11
@github-actions
Copy link

github-actions bot commented Nov 16, 2021 •
edited
Loading

PR #11834: Size comparison from e755a26 to f69be4c

Increases (6 builds for k32w, qpg, telink)
platform target config section e755a26 f69be4c change % change
k32w lighting-app k32w061+se05x+release (read/write) 703576 703640 64 0.0
.text 618876 618940 64 0.0
lock-app k32w061+debug (read/write) 595020 595084 64 0.0
.text 519840 519904 64 0.0
shell k32w061+debug (read/write) 660252 660316 64 0.0
.text 574040 574104 64 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489784 48 0.0
.text 484416 484464 48 0.0
lock-app qpg6100+debug (read only) 464692 464740 48 0.0
.text 459372 459420 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763078 64 0.0
text 529210 529280 70 0.0
Decreases (2 builds for p6)
platform target config section e755a26 f69be4c change % change
p6 all-clusters-app default (read/write) 2292608 2292272 -336 -0.0
.text 1250872 1250536 -336 -0.0
lock-app default (read/write) 2210080 2209752 -328 -0.0
.text 1168344 1168016 -328 -0.0
Full report (9 builds for k32w, p6, qpg, telink)
platform target config section e755a26 f69be4c change % change
k32w lighting-app k32w061+se05x+release (read/write) 703576 703640 64 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 618876 618940 64 0.0
lock-app k32w061+debug (read/write) 595020 595084 64 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 519840 519904 64 0.0
shell k32w061+debug (read/write) 660252 660316 64 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574040 574104 64 0.0
p6 all-clusters-app default (read/write) 2292608 2292272 -336 -0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1250872 1250536 -336 -0.0
lock-app default (read/write) 2210080 2209752 -328 -0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168344 1168016 -328 -0.0
qpg lighting-app qpg6100+debug (read only) 489736 489784 48 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484416 484464 48 0.0
lock-app qpg6100+debug (read only) 464692 464740 48 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459372 459420 48 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763078 64 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529210 529280 70 0.0

@kghost kghost force-pushed the pool-tcp-pending-packets branch from f69be4c to ab92889 Compare November 16, 2021 16:27
@github-actions
Copy link

PR #11834: Size comparison from 09f9837 to ab92889

Increases above 0.2%:

platform target config section 09f9837 ab92889 change % change
linux shell debug (read only) 794665 797785 3120 0.4
(read/write) 66088 66312 224 0.3
.data.rel.ro 37520 37728 208 0.6
.text 612674 615538 2864 0.5
Increases (26 builds for k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 09f9837 ab92889 change % change
k32w lock-app k32w061+debug (read/write) 595020 595084 64 0.0
.text 519840 519904 64 0.0
shell k32w061+debug (read/write) 660252 660316 64 0.0
.text 574040 574104 64 0.0
lighting-app k32w061+se05x+release (read/write) 703576 703640 64 0.0
.text 618876 618940 64 0.0
linux all-clusters-app debug (read only) 1701841 1701873 32 0.0
.text 1433138 1433298 160 0.0
chip-tool debug (read only) 4892293 4892325 32 0.0
.text 4317765 4317957 192 0.0
ota-provider-app debug .text 1042386 1042546 160 0.0
ota-requestor-app debug .text 1112178 1112338 160 0.0
shell debug (read only) 794665 797785 3120 0.4
(read/write) 66088 66312 224 0.3
.bss 23816 23848 32 0.1
.data.rel.ro 37520 37728 208 0.6
.text 612674 615538 2864 0.5
tv-app debug (read only) 1838569 1838633 64 0.0
.text 1539154 1539346 192 0.0
bridge-app debug+rpc .text 1089445 1089605 160 0.0
lighting-app debug+rpc .text 1303298 1303458 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2283728 2283792 64 0.0
.text 1246328 1246392 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2245560 2245624 64 0.0
.text 1208160 1208224 64 0.0
shell CY8CPROTO_062_4343W+release .bss 156160 156184 24 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860231 48 0.0
text 579140 579192 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835627 48 0.0
text 559236 559292 56 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841771 48 0.0
text 563420 563472 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835363 48 0.0
text 558856 558912 56 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776303 64 0.0
text 520124 520180 56 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822599 48 0.0
text 553312 553364 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785270 48 0.0
text 508608 508660 52 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760950 48 0.0
text 488796 488848 52 0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691342 48 0.0
text 440732 440784 52 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489784 48 0.0
.text 484416 484464 48 0.0
lock-app qpg6100+debug (read only) 464692 464740 48 0.0
.text 459372 459420 48 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763078 64 0.0
text 529210 529280 70 0.0
Decreases (17 builds for efr32, esp32, linux, mbed, p6)
platform target config section 09f9837 ab92889 change % change
efr32 lighting-app BRD4161A (read only) 745208 744880 -328 -0.0
.text 745200 744872 -328 -0.0
lock-app BRD4161A (read only) 722296 721976 -320 -0.0
.text 722288 721968 -320 -0.0
window-app BRD4161A (read only) 723272 722952 -320 -0.0
.text 723264 722944 -320 -0.0
lighting-app BRD4161A+rpc (read only) 732724 732404 -320 -0.0
.text 732716 732396 -320 -0.0
esp32 all-clusters-app c3devkit (read only) 824912 824820 -92 -0.0
(read/write) 1219650 1219378 -272 -0.0
.flash.rodata 163800 163528 -272 -0.2
.flash.text 824912 824820 -92 -0.0
m5stack (read only) 895819 895755 -64 -0.0
(read/write) 418980 418716 -264 -0.1
.flash.rodata 191780 191516 -264 -0.1
.flash.text 890435 890371 -64 -0.0
linux all-clusters-app debug .rodata 135253 135125 -128 -0.1
chip-tool debug .rodata 265554 265394 -160 -0.1
ota-provider-app debug .rodata 112999 112839 -160 -0.1
ota-requestor-app debug .rodata 123792 123632 -160 -0.1
shell debug .rodata 78479 78351 -128 -0.2
tv-app debug .rodata 155149 155021 -128 -0.1
bridge-app debug+rpc .rodata 110668 110508 -160 -0.1
lighting-app debug+rpc .rodata 128273 128113 -160 -0.1
mbed shell CY8CPROTO_062_4343W+release (read/write) 2049520 2049344 -176 -0.0
.heap 875320 875296 -24 -0.0
.text 1012120 1011944 -176 -0.0
p6 all-clusters-app default (read/write) 2292608 2292272 -336 -0.0
.text 1250872 1250536 -336 -0.0
lock-app default (read/write) 2210080 2209752 -328 -0.0
.text 1168344 1168016 -328 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 09f9837 ab92889 change % change
efr32 lighting-app BRD4161A (read only) 745208 744880 -328 -0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745200 744872 -328 -0.0
lock-app BRD4161A (read only) 722296 721976 -320 -0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722288 721968 -320 -0.0
window-app BRD4161A (read only) 723272 722952 -320 -0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723264 722944 -320 -0.0
lighting-app BRD4161A+rpc (read only) 732724 732404 -320 -0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732716 732396 -320 -0.0
esp32 all-clusters-app c3devkit (read only) 824912 824820 -92 -0.0
(read/write) 1219650 1219378 -272 -0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163528 -272 -0.2
.flash.text 824912 824820 -92 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 895755 -64 -0.0
(read/write) 418980 418716 -264 -0.1
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191516 -264 -0.1
.flash.text 890435 890371 -64 -0.0
.iram0.text 122943 122943 0 0.0
k32w lock-app k32w061+debug (read/write) 595020 595084 64 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 519840 519904 64 0.0
shell k32w061+debug (read/write) 660252 660316 64 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574040 574104 64 0.0
lighting-app k32w061+se05x+release (read/write) 703576 703640 64 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 618876 618940 64 0.0
linux all-clusters-app debug (read only) 1701841 1701873 32 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135125 -128 -0.1
.text 1433138 1433298 160 0.0
chip-tool debug (read only) 4892293 4892325 32 0.0
(read/write) 166280 166280 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 117936 117936 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 265394 -160 -0.1
.text 4317765 4317957 192 0.0
ota-provider-app debug (read only) 1252473 1252473 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112839 -160 -0.1
.text 1042386 1042546 160 0.0
ota-requestor-app debug (read only) 1335393 1335393 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 123632 -160 -0.1
.text 1112178 1112338 160 0.0
shell debug (read only) 794665 797785 3120 0.4
(read/write) 66088 66312 224 0.3
.bss 23816 23848 32 0.1
.data 242 242 0 0.0
.data.rel.ro 37520 37728 208 0.6
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78351 -128 -0.2
.text 612674 615538 2864 0.5
tv-app debug (read only) 1838569 1838633 64 0.0
(read/write) 405016 405016 0 0.0
.bss 336968 336968 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155021 -128 -0.1
.text 1539154 1539346 192 0.0
bridge-app debug+rpc (read only) 1297013 1297013 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110508 -160 -0.1
.text 1089445 1089605 160 0.0
lighting-app debug+rpc (read only) 1566073 1566073 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128113 -160 -0.1
.text 1303298 1303458 160 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2283792 64 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246328 1246392 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2269720 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232320 1232320 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2245624 64 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208160 1208224 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049344 -176 -0.0
.bss 156160 156184 24 0.0
.data 4968 4968 0 0.0
.heap 875320 875296 -24 -0.0
.text 1012120 1011944 -176 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860231 48 0.0
bss 110384 110384 0 0.0
rodata 95032 95032 0 0.0
text 579140 579192 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835627 48 0.0
bss 109408 109408 0 0.0
rodata 91500 91500 0 0.0
text 559236 559292 56 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841771 48 0.0
bss 109548 109548 0 0.0
rodata 93212 93212 0 0.0
text 563420 563472 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835363 48 0.0
bss 109444 109444 0 0.0
rodata 91460 91460 0 0.0
text 558856 558912 56 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776303 64 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520180 56 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822599 48 0.0
bss 106740 106740 0 0.0
rodata 86216 86216 0 0.0
text 553312 553364 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785270 48 0.0
bss 111760 111760 0 0.0
rodata 90288 90288 0 0.0
text 508608 508660 52 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760950 48 0.0
bss 110820 110820 0 0.0
rodata 86808 86808 0 0.0
text 488796 488848 52 0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691342 48 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440784 52 0.0
p6 all-clusters-app default (read/write) 2292608 2292272 -336 -0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1250872 1250536 -336 -0.0
lock-app default (read/write) 2210080 2209752 -328 -0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168344 1168016 -328 -0.0
qpg lighting-app qpg6100+debug (read only) 489736 489784 48 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484416 484464 48 0.0
lock-app qpg6100+debug (read only) 464692 464740 48 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459372 459420 48 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 763078 64 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529210 529280 70 0.0

@stale
Copy link

stale bot commented Nov 24, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Nov 24, 2021
@woody-apple
Copy link
Contributor

@kghost ?

@stale stale bot removed the stale Stale issue or PR label Nov 30, 2021
@kghost kghost force-pushed the pool-tcp-pending-packets branch from ab92889 to 5cf790f Compare November 30, 2021 11:43
@pullapprove pullapprove bot requested a review from vijs November 30, 2021 11:43
@github-actions
Copy link

github-actions bot commented Nov 30, 2021 •
edited
Loading

PR #11834: Size comparison from a9ffa78 to 5cf790f

Increases above 0.2%:

platform target config section a9ffa78 5cf790f change % change
linux shell debug (read only) 821761 824881 3120 0.4
(read/write) 67288 67576 288 0.4
.bss 23976 24040 64 0.3
.data.rel.ro 38560 38768 208 0.5
.text 635858 638722 2864 0.5
Increases (27 builds for k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section a9ffa78 5cf790f change % change
k32w lighting-app k32w061+se05x+release (read/write) 724356 724404 48 0.0
.text 637956 638004 48 0.0
lock-app k32w061+debug (read/write) 613348 613412 64 0.0
.text 536536 536600 64 0.0
shell k32w061+debug (read/write) 679128 679176 48 0.0
.text 590768 590816 48 0.0
linux all-clusters-app debug (read only) 1779889 1779905 16 0.0
.text 1500914 1501090 176 0.0
bridge-app debug+rpc (read only) 1353061 1353093 32 0.0
.text 1139125 1139285 160 0.0
chip-tool debug (read only) 6129597 6129629 32 0.0
.text 5444421 5444613 192 0.0
lighting-app debug+rpc .text 1363010 1363186 176 0.0
ota-provider-app debug (read only) 1313409 1313457 48 0.0
.text 1098098 1098274 176 0.0
ota-requestor-app debug .text 1180290 1180450 160 0.0
shell debug (read only) 821761 824881 3120 0.4
(read/write) 67288 67576 288 0.4
.bss 23976 24040 64 0.3
.data.rel.ro 38560 38768 208 0.5
.text 635858 638722 2864 0.5
tv-app debug .text 1617842 1618018 176 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2296160 2296224 64 0.0
.text 1258760 1258824 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2281096 2281160 64 0.0
.text 1243696 1243760 64 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2254192 2254256 64 0.0
.text 1216792 1216856 64 0.0
shell CY8CPROTO_062_4343W+release .bss 156920 156952 32 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876639 876703 64 0.0
text 590620 590676 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 839087 839151 64 0.0
text 564788 564844 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801674 801722 48 0.0
text 520076 520128 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847467 847531 64 0.0
text 568872 568928 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772738 772786 48 0.0
text 498420 498472 52 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853479 853543 64 0.0
text 572940 572992 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846559 846607 48 0.0
text 568000 568052 52 0.0
shell nrf52840dk_nrf52840 (read/write) 779043 779091 48 0.0
text 521724 521780 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694058 694106 48 0.0
text 442332 442384 52 0.0
qpg lighting-app qpg6100+debug (read only) 494220 494276 56 0.0
.text 488900 488956 56 0.0
lock-app qpg6100+debug (read only) 466824 466880 56 0.0
.text 461504 461560 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 778454 778526 72 0.0
text 541270 541338 68 0.0
Decreases (17 builds for efr32, esp32, linux, mbed, p6)
platform target config section a9ffa78 5cf790f change % change
efr32 lighting-app BRD4161A (read only) 763016 762672 -344 -0.0
.text 763008 762664 -344 -0.0
BRD4161A+rpc (read only) 791512 791160 -352 -0.0
.text 791504 791152 -352 -0.0
lock-app BRD4161A (read only) 736896 736552 -344 -0.0
.text 736888 736544 -344 -0.0
window-app BRD4161A (read only) 739984 739640 -344 -0.0
.text 739976 739632 -344 -0.0
esp32 all-clusters-app c3devkit (read only) 836580 836488 -92 -0.0
(read/write) 1225258 1224962 -296 -0.0
.flash.rodata 166400 166104 -296 -0.2
.flash.text 836580 836488 -92 -0.0
m5stack (read only) 908587 908527 -60 -0.0
(read/write) 424484 424204 -280 -0.1
.flash.rodata 194244 193964 -280 -0.1
.flash.text 903203 903143 -60 -0.0
linux all-clusters-app debug .rodata 139957 139797 -160 -0.1
bridge-app debug+rpc .rodata 113820 113692 -128 -0.1
chip-tool debug .rodata 294664 294504 -160 -0.1
lighting-app debug+rpc (read only) 1633129 1633113 -16 -0.0
.rodata 132305 132113 -192 -0.1
ota-provider-app debug .rodata 114960 114832 -128 -0.1
ota-requestor-app debug .rodata 126464 126304 -160 -0.1
shell debug .rodata 79218 79090 -128 -0.2
tv-app debug (read only) 1927729 1927713 -16 -0.0
.rodata 161448 161256 -192 -0.1
mbed shell CY8CPROTO_062_4343W+release (read/write) 2051232 2051000 -232 -0.0
.heap 874656 874624 -32 -0.0
.text 1013832 1013600 -232 -0.0
p6 all-clusters-app default (read/write) 2317928 2317568 -360 -0.0
.text 1276192 1275832 -360 -0.0
lock-app default (read/write) 2229400 2229032 -368 -0.0
.text 1187664 1187296 -368 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a9ffa78 5cf790f change % change
efr32 lighting-app BRD4161A (read only) 763016 762672 -344 -0.0
(read/write) 120300 120300 0 0.0
.bss 118476 118476 0 0.0
.data 1820 1820 0 0.0
.text 763008 762664 -344 -0.0
BRD4161A+rpc (read only) 791512 791160 -352 -0.0
(read/write) 138596 138596 0 0.0
.bss 136676 136676 0 0.0
.data 1920 1920 0 0.0
.text 791504 791152 -352 -0.0
lock-app BRD4161A (read only) 736896 736552 -344 -0.0
(read/write) 118004 118004 0 0.0
.bss 116228 116228 0 0.0
.data 1776 1776 0 0.0
.text 736888 736544 -344 -0.0
window-app BRD4161A (read only) 739984 739640 -344 -0.0
(read/write) 118436 118436 0 0.0
.bss 116652 116652 0 0.0
.data 1784 1784 0 0.0
.text 739976 739632 -344 -0.0
esp32 all-clusters-app c3devkit (read only) 836580 836488 -92 -0.0
(read/write) 1225258 1224962 -296 -0.0
.dram0.bss 59608 59608 0 0.0
.dram0.data 13988 13988 0 0.0
.flash.rodata 166400 166104 -296 -0.2
.flash.text 836580 836488 -92 -0.0
.iram0.text 61390 61390 0 0.0
m5stack (read only) 908587 908527 -60 -0.0
(read/write) 424484 424204 -280 -0.1
.dram0.bss 65000 65000 0 0.0
.dram0.data 33960 33960 0 0.0
.flash.rodata 194244 193964 -280 -0.1
.flash.text 903203 903143 -60 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724356 724404 48 0.0
.bss 78756 78756 0 0.0
.data 1844 1844 0 0.0
.text 637956 638004 48 0.0
lock-app k32w061+debug (read/write) 613348 613412 64 0.0
.bss 69204 69204 0 0.0
.data 1808 1808 0 0.0
.text 536536 536600 64 0.0
shell k32w061+debug (read/write) 679128 679176 48 0.0
.bss 80780 80780 0 0.0
.data 1780 1780 0 0.0
.text 590768 590816 48 0.0
linux all-clusters-app debug (read only) 1779889 1779905 16 0.0
(read/write) 131960 131960 0 0.0
.bss 60688 60688 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 139957 139797 -160 -0.1
.text 1500914 1501090 176 0.0
bridge-app debug+rpc (read only) 1353061 1353093 32 0.0
(read/write) 78400 78400 0 0.0
.bss 42288 42288 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113820 113692 -128 -0.1
.text 1139125 1139285 160 0.0
chip-tool debug (read only) 6129597 6129629 32 0.0
(read/write) 199800 199800 0 0.0
.bss 40640 40640 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 152560 152560 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 294664 294504 -160 -0.1
.text 5444421 5444613 192 0.0
lighting-app debug+rpc (read only) 1633129 1633113 -16 -0.0
(read/write) 111520 111520 0 0.0
.bss 47984 47984 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 132305 132113 -192 -0.1
.text 1363010 1363186 176 0.0
ota-provider-app debug (read only) 1313409 1313457 48 0.0
(read/write) 76856 76856 0 0.0
.bss 44864 44864 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114960 114832 -128 -0.1
.text 1098098 1098274 176 0.0
ota-requestor-app debug (read only) 1409897 1409897 0 0.0
(read/write) 80688 80688 0 0.0
.bss 47296 47296 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126464 126304 -160 -0.1
.text 1180290 1180450 160 0.0
shell debug (read only) 821761 824881 3120 0.4
(read/write) 67288 67576 288 0.4
.bss 23976 24040 64 0.3
.data 224 224 0 0.0
.data.rel.ro 38560 38768 208 0.5
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79218 79090 -128 -0.2
.text 635858 638722 2864 0.5
tv-app debug (read only) 1927729 1927713 -16 -0.0
(read/write) 321152 321152 0 0.0
.bss 252376 252376 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61608 61608 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 161448 161256 -192 -0.1
.text 1617842 1618018 176 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296160 2296224 64 0.0
.bss 182348 182348 0 0.0
.data 5128 5128 0 0.0
.heap 848968 848968 0 0.0
.text 1258760 1258824 64 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281096 2281160 64 0.0
.bss 172956 172956 0 0.0
.data 5488 5488 0 0.0
.heap 858000 858000 0 0.0
.text 1243696 1243760 64 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254192 2254256 64 0.0
.bss 171772 171772 0 0.0
.data 5472 5472 0 0.0
.heap 859200 859200 0 0.0
.text 1216792 1216856 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051232 2051000 -232 -0.0
.bss 156920 156952 32 0.0
.data 4872 4872 0 0.0
.heap 874656 874624 -32 -0.0
.text 1013832 1013600 -232 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876639 876703 64 0.0
bss 113124 113124 0 0.0
rodata 97344 97344 0 0.0
text 590620 590676 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 839087 839151 64 0.0
bss 109476 109476 0 0.0
rodata 88608 88608 0 0.0
text 564788 564844 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801674 801722 48 0.0
bss 114500 114500 0 0.0
rodata 92604 92604 0 0.0
text 520076 520128 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847467 847531 64 0.0
bss 110164 110164 0 0.0
rodata 93084 93084 0 0.0
text 568872 568928 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772738 772786 48 0.0
bss 111572 111572 0 0.0
rodata 88372 88372 0 0.0
text 498420 498472 52 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853479 853543 64 0.0
bss 110300 110300 0 0.0
rodata 94816 94816 0 0.0
text 572940 572992 52 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846559 846607 48 0.0
bss 110176 110176 0 0.0
rodata 92952 92952 0 0.0
text 568000 568052 52 0.0
shell nrf52840dk_nrf52840 (read/write) 779043 779091 48 0.0
bss 109604 109604 0 0.0
rodata 73192 73192 0 0.0
text 521724 521780 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694058 694106 48 0.0
bss 110588 110588 0 0.0
rodata 67836 67836 0 0.0
text 442332 442384 52 0.0
p6 all-clusters-app default (read/write) 2317928 2317568 -360 -0.0
.bss 115256 115256 0 0.0
.data 2424 2424 0 0.0
.heap 915664 915664 0 0.0
.text 1276192 1275832 -360 -0.0
lock-app default (read/write) 2229400 2229032 -368 -0.0
.bss 101552 101552 0 0.0
.data 2288 2288 0 0.0
.heap 929504 929504 0 0.0
.text 1187664 1187296 -368 -0.0
qpg lighting-app qpg6100+debug (read only) 494220 494276 56 0.0
(read/write) 114144 114144 0 0.0
.bss 77928 77928 0 0.0
.data 920 920 0 0.0
.text 488900 488956 56 0.0
lock-app qpg6100+debug (read only) 466824 466880 56 0.0
(read/write) 114144 114144 0 0.0
.bss 76840 76840 0 0.0
.data 872 872 0 0.0
.text 461504 461560 56 0.0
persistent-storage-app qpg6100+debug (read only) 105612 105612 0 0.0
(read/write) 114138 114138 0 0.0
.bss 35218 35218 0 0.0
.data 276 276 0 0.0
.text 100292 100292 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778454 778526 72 0.0
bss 79700 79700 0 0.0
noinit 37160 37160 0 0.0
text 541270 541338 68 0.0

kpschoedel
kpschoedel approved these changes Nov 30, 2021
View reviewed changes
src/lib/support/PoolWrapper.h Show resolved Hide resolved
@kghost kghost force-pushed the pool-tcp-pending-packets branch from 5cf790f to 567ecb3 Compare December 1, 2021 06:14
@restyled-io restyled-io bot mentioned this pull request Dec 1, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #11834: Size comparison from 02bd2c7 to 567ecb3

Increases (6 builds for k32w, qpg, telink)
platform target config section 02bd2c7 567ecb3 change % change
k32w lighting-app k32w061+se05x+release (read/write) 724508 724556 48 0.0
.text 638096 638144 48 0.0
lock-app k32w061+debug (read/write) 613492 613556 64 0.0
.text 536676 536740 64 0.0
shell k32w061+debug (read/write) 679288 679336 48 0.0
.text 590916 590964 48 0.0
qpg lighting-app qpg6100+debug (read only) 496860 496916 56 0.0
.text 491540 491596 56 0.0
lock-app qpg6100+debug (read only) 469448 469504 56 0.0
.text 464128 464184 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 778614 778686 72 0.0
text 541394 541462 68 0.0
Full report (7 builds for k32w, qpg, telink)
platform target config section 02bd2c7 567ecb3 change % change
k32w lighting-app k32w061+se05x+release (read/write) 724508 724556 48 0.0
.bss 78772 78772 0 0.0
.data 1840 1840 0 0.0
.text 638096 638144 48 0.0
lock-app k32w061+debug (read/write) 613492 613556 64 0.0
.bss 69212 69212 0 0.0
.data 1804 1804 0 0.0
.text 536676 536740 64 0.0
shell k32w061+debug (read/write) 679288 679336 48 0.0
.bss 80796 80796 0 0.0
.data 1776 1776 0 0.0
.text 590916 590964 48 0.0
qpg lighting-app qpg6100+debug (read only) 496860 496916 56 0.0
(read/write) 114140 114140 0 0.0
.bss 79656 79656 0 0.0
.data 940 940 0 0.0
.text 491540 491596 56 0.0
lock-app qpg6100+debug (read only) 469448 469504 56 0.0
(read/write) 114140 114140 0 0.0
.bss 78568 78568 0 0.0
.data 892 892 0 0.0
.text 464128 464184 56 0.0
persistent-storage-app qpg6100+debug (read only) 108020 108020 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36688 36688 0 0.0
.data 292 292 0 0.0
.text 102700 102700 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778614 778686 72 0.0
bss 79716 79716 0 0.0
noinit 37160 37160 0 0.0
text 541394 541462 68 0.0

@kghost kghost force-pushed the pool-tcp-pending-packets branch from 567ecb3 to 44b967d Compare December 1, 2021 08:14
@github-actions
Copy link

github-actions bot commented Dec 1, 2021 •
edited
Loading

PR #11834: Size comparison from 02bd2c7 to 44b967d

Increases above 0.2%:

platform target config section 02bd2c7 44b967d change % change
linux shell debug (read only) 805881 808969 3088 0.4
(read/write) 59848 60104 256 0.4
.bss 16808 16872 64 0.4
.data.rel.ro 38320 38528 208 0.5
.text 620610 623474 2864 0.5
Increases (25 builds for k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 02bd2c7 44b967d change % change
k32w lighting-app k32w061+se05x+release (read/write) 724508 724556 48 0.0
.text 638096 638144 48 0.0
lock-app k32w061+debug (read/write) 613492 613556 64 0.0
.text 536676 536740 64 0.0
shell k32w061+debug (read/write) 679288 679336 48 0.0
.text 590916 590964 48 0.0
linux all-clusters-app debug (read only) 1780313 1780329 16 0.0
.text 1500738 1500914 176 0.0
bridge-app debug+rpc (read only) 1352373 1352389 16 0.0
.text 1138181 1138357 176 0.0
chip-tool debug .text 5549909 5550101 192 0.0
lighting-app debug+rpc (read only) 1632441 1632457 16 0.0
.text 1362098 1362274 176 0.0
ota-provider-app debug (read only) 1312817 1312833 16 0.0
.text 1097186 1097362 176 0.0
ota-requestor-app debug .text 1181906 1182066 160 0.0
shell debug (read only) 805881 808969 3088 0.4
(read/write) 59848 60104 256 0.4
.bss 16808 16872 64 0.4
.data.rel.ro 38320 38528 208 0.5
.text 620610 623474 2864 0.5
tv-app debug (read only) 1927025 1927089 64 0.0
.text 1616914 1617106 192 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2254344 2254408 64 0.0
.text 1216944 1217008 64 0.0
shell CY8CPROTO_062_4343W+release .bss 156592 156624 32 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876791 876839 48 0.0
text 590740 590792 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 839239 839287 48 0.0
text 564908 564960 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801810 801858 48 0.0
text 520196 520248 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847603 847667 64 0.0
text 568988 569040 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772874 772922 48 0.0
text 498536 498588 52 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853647 853711 64 0.0
text 573052 573108 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846711 846775 64 0.0
text 568112 568168 56 0.0
shell nrf52840dk_nrf52840 (read/write) 779163 779227 64 0.0
text 521832 521888 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694210 694274 64 0.0
text 442444 442496 52 0.0
qpg lighting-app qpg6100+debug (read only) 496860 496916 56 0.0
.text 491540 491596 56 0.0
lock-app qpg6100+debug (read only) 469448 469504 56 0.0
.text 464128 464184 56 0.0
telink lighting-app tlsr9518adk80d (read/write) 778614 778686 72 0.0
text 541394 541462 68 0.0
Decreases (17 builds for efr32, esp32, linux, mbed, p6)
platform target config section 02bd2c7 44b967d change % change
efr32 lighting-app BRD4161A (read only) 763096 762752 -344 -0.0
.text 763088 762744 -344 -0.0
BRD4161A+rpc (read only) 791608 791240 -368 -0.0
.text 791600 791232 -368 -0.0
lock-app BRD4161A (read only) 736976 736632 -344 -0.0
.text 736968 736624 -344 -0.0
window-app BRD4161A (read only) 740080 739720 -360 -0.0
.text 740072 739712 -360 -0.0
esp32 all-clusters-app c3devkit (read only) 837376 837284 -92 -0.0
(read/write) 1224330 1224034 -296 -0.0
.flash.rodata 166528 166232 -296 -0.2
.flash.text 837376 837284 -92 -0.0
m5stack (read only) 908883 908795 -88 -0.0
(read/write) 423572 423292 -280 -0.1
.flash.rodata 194364 194084 -280 -0.1
.flash.text 903499 903411 -88 -0.0
linux all-clusters-app debug .rodata 139957 139797 -160 -0.1
bridge-app debug+rpc .rodata 113980 113820 -160 -0.1
chip-tool debug .rodata 294984 294792 -192 -0.1
lighting-app debug+rpc .rodata 132433 132273 -160 -0.1
ota-provider-app debug .rodata 115184 115024 -160 -0.1
ota-requestor-app debug .rodata 127008 126848 -160 -0.1
shell debug .rodata 79954 79794 -160 -0.2
tv-app debug .rodata 161576 161448 -128 -0.1
mbed shell CY8CPROTO_062_4343W+release (read/write) 2046096 2045928 -168 -0.0
.heap 874992 874960 -32 -0.0
.text 1008696 1008528 -168 -0.0
p6 all-clusters-app default (read/write) 2318288 2317928 -360 -0.0
.text 1276552 1276192 -360 -0.0
lock-app default (read/write) 2229528 2229176 -352 -0.0
.text 1187792 1187440 -352 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 02bd2c7 44b967d change % change
efr32 lighting-app BRD4161A (read only) 763096 762752 -344 -0.0
(read/write) 119956 119956 0 0.0
.bss 118140 118140 0 0.0
.data 1812 1812 0 0.0
.text 763088 762744 -344 -0.0
BRD4161A+rpc (read only) 791608 791240 -368 -0.0
(read/write) 138252 138252 0 0.0
.bss 136340 136340 0 0.0
.data 1912 1912 0 0.0
.text 791600 791232 -368 -0.0
lock-app BRD4161A (read only) 736976 736632 -344 -0.0
(read/write) 117660 117660 0 0.0
.bss 115892 115892 0 0.0
.data 1768 1768 0 0.0
.text 736968 736624 -344 -0.0
window-app BRD4161A (read only) 740080 739720 -360 -0.0
(read/write) 118092 118092 0 0.0
.bss 116316 116316 0 0.0
.data 1776 1776 0 0.0
.text 740072 739712 -360 -0.0
esp32 all-clusters-app c3devkit (read only) 837376 837284 -92 -0.0
(read/write) 1224330 1224034 -296 -0.0
.dram0.bss 58528 58528 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166528 166232 -296 -0.2
.flash.text 837376 837284 -92 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 908883 908795 -88 -0.0
(read/write) 423572 423292 -280 -0.1
.dram0.bss 63928 63928 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194364 194084 -280 -0.1
.flash.text 903499 903411 -88 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724508 724556 48 0.0
.bss 78772 78772 0 0.0
.data 1840 1840 0 0.0
.text 638096 638144 48 0.0
lock-app k32w061+debug (read/write) 613492 613556 64 0.0
.bss 69212 69212 0 0.0
.data 1804 1804 0 0.0
.text 536676 536740 64 0.0
shell k32w061+debug (read/write) 679288 679336 48 0.0
.bss 80796 80796 0 0.0
.data 1776 1776 0 0.0
.text 590916 590964 48 0.0
linux all-clusters-app debug (read only) 1780313 1780329 16 0.0
(read/write) 125160 125160 0 0.0
.bss 53072 53072 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 65696 65696 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139957 139797 -160 -0.1
.text 1500738 1500914 176 0.0
bridge-app debug+rpc (read only) 1352373 1352389 16 0.0
(read/write) 71312 71312 0 0.0
.bss 35120 35120 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29488 29488 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 113980 113820 -160 -0.1
.text 1138181 1138357 176 0.0
chip-tool debug (read only) 6247237 6247237 0 0.0
(read/write) 197648 197648 0 0.0
.bss 33448 33448 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 157608 157608 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 294984 294792 -192 -0.1
.text 5549909 5550101 192 0.0
lighting-app debug+rpc (read only) 1632441 1632457 16 0.0
(read/write) 104400 104400 0 0.0
.bss 40784 40784 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 57072 57072 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 132433 132273 -160 -0.1
.text 1362098 1362274 176 0.0
ota-provider-app debug (read only) 1312817 1312833 16 0.0
(read/write) 69768 69768 0 0.0
.bss 37696 37696 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 115184 115024 -160 -0.1
.text 1097186 1097362 176 0.0
ota-requestor-app debug (read only) 1412801 1412801 0 0.0
(read/write) 73664 73664 0 0.0
.bss 39808 39808 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27736 27736 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 127008 126848 -160 -0.1
.text 1181906 1182066 160 0.0
shell debug (read only) 805881 808969 3088 0.4
(read/write) 59848 60104 256 0.4
.bss 16808 16872 64 0.4
.data 240 240 0 0.0
.data.rel.ro 38320 38528 208 0.5
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 79954 79794 -160 -0.2
.text 620610 623474 2864 0.5
tv-app debug (read only) 1927025 1927089 64 0.0
(read/write) 314032 314032 0 0.0
.bss 245176 245176 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61696 61696 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 161576 161448 -128 -0.1
.text 1616914 1617106 192 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2296552 2296552 0 0.0
.bss 181612 181612 0 0.0
.data 5168 5168 0 0.0
.heap 849664 849664 0 0.0
.text 1259152 1259152 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2281312 2281312 0 0.0
.bss 172636 172636 0 0.0
.data 5480 5480 0 0.0
.heap 858328 858328 0 0.0
.text 1243912 1243912 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2254344 2254408 64 0.0
.bss 171452 171452 0 0.0
.data 5464 5464 0 0.0
.heap 859528 859528 0 0.0
.text 1216944 1217008 64 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046096 2045928 -168 -0.0
.bss 156592 156624 32 0.0
.data 4864 4864 0 0.0
.heap 874992 874960 -32 -0.0
.text 1008696 1008528 -168 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 876791 876839 48 0.0
bss 113136 113136 0 0.0
rodata 97368 97368 0 0.0
text 590740 590792 52 0.0
nrf52840dk_nrf52840+rpc (read/write) 839239 839287 48 0.0
bss 109488 109488 0 0.0
rodata 88632 88632 0 0.0
text 564908 564960 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801810 801858 48 0.0
bss 114512 114512 0 0.0
rodata 92628 92628 0 0.0
text 520196 520248 52 0.0
lock-app nrf52840dk_nrf52840 (read/write) 847603 847667 64 0.0
bss 110176 110176 0 0.0
rodata 93108 93108 0 0.0
text 568988 569040 52 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 772874 772922 48 0.0
bss 111584 111584 0 0.0
rodata 88396 88396 0 0.0
text 498536 498588 52 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 853647 853711 64 0.0
bss 110312 110312 0 0.0
rodata 94840 94840 0 0.0
text 573052 573108 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 846711 846775 64 0.0
bss 110188 110188 0 0.0
rodata 92976 92976 0 0.0
text 568112 568168 56 0.0
shell nrf52840dk_nrf52840 (read/write) 779163 779227 64 0.0
bss 109616 109616 0 0.0
rodata 73216 73216 0 0.0
text 521832 521888 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694210 694274 64 0.0
bss 110600 110600 0 0.0
rodata 67860 67860 0 0.0
text 442444 442496 52 0.0
p6 all-clusters-app default (read/write) 2318288 2317928 -360 -0.0
.bss 109688 109688 0 0.0
.data 2456 2456 0 0.0
.heap 921200 921200 0 0.0
.text 1276552 1276192 -360 -0.0
lock-app default (read/write) 2229528 2229176 -352 -0.0
.bss 96408 96408 0 0.0
.data 2280 2280 0 0.0
.heap 934656 934656 0 0.0
.text 1187792 1187440 -352 -0.0
qpg lighting-app qpg6100+debug (read only) 496860 496916 56 0.0
(read/write) 114140 114140 0 0.0
.bss 79656 79656 0 0.0
.data 940 940 0 0.0
.text 491540 491596 56 0.0
lock-app qpg6100+debug (read only) 469448 469504 56 0.0
(read/write) 114140 114140 0 0.0
.bss 78568 78568 0 0.0
.data 892 892 0 0.0
.text 464128 464184 56 0.0
persistent-storage-app qpg6100+debug (read only) 108020 108020 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36688 36688 0 0.0
.data 292 292 0 0.0
.text 102700 102700 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 778614 778686 72 0.0
bss 79716 79716 0 0.0
noinit 37160 37160 0 0.0
text 541394 541462 68 0.0

@kghost kghost mentioned this pull request Dec 1, 2021
Closed
@kghost kghost merged commit a7b18b8 into project-chip:master Dec 1, 2021
@kghost kghost deleted the pool-tcp-pending-packets branch December 1, 2021 16:26
@kghost kghost restored the pool-tcp-pending-packets branch December 1, 2021 16:31
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Dec 14, 2021
@kpschoedel
Extend PoolInterface to heap pools
8ac905b 
#### Problem

PR project-chip#11834 added `PoolInterface`, a useful helper for passing object
pools, but it only supports `BitMapObjectPool`.

#### Change overview

Generalize `PoolInterface` to handle both static and heap pools.

#### Testing

Added a unit test.
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Dec 14, 2021
@kpschoedel
Extend PoolInterface to heap pools
f5a6f48 
#### Problem

PR project-chip#11834 added `PoolInterface`, a useful helper for passing object
pools, but it only supports `BitMapObjectPool`.

#### Change overview

Generalize `PoolInterface` to handle both static and heap pools.

#### Testing

Added a unit test.
@kpschoedel kpschoedel mentioned this pull request Dec 14, 2021
Merged
bzbarsky-apple pushed a commit that referenced this pull request Dec 15, 2021
@kpschoedel
Extend PoolInterface to heap pools (#12997)
4e3d0b1 
#### Problem

PR #11834 added `PoolInterface`, a useful helper for passing object
pools, but it only supports `BitMapObjectPool`.

#### Change overview

Generalize `PoolInterface` to handle both static and heap pools.

#### Testing

Added a unit test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpschoedel kpschoedel kpschoedel approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@andy31415 andy31415 Awaiting requested review from andy31415

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@msandstedt msandstedt Awaiting requested review from msandstedt

@woody-apple woody-apple Awaiting requested review from woody-apple

@vijs vijs Awaiting requested review from vijs

Assignees
No one assigned
Labels
lib review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kghost @woody-apple @andy31415 @msandstedt @kpschoedel @jmartinez-silabs