Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update encoding for read/subscribe/write request #11856

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Update encoding for read/subscribe/write request #11856

merged 1 commit into from
Nov 17, 2021

Conversation

yunhanw-google
Copy link
Contributor

Problem

update encoding for IM read/subscribe/write request and corresponding client/server

Change overview

See above

Testing

Update the existing unit tests to cover changes

@github-actions
Copy link

PR #11856: Size comparison from 09f9837 to 41c63a2

Increases above 0.2%:

platform target config section 09f9837 41c63a2 change % change
linux all-clusters-app debug .rodata 135253 135925 672 0.5
chip-tool debug .rodata 265554 266162 608 0.2
ota-provider-app debug .rodata 112999 113639 640 0.6
ota-requestor-app debug (read only) 1335393 1339089 3696 0.3
.rodata 123792 124400 608 0.5
.text 1112178 1115266 3088 0.3
shell debug .rodata 78479 78735 256 0.3
tv-app debug (read only) 1838569 1842297 3728 0.2
.rodata 155149 155789 640 0.4
.text 1539154 1542242 3088 0.2
bridge-app debug+rpc .rodata 110668 111308 640 0.6
lighting-app debug+rpc .rodata 128273 128881 608 0.5
Increases (21 builds for efr32, esp32, linux, mbed, nrfconnect, p6)
platform target config section 09f9837 41c63a2 change % change
efr32 lighting-app BRD4161A (read only) 745208 745336 128 0.0
.text 745200 745328 128 0.0
lock-app BRD4161A (read only) 722296 722424 128 0.0
.text 722288 722416 128 0.0
window-app BRD4161A (read only) 723272 723384 112 0.0
.text 723264 723376 112 0.0
lighting-app BRD4161A+rpc (read only) 732724 732852 128 0.0
.text 732716 732844 128 0.0
esp32 all-clusters-app m5stack (read only) 895819 895823 4 0.0
.flash.text 890435 890439 4 0.0
linux all-clusters-app debug (read only) 1701841 1703633 1792 0.1
.rodata 135253 135925 672 0.5
.text 1433138 1434258 1120 0.1
chip-tool debug (read only) 4892293 4896533 4240 0.1
.rodata 265554 266162 608 0.2
.text 4317765 4321397 3632 0.1
ota-provider-app debug (read only) 1252473 1254233 1760 0.1
.rodata 112999 113639 640 0.6
.text 1042386 1043506 1120 0.1
ota-requestor-app debug (read only) 1335393 1339089 3696 0.3
.rodata 123792 124400 608 0.5
.text 1112178 1115266 3088 0.3
shell debug (read only) 794665 795001 336 0.0
.rodata 78479 78735 256 0.3
.text 612674 612754 80 0.0
tv-app debug (read only) 1838569 1842297 3728 0.2
.rodata 155149 155789 640 0.4
.text 1539154 1542242 3088 0.2
bridge-app debug+rpc (read only) 1297013 1298773 1760 0.1
.rodata 110668 111308 640 0.6
.text 1089445 1090565 1120 0.1
lighting-app debug+rpc (read only) 1566073 1567801 1728 0.1
.rodata 128273 128881 608 0.5
.text 1303298 1304418 1120 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 852120 852248 128 0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858896 859024 128 0.0
lock-app CY8CPROTO_062_4343W+release .heap 860016 860144 128 0.0
nrfconnect lock-app nrf52840dk_nrf52840 text 559236 559240 4 0.0
pump-controller-app nrf52840dk_nrf52840 text 558856 558860 4 0.0
lock-app nrf5340dk_nrf5340_cpuapp text 488796 488800 4 0.0
p6 all-clusters-app default (read/write) 2292608 2292720 112 0.0
.heap 918728 918856 128 0.0
.text 1250872 1250984 112 0.0
lock-app default (read/write) 2210080 2210208 128 0.0
.heap 930224 930352 128 0.0
.text 1168344 1168472 128 0.0
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 09f9837 41c63a2 change % change
efr32 lighting-app BRD4161A (read/write) 115364 115236 -128 -0.1
.bss 113564 113436 -128 -0.1
lock-app BRD4161A (read/write) 113148 113020 -128 -0.1
.bss 111388 111260 -128 -0.1
window-app BRD4161A (read/write) 113468 113340 -128 -0.1
.bss 111708 111580 -128 -0.1
lighting-app BRD4161A+rpc (read/write) 131992 131864 -128 -0.1
.bss 130068 129940 -128 -0.1
esp32 all-clusters-app c3devkit (read only) 824912 824868 -44 -0.0
(read/write) 1219650 1219522 -128 -0.0
.dram0.bss 56512 56384 -128 -0.2
.flash.text 824912 824868 -44 -0.0
m5stack (read/write) 418980 418852 -128 -0.0
.dram0.bss 61864 61736 -128 -0.2
k32w lock-app k32w061+debug (read/write) 595020 594892 -128 -0.0
.bss 67500 67372 -128 -0.2
shell k32w061+debug (read/write) 660252 660124 -128 -0.0
.bss 78564 78436 -128 -0.2
lighting-app k32w061+se05x+release (read/write) 703576 703448 -128 -0.0
.bss 76988 76860 -128 -0.2
linux all-clusters-app debug (read/write) 126624 126144 -480 -0.4
.bss 57520 57040 -480 -0.8
chip-tool debug (read/write) 166280 165800 -480 -0.3
.bss 40584 40104 -480 -1.2
ota-provider-app debug (read/write) 75560 75080 -480 -0.6
.bss 44832 44352 -480 -1.1
ota-requestor-app debug (read/write) 79264 78784 -480 -0.6
.bss 47296 46816 -480 -1.0
tv-app debug (read/write) 405016 404536 -480 -0.1
.bss 336968 336488 -480 -0.1
bridge-app debug+rpc (read/write) 76816 76336 -480 -0.6
.bss 42224 41744 -480 -1.1
lighting-app debug+rpc (read/write) 110064 109584 -480 -0.4
.bss 47888 47408 -480 -1.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2283728 2283312 -416 -0.0
.bss 179108 178980 -128 -0.1
.text 1246328 1245912 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2269720 2269312 -408 -0.0
.bss 171972 171844 -128 -0.1
.text 1232320 1231912 -408 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2245560 2245152 -408 -0.0
.bss 170860 170732 -128 -0.1
.text 1208160 1207752 -408 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860055 -128 -0.0
bss 110384 110256 -128 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 835579 835451 -128 -0.0
bss 109408 109280 -128 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 841723 841595 -128 -0.0
bss 109548 109420 -128 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835187 -128 -0.0
bss 109444 109316 -128 -0.1
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822423 -128 -0.0
bss 106740 106612 -128 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785094 -128 -0.0
bss 111760 111632 -128 -0.1
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760774 -128 -0.0
bss 110820 110692 -128 -0.1
p6 all-clusters-app default .bss 112096 111968 -128 -0.1
lock-app default .bss 100720 100592 -128 -0.1
qpg lighting-app qpg6100+debug .bss 50056 49992 -64 -0.1
lock-app qpg6100+debug .bss 49000 48936 -64 -0.1
telink lighting-app tlsr9518adk80d (read/write) 763014 762854 -160 -0.0
bss 78896 78768 -128 -0.2
text 529210 529178 -32 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 09f9837 41c63a2 change % change
efr32 lighting-app BRD4161A (read only) 745208 745336 128 0.0
(read/write) 115364 115236 -128 -0.1
.bss 113564 113436 -128 -0.1
.data 1800 1800 0 0.0
.text 745200 745328 128 0.0
lock-app BRD4161A (read only) 722296 722424 128 0.0
(read/write) 113148 113020 -128 -0.1
.bss 111388 111260 -128 -0.1
.data 1756 1756 0 0.0
.text 722288 722416 128 0.0
window-app BRD4161A (read only) 723272 723384 112 0.0
(read/write) 113468 113340 -128 -0.1
.bss 111708 111580 -128 -0.1
.data 1760 1760 0 0.0
.text 723264 723376 112 0.0
lighting-app BRD4161A+rpc (read only) 732724 732852 128 0.0
(read/write) 131992 131864 -128 -0.1
.bss 130068 129940 -128 -0.1
.data 1924 1924 0 0.0
.text 732716 732844 128 0.0
esp32 all-clusters-app c3devkit (read only) 824912 824868 -44 -0.0
(read/write) 1219650 1219522 -128 -0.0
.dram0.bss 56512 56384 -128 -0.2
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163800 0 0.0
.flash.text 824912 824868 -44 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 895823 4 0.0
(read/write) 418980 418852 -128 -0.0
.dram0.bss 61864 61736 -128 -0.2
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191780 0 0.0
.flash.text 890435 890439 4 0.0
.iram0.text 122943 122943 0 0.0
k32w lock-app k32w061+debug (read/write) 595020 594892 -128 -0.0
.bss 67500 67372 -128 -0.2
.data 1880 1880 0 0.0
.text 519840 519840 0 0.0
shell k32w061+debug (read/write) 660252 660124 -128 -0.0
.bss 78564 78436 -128 -0.2
.data 1848 1848 0 0.0
.text 574040 574040 0 0.0
lighting-app k32w061+se05x+release (read/write) 703576 703448 -128 -0.0
.bss 76988 76860 -128 -0.2
.data 1912 1912 0 0.0
.text 618876 618876 0 0.0
linux all-clusters-app debug (read only) 1701841 1703633 1792 0.1
(read/write) 126624 126144 -480 -0.4
.bss 57520 57040 -480 -0.8
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135925 672 0.5
.text 1433138 1434258 1120 0.1
chip-tool debug (read only) 4892293 4896533 4240 0.1
(read/write) 166280 165800 -480 -0.3
.bss 40584 40104 -480 -1.2
.data 2272 2272 0 0.0
.data.rel.ro 117936 117936 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265554 266162 608 0.2
.text 4317765 4321397 3632 0.1
ota-provider-app debug (read only) 1252473 1254233 1760 0.1
(read/write) 75560 75080 -480 -0.6
.bss 44832 44352 -480 -1.1
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 113639 640 0.6
.text 1042386 1043506 1120 0.1
ota-requestor-app debug (read only) 1335393 1339089 3696 0.3
(read/write) 79264 78784 -480 -0.6
.bss 47296 46816 -480 -1.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123792 124400 608 0.5
.text 1112178 1115266 3088 0.3
shell debug (read only) 794665 795001 336 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78735 256 0.3
.text 612674 612754 80 0.0
tv-app debug (read only) 1838569 1842297 3728 0.2
(read/write) 405016 404536 -480 -0.1
.bss 336968 336488 -480 -0.1
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155149 155789 640 0.4
.text 1539154 1542242 3088 0.2
bridge-app debug+rpc (read only) 1297013 1298773 1760 0.1
(read/write) 76816 76336 -480 -0.6
.bss 42224 41744 -480 -1.1
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 111308 640 0.6
.text 1089445 1090565 1120 0.1
lighting-app debug+rpc (read only) 1566073 1567801 1728 0.1
(read/write) 110064 109584 -480 -0.4
.bss 47888 47408 -480 -1.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128881 608 0.5
.text 1303298 1304418 1120 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2283312 -416 -0.0
.bss 179108 178980 -128 -0.1
.data 5216 5216 0 0.0
.heap 852120 852248 128 0.0
.text 1246328 1245912 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2269312 -408 -0.0
.bss 171972 171844 -128 -0.1
.data 5576 5576 0 0.0
.heap 858896 859024 128 0.0
.text 1232320 1231912 -408 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2245152 -408 -0.0
.bss 170860 170732 -128 -0.1
.data 5568 5568 0 0.0
.heap 860016 860144 128 0.0
.text 1208160 1207752 -408 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 860055 -128 -0.0
bss 110384 110256 -128 -0.1
rodata 95032 95032 0 0.0
text 579140 579140 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835579 835451 -128 -0.0
bss 109408 109280 -128 -0.1
rodata 91500 91500 0 0.0
text 559236 559240 4 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 841595 -128 -0.0
bss 109548 109420 -128 -0.1
rodata 93212 93212 0 0.0
text 563420 563420 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835187 -128 -0.0
bss 109444 109316 -128 -0.1
rodata 91460 91460 0 0.0
text 558856 558860 4 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read/write) 822551 822423 -128 -0.0
bss 106740 106612 -128 -0.1
rodata 86216 86216 0 0.0
text 553312 553312 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785222 785094 -128 -0.0
bss 111760 111632 -128 -0.1
rodata 90288 90288 0 0.0
text 508608 508608 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp (read/write) 760902 760774 -128 -0.0
bss 110820 110692 -128 -0.1
rodata 86808 86808 0 0.0
text 488796 488800 4 0.0
shell nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292608 2292720 112 0.0
.bss 112096 111968 -128 -0.1
.data 2520 2520 0 0.0
.heap 918728 918856 128 0.0
.text 1250872 1250984 112 0.0
lock-app default (read/write) 2210080 2210208 128 0.0
.bss 100720 100592 -128 -0.1
.data 2400 2400 0 0.0
.heap 930224 930352 128 0.0
.text 1168344 1168472 128 0.0
qpg lighting-app qpg6100+debug (read only) 489736 489736 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 49992 -64 -0.1
.data 1008 1008 0 0.0
.text 484416 484416 0 0.0
lock-app qpg6100+debug (read only) 464692 464692 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 48936 -64 -0.1
.data 964 964 0 0.0
.text 459372 459372 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 762854 -160 -0.0
bss 78896 78768 -128 -0.2
noinit 37160 37160 0 0.0
text 529210 529178 -32 -0.0

@yufengwangca yufengwangca changed the title update encoding for read/subscribe/write request Update encoding for read/subscribe/write request Nov 16, 2021
@bzbarsky-apple
Copy link
Contributor

What are the actual changes being made here? And is there a reason this is one big mega-PR instead of separate PRs for read, subscribe, write? Please keep in mind that review time goes about as O(N^2) of PR size unless the PR is just a search-and-replace...

@yunhanw-google
Copy link
Contributor Author

What are the actual changes being made here? And is there a reason this is one big mega-PR instead of separate PRs for read, subscribe, write? Please keep in mind that review time goes about as O(N^2) of PR size unless the PR is just a search-and-replace...

Agree, read and subscribe have several similar encoding stuff, so i made the change in the same PR...

@andy31415
Copy link
Contributor

@yunhanw-google - merge conflicts

@restyled-io restyled-io bot mentioned this pull request Nov 17, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11856: Size comparison from e568d70 to ee6bf0f

Increases above 0.2%:

platform target config section e568d70 ee6bf0f change % change
linux all-clusters-app debug .rodata 135605 136277 672 0.5
bridge-app debug+rpc .rodata 110980 111620 640 0.6
chip-tool debug .rodata 267690 268330 640 0.2
lighting-app debug+rpc .rodata 128625 129201 576 0.4
ota-provider-app debug .rodata 113151 113791 640 0.6
ota-requestor-app debug (read only) 1344369 1348113 3744 0.3
.rodata 124168 124808 640 0.5
.text 1120226 1123330 3104 0.3
shell debug .rodata 78383 78639 256 0.3
tv-app debug .rodata 157029 157637 608 0.4
Increases (18 builds for efr32, k32w, linux, p6, qpg)
platform target config section e568d70 ee6bf0f change % change
efr32 lighting-app BRD4161A (read only) 748400 748512 112 0.0
.text 748392 748504 112 0.0
BRD4161A+rpc (read only) 735932 736044 112 0.0
.text 735924 736036 112 0.0
lock-app BRD4161A (read only) 725472 725584 112 0.0
.text 725464 725576 112 0.0
window-app BRD4161A (read only) 726432 726560 128 0.0
.text 726424 726552 128 0.0
k32w lighting-app k32w061+se05x+release .text 621104 621120 16 0.0
lock-app k32w061+debug .text 522064 522080 16 0.0
linux all-clusters-app debug (read only) 1716873 1718665 1792 0.1
.rodata 135605 136277 672 0.5
.text 1447314 1448434 1120 0.1
bridge-app debug+rpc (read only) 1312005 1313765 1760 0.1
.rodata 110980 111620 640 0.6
.text 1103621 1104741 1120 0.1
chip-tool debug (read only) 4970909 4975181 4272 0.1
.rodata 267690 268330 640 0.2
.text 4392709 4396341 3632 0.1
lighting-app debug+rpc (read only) 1581137 1582849 1712 0.1
.rodata 128625 129201 576 0.4
.text 1317506 1318642 1136 0.1
ota-provider-app debug (read only) 1260681 1262441 1760 0.1
.rodata 113151 113791 640 0.6
.text 1049938 1051058 1120 0.1
ota-requestor-app debug (read only) 1344369 1348113 3744 0.3
.rodata 124168 124808 640 0.5
.text 1120226 1123330 3104 0.3
shell debug (read only) 797793 798129 336 0.0
.rodata 78383 78639 256 0.3
.text 615394 615474 80 0.0
tv-app debug (read only) 1861825 1865521 3696 0.2
.rodata 157029 157637 608 0.4
.text 1559666 1562754 3088 0.2
p6 all-clusters-app default (read/write) 2296424 2296552 128 0.0
.heap 918520 918616 96 0.0
.text 1254688 1254816 128 0.0
lock-app default (read/write) 2213896 2214024 128 0.0
.heap 930016 930112 96 0.0
.text 1172160 1172288 128 0.0
qpg lighting-app qpg6100+debug (read only) 492792 492800 8 0.0
.text 487472 487480 8 0.0
lock-app qpg6100+debug (read only) 467772 467780 8 0.0
.text 462452 462460 8 0.0
Decreases (19 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section e568d70 ee6bf0f change % change
efr32 lighting-app BRD4161A (read/write) 115572 115476 -96 -0.1
.bss 113772 113676 -96 -0.1
BRD4161A+rpc (read/write) 132200 132104 -96 -0.1
.bss 130276 130180 -96 -0.1
lock-app BRD4161A (read/write) 113356 113260 -96 -0.1
.bss 111596 111500 -96 -0.1
window-app BRD4161A (read/write) 113676 113580 -96 -0.1
.bss 111916 111820 -96 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 706012 705932 -80 -0.0
.bss 77196 77100 -96 -0.1
lock-app k32w061+debug (read/write) 597452 597372 -80 -0.0
.bss 67708 67612 -96 -0.1
shell k32w061+debug (read/write) 662796 662700 -96 -0.0
.bss 78836 78740 -96 -0.1
linux all-clusters-app debug (read/write) 127200 126752 -448 -0.4
.bss 57776 57328 -448 -0.8
bridge-app debug+rpc (read/write) 77392 76944 -448 -0.6
.bss 42480 42032 -448 -1.1
chip-tool debug (read/write) 167304 166856 -448 -0.3
.bss 40840 40392 -448 -1.1
lighting-app debug+rpc (read/write) 110608 110160 -448 -0.4
.bss 48144 47696 -448 -0.9
ota-provider-app debug (read/write) 76040 75592 -448 -0.6
.bss 45088 44640 -448 -1.0
ota-requestor-app debug (read/write) 79776 79328 -448 -0.6
.bss 47552 47104 -448 -0.9
tv-app debug (read/write) 319352 318904 -448 -0.1
.bss 250760 250312 -448 -0.2
p6 all-clusters-app default .bss 112304 112208 -96 -0.1
lock-app default .bss 100928 100832 -96 -0.1
qpg lighting-app qpg6100+debug .bss 50216 50176 -40 -0.1
lock-app qpg6100+debug .bss 49160 49120 -40 -0.1
telink lighting-app tlsr9518adk80d (read/write) 767062 766926 -136 -0.0
bss 79104 79008 -96 -0.1
text 532258 532224 -34 -0.0
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section e568d70 ee6bf0f change % change
efr32 lighting-app BRD4161A (read only) 748400 748512 112 0.0
(read/write) 115572 115476 -96 -0.1
.bss 113772 113676 -96 -0.1
.data 1800 1800 0 0.0
.text 748392 748504 112 0.0
BRD4161A+rpc (read only) 735932 736044 112 0.0
(read/write) 132200 132104 -96 -0.1
.bss 130276 130180 -96 -0.1
.data 1924 1924 0 0.0
.text 735924 736036 112 0.0
lock-app BRD4161A (read only) 725472 725584 112 0.0
(read/write) 113356 113260 -96 -0.1
.bss 111596 111500 -96 -0.1
.data 1756 1756 0 0.0
.text 725464 725576 112 0.0
window-app BRD4161A (read only) 726432 726560 128 0.0
(read/write) 113676 113580 -96 -0.1
.bss 111916 111820 -96 -0.1
.data 1760 1760 0 0.0
.text 726424 726552 128 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706012 705932 -80 -0.0
.bss 77196 77100 -96 -0.1
.data 1912 1912 0 0.0
.text 621104 621120 16 0.0
lock-app k32w061+debug (read/write) 597452 597372 -80 -0.0
.bss 67708 67612 -96 -0.1
.data 1880 1880 0 0.0
.text 522064 522080 16 0.0
shell k32w061+debug (read/write) 662796 662700 -96 -0.0
.bss 78836 78740 -96 -0.1
.data 1848 1848 0 0.0
.text 576312 576312 0 0.0
linux all-clusters-app debug (read only) 1716873 1718665 1792 0.1
(read/write) 127200 126752 -448 -0.4
.bss 57776 57328 -448 -0.8
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135605 136277 672 0.5
.text 1447314 1448434 1120 0.1
bridge-app debug+rpc (read only) 1312005 1313765 1760 0.1
(read/write) 77392 76944 -448 -0.6
.bss 42480 42032 -448 -1.1
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110980 111620 640 0.6
.text 1103621 1104741 1120 0.1
chip-tool debug (read only) 4970909 4975181 4272 0.1
(read/write) 167304 166856 -448 -0.3
.bss 40840 40392 -448 -1.1
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267690 268330 640 0.2
.text 4392709 4396341 3632 0.1
lighting-app debug+rpc (read only) 1581137 1582849 1712 0.1
(read/write) 110608 110160 -448 -0.4
.bss 48144 47696 -448 -0.9
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128625 129201 576 0.4
.text 1317506 1318642 1136 0.1
ota-provider-app debug (read only) 1260681 1262441 1760 0.1
(read/write) 76040 75592 -448 -0.6
.bss 45088 44640 -448 -1.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113151 113791 640 0.6
.text 1049938 1051058 1120 0.1
ota-requestor-app debug (read only) 1344369 1348113 3744 0.3
(read/write) 79776 79328 -448 -0.6
.bss 47552 47104 -448 -0.9
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124168 124808 640 0.5
.text 1120226 1123330 3104 0.3
shell debug (read only) 797793 798129 336 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78383 78639 256 0.3
.text 615394 615474 80 0.0
tv-app debug (read only) 1861825 1865521 3696 0.2
(read/write) 319352 318904 -448 -0.1
.bss 250760 250312 -448 -0.2
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157029 157637 608 0.4
.text 1559666 1562754 3088 0.2
p6 all-clusters-app default (read/write) 2296424 2296552 128 0.0
.bss 112304 112208 -96 -0.1
.data 2520 2520 0 0.0
.heap 918520 918616 96 0.0
.text 1254688 1254816 128 0.0
lock-app default (read/write) 2213896 2214024 128 0.0
.bss 100928 100832 -96 -0.1
.data 2400 2400 0 0.0
.heap 930016 930112 96 0.0
.text 1172160 1172288 128 0.0
qpg lighting-app qpg6100+debug (read only) 492792 492800 8 0.0
(read/write) 114144 114144 0 0.0
.bss 50216 50176 -40 -0.1
.data 1008 1008 0 0.0
.text 487472 487480 8 0.0
lock-app qpg6100+debug (read only) 467772 467780 8 0.0
(read/write) 114140 114140 0 0.0
.bss 49160 49120 -40 -0.1
.data 964 964 0 0.0
.text 462452 462460 8 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767062 766926 -136 -0.0
bss 79104 79008 -96 -0.1
noinit 37160 37160 0 0.0
text 532258 532224 -34 -0.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11856: Size comparison from e568d70 to 2e370f1

Increases above 0.2%:

platform target config section e568d70 2e370f1 change % change
linux all-clusters-app debug .rodata 135605 136277 672 0.5
bridge-app debug+rpc .rodata 110980 111620 640 0.6
lighting-app debug+rpc .rodata 128625 129201 576 0.4
ota-provider-app debug .rodata 113151 113791 640 0.6
ota-requestor-app debug (read only) 1344369 1348113 3744 0.3
.rodata 124168 124808 640 0.5
.text 1120226 1123330 3104 0.3
shell debug .rodata 78383 78639 256 0.3
tv-app debug .rodata 157029 157637 608 0.4
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
platform target config section e568d70 2e370f1 change % change
efr32 lighting-app BRD4161A (read only) 748400 748512 112 0.0
.text 748392 748504 112 0.0
BRD4161A+rpc (read only) 735932 736044 112 0.0
.text 735924 736036 112 0.0
lock-app BRD4161A (read only) 725472 725584 112 0.0
.text 725464 725576 112 0.0
window-app BRD4161A (read only) 726432 726560 128 0.0
.text 726424 726552 128 0.0
esp32 all-clusters-app m5stack (read only) 898475 898495 20 0.0
.flash.text 893091 893111 20 0.0
k32w lighting-app k32w061+se05x+release .text 621104 621120 16 0.0
lock-app k32w061+debug .text 522064 522080 16 0.0
linux all-clusters-app debug (read only) 1716873 1718665 1792 0.1
.rodata 135605 136277 672 0.5
.text 1447314 1448434 1120 0.1
bridge-app debug+rpc (read only) 1312005 1313765 1760 0.1
.rodata 110980 111620 640 0.6
.text 1103621 1104741 1120 0.1
chip-tool debug (read only) 4970909 4975181 4272 0.1
.rodata 267690 268330 640 0.2
.text 4392709 4396341 3632 0.1
lighting-app debug+rpc (read only) 1581137 1582849 1712 0.1
.rodata 128625 129201 576 0.4
.text 1317506 1318642 1136 0.1
ota-provider-app debug (read only) 1260681 1262441 1760 0.1
.rodata 113151 113791 640 0.6
.text 1049938 1051058 1120 0.1
ota-requestor-app debug (read only) 1344369 1348113 3744 0.3
.rodata 124168 124808 640 0.5
.text 1120226 1123330 3104 0.3
shell debug (read only) 797793 798129 336 0.0
.rodata 78383 78639 256 0.3
.text 615394 615474 80 0.0
tv-app debug (read only) 1861825 1865521 3696 0.2
.rodata 157029 157637 608 0.4
.text 1559666 1562754 3088 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 851912 852008 96 0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858688 858784 96 0.0
lock-app CY8CPROTO_062_4343W+release .heap 859808 859904 96 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 581692 581696 4 0.0
nrf52840dk_nrf52840+rpc text 555860 555864 4 0.0
nrf5340dk_nrf5340_cpuapp text 511164 511168 4 0.0
pump-app nrf52840dk_nrf52840 text 565968 565972 4 0.0
p6 all-clusters-app default (read/write) 2296424 2296552 128 0.0
.heap 918520 918616 96 0.0
.text 1254688 1254816 128 0.0
lock-app default (read/write) 2213896 2214024 128 0.0
.heap 930016 930112 96 0.0
.text 1172160 1172288 128 0.0
qpg lighting-app qpg6100+debug (read only) 492792 492800 8 0.0
.text 487472 487480 8 0.0
lock-app qpg6100+debug (read only) 467772 467780 8 0.0
.text 462452 462460 8 0.0
Decreases (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e568d70 2e370f1 change % change
efr32 lighting-app BRD4161A (read/write) 115572 115476 -96 -0.1
.bss 113772 113676 -96 -0.1
BRD4161A+rpc (read/write) 132200 132104 -96 -0.1
.bss 130276 130180 -96 -0.1
lock-app BRD4161A (read/write) 113356 113260 -96 -0.1
.bss 111596 111500 -96 -0.1
window-app BRD4161A (read/write) 113676 113580 -96 -0.1
.bss 111916 111820 -96 -0.1
esp32 all-clusters-app c3devkit (read only) 827574 827530 -44 -0.0
(read/write) 1220162 1220066 -96 -0.0
.dram0.bss 56720 56624 -96 -0.2
.flash.text 827574 827530 -44 -0.0
m5stack (read/write) 419484 419388 -96 -0.0
.dram0.bss 62072 61976 -96 -0.2
k32w lighting-app k32w061+se05x+release (read/write) 706012 705932 -80 -0.0
.bss 77196 77100 -96 -0.1
lock-app k32w061+debug (read/write) 597452 597372 -80 -0.0
.bss 67708 67612 -96 -0.1
shell k32w061+debug (read/write) 662796 662700 -96 -0.0
.bss 78836 78740 -96 -0.1
linux all-clusters-app debug (read/write) 127200 126752 -448 -0.4
.bss 57776 57328 -448 -0.8
bridge-app debug+rpc (read/write) 77392 76944 -448 -0.6
.bss 42480 42032 -448 -1.1
chip-tool debug (read/write) 167304 166856 -448 -0.3
.bss 40840 40392 -448 -1.1
lighting-app debug+rpc (read/write) 110608 110160 -448 -0.4
.bss 48144 47696 -448 -0.9
ota-provider-app debug (read/write) 76040 75592 -448 -0.6
.bss 45088 44640 -448 -1.0
ota-requestor-app debug (read/write) 79776 79328 -448 -0.6
.bss 47552 47104 -448 -0.9
tv-app debug (read/write) 319352 318904 -448 -0.1
.bss 250760 250312 -448 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2287032 2286616 -416 -0.0
.bss 179316 179220 -96 -0.1
.text 1249632 1249216 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2272960 2272552 -408 -0.0
.bss 172180 172084 -96 -0.1
.text 1235560 1235152 -408 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2248864 2248456 -408 -0.0
.bss 171068 170972 -96 -0.1
.text 1211464 1211056 -408 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863671 863591 -80 -0.0
bss 110592 110496 -96 -0.1
nrf52840dk_nrf52840+rpc (read/write) 826071 825991 -80 -0.0
bss 106948 106852 -96 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 788730 788634 -96 -0.0
bss 111968 111872 -96 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 839103 839007 -96 -0.0
bss 109616 109520 -96 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 764406 764310 -96 -0.0
bss 111028 110932 -96 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 845211 845115 -96 -0.0
bss 109756 109660 -96 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 838803 838707 -96 -0.0
bss 109652 109556 -96 -0.1
p6 all-clusters-app default .bss 112304 112208 -96 -0.1
lock-app default .bss 100928 100832 -96 -0.1
qpg lighting-app qpg6100+debug .bss 50216 50176 -40 -0.1
lock-app qpg6100+debug .bss 49160 49120 -40 -0.1
telink lighting-app tlsr9518adk80d (read/write) 767062 766926 -136 -0.0
bss 79104 79008 -96 -0.1
text 532258 532224 -34 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section e568d70 2e370f1 change % change
efr32 lighting-app BRD4161A (read only) 748400 748512 112 0.0
(read/write) 115572 115476 -96 -0.1
.bss 113772 113676 -96 -0.1
.data 1800 1800 0 0.0
.text 748392 748504 112 0.0
BRD4161A+rpc (read only) 735932 736044 112 0.0
(read/write) 132200 132104 -96 -0.1
.bss 130276 130180 -96 -0.1
.data 1924 1924 0 0.0
.text 735924 736036 112 0.0
lock-app BRD4161A (read only) 725472 725584 112 0.0
(read/write) 113356 113260 -96 -0.1
.bss 111596 111500 -96 -0.1
.data 1756 1756 0 0.0
.text 725464 725576 112 0.0
window-app BRD4161A (read only) 726432 726560 128 0.0
(read/write) 113676 113580 -96 -0.1
.bss 111916 111820 -96 -0.1
.data 1760 1760 0 0.0
.text 726424 726552 128 0.0
esp32 all-clusters-app c3devkit (read only) 827574 827530 -44 -0.0
(read/write) 1220162 1220066 -96 -0.0
.dram0.bss 56720 56624 -96 -0.2
.dram0.data 14084 14084 0 0.0
.flash.rodata 164104 164104 0 0.0
.flash.text 827574 827530 -44 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 898475 898495 20 0.0
(read/write) 419484 419388 -96 -0.0
.dram0.bss 62072 61976 -96 -0.2
.dram0.data 34056 34056 0 0.0
.flash.rodata 192076 192076 0 0.0
.flash.text 893091 893111 20 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706012 705932 -80 -0.0
.bss 77196 77100 -96 -0.1
.data 1912 1912 0 0.0
.text 621104 621120 16 0.0
lock-app k32w061+debug (read/write) 597452 597372 -80 -0.0
.bss 67708 67612 -96 -0.1
.data 1880 1880 0 0.0
.text 522064 522080 16 0.0
shell k32w061+debug (read/write) 662796 662700 -96 -0.0
.bss 78836 78740 -96 -0.1
.data 1848 1848 0 0.0
.text 576312 576312 0 0.0
linux all-clusters-app debug (read only) 1716873 1718665 1792 0.1
(read/write) 127200 126752 -448 -0.4
.bss 57776 57328 -448 -0.8
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135605 136277 672 0.5
.text 1447314 1448434 1120 0.1
bridge-app debug+rpc (read only) 1312005 1313765 1760 0.1
(read/write) 77392 76944 -448 -0.6
.bss 42480 42032 -448 -1.1
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110980 111620 640 0.6
.text 1103621 1104741 1120 0.1
chip-tool debug (read only) 4970909 4975181 4272 0.1
(read/write) 167304 166856 -448 -0.3
.bss 40840 40392 -448 -1.1
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267690 268330 640 0.2
.text 4392709 4396341 3632 0.1
lighting-app debug+rpc (read only) 1581137 1582849 1712 0.1
(read/write) 110608 110160 -448 -0.4
.bss 48144 47696 -448 -0.9
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128625 129201 576 0.4
.text 1317506 1318642 1136 0.1
ota-provider-app debug (read only) 1260681 1262441 1760 0.1
(read/write) 76040 75592 -448 -0.6
.bss 45088 44640 -448 -1.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113151 113791 640 0.6
.text 1049938 1051058 1120 0.1
ota-requestor-app debug (read only) 1344369 1348113 3744 0.3
(read/write) 79776 79328 -448 -0.6
.bss 47552 47104 -448 -0.9
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124168 124808 640 0.5
.text 1120226 1123330 3104 0.3
shell debug (read only) 797793 798129 336 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78383 78639 256 0.3
.text 615394 615474 80 0.0
tv-app debug (read only) 1861825 1865521 3696 0.2
(read/write) 319352 318904 -448 -0.1
.bss 250760 250312 -448 -0.2
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157029 157637 608 0.4
.text 1559666 1562754 3088 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287032 2286616 -416 -0.0
.bss 179316 179220 -96 -0.1
.data 5216 5216 0 0.0
.heap 851912 852008 96 0.0
.text 1249632 1249216 -416 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2272960 2272552 -408 -0.0
.bss 172180 172084 -96 -0.1
.data 5576 5576 0 0.0
.heap 858688 858784 96 0.0
.text 1235560 1235152 -408 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2248864 2248456 -408 -0.0
.bss 171068 170972 -96 -0.1
.data 5568 5568 0 0.0
.heap 859808 859904 96 0.0
.text 1211464 1211056 -408 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050352 2050352 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1012952 1012952 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 863671 863591 -80 -0.0
bss 110592 110496 -96 -0.1
rodata 95784 95784 0 0.0
text 581692 581696 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 826071 825991 -80 -0.0
bss 106948 106852 -96 -0.1
rodata 86968 86968 0 0.0
text 555860 555864 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788730 788634 -96 -0.0
bss 111968 111872 -96 -0.1
rodata 91044 91044 0 0.0
text 511164 511168 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839103 839007 -96 -0.0
bss 109616 109520 -96 -0.1
rodata 92256 92256 0 0.0
text 561788 561788 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764406 764310 -96 -0.0
bss 111028 110932 -96 -0.1
rodata 87560 87560 0 0.0
text 491352 491352 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845211 845115 -96 -0.0
bss 109756 109660 -96 -0.1
rodata 93964 93964 0 0.0
text 565968 565972 4 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 838803 838707 -96 -0.0
bss 109652 109556 -96 -0.1
rodata 92212 92212 0 0.0
text 561408 561408 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777795 777795 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521068 521068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692850 692850 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441680 441680 0 0.0
p6 all-clusters-app default (read/write) 2296424 2296552 128 0.0
.bss 112304 112208 -96 -0.1
.data 2520 2520 0 0.0
.heap 918520 918616 96 0.0
.text 1254688 1254816 128 0.0
lock-app default (read/write) 2213896 2214024 128 0.0
.bss 100928 100832 -96 -0.1
.data 2400 2400 0 0.0
.heap 930016 930112 96 0.0
.text 1172160 1172288 128 0.0
qpg lighting-app qpg6100+debug (read only) 492792 492800 8 0.0
(read/write) 114144 114144 0 0.0
.bss 50216 50176 -40 -0.1
.data 1008 1008 0 0.0
.text 487472 487480 8 0.0
lock-app qpg6100+debug (read only) 467772 467780 8 0.0
(read/write) 114140 114140 0 0.0
.bss 49160 49120 -40 -0.1
.data 964 964 0 0.0
.text 462452 462460 8 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767062 766926 -136 -0.0
bss 79104 79008 -96 -0.1
noinit 37160 37160 0 0.0
text 532258 532224 -34 -0.0

@yunhanw-google yunhanw-google merged commit 494fb9b into project-chip:master Nov 17, 2021
@bzbarsky-apple
Copy link
Contributor

Agree, read and subscribe have several similar encoding stuff, so i made the change in the same PR...

I should note that this did not answer the question I actually asked....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@LuDuda LuDuda LuDuda approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yunhanw-google @bzbarsky-apple @andy31415 @LuDuda @yufengwangca @jmartinez-silabs