Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added implementation for missing On/Off Cluster commands #11877

Merged
merged 13 commits into from
Nov 25, 2021
Merged

Added implementation for missing On/Off Cluster commands #11877

merged 13 commits into from
Nov 25, 2021

Conversation

mkardous-silabs
Copy link
Contributor

@mkardous-silabs mkardous-silabs commented Nov 16, 2021 •
edited
Loading

Problem

Fixes:

Change overview

  • Refactored On/Off cluster to fit C++ standards
  • Added missing function implementation for off-with-effect, on-with-timed-off and on-with-recall-global-scene
  • Added hook for device level processing of the ofWithEffect effects

Testing

  • Manual testing for each function

@github-actions
Copy link

github-actions bot commented Nov 16, 2021 •
edited
Loading

PR #11877: Size comparison from 1d76b09 to 0fb6596

Increases above 0.2%:

platform target config section 1d76b09 0fb6596 change % change
efr32 lighting-app BRD4161A (read only) 745208 747824 2616 0.4
.text 745200 747816 2616 0.4
BRD4161A+rpc (read only) 732724 735348 2624 0.4
.text 732716 735340 2624 0.4
k32w lighting-app k32w061+se05x+release (read/write) 703576 705416 1840 0.3
.text 618876 620700 1824 0.3
linux all-clusters-app debug .rodata 135253 135605 352 0.3
bridge-app debug+rpc .rodata 110668 110988 320 0.3
lighting-app debug+rpc (read only) 1566073 1573833 7760 0.5
.text 1303298 1310738 7440 0.6
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 862007 1824 0.2
rodata 95032 95336 304 0.3
text 579140 580656 1516 0.3
nrf52840dk_nrf52840+rpc (read/write) 822551 824407 1856 0.2
rodata 86216 86520 304 0.4
text 553312 554828 1516 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 785222 787046 1824 0.2
rodata 90288 90592 304 0.3
text 508608 510124 1516 0.3
qpg lighting-app qpg6100+debug (read only) 489736 491544 1808 0.4
.text 484416 486224 1808 0.4
telink lighting-app tlsr9518adk80d (read/write) 763014 765138 2124 0.3
text 529210 530986 1776 0.3
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1d76b09 0fb6596 change % change
efr32 lighting-app BRD4161A (read only) 745208 747824 2616 0.4
(read/write) 115364 115388 24 0.0
.bss 113564 113588 24 0.0
.text 745200 747816 2616 0.4
BRD4161A+rpc (read only) 732724 735348 2624 0.4
(read/write) 131992 132016 24 0.0
.bss 130068 130092 24 0.0
.text 732716 735340 2624 0.4
lock-app BRD4161A (read only) 722296 722944 648 0.1
(read/write) 113148 113164 16 0.0
.bss 111388 111404 16 0.0
.text 722288 722936 648 0.1
esp32 all-clusters-app c3devkit (read only) 824912 825216 304 0.0
(read/write) 1219650 1219778 128 0.0
.dram0.bss 56512 56536 24 0.0
.flash.rodata 163800 163896 96 0.1
.flash.text 824912 825216 304 0.0
m5stack (read only) 895819 896107 288 0.0
(read/write) 418980 419092 112 0.0
.dram0.bss 61864 61888 24 0.0
.flash.rodata 191780 191868 88 0.0
.flash.text 890435 890723 288 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703576 705416 1840 0.3
.bss 76988 77004 16 0.0
.text 618876 620700 1824 0.3
lock-app k32w061+debug (read/write) 595020 595628 608 0.1
.bss 67500 67524 24 0.0
.text 519840 520424 584 0.1
shell k32w061+debug (read/write) 660252 660860 608 0.1
.bss 78564 78588 24 0.0
.text 574040 574624 584 0.1
linux all-clusters-app debug (read only) 1701841 1703057 1216 0.1
(read/write) 126624 126688 64 0.1
.bss 57520 57584 64 0.1
.rodata 135253 135605 352 0.3
.text 1433138 1434002 864 0.1
bridge-app debug+rpc (read only) 1297013 1298213 1200 0.1
(read/write) 76816 76848 32 0.0
.bss 42224 42256 32 0.1
.rodata 110668 110988 320 0.3
.text 1089445 1090325 880 0.1
lighting-app debug+rpc (read only) 1566073 1573833 7760 0.5
(read/write) 110064 110096 32 0.0
.bss 47888 47920 32 0.1
.rodata 128273 128593 320 0.2
.text 1303298 1310738 7440 0.6
tv-app debug (read only) 1839065 1840249 1184 0.1
(read/write) 405016 405080 64 0.0
.bss 336968 337032 64 0.0
.rodata 155277 155597 320 0.2
.text 1539522 1540386 864 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2283728 2284064 336 0.0
.bss 179108 179132 24 0.0
.text 1246328 1246664 336 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2269720 2271496 1776 0.1
.bss 171972 171988 16 0.0
.text 1232320 1234096 1776 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2245560 2246096 536 0.0
.bss 170860 170876 16 0.0
.text 1208160 1208696 536 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 862007 1824 0.2
bss 110384 110400 16 0.0
rodata 95032 95336 304 0.3
text 579140 580656 1516 0.3
nrf52840dk_nrf52840+rpc (read/write) 822551 824407 1856 0.2
bss 106740 106756 16 0.0
rodata 86216 86520 304 0.4
text 553312 554828 1516 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 785222 787046 1824 0.2
bss 111760 111776 16 0.0
rodata 90288 90592 304 0.3
text 508608 510124 1516 0.3
lock-app nrf52840dk_nrf52840 (read/write) 835579 836179 600 0.1
bss 109408 109428 20 0.0
rodata 91500 91588 88 0.1
text 559236 559728 492 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 760902 761482 580 0.1
bss 110820 110840 20 0.0
rodata 86808 86892 84 0.1
text 488796 489288 492 0.1
pump-app nrf52840dk_nrf52840 (read/write) 841723 842159 436 0.1
bss 109548 109568 20 0.0
rodata 93212 93296 84 0.1
text 563420 563772 352 0.1
p6 all-clusters-app default (read/write) 2292608 2292984 376 0.0
.bss 112096 112120 24 0.0
.text 1250872 1251248 376 0.0
lock-app default (read/write) 2210080 2210728 648 0.0
.bss 100720 100736 16 0.0
.text 1168344 1168992 648 0.1
qpg lighting-app qpg6100+debug (read only) 489736 491544 1808 0.4
.bss 50056 50072 16 0.0
.text 484416 486224 1808 0.4
lock-app qpg6100+debug (read only) 464692 465276 584 0.1
.bss 49000 49016 16 0.0
.text 459372 459956 584 0.1
telink lighting-app tlsr9518adk80d (read/write) 763014 765138 2124 0.3
bss 78896 78916 20 0.0
text 529210 530986 1776 0.3
Decreases (5 builds for mbed, p6)
platform target config section 1d76b09 0fb6596 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 852120 852096 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858896 858880 -16 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 860016 860000 -16 -0.0
p6 all-clusters-app default .heap 918728 918704 -24 -0.0
lock-app default .heap 930224 930208 -16 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1d76b09 0fb6596 change % change
efr32 lighting-app BRD4161A (read only) 745208 747824 2616 0.4
(read/write) 115364 115388 24 0.0
.bss 113564 113588 24 0.0
.data 1800 1800 0 0.0
.text 745200 747816 2616 0.4
BRD4161A+rpc (read only) 732724 735348 2624 0.4
(read/write) 131992 132016 24 0.0
.bss 130068 130092 24 0.0
.data 1924 1924 0 0.0
.text 732716 735340 2624 0.4
lock-app BRD4161A (read only) 722296 722944 648 0.1
(read/write) 113148 113164 16 0.0
.bss 111388 111404 16 0.0
.data 1756 1756 0 0.0
.text 722288 722936 648 0.1
window-app BRD4161A (read only) 723272 723272 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723264 723264 0 0.0
esp32 all-clusters-app c3devkit (read only) 824912 825216 304 0.0
(read/write) 1219650 1219778 128 0.0
.dram0.bss 56512 56536 24 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163800 163896 96 0.1
.flash.text 824912 825216 304 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 895819 896107 288 0.0
(read/write) 418980 419092 112 0.0
.dram0.bss 61864 61888 24 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191780 191868 88 0.0
.flash.text 890435 890723 288 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703576 705416 1840 0.3
.bss 76988 77004 16 0.0
.data 1912 1912 0 0.0
.text 618876 620700 1824 0.3
lock-app k32w061+debug (read/write) 595020 595628 608 0.1
.bss 67500 67524 24 0.0
.data 1880 1880 0 0.0
.text 519840 520424 584 0.1
shell k32w061+debug (read/write) 660252 660860 608 0.1
.bss 78564 78588 24 0.0
.data 1848 1848 0 0.0
.text 574040 574624 584 0.1
linux all-clusters-app debug (read only) 1701841 1703057 1216 0.1
(read/write) 126624 126688 64 0.1
.bss 57520 57584 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135253 135605 352 0.3
.text 1433138 1434002 864 0.1
bridge-app debug+rpc (read only) 1297013 1298213 1200 0.1
(read/write) 76816 76848 32 0.0
.bss 42224 42256 32 0.1
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110668 110988 320 0.3
.text 1089445 1090325 880 0.1
chip-tool debug (read only) 4950077 4950077 0 0.0
(read/write) 166376 166376 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118016 118016 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 265778 265778 0 0.0
.text 4375157 4375157 0 0.0
lighting-app debug+rpc (read only) 1566073 1573833 7760 0.5
(read/write) 110064 110096 32 0.0
.bss 47888 47920 32 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128273 128593 320 0.2
.text 1303298 1310738 7440 0.6
ota-provider-app debug (read only) 1252473 1252473 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 112999 112999 0 0.0
.text 1042386 1042386 0 0.0
ota-requestor-app debug (read only) 1335553 1335553 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123920 123920 0 0.0
.text 1112210 1112210 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1839065 1840249 1184 0.1
(read/write) 405016 405080 64 0.0
.bss 336968 337032 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59600 59600 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 155277 155597 320 0.2
.text 1539522 1540386 864 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283728 2284064 336 0.0
.bss 179108 179132 24 0.0
.data 5216 5216 0 0.0
.heap 852120 852096 -24 -0.0
.text 1246328 1246664 336 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2269720 2271496 1776 0.1
.bss 171972 171988 16 0.0
.data 5576 5576 0 0.0
.heap 858896 858880 -16 -0.0
.text 1232320 1234096 1776 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2245560 2246096 536 0.0
.bss 170860 170876 16 0.0
.data 5568 5568 0 0.0
.heap 860016 860000 -16 -0.0
.text 1208160 1208696 536 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860183 862007 1824 0.2
bss 110384 110400 16 0.0
rodata 95032 95336 304 0.3
text 579140 580656 1516 0.3
nrf52840dk_nrf52840+rpc (read/write) 822551 824407 1856 0.2
bss 106740 106756 16 0.0
rodata 86216 86520 304 0.4
text 553312 554828 1516 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 785222 787046 1824 0.2
bss 111760 111776 16 0.0
rodata 90288 90592 304 0.3
text 508608 510124 1516 0.3
lock-app nrf52840dk_nrf52840 (read/write) 835579 836179 600 0.1
bss 109408 109428 20 0.0
rodata 91500 91588 88 0.1
text 559236 559728 492 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 760902 761482 580 0.1
bss 110820 110840 20 0.0
rodata 86808 86892 84 0.1
text 488796 489288 492 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 841723 842159 436 0.1
bss 109548 109568 20 0.0
rodata 93212 93296 84 0.1
text 563420 563772 352 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 835315 835315 0 0.0
bss 109444 109444 0 0.0
rodata 91460 91460 0 0.0
text 558856 558856 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292608 2292984 376 0.0
.bss 112096 112120 24 0.0
.data 2520 2520 0 0.0
.heap 918728 918704 -24 -0.0
.text 1250872 1251248 376 0.0
lock-app default (read/write) 2210080 2210728 648 0.0
.bss 100720 100736 16 0.0
.data 2400 2400 0 0.0
.heap 930224 930208 -16 -0.0
.text 1168344 1168992 648 0.1
qpg lighting-app qpg6100+debug (read only) 489736 491544 1808 0.4
(read/write) 114144 114144 0 0.0
.bss 50056 50072 16 0.0
.data 1008 1008 0 0.0
.text 484416 486224 1808 0.4
lock-app qpg6100+debug (read only) 464692 465276 584 0.1
(read/write) 114140 114140 0 0.0
.bss 49000 49016 16 0.0
.data 964 964 0 0.0
.text 459372 459956 584 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763014 765138 2124 0.3
bss 78896 78916 20 0.0
noinit 37160 37160 0 0.0
text 529210 530986 1776 0.3

@mkardous-silabs mkardous-silabs marked this pull request as ready for review November 17, 2021 13:29
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11877: Size comparison from cbd3e95 to b811966

Increases above 0.2%:

platform target config section cbd3e95 b811966 change % change
efr32 lighting-app BRD4161A (read only) 745448 748080 2632 0.4
.text 745440 748072 2632 0.4
BRD4161A+rpc (read only) 732964 735604 2640 0.4
.text 732956 735596 2640 0.4
k32w lighting-app k32w061+se05x+release (read/write) 703856 705712 1856 0.3
.text 619156 620996 1840 0.3
linux bridge-app debug+rpc .rodata 110764 111084 320 0.3
lighting-app debug+rpc (read only) 1567113 1574873 7760 0.5
.text 1304210 1311650 7440 0.6
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 862303 1840 0.2
rodata 95136 95440 304 0.3
text 579316 580852 1536 0.3
nrf52840dk_nrf52840+rpc (read/write) 822831 824703 1872 0.2
rodata 86320 86624 304 0.4
text 553488 555024 1536 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 785502 787342 1840 0.2
rodata 90392 90696 304 0.3
text 508788 510320 1532 0.3
qpg lighting-app qpg6100+debug (read only) 490080 491904 1824 0.4
.text 484760 486584 1824 0.4
telink lighting-app tlsr9518adk80d (read/write) 763250 765390 2140 0.3
text 529344 531136 1792 0.3
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cbd3e95 b811966 change % change
efr32 lighting-app BRD4161A (read only) 745448 748080 2632 0.4
(read/write) 115364 115388 24 0.0
.bss 113564 113588 24 0.0
.text 745440 748072 2632 0.4
BRD4161A+rpc (read only) 732964 735604 2640 0.4
(read/write) 131992 132016 24 0.0
.bss 130068 130092 24 0.0
.text 732956 735596 2640 0.4
lock-app BRD4161A (read only) 722536 723184 648 0.1
(read/write) 113148 113164 16 0.0
.bss 111388 111404 16 0.0
.text 722528 723176 648 0.1
esp32 all-clusters-app c3devkit (read only) 825128 825432 304 0.0
(read/write) 1219762 1219882 120 0.0
.dram0.bss 56512 56536 24 0.0
.flash.rodata 163912 164000 88 0.1
.flash.text 825128 825432 304 0.0
m5stack (read only) 896127 896395 268 0.0
(read/write) 419084 419188 104 0.0
.dram0.bss 61864 61888 24 0.0
.flash.rodata 191884 191964 80 0.0
.flash.text 890743 891011 268 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 705712 1856 0.3
.bss 76988 77004 16 0.0
.text 619156 620996 1840 0.3
lock-app k32w061+debug (read/write) 595300 595908 608 0.1
.bss 67500 67524 24 0.0
.text 520120 520704 584 0.1
shell k32w061+debug (read/write) 660532 661140 608 0.1
.bss 78564 78588 24 0.0
.text 574320 574904 584 0.1
linux all-clusters-app debug (read only) 1702849 1704049 1200 0.1
(read/write) 126624 126688 64 0.1
.bss 57520 57584 64 0.1
.rodata 135349 135669 320 0.2
.text 1434050 1434930 880 0.1
bridge-app debug+rpc (read only) 1298021 1299221 1200 0.1
(read/write) 76816 76848 32 0.0
.bss 42224 42256 32 0.1
.rodata 110764 111084 320 0.3
.text 1090357 1091237 880 0.1
lighting-app debug+rpc (read only) 1567113 1574873 7760 0.5
(read/write) 110064 110096 32 0.0
.bss 47888 47920 32 0.1
.rodata 128401 128721 320 0.2
.text 1304210 1311650 7440 0.6
tv-app debug (read only) 1846009 1847241 1232 0.1
(read/write) 318136 318200 64 0.0
.bss 249960 250024 64 0.0
.rodata 156653 157005 352 0.2
.text 1544802 1545682 880 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2284296 2284632 336 0.0
.bss 179108 179132 24 0.0
.text 1246896 1247232 336 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2270224 2272064 1840 0.1
.bss 171972 171988 16 0.0
.text 1232824 1234664 1840 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2246128 2246664 536 0.0
.bss 170860 170876 16 0.0
.text 1208728 1209264 536 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 862303 1840 0.2
bss 110384 110400 16 0.0
rodata 95136 95440 304 0.3
text 579316 580852 1536 0.3
nrf52840dk_nrf52840+rpc (read/write) 822831 824703 1872 0.2
bss 106740 106756 16 0.0
rodata 86320 86624 304 0.4
text 553488 555024 1536 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 785502 787342 1840 0.2
bss 111760 111776 16 0.0
rodata 90392 90696 304 0.3
text 508788 510320 1532 0.3
lock-app nrf52840dk_nrf52840 (read/write) 835859 836459 600 0.1
bss 109408 109428 20 0.0
rodata 91604 91692 88 0.1
text 559416 559904 488 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 761182 761762 580 0.1
bss 110820 110840 20 0.0
rodata 86912 86996 84 0.1
text 488976 489468 492 0.1
pump-app nrf52840dk_nrf52840 (read/write) 842003 842439 436 0.1
bss 109548 109568 20 0.0
rodata 93316 93400 84 0.1
text 563596 563948 352 0.1
p6 all-clusters-app default (read/write) 2292832 2293224 392 0.0
.bss 112096 112120 24 0.0
.text 1251096 1251488 392 0.0
lock-app default (read/write) 2210320 2210968 648 0.0
.bss 100720 100736 16 0.0
.text 1168584 1169232 648 0.1
qpg lighting-app qpg6100+debug (read only) 490080 491904 1824 0.4
.bss 50056 50072 16 0.0
.text 484760 486584 1824 0.4
lock-app qpg6100+debug (read only) 465044 465628 584 0.1
.bss 49000 49016 16 0.0
.text 459724 460308 584 0.1
telink lighting-app tlsr9518adk80d (read/write) 763250 765390 2140 0.3
bss 78896 78916 20 0.0
text 529344 531136 1792 0.3
Decreases (5 builds for mbed, p6)
platform target config section cbd3e95 b811966 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 852120 852096 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858896 858880 -16 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 860016 860000 -16 -0.0
p6 all-clusters-app default .heap 918728 918704 -24 -0.0
lock-app default .heap 930224 930208 -16 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cbd3e95 b811966 change % change
efr32 lighting-app BRD4161A (read only) 745448 748080 2632 0.4
(read/write) 115364 115388 24 0.0
.bss 113564 113588 24 0.0
.data 1800 1800 0 0.0
.text 745440 748072 2632 0.4
BRD4161A+rpc (read only) 732964 735604 2640 0.4
(read/write) 131992 132016 24 0.0
.bss 130068 130092 24 0.0
.data 1924 1924 0 0.0
.text 732956 735596 2640 0.4
lock-app BRD4161A (read only) 722536 723184 648 0.1
(read/write) 113148 113164 16 0.0
.bss 111388 111404 16 0.0
.data 1756 1756 0 0.0
.text 722528 723176 648 0.1
window-app BRD4161A (read only) 723496 723496 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723488 723488 0 0.0
esp32 all-clusters-app c3devkit (read only) 825128 825432 304 0.0
(read/write) 1219762 1219882 120 0.0
.dram0.bss 56512 56536 24 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163912 164000 88 0.1
.flash.text 825128 825432 304 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896127 896395 268 0.0
(read/write) 419084 419188 104 0.0
.dram0.bss 61864 61888 24 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191884 191964 80 0.0
.flash.text 890743 891011 268 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 705712 1856 0.3
.bss 76988 77004 16 0.0
.data 1912 1912 0 0.0
.text 619156 620996 1840 0.3
lock-app k32w061+debug (read/write) 595300 595908 608 0.1
.bss 67500 67524 24 0.0
.data 1880 1880 0 0.0
.text 520120 520704 584 0.1
shell k32w061+debug (read/write) 660532 661140 608 0.1
.bss 78564 78588 24 0.0
.data 1848 1848 0 0.0
.text 574320 574904 584 0.1
linux all-clusters-app debug (read only) 1702849 1704049 1200 0.1
(read/write) 126624 126688 64 0.1
.bss 57520 57584 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135669 320 0.2
.text 1434050 1434930 880 0.1
bridge-app debug+rpc (read only) 1298021 1299221 1200 0.1
(read/write) 76816 76848 32 0.0
.bss 42224 42256 32 0.1
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 111084 320 0.3
.text 1090357 1091237 880 0.1
chip-tool debug (read only) 4957053 4957053 0 0.0
(read/write) 166504 166504 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118136 118136 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267186 267186 0 0.0
.text 4380437 4380437 0 0.0
lighting-app debug+rpc (read only) 1567113 1574873 7760 0.5
(read/write) 110064 110096 32 0.0
.bss 47888 47920 32 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128401 128721 320 0.2
.text 1304210 1311650 7440 0.6
ota-provider-app debug (read only) 1253449 1253449 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 113063 0 0.0
.text 1043298 1043298 0 0.0
ota-requestor-app debug (read only) 1337025 1337025 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124112 124112 0 0.0
.text 1113490 1113490 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1846009 1847241 1232 0.1
(read/write) 318136 318200 64 0.0
.bss 249960 250024 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156653 157005 352 0.2
.text 1544802 1545682 880 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284296 2284632 336 0.0
.bss 179108 179132 24 0.0
.data 5216 5216 0 0.0
.heap 852120 852096 -24 -0.0
.text 1246896 1247232 336 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2272064 1840 0.1
.bss 171972 171988 16 0.0
.data 5576 5576 0 0.0
.heap 858896 858880 -16 -0.0
.text 1232824 1234664 1840 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2246128 2246664 536 0.0
.bss 170860 170876 16 0.0
.data 5568 5568 0 0.0
.heap 860016 860000 -16 -0.0
.text 1208728 1209264 536 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 862303 1840 0.2
bss 110384 110400 16 0.0
rodata 95136 95440 304 0.3
text 579316 580852 1536 0.3
nrf52840dk_nrf52840+rpc (read/write) 822831 824703 1872 0.2
bss 106740 106756 16 0.0
rodata 86320 86624 304 0.4
text 553488 555024 1536 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 785502 787342 1840 0.2
bss 111760 111776 16 0.0
rodata 90392 90696 304 0.3
text 508788 510320 1532 0.3
lock-app nrf52840dk_nrf52840 (read/write) 835859 836459 600 0.1
bss 109408 109428 20 0.0
rodata 91604 91692 88 0.1
text 559416 559904 488 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 761182 761762 580 0.1
bss 110820 110840 20 0.0
rodata 86912 86996 84 0.1
text 488976 489468 492 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842003 842439 436 0.1
bss 109548 109568 20 0.0
rodata 93316 93400 84 0.1
text 563596 563948 352 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 835595 835595 0 0.0
bss 109444 109444 0 0.0
rodata 91564 91564 0 0.0
text 559036 559036 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292832 2293224 392 0.0
.bss 112096 112120 24 0.0
.data 2520 2520 0 0.0
.heap 918728 918704 -24 -0.0
.text 1251096 1251488 392 0.0
lock-app default (read/write) 2210320 2210968 648 0.0
.bss 100720 100736 16 0.0
.data 2400 2400 0 0.0
.heap 930224 930208 -16 -0.0
.text 1168584 1169232 648 0.1
qpg lighting-app qpg6100+debug (read only) 490080 491904 1824 0.4
(read/write) 114144 114144 0 0.0
.bss 50056 50072 16 0.0
.data 1008 1008 0 0.0
.text 484760 486584 1824 0.4
lock-app qpg6100+debug (read only) 465044 465628 584 0.1
(read/write) 114140 114140 0 0.0
.bss 49000 49016 16 0.0
.data 964 964 0 0.0
.text 459724 460308 584 0.1
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 765390 2140 0.3
bss 78896 78916 20 0.0
noinit 37160 37160 0 0.0
text 529344 531136 1792 0.3

andy31415
andy31415 approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@andy31415 andy31415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly consensus checkmark here.

src/app/clusters/on-off-server/on-off-server.h Outdated Show resolved Hide resolved
src/app/clusters/on-off-server/on-off-server.cpp Show resolved Hide resolved
src/app/clusters/on-off-server/on-off-server.cpp Outdated Show resolved Hide resolved
@restyled-io restyled-io bot mentioned this pull request Nov 25, 2021
Closed
@andy31415
Copy link
Contributor

fast track: opened for a long time and has several checkmarks

@github-actions
Copy link

github-actions bot commented Nov 25, 2021 •
edited
Loading

PR #11877: Size comparison from 15929eb to 64b1377

Increases above 0.2%:

platform target config section 15929eb 64b1377 change % change
efr32 lighting-app BRD4161A (read only) 759568 762200 2632 0.3
.text 759560 762192 2632 0.3
BRD4161A+rpc (read only) 747236 749860 2624 0.4
.text 747228 749852 2624 0.4
k32w lighting-app k32w061+se05x+release (read/write) 721348 723188 1840 0.3
.text 635316 637140 1824 0.3
linux bridge-app debug+rpc .rodata 113084 113404 320 0.3
lighting-app debug+rpc (read only) 1619433 1627449 8016 0.5
.text 1350338 1358034 7696 0.6
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873643 875467 1824 0.2
rodata 96788 97092 304 0.3
text 588544 590076 1532 0.3
nrf52840dk_nrf52840+rpc (read/write) 836203 838043 1840 0.2
rodata 88036 88340 304 0.3
text 562844 564380 1536 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 798666 800506 1840 0.2
rodata 92044 92348 304 0.3
text 518004 519540 1536 0.3
qpg lighting-app qpg6100+debug (read only) 501148 502996 1848 0.4
.text 495828 497676 1848 0.4
telink lighting-app tlsr9518adk80d (read/write) 775246 777386 2140 0.3
text 539022 540814 1792 0.3
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 15929eb 64b1377 change % change
efr32 lighting-app BRD4161A (read only) 759568 762200 2632 0.3
(read/write) 119812 119836 24 0.0
.bss 117988 118012 24 0.0
.text 759560 762192 2632 0.3
BRD4161A+rpc (read only) 747236 749860 2624 0.4
(read/write) 136436 136460 24 0.0
.bss 134492 134516 24 0.0
.text 747228 749852 2624 0.4
lock-app BRD4161A (read only) 735504 736168 664 0.1
(read/write) 117524 117540 16 0.0
.bss 115748 115764 16 0.0
.text 735496 736160 664 0.1
esp32 all-clusters-app c3devkit (read only) 835796 836100 304 0.0
(read/write) 1224250 1224370 120 0.0
.dram0.bss 59120 59144 24 0.0
.flash.rodata 165776 165864 88 0.1
.flash.text 835796 836100 304 0.0
m5stack (read only) 907139 907475 336 0.0
(read/write) 423492 423596 104 0.0
.dram0.bss 64512 64536 24 0.0
.flash.rodata 193628 193708 80 0.0
.flash.text 901755 902091 336 0.0
k32w lighting-app k32w061+se05x+release (read/write) 721348 723188 1840 0.3
.bss 78276 78292 16 0.0
.text 635316 637140 1824 0.3
lock-app k32w061+debug (read/write) 611668 612276 608 0.1
.bss 68716 68740 24 0.0
.text 535232 535816 584 0.1
shell k32w061+debug (read/write) 676972 677580 608 0.1
.bss 79868 79892 24 0.0
.text 589412 589996 584 0.1
linux all-clusters-app debug (read only) 1770537 1771945 1408 0.1
(read/write) 131480 131544 64 0.0
.bss 60080 60144 64 0.1
.rodata 138453 138773 320 0.2
.text 1493714 1494802 1088 0.1
bridge-app debug+rpc (read only) 1346365 1347805 1440 0.1
(read/write) 77824 77856 32 0.0
.bss 41712 41744 32 0.1
.rodata 113084 113404 320 0.3
.text 1133189 1134309 1120 0.1
lighting-app debug+rpc (read only) 1619433 1627449 8016 0.5
(read/write) 111072 111104 32 0.0
.bss 47408 47440 32 0.1
.rodata 131377 131697 320 0.2
.text 1350338 1358034 7696 0.6
tv-app debug (read only) 1916225 1917665 1440 0.1
(read/write) 320088 320152 64 0.0
.bss 250168 250232 64 0.0
.rodata 159432 159752 320 0.2
.text 1608594 1609714 1120 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293680 2294088 408 0.0
.bss 181668 181692 24 0.0
.text 1256280 1256688 408 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2277712 2279552 1840 0.1
.bss 172284 172300 16 0.0
.text 1240312 1242152 1840 0.1
lock-app CY8CPROTO_062_4343W+release (read/write) 2252096 2252696 600 0.0
.bss 171100 171116 16 0.0
.text 1214696 1215296 600 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873643 875467 1824 0.2
bss 112644 112660 16 0.0
rodata 96788 97092 304 0.3
text 588544 590076 1532 0.3
nrf52840dk_nrf52840+rpc (read/write) 836203 838043 1840 0.2
bss 108996 109012 16 0.0
rodata 88036 88340 304 0.3
text 562844 564380 1536 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 798666 800506 1840 0.2
bss 114020 114036 16 0.0
rodata 92044 92348 304 0.3
text 518004 519540 1536 0.3
lock-app nrf52840dk_nrf52840 (read/write) 845799 846411 612 0.1
bss 109680 109700 20 0.0
rodata 92792 92876 84 0.1
text 567856 568348 492 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 771070 771686 616 0.1
bss 111088 111108 20 0.0
rodata 88080 88168 88 0.1
text 497412 497900 488 0.1
pump-app nrf52840dk_nrf52840 (read/write) 851899 852371 472 0.1
bss 109816 109836 20 0.0
rodata 94500 94588 88 0.1
text 572040 572392 352 0.1
p6 all-clusters-app default (read/write) 2310568 2310968 400 0.0
.bss 114664 114688 24 0.0
.text 1268832 1269232 400 0.0
lock-app default (read/write) 2222400 2223048 648 0.0
.bss 100960 100976 16 0.0
.text 1180664 1181312 648 0.1
qpg lighting-app qpg6100+debug (read only) 501148 502996 1848 0.4
.bss 50384 50400 16 0.0
.text 495828 497676 1848 0.4
lock-app qpg6100+debug (read only) 475116 475696 580 0.1
.bss 49256 49272 16 0.0
.text 469796 470376 580 0.1
telink lighting-app tlsr9518adk80d (read/write) 775246 777386 2140 0.3
bss 79216 79236 20 0.0
text 539022 540814 1792 0.3
Decreases (5 builds for mbed, p6)
platform target config section 15929eb 64b1377 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 849536 849512 -24 -0.0
lighting-app CY8CPROTO_062_4343W+release .heap 858560 858544 -16 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 859760 859744 -16 -0.0
p6 all-clusters-app default .heap 916136 916112 -24 -0.0
lock-app default .heap 929968 929952 -16 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 15929eb 64b1377 change % change
efr32 lighting-app BRD4161A (read only) 759568 762200 2632 0.3
(read/write) 119812 119836 24 0.0
.bss 117988 118012 24 0.0
.data 1820 1820 0 0.0
.text 759560 762192 2632 0.3
BRD4161A+rpc (read only) 747236 749860 2624 0.4
(read/write) 136436 136460 24 0.0
.bss 134492 134516 24 0.0
.data 1944 1944 0 0.0
.text 747228 749852 2624 0.4
lock-app BRD4161A (read only) 735504 736168 664 0.1
(read/write) 117524 117540 16 0.0
.bss 115748 115764 16 0.0
.data 1776 1776 0 0.0
.text 735496 736160 664 0.1
window-app BRD4161A (read only) 738960 738960 0 0.0
(read/write) 117884 117884 0 0.0
.bss 116100 116100 0 0.0
.data 1784 1784 0 0.0
.text 738952 738952 0 0.0
esp32 all-clusters-app c3devkit (read only) 835796 836100 304 0.0
(read/write) 1224250 1224370 120 0.0
.dram0.bss 59120 59144 24 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165776 165864 88 0.1
.flash.text 835796 836100 304 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907139 907475 336 0.0
(read/write) 423492 423596 104 0.0
.dram0.bss 64512 64536 24 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193628 193708 80 0.0
.flash.text 901755 902091 336 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 721348 723188 1840 0.3
.bss 78276 78292 16 0.0
.data 1956 1956 0 0.0
.text 635316 637140 1824 0.3
lock-app k32w061+debug (read/write) 611668 612276 608 0.1
.bss 68716 68740 24 0.0
.data 1920 1920 0 0.0
.text 535232 535816 584 0.1
shell k32w061+debug (read/write) 676972 677580 608 0.1
.bss 79868 79892 24 0.0
.data 1892 1892 0 0.0
.text 589412 589996 584 0.1
linux all-clusters-app debug (read only) 1770537 1771945 1408 0.1
(read/write) 131480 131544 64 0.0
.bss 60080 60144 64 0.1
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138453 138773 320 0.2
.text 1493714 1494802 1088 0.1
bridge-app debug+rpc (read only) 1346365 1347805 1440 0.1
(read/write) 77824 77856 32 0.0
.bss 41712 41744 32 0.1
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113084 113404 320 0.3
.text 1133189 1134309 1120 0.1
chip-tool debug (read only) 6070205 6070205 0 0.0
(read/write) 199728 199728 0 0.0
.bss 40064 40064 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 151712 151712 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 290408 290408 0 0.0
.text 5391077 5391077 0 0.0
lighting-app debug+rpc (read only) 1619433 1627449 8016 0.5
(read/write) 111072 111104 32 0.0
.bss 47408 47440 32 0.1
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131377 131697 320 0.2
.text 1350338 1358034 7696 0.6
ota-provider-app debug (read only) 1309361 1309361 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114736 114736 0 0.0
.text 1094274 1094274 0 0.0
ota-requestor-app debug (read only) 1405849 1405849 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126208 126208 0 0.0
.text 1176498 1176498 0 0.0
shell debug (read only) 820129 820129 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 78927 78927 0 0.0
.text 634514 634514 0 0.0
tv-app debug (read only) 1916225 1917665 1440 0.1
(read/write) 320088 320152 64 0.0
.bss 250168 250232 64 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61368 61368 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159432 159752 320 0.2
.text 1608594 1609714 1120 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293680 2294088 408 0.0
.bss 181668 181692 24 0.0
.data 5240 5240 0 0.0
.heap 849536 849512 -24 -0.0
.text 1256280 1256688 408 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277712 2279552 1840 0.1
.bss 172284 172300 16 0.0
.data 5600 5600 0 0.0
.heap 858560 858544 -16 -0.0
.text 1240312 1242152 1840 0.1
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2252096 2252696 600 0.0
.bss 171100 171116 16 0.0
.data 5584 5584 0 0.0
.heap 859760 859744 -16 -0.0
.text 1214696 1215296 600 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050584 2050584 0 0.0
.bss 156304 156304 0 0.0
.data 4984 4984 0 0.0
.heap 875160 875160 0 0.0
.text 1013184 1013184 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 873643 875467 1824 0.2
bss 112644 112660 16 0.0
rodata 96788 97092 304 0.3
text 588544 590076 1532 0.3
nrf52840dk_nrf52840+rpc (read/write) 836203 838043 1840 0.2
bss 108996 109012 16 0.0
rodata 88036 88340 304 0.3
text 562844 564380 1536 0.3
nrf5340dk_nrf5340_cpuapp (read/write) 798666 800506 1840 0.2
bss 114020 114036 16 0.0
rodata 92044 92348 304 0.3
text 518004 519540 1536 0.3
lock-app nrf52840dk_nrf52840 (read/write) 845799 846411 612 0.1
bss 109680 109700 20 0.0
rodata 92792 92876 84 0.1
text 567856 568348 492 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 771070 771686 616 0.1
bss 111088 111108 20 0.0
rodata 88080 88168 88 0.1
text 497412 497900 488 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 851899 852371 472 0.1
bss 109816 109836 20 0.0
rodata 94500 94588 88 0.1
text 572040 572392 352 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 845491 845491 0 0.0
bss 109712 109712 0 0.0
rodata 92748 92748 0 0.0
text 567476 567476 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778319 778319 0 0.0
bss 109180 109180 0 0.0
rodata 72988 72988 0 0.0
text 521552 521552 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693374 693374 0 0.0
bss 110164 110164 0 0.0
rodata 67632 67632 0 0.0
text 442160 442160 0 0.0
p6 all-clusters-app default (read/write) 2310568 2310968 400 0.0
.bss 114664 114688 24 0.0
.data 2544 2544 0 0.0
.heap 916136 916112 -24 -0.0
.text 1268832 1269232 400 0.0
lock-app default (read/write) 2222400 2223048 648 0.0
.bss 100960 100976 16 0.0
.data 2416 2416 0 0.0
.heap 929968 929952 -16 -0.0
.text 1180664 1181312 648 0.1
qpg lighting-app qpg6100+debug (read only) 501148 502996 1848 0.4
(read/write) 114144 114144 0 0.0
.bss 50384 50400 16 0.0
.data 1024 1024 0 0.0
.text 495828 497676 1848 0.4
lock-app qpg6100+debug (read only) 475116 475696 580 0.1
(read/write) 114140 114140 0 0.0
.bss 49256 49272 16 0.0
.data 980 980 0 0.0
.text 469796 470376 580 0.1
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 775246 777386 2140 0.3
bss 79216 79236 20 0.0
noinit 37160 37160 0 0.0
text 539022 540814 1792 0.3

@jmartinez-silabs jmartinez-silabs merged commit d8928bf into project-chip:master Nov 25, 2021
@mkardous-silabs mkardous-silabs deleted the feature/onoff_commands branch November 25, 2021 19:55
@bzbarsky-apple bzbarsky-apple mentioned this pull request Dec 2, 2021
Closed
@mkardous-silabs mkardous-silabs mentioned this pull request Dec 6, 2021
Closed
@jmartinez-silabs jmartinez-silabs mentioned this pull request Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mkardous-silabs @andy31415 @yunhanw-google @bzbarsky-apple @jmartinez-silabs @restyled-commits