Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow piecemeal migration from EmberAf non-enum-class enums to cluster-objects enum classes #11900

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Allow piecemeal migration from EmberAf non-enum-class enums to cluster-objects enum classes #11900

merged 4 commits into from
Nov 29, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

No real plausible path to migrate to strongly typed cluster-objects enums.

Change overview

Introduce such a path, so it can be done on a per-enum basis, not for everything at once (which seems hard to imagine happening).

Testing

Tree compiles. No expected behavior changes.

@boring-cyborg boring-cyborg bot added the app label Nov 17, 2021
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11900: Size comparison from 2b52b36 to 5476e3f

Full report (13 builds for efr32, k32w, p6, qpg, telink)
platform target config section 2b52b36 5476e3f change % change
efr32 lighting-app BRD4161A (read only) 749456 749456 0 0.0
(read/write) 115540 115540 0 0.0
.bss 113740 113740 0 0.0
.data 1800 1800 0 0.0
.text 749448 749448 0 0.0
BRD4161A+rpc (read only) 736988 736988 0 0.0
(read/write) 132168 132168 0 0.0
.bss 130244 130244 0 0.0
.data 1924 1924 0 0.0
.text 736980 736980 0 0.0
lock-app BRD4161A (read only) 726528 726528 0 0.0
(read/write) 113324 113324 0 0.0
.bss 111564 111564 0 0.0
.data 1756 1756 0 0.0
.text 726520 726520 0 0.0
window-app BRD4161A (read only) 727504 727504 0 0.0
(read/write) 113644 113644 0 0.0
.bss 111884 111884 0 0.0
.data 1760 1760 0 0.0
.text 727496 727496 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706636 706636 0 0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 621760 621760 0 0.0
lock-app k32w061+debug (read/write) 598076 598076 0 0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 522720 522720 0 0.0
shell k32w061+debug (read/write) 663420 663420 0 0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 576968 576968 0 0.0
p6 all-clusters-app default (read/write) 2297480 2297480 0 0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1255744 1255744 0 0.0
lock-app default (read/write) 2214968 2214968 0 0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1173232 1173232 0 0.0
qpg lighting-app qpg6100+debug (read only) 493472 493472 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488152 488152 0 0.0
lock-app qpg6100+debug (read only) 468452 468452 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463132 463132 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767742 767742 0 0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 532972 532972 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch from 5476e3f to d7dcfa6 Compare November 17, 2021 23:25
@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11900: Size comparison from 2b52b36 to d7dcfa6

Decreases (2 builds for linux)
platform target config section 2b52b36 d7dcfa6 change % change
linux all-clusters-app debug (read only) 1724201 1724185 -16 -0.0
.text 1453906 1453890 -16 -0.0
chip-tool debug (read only) 4980557 4980509 -48 -0.0
.text 4401685 4401637 -48 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2b52b36 d7dcfa6 change % change
efr32 lighting-app BRD4161A (read only) 749456 749456 0 0.0
(read/write) 115540 115540 0 0.0
.bss 113740 113740 0 0.0
.data 1800 1800 0 0.0
.text 749448 749448 0 0.0
BRD4161A+rpc (read only) 736988 736988 0 0.0
(read/write) 132168 132168 0 0.0
.bss 130244 130244 0 0.0
.data 1924 1924 0 0.0
.text 736980 736980 0 0.0
lock-app BRD4161A (read only) 726528 726528 0 0.0
(read/write) 113324 113324 0 0.0
.bss 111564 111564 0 0.0
.data 1756 1756 0 0.0
.text 726520 726520 0 0.0
window-app BRD4161A (read only) 727504 727504 0 0.0
(read/write) 113644 113644 0 0.0
.bss 111884 111884 0 0.0
.data 1760 1760 0 0.0
.text 727496 727496 0 0.0
esp32 all-clusters-app c3devkit (read only) 828296 828296 0 0.0
(read/write) 1220130 1220130 0 0.0
.dram0.bss 56688 56688 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 164104 164104 0 0.0
.flash.text 828296 828296 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 899319 899319 0 0.0
(read/write) 419452 419452 0 0.0
.dram0.bss 62040 62040 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192076 192076 0 0.0
.flash.text 893935 893935 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 706636 706636 0 0.0
.bss 77164 77164 0 0.0
.data 1912 1912 0 0.0
.text 621760 621760 0 0.0
lock-app k32w061+debug (read/write) 598076 598076 0 0.0
.bss 67676 67676 0 0.0
.data 1880 1880 0 0.0
.text 522720 522720 0 0.0
shell k32w061+debug (read/write) 663420 663420 0 0.0
.bss 78804 78804 0 0.0
.data 1848 1848 0 0.0
.text 576968 576968 0 0.0
linux all-clusters-app debug (read only) 1724201 1724185 -16 -0.0
(read/write) 126816 126816 0 0.0
.bss 57392 57392 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63088 63088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 136341 136341 0 0.0
.text 1453906 1453890 -16 -0.0
bridge-app debug+rpc (read only) 1319301 1319301 0 0.0
(read/write) 77008 77008 0 0.0
.bss 42096 42096 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28344 28344 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111684 111684 0 0.0
.text 1110213 1110213 0 0.0
chip-tool debug (read only) 4980557 4980509 -48 -0.0
(read/write) 166920 166920 0 0.0
.bss 40456 40456 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118680 118680 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268362 268362 0 0.0
.text 4401685 4401637 -48 -0.0
lighting-app debug+rpc (read only) 1588385 1588385 0 0.0
(read/write) 110224 110224 0 0.0
.bss 47760 47760 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55904 55904 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129265 129265 0 0.0
.text 1324114 1324114 0 0.0
ota-provider-app debug (read only) 1267993 1267993 0 0.0
(read/write) 75656 75656 0 0.0
.bss 44704 44704 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113855 113855 0 0.0
.text 1056546 1056546 0 0.0
ota-requestor-app debug (read only) 1353665 1353665 0 0.0
(read/write) 79392 79392 0 0.0
.bss 47168 47168 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26280 26280 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124872 124872 0 0.0
.text 1128818 1128818 0 0.0
shell debug (read only) 798209 798209 0 0.0
(read/write) 66440 66440 0 0.0
.bss 23944 23944 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 615490 615490 0 0.0
tv-app debug (read only) 1870881 1870881 0 0.0
(read/write) 318968 318968 0 0.0
.bss 250376 250376 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60136 60136 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157669 157669 0 0.0
.text 1568082 1568082 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2287384 2287384 0 0.0
.bss 179284 179284 0 0.0
.data 5216 5216 0 0.0
.heap 851944 851944 0 0.0
.text 1249984 1249984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273320 2273320 0 0.0
.bss 172148 172148 0 0.0
.data 5576 5576 0 0.0
.heap 858720 858720 0 0.0
.text 1235920 1235920 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249160 2249160 0 0.0
.bss 171036 171036 0 0.0
.data 5568 5568 0 0.0
.heap 859840 859840 0 0.0
.text 1211760 1211760 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050352 2050352 0 0.0
.bss 156224 156224 0 0.0
.data 4968 4968 0 0.0
.heap 875256 875256 0 0.0
.text 1012952 1012952 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 864295 864295 0 0.0
bss 110560 110560 0 0.0
rodata 95784 95784 0 0.0
text 582344 582344 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 826695 826695 0 0.0
bss 106916 106916 0 0.0
rodata 86968 86968 0 0.0
text 556512 556512 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 789354 789354 0 0.0
bss 111936 111936 0 0.0
rodata 91044 91044 0 0.0
text 511816 511816 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839727 839727 0 0.0
bss 109584 109584 0 0.0
rodata 92256 92256 0 0.0
text 562436 562436 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765014 765014 0 0.0
bss 110996 110996 0 0.0
rodata 87560 87560 0 0.0
text 492000 492000 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 845835 845835 0 0.0
bss 109724 109724 0 0.0
rodata 93964 93964 0 0.0
text 566620 566620 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839427 839427 0 0.0
bss 109620 109620 0 0.0
rodata 92212 92212 0 0.0
text 562056 562056 0 0.0
shell nrf52840dk_nrf52840 (read/write) 777795 777795 0 0.0
bss 109068 109068 0 0.0
rodata 73064 73064 0 0.0
text 521068 521068 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 692850 692850 0 0.0
bss 110052 110052 0 0.0
rodata 67708 67708 0 0.0
text 441680 441680 0 0.0
p6 all-clusters-app default (read/write) 2297480 2297480 0 0.0
.bss 112272 112272 0 0.0
.data 2520 2520 0 0.0
.heap 918552 918552 0 0.0
.text 1255744 1255744 0 0.0
lock-app default (read/write) 2214968 2214968 0 0.0
.bss 100896 100896 0 0.0
.data 2400 2400 0 0.0
.heap 930048 930048 0 0.0
.text 1173232 1173232 0 0.0
qpg lighting-app qpg6100+debug (read only) 493472 493472 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50208 50208 0 0.0
.data 1008 1008 0 0.0
.text 488152 488152 0 0.0
lock-app qpg6100+debug (read only) 468452 468452 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49152 49152 0 0.0
.data 964 964 0 0.0
.text 463132 463132 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 767742 767742 0 0.0
bss 79072 79072 0 0.0
noinit 37160 37160 0 0.0
text 532972 532972 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

@carol-apple @pan-apple @msandstedt @saurabhst @LuDuda @Damian-Nordic @jepenven-silabs @jmartinez-silabs Please review?

@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch from d7dcfa6 to 04f9472 Compare November 22, 2021 16:51
@github-actions
Copy link

github-actions bot commented Nov 22, 2021 •
edited
Loading

PR #11900: Size comparison from aa8a6d0 to 04f9472

Decreases (1 build for linux)
platform target config section aa8a6d0 04f9472 change % change
linux chip-tool debug (read only) 5867301 5867237 -64 -0.0
.text 5210149 5210085 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section aa8a6d0 04f9472 change % change
efr32 lighting-app BRD4161A (read only) 750736 750736 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750728 750728 0 0.0
BRD4161A+rpc (read only) 738276 738276 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 738268 738268 0 0.0
lock-app BRD4161A (read only) 727808 727808 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727800 727800 0 0.0
window-app BRD4161A (read only) 728792 728792 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728784 728784 0 0.0
esp32 all-clusters-app c3devkit (read only) 833410 833410 0 0.0
(read/write) 1221938 1221938 0 0.0
.dram0.bss 57752 57752 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 164840 164840 0 0.0
.flash.text 833410 833410 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904403 904403 0 0.0
(read/write) 421232 421232 0 0.0
.dram0.bss 63112 63112 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192784 192784 0 0.0
.flash.text 899019 899019 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707528 707528 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622604 622604 0 0.0
lock-app k32w061+debug (read/write) 598960 598960 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523564 523564 0 0.0
shell k32w061+debug (read/write) 664336 664336 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577812 577812 0 0.0
linux all-clusters-app debug (read only) 1746601 1746601 0 0.0
(read/write) 128392 128392 0 0.0
.bss 58544 58544 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63504 63504 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 137781 137781 0 0.0
.text 1473186 1473186 0 0.0
bridge-app debug+rpc (read only) 1326413 1326413 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112316 112316 0 0.0
.text 1116693 1116693 0 0.0
chip-tool debug (read only) 5867301 5867237 -64 -0.0
(read/write) 195496 195496 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 147872 147872 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 278122 278122 0 0.0
.text 5210149 5210085 -64 -0.0
lighting-app debug+rpc (read only) 1595521 1595521 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129937 129937 0 0.0
.text 1330578 1330578 0 0.0
ota-provider-app debug (read only) 1273961 1273961 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114335 114335 0 0.0
.text 1062034 1062034 0 0.0
ota-requestor-app debug (read only) 1370209 1370209 0 0.0
(read/write) 78912 78912 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26408 26408 0 0.0
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125736 125736 0 0.0
.text 1144098 1144098 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1888137 1888137 0 0.0
(read/write) 318520 318520 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158629 158629 0 0.0
.text 1584066 1584066 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290256 2290256 0 0.0
.bss 180308 180308 0 0.0
.data 5224 5224 0 0.0
.heap 850912 850912 0 0.0
.text 1252856 1252856 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274384 2274384 0 0.0
.bss 172204 172204 0 0.0
.data 5576 5576 0 0.0
.heap 858664 858664 0 0.0
.text 1236984 1236984 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250224 2250224 0 0.0
.bss 171092 171092 0 0.0
.data 5568 5568 0 0.0
.heap 859784 859784 0 0.0
.text 1212824 1212824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050544 2050544 0 0.0
.bss 156280 156280 0 0.0
.data 4968 4968 0 0.0
.heap 875200 875200 0 0.0
.text 1013144 1013144 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865267 865267 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 583200 583200 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827635 827635 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557368 557368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790306 790306 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512672 512672 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840651 840651 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563296 563296 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765954 765954 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492856 492856 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846791 846791 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567476 567476 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840351 840351 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562916 562916 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2303032 2303032 0 0.0
.bss 113280 113280 0 0.0
.data 2528 2528 0 0.0
.heap 917536 917536 0 0.0
.text 1261296 1261296 0 0.0
lock-app default (read/write) 2216232 2216232 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174496 1174496 0 0.0
qpg lighting-app qpg6100+debug (read only) 494312 494312 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488992 488992 0 0.0
lock-app qpg6100+debug (read only) 469268 469268 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463948 463948 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768682 768682 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533824 533824 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch 2 times, most recently from c93ae1e to f141678 Compare November 23, 2021 05:58
@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #11900: Size comparison from b83502b to f141678

Decreases (1 build for linux)
platform target config section b83502b f141678 change % change
linux chip-tool debug (read only) 5877581 5877533 -48 -0.0
.text 5218373 5218325 -48 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b83502b f141678 change % change
efr32 lighting-app BRD4161A (read only) 751936 751936 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117884 117884 0 0.0
.data 1808 1808 0 0.0
.text 751928 751928 0 0.0
BRD4161A+rpc (read only) 739428 739428 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134388 134388 0 0.0
.data 1932 1932 0 0.0
.text 739420 739420 0 0.0
lock-app BRD4161A (read only) 729008 729008 0 0.0
(read/write) 117476 117476 0 0.0
.bss 115708 115708 0 0.0
.data 1764 1764 0 0.0
.text 729000 729000 0 0.0
window-app BRD4161A (read only) 732456 732456 0 0.0
(read/write) 117836 117836 0 0.0
.bss 116060 116060 0 0.0
.data 1772 1772 0 0.0
.text 732448 732448 0 0.0
esp32 all-clusters-app c3devkit (read only) 833976 833976 0 0.0
(read/write) 1222154 1222154 0 0.0
.dram0.bss 57760 57760 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165040 165040 0 0.0
.flash.text 833976 833976 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 904991 904991 0 0.0
(read/write) 421448 421448 0 0.0
.dram0.bss 63120 63120 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 192984 192984 0 0.0
.flash.text 899607 899607 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708276 708276 0 0.0
.bss 77212 77212 0 0.0
.data 1920 1920 0 0.0
.text 623344 623344 0 0.0
lock-app k32w061+debug (read/write) 599716 599716 0 0.0
.bss 67724 67724 0 0.0
.data 1888 1888 0 0.0
.text 524304 524304 0 0.0
shell k32w061+debug (read/write) 665080 665080 0 0.0
.bss 78884 78884 0 0.0
.data 1856 1856 0 0.0
.text 578540 578540 0 0.0
linux all-clusters-app debug (read only) 1750609 1750609 0 0.0
(read/write) 128688 128688 0 0.0
.bss 58576 58576 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63760 63760 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 568 568 0 0.0
.rodata 138613 138613 0 0.0
.text 1475618 1475618 0 0.0
bridge-app debug+rpc (read only) 1330101 1330101 0 0.0
(read/write) 76760 76760 0 0.0
.bss 41552 41552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 28608 28608 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 113212 113212 0 0.0
.text 1118741 1118741 0 0.0
chip-tool debug (read only) 5877581 5877533 -48 -0.0
(read/write) 195936 195936 0 0.0
.bss 39896 39896 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 148192 148192 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 278842 278842 0 0.0
.text 5218373 5218325 -48 -0.0
lighting-app debug+rpc (read only) 1599241 1599241 0 0.0
(read/write) 109976 109976 0 0.0
.bss 47216 47216 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 56208 56208 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 130897 130897 0 0.0
.text 1332594 1332594 0 0.0
ota-provider-app debug (read only) 1280873 1280873 0 0.0
(read/write) 75376 75376 0 0.0
.bss 44128 44128 0 0.0
.data 800 800 0 0.0
.data.rel.ro 25336 25336 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 456 456 0 0.0
.rodata 114999 114999 0 0.0
.text 1067202 1067202 0 0.0
ota-requestor-app debug (read only) 1377457 1377457 0 0.0
(read/write) 79240 79240 0 0.0
.bss 46592 46592 0 0.0
.data 864 864 0 0.0
.data.rel.ro 26664 26664 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 126408 126408 0 0.0
.text 1149586 1149586 0 0.0
shell debug (read only) 804641 804641 0 0.0
(read/write) 66160 66160 0 0.0
.bss 23336 23336 0 0.0
.data 274 274 0 0.0
.data.rel.ro 38008 38008 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 352 352 0 0.0
.rodata 79279 79279 0 0.0
.text 620258 620258 0 0.0
tv-app debug (read only) 1892073 1892073 0 0.0
(read/write) 318832 318832 0 0.0
.bss 249848 249848 0 0.0
.data 2784 2784 0 0.0
.data.rel.ro 60520 60520 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159485 159485 0 0.0
.text 1586402 1586402 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290912 2290912 0 0.0
.bss 180308 180308 0 0.0
.data 5232 5232 0 0.0
.heap 850904 850904 0 0.0
.text 1253512 1253512 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275168 2275168 0 0.0
.bss 172212 172212 0 0.0
.data 5584 5584 0 0.0
.heap 858648 858648 0 0.0
.text 1237768 1237768 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251000 2251000 0 0.0
.bss 171092 171092 0 0.0
.data 5576 5576 0 0.0
.heap 859776 859776 0 0.0
.text 1213600 1213600 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156280 156280 0 0.0
.data 4976 4976 0 0.0
.heap 875192 875192 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 866003 866003 0 0.0
bss 110616 110616 0 0.0
rodata 96028 96028 0 0.0
text 583732 583732 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 828371 828371 0 0.0
bss 106972 106972 0 0.0
rodata 87212 87212 0 0.0
text 557900 557900 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 791042 791042 0 0.0
bss 111992 111992 0 0.0
rodata 91284 91284 0 0.0
text 513196 513196 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841415 841415 0 0.0
bss 109640 109640 0 0.0
rodata 92496 92496 0 0.0
text 563824 563824 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 766722 766722 0 0.0
bss 111052 111052 0 0.0
rodata 87804 87804 0 0.0
text 493384 493384 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847543 847543 0 0.0
bss 109780 109780 0 0.0
rodata 94208 94208 0 0.0
text 568008 568008 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841119 841119 0 0.0
bss 109676 109676 0 0.0
rodata 92456 92456 0 0.0
text 563444 563444 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778671 778671 0 0.0
bss 109160 109160 0 0.0
rodata 73196 73196 0 0.0
text 521696 521696 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693678 693678 0 0.0
bss 110144 110144 0 0.0
rodata 67840 67840 0 0.0
text 442304 442304 0 0.0
p6 all-clusters-app default (read/write) 2304216 2304216 0 0.0
.bss 113296 113296 0 0.0
.data 2536 2536 0 0.0
.heap 917512 917512 0 0.0
.text 1262480 1262480 0 0.0
lock-app default (read/write) 2217400 2217400 0 0.0
.bss 100952 100952 0 0.0
.data 2408 2408 0 0.0
.heap 929984 929984 0 0.0
.text 1175664 1175664 0 0.0
qpg lighting-app qpg6100+debug (read only) 495024 495024 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50264 50264 0 0.0
.data 1016 1016 0 0.0
.text 489704 489704 0 0.0
lock-app qpg6100+debug (read only) 469996 469996 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 972 972 0 0.0
.text 464676 464676 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769434 769434 0 0.0
bss 79136 79136 0 0.0
noinit 37160 37160 0 0.0
text 534348 534348 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch from f141678 to 4606be8 Compare November 24, 2021 05:10
@github-actions
Copy link

github-actions bot commented Nov 24, 2021 •
edited
Loading

PR #11900: Size comparison from 2e85d48 to 4606be8

Decreases (2 builds for linux)
platform target config section 2e85d48 4606be8 change % change
linux all-clusters-app debug (read only) 1752673 1752657 -16 -0.0
.text 1476178 1476162 -16 -0.0
chip-tool debug (read only) 5939053 5938989 -64 -0.0
.text 5272773 5272709 -64 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2e85d48 4606be8 change % change
efr32 lighting-app BRD4161A (read only) 754832 754832 0 0.0
(read/write) 119796 119796 0 0.0
.bss 117980 117980 0 0.0
.data 1812 1812 0 0.0
.text 754824 754824 0 0.0
BRD4161A+rpc (read only) 742292 742292 0 0.0
(read/write) 136420 136420 0 0.0
.bss 134484 134484 0 0.0
.data 1936 1936 0 0.0
.text 742284 742284 0 0.0
lock-app BRD4161A (read only) 730688 730688 0 0.0
(read/write) 117508 117508 0 0.0
.bss 115740 115740 0 0.0
.data 1768 1768 0 0.0
.text 730680 730680 0 0.0
window-app BRD4161A (read only) 734136 734136 0 0.0
(read/write) 117868 117868 0 0.0
.bss 116092 116092 0 0.0
.data 1776 1776 0 0.0
.text 734128 734128 0 0.0
esp32 all-clusters-app c3devkit (read only) 834242 834242 0 0.0
(read/write) 1222658 1222658 0 0.0
.dram0.bss 57832 57832 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165464 165464 0 0.0
.flash.text 834242 834242 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 905103 905103 0 0.0
(read/write) 421956 421956 0 0.0
.dram0.bss 63224 63224 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 193388 193388 0 0.0
.flash.text 899719 899719 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 710268 710268 0 0.0
.bss 77316 77316 0 0.0
.data 1924 1924 0 0.0
.text 625228 625228 0 0.0
lock-app k32w061+debug (read/write) 600480 600480 0 0.0
.bss 67756 67756 0 0.0
.data 1892 1892 0 0.0
.text 525032 525032 0 0.0
shell k32w061+debug (read/write) 665960 665960 0 0.0
.bss 78916 78916 0 0.0
.data 1860 1860 0 0.0
.text 579384 579384 0 0.0
linux all-clusters-app debug (read only) 1752673 1752657 -16 -0.0
(read/write) 129432 129432 0 0.0
.bss 58576 58576 0 0.0
.data 1138 1138 0 0.0
.data.rel.ro 64400 64400 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138485 138485 0 0.0
.text 1476178 1476162 -16 -0.0
bridge-app debug+rpc (read only) 1331405 1331405 0 0.0
(read/write) 77408 77408 0 0.0
.bss 41488 41488 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29200 29200 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113044 113044 0 0.0
.text 1118581 1118581 0 0.0
chip-tool debug (read only) 5939053 5938989 -64 -0.0
(read/write) 196776 196776 0 0.0
.bss 39896 39896 0 0.0
.data 2384 2384 0 0.0
.data.rel.ro 148936 148936 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 283922 283922 0 0.0
.text 5272773 5272709 -64 -0.0
lighting-app debug+rpc (read only) 1602017 1602017 0 0.0
(read/write) 110688 110688 0 0.0
.bss 47216 47216 0 0.0
.data 1330 1330 0 0.0
.data.rel.ro 56800 56800 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131409 131409 0 0.0
.text 1333202 1333202 0 0.0
ota-provider-app debug (read only) 1296153 1296153 0 0.0
(read/write) 75928 75928 0 0.0
.bss 44128 44128 0 0.0
.data 880 880 0 0.0
.data.rel.ro 25784 25784 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114831 114831 0 0.0
.text 1081282 1081282 0 0.0
ota-requestor-app debug (read only) 1392673 1392673 0 0.0
(read/write) 79792 79792 0 0.0
.bss 46592 46592 0 0.0
.data 944 944 0 0.0
.data.rel.ro 27112 27112 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126240 126240 0 0.0
.text 1163602 1163602 0 0.0
shell debug (read only) 820313 820313 0 0.0
(read/write) 66584 66584 0 0.0
.bss 23272 23272 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38440 38440 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79119 79119 0 0.0
.text 634770 634770 0 0.0
tv-app debug (read only) 1901081 1901081 0 0.0
(read/write) 319704 319704 0 0.0
.bss 249976 249976 0 0.0
.data 2880 2880 0 0.0
.data.rel.ro 61184 61184 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 159317 159317 0 0.0
.text 1593874 1593874 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293064 2293064 0 0.0
.bss 180388 180388 0 0.0
.data 5240 5240 0 0.0
.heap 850816 850816 0 0.0
.text 1255664 1255664 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2277344 2277344 0 0.0
.bss 172292 172292 0 0.0
.data 5592 5592 0 0.0
.heap 858560 858560 0 0.0
.text 1239944 1239944 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251664 2251664 0 0.0
.bss 171108 171108 0 0.0
.data 5576 5576 0 0.0
.heap 859760 859760 0 0.0
.text 1214264 1214264 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2051224 2051224 0 0.0
.bss 156320 156320 0 0.0
.data 4984 4984 0 0.0
.heap 875144 875144 0 0.0
.text 1013824 1013824 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 870183 870183 0 0.0
bss 112640 112640 0 0.0
rodata 96784 96784 0 0.0
text 585136 585136 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 832551 832551 0 0.0
bss 108992 108992 0 0.0
rodata 87968 87968 0 0.0
text 559304 559304 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795222 795222 0 0.0
bss 114012 114012 0 0.0
rodata 92040 92040 0 0.0
text 514600 514600 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 842299 842299 0 0.0
bss 109672 109672 0 0.0
rodata 92788 92788 0 0.0
text 564380 564380 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 767586 767586 0 0.0
bss 111084 111084 0 0.0
rodata 88076 88076 0 0.0
text 493936 493936 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 848407 848407 0 0.0
bss 109812 109812 0 0.0
rodata 94496 94496 0 0.0
text 568560 568560 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841999 841999 0 0.0
bss 109708 109708 0 0.0
rodata 92744 92744 0 0.0
text 564000 564000 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778907 778907 0 0.0
bss 109184 109184 0 0.0
rodata 73304 73304 0 0.0
text 521828 521828 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693962 693962 0 0.0
bss 110168 110168 0 0.0
rodata 67948 67948 0 0.0
text 442436 442436 0 0.0
p6 all-clusters-app default (read/write) 2306904 2306904 0 0.0
.bss 113376 113376 0 0.0
.data 2536 2536 0 0.0
.heap 917432 917432 0 0.0
.text 1265168 1265168 0 0.0
lock-app default (read/write) 2218904 2218904 0 0.0
.bss 100968 100968 0 0.0
.data 2416 2416 0 0.0
.heap 929960 929960 0 0.0
.text 1177168 1177168 0 0.0
qpg lighting-app qpg6100+debug (read only) 497012 497012 0 0.0
(read/write) 114140 114140 0 0.0
.bss 50360 50360 0 0.0
.data 1020 1020 0 0.0
.text 491692 491692 0 0.0
lock-app qpg6100+debug (read only) 470916 470916 0 0.0
(read/write) 114144 114144 0 0.0
.bss 49232 49232 0 0.0
.data 976 976 0 0.0
.text 465596 465596 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 771514 771514 0 0.0
bss 79216 79216 0 0.0
noinit 37160 37160 0 0.0
text 535570 535570 0 0.0

@bzbarsky-apple
Enable us to migrate enums to enum class one by one.
1eba811 
Introduces an explicit list of spec enums that are generated as not
enum class.  We can then drive this list down to 0.
@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch from 4606be8 to 1063c5a Compare November 29, 2021 17:32
@github-actions
Copy link

github-actions bot commented Nov 29, 2021 •
edited
Loading

PR #11900: Size comparison from 7d55d2e to 1063c5a

Decreases (1 build for linux)
platform target config section 7d55d2e 1063c5a change % change
linux chip-tool debug (read only) 6088629 6088565 -64 -0.0
.text 5406517 5406453 -64 -0.0
Full report (10 builds for linux, p6)
platform target config section 7d55d2e 1063c5a change % change
linux all-clusters-app debug (read only) 1775081 1775081 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138965 138965 0 0.0
.text 1497746 1497746 0 0.0
bridge-app debug+rpc (read only) 1349405 1349405 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1135717 1135717 0 0.0
chip-tool debug (read only) 6088629 6088565 -64 -0.0
(read/write) 198808 198808 0 0.0
.bss 40096 40096 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 152000 152000 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 292840 292840 0 0.0
.text 5406517 5406453 -64 -0.0
lighting-app debug+rpc (read only) 1629065 1629065 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131889 131889 0 0.0
.text 1359458 1359458 0 0.0
ota-provider-app debug (read only) 1310401 1310401 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1095154 1095154 0 0.0
ota-requestor-app debug (read only) 1406873 1406873 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1177330 1177330 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1921377 1921377 0 0.0
(read/write) 319072 319072 0 0.0
.bss 250264 250264 0 0.0
.data 1632 1632 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160872 160872 0 0.0
.text 1612162 1612162 0 0.0
p6 all-clusters-app default (read/write) 2311304 2311304 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269568 1269568 0 0.0
lock-app default (read/write) 2223120 2223120 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181384 1181384 0 0.0

@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch from 1063c5a to 80e1fa6 Compare November 29, 2021 18:17
@github-actions
Copy link

github-actions bot commented Nov 29, 2021 •
edited
Loading

PR #11900: Size comparison from 2bd6bd6 to 80e1fa6

Decreases (1 build for linux)
platform target config section 2bd6bd6 80e1fa6 change % change
linux chip-tool debug (read only) 6088437 6088389 -48 -0.0
.text 5406325 5406277 -48 -0.0
Full report (17 builds for esp32, linux, mbed, p6)
platform target config section 2bd6bd6 80e1fa6 change % change
esp32 all-clusters-app c3devkit (read only) 836536 836536 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836536 836536 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907919 907919 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902535 902535 0 0.0
.iram0.text 122943 122943 0 0.0
linux all-clusters-app debug (read only) 1775081 1775081 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138965 138965 0 0.0
.text 1497746 1497746 0 0.0
bridge-app debug+rpc (read only) 1349405 1349405 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1135717 1135717 0 0.0
chip-tool debug (read only) 6088437 6088389 -48 -0.0
(read/write) 198808 198808 0 0.0
.bss 40096 40096 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 152000 152000 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 292840 292840 0 0.0
.text 5406325 5406277 -48 -0.0
lighting-app debug+rpc (read only) 1629065 1629065 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131889 131889 0 0.0
.text 1359458 1359458 0 0.0
ota-provider-app debug (read only) 1310401 1310401 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1095154 1095154 0 0.0
ota-requestor-app debug (read only) 1406873 1406873 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1177330 1177330 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1921185 1921185 0 0.0
(read/write) 319072 319072 0 0.0
.bss 250264 250264 0 0.0
.data 1632 1632 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160872 160872 0 0.0
.text 1611970 1611970 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294976 2294976 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257576 1257576 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2280256 2280256 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242856 1242856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253336 2253336 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215936 1215936 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
p6 all-clusters-app default (read/write) 2311304 2311304 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269568 1269568 0 0.0
lock-app default (read/write) 2223120 2223120 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181384 1181384 0 0.0

vivien-apple
vivien-apple approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@vivien-apple vivien-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds pretty reasonable. I like the patch that allows what is currently in use, but do not let us introduce new weakly typed enum.

@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch from 80e1fa6 to b1f2245 Compare November 29, 2021 19:46
@bzbarsky-apple bzbarsky-apple force-pushed the enum-migration-piecemeal branch from b1f2245 to 0880b32 Compare November 29, 2021 20:00
@github-actions
Copy link

github-actions bot commented Nov 29, 2021 •
edited
Loading

PR #11900: Size comparison from 4bac98f to 0880b32

Decreases (1 build for linux)
platform target config section 4bac98f 0880b32 change % change
linux chip-tool debug (read only) 6090277 6090229 -48 -0.0
.text 5408037 5407989 -48 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 4bac98f 0880b32 change % change
efr32 lighting-app BRD4161A (read only) 762200 762200 0 0.0
(read/write) 119836 119836 0 0.0
.bss 118012 118012 0 0.0
.data 1820 1820 0 0.0
.text 762192 762192 0 0.0
BRD4161A+rpc (read only) 790632 790632 0 0.0
(read/write) 138132 138132 0 0.0
.bss 136212 136212 0 0.0
.data 1920 1920 0 0.0
.text 790624 790624 0 0.0
lock-app BRD4161A (read only) 736144 736144 0 0.0
(read/write) 117540 117540 0 0.0
.bss 115764 115764 0 0.0
.data 1776 1776 0 0.0
.text 736136 736136 0 0.0
window-app BRD4161A (read only) 739208 739208 0 0.0
(read/write) 117972 117972 0 0.0
.bss 116188 116188 0 0.0
.data 1784 1784 0 0.0
.text 739200 739200 0 0.0
esp32 all-clusters-app c3devkit (read only) 836536 836536 0 0.0
(read/write) 1224474 1224474 0 0.0
.dram0.bss 59144 59144 0 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165968 165968 0 0.0
.flash.text 836536 836536 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 907919 907919 0 0.0
(read/write) 423692 423692 0 0.0
.dram0.bss 64536 64536 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 193804 193804 0 0.0
.flash.text 902535 902535 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 723320 723320 0 0.0
.bss 78292 78292 0 0.0
.data 1956 1956 0 0.0
.text 637272 637272 0 0.0
lock-app k32w061+debug (read/write) 612392 612392 0 0.0
.bss 68740 68740 0 0.0
.data 1920 1920 0 0.0
.text 535932 535932 0 0.0
shell k32w061+debug (read/write) 677712 677712 0 0.0
.bss 79892 79892 0 0.0
.data 1892 1892 0 0.0
.text 590128 590128 0 0.0
linux all-clusters-app debug (read only) 1775081 1775081 0 0.0
(read/write) 131544 131544 0 0.0
.bss 60144 60144 0 0.0
.data 1170 1170 0 0.0
.data.rel.ro 64928 64928 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 576 576 0 0.0
.rodata 138965 138965 0 0.0
.text 1497746 1497746 0 0.0
bridge-app debug+rpc (read only) 1349405 1349405 0 0.0
(read/write) 77856 77856 0 0.0
.bss 41744 41744 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29384 29384 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 113596 113596 0 0.0
.text 1135717 1135717 0 0.0
chip-tool debug (read only) 6090277 6090229 -48 -0.0
(read/write) 198872 198872 0 0.0
.bss 40096 40096 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 152048 152048 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 496 496 0 0.0
.rodata 292808 292808 0 0.0
.text 5408037 5407989 -48 -0.0
lighting-app debug+rpc (read only) 1629065 1629065 0 0.0
(read/write) 111104 111104 0 0.0
.bss 47440 47440 0 0.0
.data 1362 1362 0 0.0
.data.rel.ro 56976 56976 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 131889 131889 0 0.0
.text 1359458 1359458 0 0.0
ota-provider-app debug (read only) 1310401 1310401 0 0.0
(read/write) 76312 76312 0 0.0
.bss 44320 44320 0 0.0
.data 912 912 0 0.0
.data.rel.ro 25944 25944 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 464 464 0 0.0
.rodata 114896 114896 0 0.0
.text 1095154 1095154 0 0.0
ota-requestor-app debug (read only) 1406873 1406873 0 0.0
(read/write) 80144 80144 0 0.0
.bss 46752 46752 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 488 488 0 0.0
.rodata 126400 126400 0 0.0
.text 1177330 1177330 0 0.0
shell debug (read only) 820321 820321 0 0.0
(read/write) 66936 66936 0 0.0
.bss 23496 23496 0 0.0
.data 338 338 0 0.0
.data.rel.ro 38560 38560 0 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 360 360 0 0.0
.rodata 79023 79023 0 0.0
.text 634610 634610 0 0.0
tv-app debug (read only) 1921185 1921185 0 0.0
(read/write) 319072 319072 0 0.0
.bss 250264 250264 0 0.0
.data 1632 1632 0 0.0
.data.rel.ro 61480 61480 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 160872 160872 0 0.0
.text 1611970 1611970 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294976 2294976 0 0.0
.bss 181884 181884 0 0.0
.data 5240 5240 0 0.0
.heap 849320 849320 0 0.0
.text 1257576 1257576 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2280256 2280256 0 0.0
.bss 172492 172492 0 0.0
.data 5600 5600 0 0.0
.heap 858352 858352 0 0.0
.text 1242856 1242856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2253336 2253336 0 0.0
.bss 171308 171308 0 0.0
.data 5584 5584 0 0.0
.heap 859552 859552 0 0.0
.text 1215936 1215936 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050936 0 0.0
.bss 156496 156496 0 0.0
.data 4984 4984 0 0.0
.heap 874968 874968 0 0.0
.text 1013536 1013536 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 875611 875611 0 0.0
bss 112660 112660 0 0.0
rodata 97188 97188 0 0.0
text 590116 590116 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 838187 838187 0 0.0
bss 109012 109012 0 0.0
rodata 88436 88436 0 0.0
text 564432 564432 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 800650 800650 0 0.0
bss 114036 114036 0 0.0
rodata 92444 92444 0 0.0
text 519580 519580 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 846539 846539 0 0.0
bss 109700 109700 0 0.0
rodata 92972 92972 0 0.0
text 568388 568388 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 771810 771810 0 0.0
bss 111108 111108 0 0.0
rodata 88260 88260 0 0.0
text 497940 497940 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 852511 852511 0 0.0
bss 109836 109836 0 0.0
rodata 94680 94680 0 0.0
text 572432 572432 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 845619 845619 0 0.0
bss 109712 109712 0 0.0
rodata 92844 92844 0 0.0
text 567512 567512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778447 778447 0 0.0
bss 109180 109180 0 0.0
rodata 73084 73084 0 0.0
text 521576 521576 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693482 693482 0 0.0
bss 110164 110164 0 0.0
rodata 67724 67724 0 0.0
text 442184 442184 0 0.0
p6 all-clusters-app default (read/write) 2311304 2311304 0 0.0
.bss 114688 114688 0 0.0
.data 2544 2544 0 0.0
.heap 916112 916112 0 0.0
.text 1269568 1269568 0 0.0
lock-app default (read/write) 2223120 2223120 0 0.0
.bss 100976 100976 0 0.0
.data 2416 2416 0 0.0
.heap 929952 929952 0 0.0
.text 1181384 1181384 0 0.0
qpg lighting-app qpg6100+debug (read only) 503096 503096 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50400 50400 0 0.0
.data 1024 1024 0 0.0
.text 497776 497776 0 0.0
lock-app qpg6100+debug (read only) 475804 475804 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 980 980 0 0.0
.text 470484 470484 0 0.0
persistent-storage-app qpg6100+debug (read only) 105424 105424 0 0.0
(read/write) 114138 114138 0 0.0
.bss 12002 12002 0 0.0
.data 276 276 0 0.0
.text 100104 100104 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 777398 777398 0 0.0
bss 79236 79236 0 0.0
noinit 37160 37160 0 0.0
text 540724 540724 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 489de97 into project-chip:master Nov 29, 2021
@bzbarsky-apple bzbarsky-apple deleted the enum-migration-piecemeal branch November 29, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app controller darwin lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzbarsky-apple @mrjerryjohns @yunhanw-google @vivien-apple @jmartinez-silabs @jmeg-sfy