-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Enable Write Group msg test case #11933
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:enable_group_msg_test_case
Nov 18, 2021
Merged
[Group] Enable Write Group msg test case #11933
jepenven-silabs
merged 1 commit into
project-chip:master
from
jepenven-silabs:enable_group_msg_test_case
Nov 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#11911connectedhomeip/src/transport/SessionManager.cpp Lines 122 to 132 in 3bc1bc3
This comment was generated by todo based on a
|
Replace the PeerNodeId with Our nodeIdconnectedhomeip/src/transport/SessionManager.cpp Lines 127 to 137 in 3bc1bc3
This comment was generated by todo based on a
|
PR #11933: Size comparison from e568d70 to 3bc1bc3 Increases (26 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
3bc1bc3
to
7acb800
Compare
PR #11933: Size comparison from 1359f6e to 7acb800 Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 18, 2021
andy31415
approved these changes
Nov 18, 2021
jmartinez-silabs
approved these changes
Nov 18, 2021
This was referenced Nov 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up of PR #11808
Change overview
Partial fix of #11078
Partial fix of #11604
Group Messaging test case isn't yet complete. We still need to enable the multicast IPV6 address and verify that the Group message reception is handled properly.
However, enabling it as soon as possible will allow us to detect PR that could possibly break the group communication.
Testing
Tested with the enabled test case and Unit test