-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an accessing fabric index to AttributeAccessInterface writes. #12040
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:attr-write-fabric
Nov 22, 2021
Merged
Add an accessing fabric index to AttributeAccessInterface writes. #12040
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:attr-write-fabric
Nov 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vivien-apple and
wbschiller
November 19, 2021 16:49
pullapprove
bot
requested review from
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
November 19, 2021 16:49
msandstedt
approved these changes
Nov 19, 2021
bzbarsky-apple
force-pushed
the
attr-write-fabric
branch
from
November 19, 2021 17:15
a74de4b
to
388d26b
Compare
PR #12040: Size comparison from 1adaf7a to 388d26b Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
We will need this for bindings.
bzbarsky-apple
force-pushed
the
attr-write-fabric
branch
from
November 19, 2021 19:37
388d26b
to
955c20b
Compare
PR #12040: Size comparison from 1adaf7a to 955c20b Increases (30 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
mrjerryjohns
approved these changes
Nov 20, 2021
fast track: domain owner created and checkmarked, has been up for sufficient time for all timezone review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need this for bindings.
Problem
No way to get fabric info in an AttributeAccessInterface write.
Change overview
Add GetAccessingFabricIndex on
AttributeValueDecoder
like we have forAttributeValueEncoder
Testing
Compiles. No consumers yet.