-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Group] Fix Group Write Attribute sending and receiving path #12052
[Group] Fix Group Write Attribute sending and receiving path #12052
Conversation
retrieve Endpoint ID with GroupDataProvider using GroupId and FabricIdconnectedhomeip/src/app/WriteHandler.cpp Lines 143 to 153 in 062a125
This comment was generated by todo based on a
|
#11911connectedhomeip/src/transport/SessionManager.cpp Lines 134 to 138 in 062a125
This comment was generated by todo based on a
|
PR #12052: Size comparison from 5bad4ed to 062a125 Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming my comments are addressed....
062a125
to
210151c
Compare
PR #12052: Size comparison from befd208 to 210151c Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Problem
Fix #11980
Fix #11604
Change overview
Enable the complete test case (Group Attribute Write + Unicast Read)
Testing
With the enabled yaml test case