Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group MRP parameters #12069

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Group MRP parameters #12069

merged 1 commit into from
Nov 23, 2021

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Nov 20, 2021

Problem

Passing MRP parameters as 2 int is hard to maintain.

Change overview

Group MRP parameters into ReliableMessageProtocolConfig class

Testing

Verified by unit-tests

@todo
Copy link

todo bot commented Nov 20, 2021

(#6652): This is a stub implementation, should be replaced by the real one when CASE and PASE is completed

connectedhomeip/src/transport/PairingSession.h

Lines 92 to 98 in 105366d

// TODO(#6652): This is a stub implementation, should be replaced by the real one when CASE and PASE is completed
return gDefaultMRPConfig;
}
virtual const char * GetI2RSessionInfo() const = 0;
virtual const char * GetR2ISessionInfo() const = 0;

This comment was generated by todo based on a TODO comment in 105366d in #12069. cc @kghost.

@restyled-io restyled-io bot mentioned this pull request Nov 20, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 20, 2021 •
edited
Loading

PR #12069: Size comparison from 55349a5 to 105366d

Increases above 0.2%:

platform target config section 55349a5 105366d change % change
efr32 lighting-app BRD4161A .data 1800 1804 4 0.2
BRD4161A+rpc .data 1924 1928 4 0.2
lock-app BRD4161A .data 1756 1760 4 0.2
window-app BRD4161A .data 1760 1764 4 0.2
linux all-clusters-app debug .init_array 560 568 8 1.4
bridge-app debug+rpc .init_array 408 416 8 2.0
chip-tool debug .init_array 472 480 8 1.7
lighting-app debug+rpc .init_array 536 544 8 1.5
ota-provider-app debug .init_array 448 456 8 1.8
ota-requestor-app debug .init_array 472 480 8 1.7
shell debug .init_array 344 352 8 2.3
tv-app debug .init_array 616 624 8 1.3
p6 lock-app default .data 2400 2408 8 0.3
qpg lighting-app qpg6100+debug .data 1008 1012 4 0.4
lock-app qpg6100+debug .data 964 968 4 0.4
Increases (17 builds for efr32, linux, p6, qpg, telink)
platform target config section 55349a5 105366d change % change
efr32 lighting-app BRD4161A (read only) 750544 750552 8 0.0
(read/write) 119692 119724 32 0.0
.bss 117892 117916 24 0.0
.data 1800 1804 4 0.2
.text 750536 750544 8 0.0
BRD4161A+rpc (read only) 738068 738076 8 0.0
(read/write) 136320 136348 28 0.0
.bss 134396 134420 24 0.0
.data 1924 1928 4 0.2
.text 738060 738068 8 0.0
lock-app BRD4161A (read only) 727600 727624 24 0.0
(read/write) 113380 113404 24 0.0
.bss 111620 111644 24 0.0
.data 1756 1760 4 0.2
.text 727592 727616 24 0.0
window-app BRD4161A (read only) 728584 728608 24 0.0
(read/write) 113700 113732 32 0.0
.bss 111940 111964 24 0.0
.data 1760 1764 4 0.2
.text 728576 728600 24 0.0
linux all-clusters-app debug (read only) 1745561 1746193 632 0.0
(read/write) 128392 128496 104 0.1
.bss 58544 58608 64 0.1
.data.rel.ro 63504 63536 32 0.1
.init_array 560 568 8 1.4
.text 1472434 1473202 768 0.1
bridge-app debug+rpc (read/write) 76432 76504 72 0.1
.bss 41520 41552 32 0.1
.data.rel.ro 28352 28384 32 0.1
.init_array 408 416 8 2.0
chip-tool debug (read only) 4999237 5000093 856 0.0
(read/write) 165960 166064 104 0.1
.bss 39848 39912 64 0.2
.data.rel.ro 118352 118384 32 0.0
.init_array 472 480 8 1.7
.text 4419349 4420309 960 0.0
lighting-app debug+rpc (read only) 1594465 1595017 552 0.0
(read/write) 109616 109720 104 0.1
.bss 47152 47216 64 0.1
.data.rel.ro 55920 55952 32 0.1
.init_array 536 544 8 1.5
.text 1329810 1330498 688 0.1
ota-provider-app debug (read only) 1272905 1273553 648 0.1
(read/write) 75048 75152 104 0.1
.bss 44096 44160 64 0.1
.data.rel.ro 25080 25112 32 0.1
.init_array 448 456 8 1.8
.text 1061266 1062050 784 0.1
ota-requestor-app debug (read only) 1369153 1369721 568 0.0
(read/write) 78912 79016 104 0.1
.bss 46560 46624 64 0.1
.data.rel.ro 26408 26440 32 0.1
.init_array 472 480 8 1.7
.text 1143330 1144034 704 0.1
shell debug (read only) 799185 800249 1064 0.1
(read/write) 65832 65872 40 0.1
.bss 23336 23368 32 0.1
.data.rel.ro 37752 37768 16 0.0
.init_array 344 352 8 2.3
.text 616466 617682 1216 0.2
tv-app debug (read only) 1887129 1887857 728 0.0
(read/write) 318520 318720 200 0.1
.bss 249800 249960 160 0.1
.data.rel.ro 60264 60296 32 0.1
.init_array 616 624 8 1.3
.text 1583314 1584146 832 0.1
p6 all-clusters-app default .bss 113280 113288 8 0.0
lock-app default .bss 100944 100952 8 0.0
.data 2400 2408 8 0.3
qpg lighting-app qpg6100+debug (read only) 494152 494244 92 0.0
.bss 50256 50280 24 0.0
.data 1008 1012 4 0.4
.text 488832 488924 92 0.0
lock-app qpg6100+debug (read only) 469108 469208 100 0.0
(read/write) 114140 114144 4 0.0
.bss 49200 49224 24 0.0
.data 964 968 4 0.4
.text 463788 463888 100 0.0
telink lighting-app tlsr9518adk80d (read/write) 768482 768526 44 0.0
bss 79116 79124 8 0.0
text 533624 533630 6 0.0
Decreases (11 builds for linux, p6, qpg)
platform target config section 55349a5 105366d change % change
linux all-clusters-app debug .rodata 137493 137237 -256 -0.2
bridge-app debug+rpc (read only) 1325357 1325157 -200 -0.0
.rodata 112028 111932 -96 -0.1
.text 1115925 1115701 -224 -0.0
chip-tool debug .rodata 269738 269514 -224 -0.1
lighting-app debug+rpc .rodata 129649 129393 -256 -0.2
ota-provider-app debug .rodata 114047 113791 -256 -0.2
ota-requestor-app debug .rodata 125448 125192 -256 -0.2
shell debug .rodata 78703 78479 -224 -0.3
tv-app debug .rodata 158373 158149 -224 -0.1
p6 all-clusters-app default (read/write) 2302824 2302656 -168 -0.0
.heap 917536 917528 -8 -0.0
.text 1261088 1260920 -168 -0.0
lock-app default (read/write) 2216040 2215872 -168 -0.0
.heap 930000 929984 -16 -0.0
.text 1174304 1174136 -168 -0.0
qpg lighting-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
Full report (18 builds for efr32, linux, p6, qpg, telink)
platform target config section 55349a5 105366d change % change
efr32 lighting-app BRD4161A (read only) 750544 750552 8 0.0
(read/write) 119692 119724 32 0.0
.bss 117892 117916 24 0.0
.data 1800 1804 4 0.2
.text 750536 750544 8 0.0
BRD4161A+rpc (read only) 738068 738076 8 0.0
(read/write) 136320 136348 28 0.0
.bss 134396 134420 24 0.0
.data 1924 1928 4 0.2
.text 738060 738068 8 0.0
lock-app BRD4161A (read only) 727600 727624 24 0.0
(read/write) 113380 113404 24 0.0
.bss 111620 111644 24 0.0
.data 1756 1760 4 0.2
.text 727592 727616 24 0.0
window-app BRD4161A (read only) 728584 728608 24 0.0
(read/write) 113700 113732 32 0.0
.bss 111940 111964 24 0.0
.data 1760 1764 4 0.2
.text 728576 728600 24 0.0
linux all-clusters-app debug (read only) 1745561 1746193 632 0.0
(read/write) 128392 128496 104 0.1
.bss 58544 58608 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 63504 63536 32 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 568 8 1.4
.rodata 137493 137237 -256 -0.2
.text 1472434 1473202 768 0.1
bridge-app debug+rpc (read only) 1325357 1325157 -200 -0.0
(read/write) 76432 76504 72 0.1
.bss 41520 41552 32 0.1
.data 1568 1568 0 0.0
.data.rel.ro 28352 28384 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 416 8 2.0
.rodata 112028 111932 -96 -0.1
.text 1115925 1115701 -224 -0.0
chip-tool debug (read only) 4999237 5000093 856 0.0
(read/write) 165960 166064 104 0.1
.bss 39848 39912 64 0.2
.data 2272 2272 0 0.0
.data.rel.ro 118352 118384 32 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 480 8 1.7
.rodata 269738 269514 -224 -0.1
.text 4419349 4420309 960 0.0
lighting-app debug+rpc (read only) 1594465 1595017 552 0.0
(read/write) 109616 109720 104 0.1
.bss 47152 47216 64 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55920 55952 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 544 8 1.5
.rodata 129649 129393 -256 -0.2
.text 1329810 1330498 688 0.1
ota-provider-app debug (read only) 1272905 1273553 648 0.1
(read/write) 75048 75152 104 0.1
.bss 44096 44160 64 0.1
.data 784 784 0 0.0
.data.rel.ro 25080 25112 32 0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 456 8 1.8
.rodata 114047 113791 -256 -0.2
.text 1061266 1062050 784 0.1
ota-requestor-app debug (read only) 1369153 1369721 568 0.0
(read/write) 78912 79016 104 0.1
.bss 46560 46624 64 0.1
.data 848 848 0 0.0
.data.rel.ro 26408 26440 32 0.1
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 480 8 1.7
.rodata 125448 125192 -256 -0.2
.text 1143330 1144034 704 0.1
shell debug (read only) 799185 800249 1064 0.1
(read/write) 65832 65872 40 0.1
.bss 23336 23368 32 0.1
.data 242 242 0 0.0
.data.rel.ro 37752 37768 16 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 352 8 2.3
.rodata 78703 78479 -224 -0.3
.text 616466 617682 1216 0.2
tv-app debug (read only) 1887129 1887857 728 0.0
(read/write) 318520 318720 200 0.1
.bss 249800 249960 160 0.1
.data 2768 2768 0 0.0
.data.rel.ro 60264 60296 32 0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 624 8 1.3
.rodata 158373 158149 -224 -0.1
.text 1583314 1584146 832 0.1
p6 all-clusters-app default (read/write) 2302824 2302656 -168 -0.0
.bss 113280 113288 8 0.0
.data 2528 2528 0 0.0
.heap 917536 917528 -8 -0.0
.text 1261088 1260920 -168 -0.0
lock-app default (read/write) 2216040 2215872 -168 -0.0
.bss 100944 100952 8 0.0
.data 2400 2408 8 0.3
.heap 930000 929984 -16 -0.0
.text 1174304 1174136 -168 -0.0
qpg lighting-app qpg6100+debug (read only) 494152 494244 92 0.0
(read/write) 114144 114140 -4 -0.0
.bss 50256 50280 24 0.0
.data 1008 1012 4 0.4
.text 488832 488924 92 0.0
lock-app qpg6100+debug (read only) 469108 469208 100 0.0
(read/write) 114140 114144 4 0.0
.bss 49200 49224 24 0.0
.data 964 968 4 0.4
.text 463788 463888 100 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768482 768526 44 0.0
bss 79116 79124 8 0.0
noinit 37160 37160 0 0.0
text 533624 533630 6 0.0

@github-actions
Copy link

github-actions bot commented Nov 20, 2021 •
edited
Loading

PR #12069: Size comparison from 55349a5 to 8f22514

Increases above 0.2%:

platform target config section 55349a5 8f22514 change % change
linux all-clusters-app debug .init_array 560 568 8 1.4
bridge-app debug+rpc .init_array 408 416 8 2.0
chip-tool debug .init_array 472 480 8 1.7
lighting-app debug+rpc .init_array 536 544 8 1.5
ota-provider-app debug .init_array 448 456 8 1.8
ota-requestor-app debug .init_array 472 480 8 1.7
shell debug .init_array 344 352 8 2.3
tv-app debug .init_array 616 624 8 1.3
p6 lock-app default .data 2400 2408 8 0.3
qpg lighting-app qpg6100+debug .data 1008 1012 4 0.4
lock-app qpg6100+debug .data 964 968 4 0.4
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 55349a5 8f22514 change % change
efr32 lighting-app BRD4161A (read only) 750544 750584 40 0.0
(read/write) 119692 119724 32 0.0
.bss 117892 117916 24 0.0
.data 1800 1804 4 0.2
.text 750536 750576 40 0.0
BRD4161A+rpc (read only) 738068 738108 40 0.0
(read/write) 136320 136348 28 0.0
.bss 134396 134420 24 0.0
.data 1924 1928 4 0.2
.text 738060 738100 40 0.0
lock-app BRD4161A (read only) 727600 727656 56 0.0
(read/write) 113380 113404 24 0.0
.bss 111620 111644 24 0.0
.data 1756 1760 4 0.2
.text 727592 727648 56 0.0
window-app BRD4161A (read only) 728584 728640 56 0.0
(read/write) 113700 113732 32 0.0
.bss 111940 111964 24 0.0
.data 1760 1764 4 0.2
.text 728576 728632 56 0.0
esp32 all-clusters-app c3devkit (read/write) 1221210 1221242 32 0.0
.dram0.bss 57696 57704 8 0.0
.flash.rodata 164176 164192 16 0.0
m5stack (read/write) 420536 420588 52 0.0
.dram0.bss 63056 63096 40 0.1
.flash.rodata 192144 192156 12 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707384 707400 16 0.0
.bss 77212 77236 24 0.0
.data 1912 1916 4 0.2
lock-app k32w061+debug .bss 67716 67740 24 0.0
.data 1880 1884 4 0.2
shell k32w061+debug (read/write) 664192 664212 20 0.0
.bss 78876 78900 24 0.0
.data 1848 1852 4 0.2
linux all-clusters-app debug (read only) 1745561 1746241 680 0.0
(read/write) 128392 128496 104 0.1
.bss 58544 58608 64 0.1
.data.rel.ro 63504 63536 32 0.1
.init_array 560 568 8 1.4
.text 1472434 1473250 816 0.1
bridge-app debug+rpc (read/write) 76432 76504 72 0.1
.bss 41520 41552 32 0.1
.data.rel.ro 28352 28384 32 0.1
.init_array 408 416 8 2.0
chip-tool debug (read only) 4999237 5000141 904 0.0
(read/write) 165960 166064 104 0.1
.bss 39848 39912 64 0.2
.data.rel.ro 118352 118384 32 0.0
.init_array 472 480 8 1.7
.text 4419349 4420357 1008 0.0
lighting-app debug+rpc (read only) 1594465 1595065 600 0.0
(read/write) 109616 109720 104 0.1
.bss 47152 47216 64 0.1
.data.rel.ro 55920 55952 32 0.1
.init_array 536 544 8 1.5
.text 1329810 1330546 736 0.1
ota-provider-app debug (read only) 1272905 1273601 696 0.1
(read/write) 75048 75152 104 0.1
.bss 44096 44160 64 0.1
.data.rel.ro 25080 25112 32 0.1
.init_array 448 456 8 1.8
.text 1061266 1062098 832 0.1
ota-requestor-app debug (read only) 1369153 1369769 616 0.0
(read/write) 78912 79016 104 0.1
.bss 46560 46624 64 0.1
.data.rel.ro 26408 26440 32 0.1
.init_array 472 480 8 1.7
.text 1143330 1144082 752 0.1
shell debug (read only) 799185 800249 1064 0.1
(read/write) 65832 65872 40 0.1
.bss 23336 23368 32 0.1
.data.rel.ro 37752 37768 16 0.0
.init_array 344 352 8 2.3
.text 616466 617682 1216 0.2
tv-app debug (read only) 1887129 1887921 792 0.0
(read/write) 318520 318720 200 0.1
.bss 249800 249960 160 0.1
.data.rel.ro 60264 60296 32 0.1
.init_array 616 624 8 1.3
.text 1583314 1584210 896 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 180300 180308 8 0.0
.data 5224 5232 8 0.2
lighting-app CY8CPROTO_062_4343W+release .bss 172196 172204 8 0.0
.data 5576 5584 8 0.1
lock-app CY8CPROTO_062_4343W+release .bss 171084 171092 8 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2050480 2050536 56 0.0
.bss 156272 156312 40 0.0
.data 4968 4976 8 0.2
.text 1013080 1013136 56 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865107 865167 60 0.0
bss 110604 110628 24 0.0
rodata 95828 95840 12 0.0
text 583048 583060 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 827475 827535 60 0.0
bss 106960 106984 24 0.0
rodata 87012 87024 12 0.0
text 557216 557228 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790162 790222 60 0.0
bss 111980 112004 24 0.0
rodata 91084 91096 12 0.0
text 512520 512532 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840507 840567 60 0.0
bss 109628 109652 24 0.0
rodata 92300 92312 12 0.0
text 563144 563156 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765810 765854 44 0.0
bss 111040 111064 24 0.0
text 492708 492720 12 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846647 846675 28 0.0
bss 109768 109792 24 0.0
rodata 94008 94020 12 0.0
text 567324 567336 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840207 840267 60 0.0
bss 109664 109688 24 0.0
rodata 92256 92268 12 0.0
text 562764 562776 12 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778071 68 0.0
bss 109112 109136 24 0.0
rodata 73064 73068 4 0.0
text 521244 521272 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693126 68 0.0
bss 110096 110120 24 0.0
rodata 67708 67712 4 0.0
text 441856 441884 28 0.0
p6 all-clusters-app default .bss 113280 113288 8 0.0
lock-app default .bss 100944 100952 8 0.0
.data 2400 2408 8 0.3
qpg lighting-app qpg6100+debug (read only) 494152 494244 92 0.0
.bss 50256 50280 24 0.0
.data 1008 1012 4 0.4
.text 488832 488924 92 0.0
lock-app qpg6100+debug (read only) 469108 469208 100 0.0
(read/write) 114140 114144 4 0.0
.bss 49200 49224 24 0.0
.data 964 968 4 0.4
.text 463788 463888 100 0.0
telink lighting-app tlsr9518adk80d (read/write) 768482 768526 44 0.0
bss 79116 79124 8 0.0
text 533624 533630 6 0.0
Decreases (21 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
platform target config section 55349a5 8f22514 change % change
esp32 all-clusters-app c3devkit (read only) 831668 831494 -174 -0.0
.flash.text 831668 831494 -174 -0.0
m5stack (read only) 902739 902671 -68 -0.0
.flash.text 897355 897287 -68 -0.0
k32w lighting-app k32w061+se05x+release .text 622460 622448 -12 -0.0
lock-app k32w061+debug (read/write) 598816 598736 -80 -0.0
.text 523420 523312 -108 -0.0
shell k32w061+debug .text 577668 577660 -8 -0.0
linux all-clusters-app debug .rodata 137493 137237 -256 -0.2
bridge-app debug+rpc (read only) 1325357 1325205 -152 -0.0
.rodata 112028 111932 -96 -0.1
.text 1115925 1115749 -176 -0.0
chip-tool debug .rodata 269738 269514 -224 -0.1
lighting-app debug+rpc .rodata 129649 129393 -256 -0.2
ota-provider-app debug .rodata 114047 113791 -256 -0.2
ota-requestor-app debug .rodata 125448 125192 -256 -0.2
shell debug .rodata 78703 78479 -224 -0.3
tv-app debug .rodata 158373 158149 -224 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2289872 2289752 -120 -0.0
.heap 850920 850904 -16 -0.0
.text 1252472 1252352 -120 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274064 2273880 -184 -0.0
.heap 858672 858656 -16 -0.0
.text 1236664 1236480 -184 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2249904 2249712 -192 -0.0
.heap 859792 859784 -8 -0.0
.text 1212504 1212312 -192 -0.0
shell CY8CPROTO_062_4343W+release .heap 875208 875160 -48 -0.0
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 87604 87600 -4 -0.0
p6 all-clusters-app default (read/write) 2302824 2302688 -136 -0.0
.heap 917536 917528 -8 -0.0
.text 1261088 1260952 -136 -0.0
lock-app default (read/write) 2216040 2215888 -152 -0.0
.heap 930000 929984 -16 -0.0
.text 1174304 1174152 -152 -0.0
qpg lighting-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 55349a5 8f22514 change % change
efr32 lighting-app BRD4161A (read only) 750544 750584 40 0.0
(read/write) 119692 119724 32 0.0
.bss 117892 117916 24 0.0
.data 1800 1804 4 0.2
.text 750536 750576 40 0.0
BRD4161A+rpc (read only) 738068 738108 40 0.0
(read/write) 136320 136348 28 0.0
.bss 134396 134420 24 0.0
.data 1924 1928 4 0.2
.text 738060 738100 40 0.0
lock-app BRD4161A (read only) 727600 727656 56 0.0
(read/write) 113380 113404 24 0.0
.bss 111620 111644 24 0.0
.data 1756 1760 4 0.2
.text 727592 727648 56 0.0
window-app BRD4161A (read only) 728584 728640 56 0.0
(read/write) 113700 113732 32 0.0
.bss 111940 111964 24 0.0
.data 1760 1764 4 0.2
.text 728576 728632 56 0.0
esp32 all-clusters-app c3devkit (read only) 831668 831494 -174 -0.0
(read/write) 1221210 1221242 32 0.0
.dram0.bss 57696 57704 8 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 164176 164192 16 0.0
.flash.text 831668 831494 -174 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 902739 902671 -68 -0.0
(read/write) 420536 420588 52 0.0
.dram0.bss 63056 63096 40 0.1
.dram0.data 34056 34056 0 0.0
.flash.rodata 192144 192156 12 0.0
.flash.text 897355 897287 -68 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707384 707400 16 0.0
.bss 77212 77236 24 0.0
.data 1912 1916 4 0.2
.text 622460 622448 -12 -0.0
lock-app k32w061+debug (read/write) 598816 598736 -80 -0.0
.bss 67716 67740 24 0.0
.data 1880 1884 4 0.2
.text 523420 523312 -108 -0.0
shell k32w061+debug (read/write) 664192 664212 20 0.0
.bss 78876 78900 24 0.0
.data 1848 1852 4 0.2
.text 577668 577660 -8 -0.0
linux all-clusters-app debug (read only) 1745561 1746241 680 0.0
(read/write) 128392 128496 104 0.1
.bss 58544 58608 64 0.1
.data 1042 1042 0 0.0
.data.rel.ro 63504 63536 32 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 568 8 1.4
.rodata 137493 137237 -256 -0.2
.text 1472434 1473250 816 0.1
bridge-app debug+rpc (read only) 1325357 1325205 -152 -0.0
(read/write) 76432 76504 72 0.1
.bss 41520 41552 32 0.1
.data 1568 1568 0 0.0
.data.rel.ro 28352 28384 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 416 8 2.0
.rodata 112028 111932 -96 -0.1
.text 1115925 1115749 -176 -0.0
chip-tool debug (read only) 4999237 5000141 904 0.0
(read/write) 165960 166064 104 0.1
.bss 39848 39912 64 0.2
.data 2272 2272 0 0.0
.data.rel.ro 118352 118384 32 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 480 8 1.7
.rodata 269738 269514 -224 -0.1
.text 4419349 4420357 1008 0.0
lighting-app debug+rpc (read only) 1594465 1595065 600 0.0
(read/write) 109616 109720 104 0.1
.bss 47152 47216 64 0.1
.data 1234 1234 0 0.0
.data.rel.ro 55920 55952 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 544 8 1.5
.rodata 129649 129393 -256 -0.2
.text 1329810 1330546 736 0.1
ota-provider-app debug (read only) 1272905 1273601 696 0.1
(read/write) 75048 75152 104 0.1
.bss 44096 44160 64 0.1
.data 784 784 0 0.0
.data.rel.ro 25080 25112 32 0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 456 8 1.8
.rodata 114047 113791 -256 -0.2
.text 1061266 1062098 832 0.1
ota-requestor-app debug (read only) 1369153 1369769 616 0.0
(read/write) 78912 79016 104 0.1
.bss 46560 46624 64 0.1
.data 848 848 0 0.0
.data.rel.ro 26408 26440 32 0.1
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 480 8 1.7
.rodata 125448 125192 -256 -0.2
.text 1143330 1144082 752 0.1
shell debug (read only) 799185 800249 1064 0.1
(read/write) 65832 65872 40 0.1
.bss 23336 23368 32 0.1
.data 242 242 0 0.0
.data.rel.ro 37752 37768 16 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 352 8 2.3
.rodata 78703 78479 -224 -0.3
.text 616466 617682 1216 0.2
tv-app debug (read only) 1887129 1887921 792 0.0
(read/write) 318520 318720 200 0.1
.bss 249800 249960 160 0.1
.data 2768 2768 0 0.0
.data.rel.ro 60264 60296 32 0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 624 8 1.3
.rodata 158373 158149 -224 -0.1
.text 1583314 1584210 896 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2289872 2289752 -120 -0.0
.bss 180300 180308 8 0.0
.data 5224 5232 8 0.2
.heap 850920 850904 -16 -0.0
.text 1252472 1252352 -120 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274064 2273880 -184 -0.0
.bss 172196 172204 8 0.0
.data 5576 5584 8 0.1
.heap 858672 858656 -16 -0.0
.text 1236664 1236480 -184 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2249904 2249712 -192 -0.0
.bss 171084 171092 8 0.0
.data 5568 5568 0 0.0
.heap 859792 859784 -8 -0.0
.text 1212504 1212312 -192 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050536 56 0.0
.bss 156272 156312 40 0.0
.data 4968 4976 8 0.2
.heap 875208 875160 -48 -0.0
.text 1013080 1013136 56 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865107 865167 60 0.0
bss 110604 110628 24 0.0
rodata 95828 95840 12 0.0
text 583048 583060 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 827475 827535 60 0.0
bss 106960 106984 24 0.0
rodata 87012 87024 12 0.0
text 557216 557228 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790162 790222 60 0.0
bss 111980 112004 24 0.0
rodata 91084 91096 12 0.0
text 512520 512532 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840507 840567 60 0.0
bss 109628 109652 24 0.0
rodata 92300 92312 12 0.0
text 563144 563156 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765810 765854 44 0.0
bss 111040 111064 24 0.0
rodata 87604 87600 -4 -0.0
text 492708 492720 12 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846647 846675 28 0.0
bss 109768 109792 24 0.0
rodata 94008 94020 12 0.0
text 567324 567336 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840207 840267 60 0.0
bss 109664 109688 24 0.0
rodata 92256 92268 12 0.0
text 562764 562776 12 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778071 68 0.0
bss 109112 109136 24 0.0
rodata 73064 73068 4 0.0
text 521244 521272 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693126 68 0.0
bss 110096 110120 24 0.0
rodata 67708 67712 4 0.0
text 441856 441884 28 0.0
p6 all-clusters-app default (read/write) 2302824 2302688 -136 -0.0
.bss 113280 113288 8 0.0
.data 2528 2528 0 0.0
.heap 917536 917528 -8 -0.0
.text 1261088 1260952 -136 -0.0
lock-app default (read/write) 2216040 2215888 -152 -0.0
.bss 100944 100952 8 0.0
.data 2400 2408 8 0.3
.heap 930000 929984 -16 -0.0
.text 1174304 1174152 -152 -0.0
qpg lighting-app qpg6100+debug (read only) 494152 494244 92 0.0
(read/write) 114144 114140 -4 -0.0
.bss 50256 50280 24 0.0
.data 1008 1012 4 0.4
.text 488832 488924 92 0.0
lock-app qpg6100+debug (read only) 469108 469208 100 0.0
(read/write) 114140 114144 4 0.0
.bss 49200 49224 24 0.0
.data 964 968 4 0.4
.text 463788 463888 100 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768482 768526 44 0.0
bss 79116 79124 8 0.0
noinit 37160 37160 0 0.0
text 533624 533630 6 0.0

@kghost kghost mentioned this pull request Nov 20, 2021
Merged
andy31415
andy31415 reviewed Nov 22, 2021
View reviewed changes
src/lib/core/Optional.h Outdated Show resolved Hide resolved
@andy31415
Copy link
Contributor

@kghost - one comment left (minor) and merge conflicts

@todo
Copy link

todo bot commented Nov 23, 2021

move following 5 functions into SessionHandle once we can access session vars w/o using a SessionManager

connectedhomeip/src/messaging/ExchangeContext.h

Lines 169 to 172 in ae9a662

// TODO: move following 5 functions into SessionHandle once we can access session vars w/o using a SessionManager
/*
* Get the overall acknowledge timeout period for the underneath transport(MRP+UDP/TCP)
*/

This comment was generated by todo based on a TODO comment in ae9a662 in #12069. cc @kghost.

@restyled-io restyled-io bot mentioned this pull request Nov 23, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 23, 2021 •
edited
Loading

PR #12069: Size comparison from 71a3fb2 to 92435e1

Increases above 0.2%:

platform target config section 71a3fb2 92435e1 change % change
linux all-clusters-app debug .init_array 568 576 8 1.4
bridge-app debug+rpc .init_array 416 424 8 1.9
chip-tool debug .init_array 480 488 8 1.7
lighting-app debug+rpc .init_array 544 552 8 1.5
ota-provider-app debug .init_array 456 464 8 1.8
ota-requestor-app debug .init_array 480 488 8 1.7
shell debug .init_array 352 360 8 2.3
tv-app debug .init_array 624 632 8 1.3
p6 lock-app default .data 2408 2416 8 0.3
qpg lighting-app qpg6100+debug .data 1016 1020 4 0.4
lock-app qpg6100+debug .data 972 976 4 0.4
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 71a3fb2 92435e1 change % change
efr32 lighting-app BRD4161A (read only) 752544 752584 40 0.0
(read/write) 119756 119788 32 0.0
.bss 117948 117972 24 0.0
.data 1808 1812 4 0.2
.text 752536 752576 40 0.0
BRD4161A+rpc (read only) 740028 740068 40 0.0
(read/write) 136384 136412 28 0.0
.bss 134452 134476 24 0.0
.data 1932 1936 4 0.2
.text 740020 740060 40 0.0
lock-app BRD4161A (read only) 729544 729600 56 0.0
(read/write) 117476 117500 24 0.0
.bss 115708 115732 24 0.0
.data 1764 1768 4 0.2
.text 729536 729592 56 0.0
window-app BRD4161A (read only) 732992 733048 56 0.0
(read/write) 117836 117860 24 0.0
.bss 116060 116084 24 0.0
.data 1772 1776 4 0.2
.text 732984 733040 56 0.0
esp32 all-clusters-app c3devkit (read/write) 1222314 1222354 40 0.0
.dram0.bss 57824 57832 8 0.0
.flash.rodata 165136 165160 24 0.0
m5stack (read/write) 421600 421652 52 0.0
.dram0.bss 63184 63224 40 0.1
.flash.rodata 193072 193084 12 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708668 708684 16 0.0
.bss 77284 77308 24 0.0
.data 1920 1924 4 0.2
lock-app k32w061+debug .bss 67724 67748 24 0.0
.data 1888 1892 4 0.2
shell k32w061+debug (read/write) 665380 665416 36 0.0
.bss 78884 78908 24 0.0
.data 1856 1860 4 0.2
.text 578840 578848 8 0.0
linux all-clusters-app debug (read only) 1751433 1752161 728 0.0
(read/write) 128880 128952 72 0.1
.bss 58640 58672 32 0.1
.data.rel.ro 63888 63920 32 0.1
.init_array 568 576 8 1.4
.text 1476162 1476994 832 0.1
bridge-app debug+rpc (read/write) 76856 76896 40 0.1
.data.rel.ro 28688 28720 32 0.1
.init_array 416 424 8 1.9
chip-tool debug (read only) 5914389 5915277 888 0.0
(read/write) 196032 196136 104 0.1
.bss 39896 39960 64 0.2
.data.rel.ro 148272 148304 32 0.0
.init_array 480 488 8 1.7
.text 5249957 5250949 992 0.0
lighting-app debug+rpc (read only) 1600809 1601521 712 0.0
(read/write) 110136 110208 72 0.1
.bss 47280 47312 32 0.1
.data.rel.ro 56304 56336 32 0.1
.init_array 544 552 8 1.5
.text 1333186 1334002 816 0.1
ota-provider-app debug (read only) 1280873 1281601 728 0.1
(read/write) 75376 75480 104 0.1
.bss 44128 44192 64 0.1
.data.rel.ro 25336 25368 32 0.1
.init_array 456 464 8 1.8
.text 1067202 1068034 832 0.1
ota-requestor-app debug (read only) 1377457 1378105 648 0.0
(read/write) 79240 79344 104 0.1
.bss 46592 46656 64 0.1
.data.rel.ro 26664 26696 32 0.1
.init_array 480 488 8 1.7
.text 1149586 1150338 752 0.1
shell debug (read only) 804641 805705 1064 0.1
(read/write) 66160 66200 40 0.1
.bss 23336 23368 32 0.1
.data.rel.ro 38008 38024 16 0.0
.init_array 352 360 8 2.3
.text 620258 621474 1216 0.2
tv-app debug (read only) 1892849 1893641 792 0.0
(read/write) 319024 319192 168 0.1
.bss 249912 250040 128 0.1
.data.rel.ro 60648 60680 32 0.1
.init_array 624 632 8 1.3
.text 1586930 1587826 896 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 180372 180380 8 0.0
.data 5232 5240 8 0.2
lighting-app CY8CPROTO_062_4343W+release .bss 172276 172284 8 0.0
.data 5584 5592 8 0.1
lock-app CY8CPROTO_062_4343W+release .bss 171092 171100 8 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2050936 2050992 56 0.0
.bss 156280 156320 40 0.0
.data 4976 4984 8 0.2
.text 1013536 1013592 56 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 868563 868623 60 0.0
bss 112608 112632 24 0.0
rodata 96140 96152 12 0.0
text 584192 584204 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 830931 830991 60 0.0
bss 108960 108984 24 0.0
rodata 87324 87336 12 0.0
text 558360 558372 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793602 793662 60 0.0
bss 113980 114004 24 0.0
rodata 91396 91408 12 0.0
text 513660 513672 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841715 841743 28 0.0
bss 109640 109664 24 0.0
rodata 92572 92584 12 0.0
text 564044 564056 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 767022 767066 44 0.0
bss 111052 111076 24 0.0
text 493604 493616 12 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847827 847887 60 0.0
bss 109780 109804 24 0.0
rodata 94284 94296 12 0.0
text 568228 568240 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841419 841479 60 0.0
bss 109676 109700 24 0.0
rodata 92532 92544 12 0.0
text 563664 563676 12 0.0
shell nrf52840dk_nrf52840 (read/write) 778671 778707 36 0.0
bss 109160 109184 24 0.0
rodata 73196 73200 4 0.0
text 521696 521724 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693678 693746 68 0.0
bss 110144 110168 24 0.0
rodata 67840 67844 4 0.0
text 442304 442332 28 0.0
p6 all-clusters-app default .bss 113360 113368 8 0.0
lock-app default .bss 100952 100960 8 0.0
.data 2408 2416 8 0.3
qpg lighting-app qpg6100+debug (read only) 495344 495444 100 0.0
.bss 50328 50352 24 0.0
.data 1016 1020 4 0.4
.text 490024 490124 100 0.0
lock-app qpg6100+debug (read only) 470288 470380 92 0.0
(read/write) 114140 114144 4 0.0
.bss 49200 49224 24 0.0
.data 972 976 4 0.4
.text 464968 465060 92 0.0
telink lighting-app tlsr9518adk80d (read/write) 769898 769934 36 0.0
bss 79200 79208 8 0.0
text 534636 534642 6 0.0
Decreases (20 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg)
platform target config section 71a3fb2 92435e1 change % change
esp32 all-clusters-app c3devkit (read only) 834250 834076 -174 -0.0
.flash.text 834250 834076 -174 -0.0
m5stack (read only) 905215 905135 -80 -0.0
.flash.text 899831 899751 -80 -0.0
k32w lighting-app k32w061+se05x+release .text 623664 623652 -12 -0.0
lock-app k32w061+debug (read/write) 600000 599936 -64 -0.0
.text 524588 524496 -92 -0.0
linux all-clusters-app debug .rodata 138677 138453 -224 -0.2
bridge-app debug+rpc (read only) 1330909 1330629 -280 -0.0
.rodata 113276 113052 -224 -0.2
.text 1119269 1119093 -176 -0.0
chip-tool debug .rodata 283898 283674 -224 -0.1
lighting-app debug+rpc .rodata 131633 131409 -224 -0.2
ota-provider-app debug .rodata 114999 114775 -224 -0.2
ota-requestor-app debug .rodata 126408 126184 -224 -0.2
shell debug .rodata 79279 79055 -224 -0.3
tv-app debug .rodata 159517 159293 -224 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2291256 2291072 -184 -0.0
.heap 850840 850824 -16 -0.0
.text 1253856 1253672 -184 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2275472 2275280 -192 -0.0
.heap 858584 858568 -16 -0.0
.text 1238072 1237880 -192 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2251272 2251080 -192 -0.0
.heap 859776 859768 -8 -0.0
.text 1213872 1213680 -192 -0.0
shell CY8CPROTO_062_4343W+release .heap 875192 875144 -48 -0.0
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 87880 87876 -4 -0.0
p6 all-clusters-app default (read/write) 2304784 2304648 -136 -0.0
.heap 917448 917440 -8 -0.0
.text 1263048 1262912 -136 -0.0
lock-app default (read/write) 2217952 2217800 -152 -0.0
.heap 929984 929968 -16 -0.0
.text 1176216 1176064 -152 -0.0
qpg lighting-app qpg6100+debug (read/write) 114144 114140 -4 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 71a3fb2 92435e1 change % change
efr32 lighting-app BRD4161A (read only) 752544 752584 40 0.0
(read/write) 119756 119788 32 0.0
.bss 117948 117972 24 0.0
.data 1808 1812 4 0.2
.text 752536 752576 40 0.0
BRD4161A+rpc (read only) 740028 740068 40 0.0
(read/write) 136384 136412 28 0.0
.bss 134452 134476 24 0.0
.data 1932 1936 4 0.2
.text 740020 740060 40 0.0
lock-app BRD4161A (read only) 729544 729600 56 0.0
(read/write) 117476 117500 24 0.0
.bss 115708 115732 24 0.0
.data 1764 1768 4 0.2
.text 729536 729592 56 0.0
window-app BRD4161A (read only) 732992 733048 56 0.0
(read/write) 117836 117860 24 0.0
.bss 116060 116084 24 0.0
.data 1772 1776 4 0.2
.text 732984 733040 56 0.0
esp32 all-clusters-app c3devkit (read only) 834250 834076 -174 -0.0
(read/write) 1222314 1222354 40 0.0
.dram0.bss 57824 57832 8 0.0
.dram0.data 14100 14100 0 0.0
.flash.rodata 165136 165160 24 0.0
.flash.text 834250 834076 -174 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 905215 905135 -80 -0.0
(read/write) 421600 421652 52 0.0
.dram0.bss 63184 63224 40 0.1
.dram0.data 34064 34064 0 0.0
.flash.rodata 193072 193084 12 0.0
.flash.text 899831 899751 -80 -0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 708668 708684 16 0.0
.bss 77284 77308 24 0.0
.data 1920 1924 4 0.2
.text 623664 623652 -12 -0.0
lock-app k32w061+debug (read/write) 600000 599936 -64 -0.0
.bss 67724 67748 24 0.0
.data 1888 1892 4 0.2
.text 524588 524496 -92 -0.0
shell k32w061+debug (read/write) 665380 665416 36 0.0
.bss 78884 78908 24 0.0
.data 1856 1860 4 0.2
.text 578840 578848 8 0.0
linux all-clusters-app debug (read only) 1751433 1752161 728 0.0
(read/write) 128880 128952 72 0.1
.bss 58640 58672 32 0.1
.data 1042 1042 0 0.0
.data.rel.ro 63888 63920 32 0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 568 576 8 1.4
.rodata 138677 138453 -224 -0.2
.text 1476162 1476994 832 0.1
bridge-app debug+rpc (read only) 1330909 1330629 -280 -0.0
(read/write) 76856 76896 40 0.1
.bss 41552 41552 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 28688 28720 32 0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 416 424 8 1.9
.rodata 113276 113052 -224 -0.2
.text 1119269 1119093 -176 -0.0
chip-tool debug (read only) 5914389 5915277 888 0.0
(read/write) 196032 196136 104 0.1
.bss 39896 39960 64 0.2
.data 2288 2288 0 0.0
.data.rel.ro 148272 148304 32 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 480 488 8 1.7
.rodata 283898 283674 -224 -0.1
.text 5249957 5250949 992 0.0
lighting-app debug+rpc (read only) 1600809 1601521 712 0.0
(read/write) 110136 110208 72 0.1
.bss 47280 47312 32 0.1
.data 1234 1234 0 0.0
.data.rel.ro 56304 56336 32 0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 544 552 8 1.5
.rodata 131633 131409 -224 -0.2
.text 1333186 1334002 816 0.1
ota-provider-app debug (read only) 1280873 1281601 728 0.1
(read/write) 75376 75480 104 0.1
.bss 44128 44192 64 0.1
.data 800 800 0 0.0
.data.rel.ro 25336 25368 32 0.1
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 456 464 8 1.8
.rodata 114999 114775 -224 -0.2
.text 1067202 1068034 832 0.1
ota-requestor-app debug (read only) 1377457 1378105 648 0.0
(read/write) 79240 79344 104 0.1
.bss 46592 46656 64 0.1
.data 864 864 0 0.0
.data.rel.ro 26664 26696 32 0.1
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 480 488 8 1.7
.rodata 126408 126184 -224 -0.2
.text 1149586 1150338 752 0.1
shell debug (read only) 804641 805705 1064 0.1
(read/write) 66160 66200 40 0.1
.bss 23336 23368 32 0.1
.data 274 274 0 0.0
.data.rel.ro 38008 38024 16 0.0
.dynamic 592 592 0 0.0
.got 3560 3560 0 0.0
.init 27 27 0 0.0
.init_array 352 360 8 2.3
.rodata 79279 79055 -224 -0.3
.text 620258 621474 1216 0.2
tv-app debug (read only) 1892849 1893641 792 0.0
(read/write) 319024 319192 168 0.1
.bss 249912 250040 128 0.1
.data 2784 2784 0 0.0
.data.rel.ro 60648 60680 32 0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 624 632 8 1.3
.rodata 159517 159293 -224 -0.1
.text 1586930 1587826 896 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2291256 2291072 -184 -0.0
.bss 180372 180380 8 0.0
.data 5232 5240 8 0.2
.heap 850840 850824 -16 -0.0
.text 1253856 1253672 -184 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2275472 2275280 -192 -0.0
.bss 172276 172284 8 0.0
.data 5584 5592 8 0.1
.heap 858584 858568 -16 -0.0
.text 1238072 1237880 -192 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2251272 2251080 -192 -0.0
.bss 171092 171100 8 0.0
.data 5576 5576 0 0.0
.heap 859776 859768 -8 -0.0
.text 1213872 1213680 -192 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050936 2050992 56 0.0
.bss 156280 156320 40 0.0
.data 4976 4984 8 0.2
.heap 875192 875144 -48 -0.0
.text 1013536 1013592 56 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 868563 868623 60 0.0
bss 112608 112632 24 0.0
rodata 96140 96152 12 0.0
text 584192 584204 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 830931 830991 60 0.0
bss 108960 108984 24 0.0
rodata 87324 87336 12 0.0
text 558360 558372 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793602 793662 60 0.0
bss 113980 114004 24 0.0
rodata 91396 91408 12 0.0
text 513660 513672 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 841715 841743 28 0.0
bss 109640 109664 24 0.0
rodata 92572 92584 12 0.0
text 564044 564056 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 767022 767066 44 0.0
bss 111052 111076 24 0.0
rodata 87880 87876 -4 -0.0
text 493604 493616 12 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 847827 847887 60 0.0
bss 109780 109804 24 0.0
rodata 94284 94296 12 0.0
text 568228 568240 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 841419 841479 60 0.0
bss 109676 109700 24 0.0
rodata 92532 92544 12 0.0
text 563664 563676 12 0.0
shell nrf52840dk_nrf52840 (read/write) 778671 778707 36 0.0
bss 109160 109184 24 0.0
rodata 73196 73200 4 0.0
text 521696 521724 28 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693678 693746 68 0.0
bss 110144 110168 24 0.0
rodata 67840 67844 4 0.0
text 442304 442332 28 0.0
p6 all-clusters-app default (read/write) 2304784 2304648 -136 -0.0
.bss 113360 113368 8 0.0
.data 2536 2536 0 0.0
.heap 917448 917440 -8 -0.0
.text 1263048 1262912 -136 -0.0
lock-app default (read/write) 2217952 2217800 -152 -0.0
.bss 100952 100960 8 0.0
.data 2408 2416 8 0.3
.heap 929984 929968 -16 -0.0
.text 1176216 1176064 -152 -0.0
qpg lighting-app qpg6100+debug (read only) 495344 495444 100 0.0
(read/write) 114144 114140 -4 -0.0
.bss 50328 50352 24 0.0
.data 1016 1020 4 0.4
.text 490024 490124 100 0.0
lock-app qpg6100+debug (read only) 470288 470380 92 0.0
(read/write) 114140 114144 4 0.0
.bss 49200 49224 24 0.0
.data 972 976 4 0.4
.text 464968 465060 92 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8986 8986 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 769898 769934 36 0.0
bss 79200 79208 8 0.0
noinit 37160 37160 0 0.0
text 534636 534642 6 0.0

@kghost kghost merged commit 619b726 into project-chip:master Nov 23, 2021
@todo todo bot mentioned this pull request Nov 23, 2021
Closed
@kghost kghost deleted the mrp-param branch November 23, 2021 18:33
@todo todo bot mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kghost @andy31415 @msandstedt @Damian-Nordic @jmartinez-silabs