Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change stack size to fix assertion #12095

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Change stack size to fix assertion #12095

merged 1 commit into from
Nov 23, 2021

Conversation

michalbudzon-q
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Fix crash on startup of lock-app

Change overview

  • Increased stack size of the AppTask form 2048 to 3072 B

Testing

  • Longevity test

@github-actions
Copy link

github-actions bot commented Nov 22, 2021 •
edited
Loading

PR #12095: Size comparison from 7bf757b to 1368fca

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7bf757b 1368fca change % change
efr32 lighting-app BRD4161A (read only) 750704 750704 0 0.0
(read/write) 119692 119692 0 0.0
.bss 117892 117892 0 0.0
.data 1800 1800 0 0.0
.text 750696 750696 0 0.0
BRD4161A+rpc (read only) 738244 738244 0 0.0
(read/write) 136320 136320 0 0.0
.bss 134396 134396 0 0.0
.data 1924 1924 0 0.0
.text 738236 738236 0 0.0
lock-app BRD4161A (read only) 727776 727776 0 0.0
(read/write) 113380 113380 0 0.0
.bss 111620 111620 0 0.0
.data 1756 1756 0 0.0
.text 727768 727768 0 0.0
window-app BRD4161A (read only) 728760 728760 0 0.0
(read/write) 113700 113700 0 0.0
.bss 111940 111940 0 0.0
.data 1760 1760 0 0.0
.text 728752 728752 0 0.0
esp32 all-clusters-app c3devkit (read only) 831824 831824 0 0.0
(read/write) 1221210 1221210 0 0.0
.dram0.bss 57696 57696 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 164176 164176 0 0.0
.flash.text 831824 831824 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 902843 902843 0 0.0
(read/write) 420536 420536 0 0.0
.dram0.bss 63056 63056 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 192144 192144 0 0.0
.flash.text 897459 897459 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 707528 707528 0 0.0
.bss 77212 77212 0 0.0
.data 1912 1912 0 0.0
.text 622604 622604 0 0.0
lock-app k32w061+debug (read/write) 598960 598960 0 0.0
.bss 67716 67716 0 0.0
.data 1880 1880 0 0.0
.text 523564 523564 0 0.0
shell k32w061+debug (read/write) 664320 664320 0 0.0
.bss 78876 78876 0 0.0
.data 1848 1848 0 0.0
.text 577796 577796 0 0.0
linux all-clusters-app debug (read only) 1746185 1746185 0 0.0
(read/write) 128392 128392 0 0.0
.bss 58544 58544 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 63504 63504 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 137493 137493 0 0.0
.text 1473058 1473058 0 0.0
bridge-app debug+rpc (read only) 1325997 1325997 0 0.0
(read/write) 76432 76432 0 0.0
.bss 41520 41520 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28352 28352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 112028 112028 0 0.0
.text 1116565 1116565 0 0.0
chip-tool debug (read only) 4999877 4999877 0 0.0
(read/write) 165960 165960 0 0.0
.bss 39848 39848 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118352 118352 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 269738 269738 0 0.0
.text 4419989 4419989 0 0.0
lighting-app debug+rpc (read only) 1595105 1595105 0 0.0
(read/write) 109616 109616 0 0.0
.bss 47152 47152 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55920 55920 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129649 129649 0 0.0
.text 1330450 1330450 0 0.0
ota-provider-app debug (read only) 1273545 1273545 0 0.0
(read/write) 75048 75048 0 0.0
.bss 44096 44096 0 0.0
.data 784 784 0 0.0
.data.rel.ro 25080 25080 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 114047 114047 0 0.0
.text 1061906 1061906 0 0.0
ota-requestor-app debug (read only) 1369793 1369793 0 0.0
(read/write) 78912 78912 0 0.0
.bss 46560 46560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26408 26408 0 0.0
.dynamic 592 592 0 0.0
.got 4000 4000 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 125448 125448 0 0.0
.text 1143970 1143970 0 0.0
shell debug (read only) 799185 799185 0 0.0
(read/write) 65832 65832 0 0.0
.bss 23336 23336 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37752 37752 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78703 78703 0 0.0
.text 616466 616466 0 0.0
tv-app debug (read only) 1887753 1887753 0 0.0
(read/write) 318520 318520 0 0.0
.bss 249800 249800 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158373 158373 0 0.0
.text 1583938 1583938 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2290128 2290128 0 0.0
.bss 180300 180300 0 0.0
.data 5224 5224 0 0.0
.heap 850920 850920 0 0.0
.text 1252728 1252728 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274256 2274256 0 0.0
.bss 172196 172196 0 0.0
.data 5576 5576 0 0.0
.heap 858672 858672 0 0.0
.text 1236856 1236856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250160 2250160 0 0.0
.bss 171084 171084 0 0.0
.data 5568 5568 0 0.0
.heap 859792 859792 0 0.0
.text 1212760 1212760 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2050480 2050480 0 0.0
.bss 156272 156272 0 0.0
.data 4968 4968 0 0.0
.heap 875208 875208 0 0.0
.text 1013080 1013080 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865251 865251 0 0.0
bss 110604 110604 0 0.0
rodata 95828 95828 0 0.0
text 583184 583184 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827619 827619 0 0.0
bss 106960 106960 0 0.0
rodata 87012 87012 0 0.0
text 557352 557352 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790290 790290 0 0.0
bss 111980 111980 0 0.0
rodata 91084 91084 0 0.0
text 512656 512656 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840635 840635 0 0.0
bss 109628 109628 0 0.0
rodata 92300 92300 0 0.0
text 563280 563280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765938 765938 0 0.0
bss 111040 111040 0 0.0
rodata 87604 87604 0 0.0
text 492840 492840 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846775 846775 0 0.0
bss 109768 109768 0 0.0
rodata 94008 94008 0 0.0
text 567460 567460 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840335 840335 0 0.0
bss 109664 109664 0 0.0
rodata 92256 92256 0 0.0
text 562900 562900 0 0.0
shell nrf52840dk_nrf52840 (read/write) 778003 778003 0 0.0
bss 109112 109112 0 0.0
rodata 73064 73064 0 0.0
text 521244 521244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 693058 693058 0 0.0
bss 110096 110096 0 0.0
rodata 67708 67708 0 0.0
text 441856 441856 0 0.0
p6 all-clusters-app default (read/write) 2303000 2303000 0 0.0
.bss 113280 113280 0 0.0
.data 2528 2528 0 0.0
.heap 917536 917536 0 0.0
.text 1261264 1261264 0 0.0
lock-app default (read/write) 2216200 2216200 0 0.0
.bss 100944 100944 0 0.0
.data 2400 2400 0 0.0
.heap 930000 930000 0 0.0
.text 1174464 1174464 0 0.0
qpg lighting-app qpg6100+debug (read only) 494288 494288 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50256 50256 0 0.0
.data 1008 1008 0 0.0
.text 488968 488968 0 0.0
lock-app qpg6100+debug (read only) 469252 469252 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49200 49200 0 0.0
.data 964 964 0 0.0
.text 463932 463932 0 0.0
persistent-storage-app qpg6100+debug (read only) 105416 105416 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8994 8994 0 0.0
.data 272 272 0 0.0
.text 100096 100096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 768642 768642 0 0.0
bss 79116 79116 0 0.0
noinit 37160 37160 0 0.0
text 533780 533780 0 0.0

@tima-q tima-q added the qpg QPG6xxx platform label Nov 22, 2021
@michalbudzon-q michalbudzon-q marked this pull request as ready for review November 23, 2021 13:59
@andy31415 andy31415 merged commit 7b0bdf8 into project-chip:master Nov 23, 2021
@michalbudzon-q michalbudzon-q deleted the stack_size branch November 23, 2021 14:17
q-thla pushed a commit to Qorvo/connectedhomeip that referenced this pull request Jan 6, 2022
@michalbudzon-q
Change stack size to fix assertion (project-chip#12095)
43908bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
examples qpg QPG6xxx platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalbudzon-q @andy31415 @saurabhst @Damian-Nordic @tima-q