-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for float and double types. #12252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
pan-apple,
sagar-apple and
saurabhst
November 25, 2021 08:26
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
wbschiller,
woody-apple and
yunhanw-google
November 25, 2021 08:26
bzbarsky-apple
force-pushed
the
add-float-test
branch
from
November 25, 2021 08:34
ba248b0
to
6ddd96b
Compare
Note: This does NOT add support for float/double typed attributes yet. This PR had gotten way too big as it was.... That will need to be a followup. |
PR #12252: Size comparison from c79b67b to 6ddd96b Increases (3 builds for linux, p6)
Full report (21 builds for efr32, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
add-float-test
branch
from
November 25, 2021 09:12
6ddd96b
to
064f061
Compare
bzbarsky-apple
force-pushed
the
add-float-test
branch
from
November 25, 2021 09:14
064f061
to
1c4f64c
Compare
PR #12252: Size comparison from c79b67b to 1c4f64c Increases (6 builds for esp32, linux, mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 25, 2021
yunhanw-google
approved these changes
Nov 25, 2021
* Adds Encode and Decode support for float and double. * Adds support for float/double in various code generation type helpers (for chip-tool, java, darwin). * Adds float and double members to the SimpleStruct test struct. * Adds a command to send and receive a SimpleStruct, and a yaml test that does that. * Fixes chip-tool to handle BitFlags value checking correctly (since SimpleStruct has a BitFlags member). * Removes some code in ClustersHelper.js that failed for float/double types and whose output was completely unused. * Fixes templates for old-style commands and java that completely blew up on structs in a response command field to at least generate code successfully, though that code wouldn't work right if it ever ran.
bzbarsky-apple
force-pushed
the
add-float-test
branch
from
November 25, 2021 17:03
1c4f64c
to
e57f9d9
Compare
PR #12252: Size comparison from 15929eb to e57f9d9 Increases (6 builds for esp32, linux, mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
fast track: change created and approved by domain owners |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Encode and Decode support for float and double.
Adds support for float/double in various code generation type
helpers (for chip-tool, java, darwin).
Adds float and double members to the SimpleStruct test struct.
Adds a command to send and receive a SimpleStruct, and a yaml test
that does that.
Fixes chip-tool to handle BitFlags value checking correctly (since
SimpleStruct has a BitFlags member).
Removes some code in ClustersHelper.js that failed for float/double
types and whose output was completely unused.
Fixes templates for old-style commands and java that completely blew
up on structs in a response command field to at least generate code
successfully, though that code wouldn't work right if it ever ran.
Problem
Codegen fails if someone uses the "single" or "double" type in an XML file.
Change overview
See above.
Testing
New yaml test, plus some code inspection of the generated code.