Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tracing service to example/platform/esp rpc #12386

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Add tracing service to example/platform/esp rpc #12386

merged 2 commits into from
Dec 3, 2021

Conversation

yyzhong-g
Copy link
Contributor

Problem

Add trace functionality to esp32 examples

Change overview

Add trace service to RPC services

Testing

Build esp32 all cluster example with RPC turned on and off.

@restyled-io restyled-io bot mentioned this pull request Nov 30, 2021
Closed
@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12386: Size comparison from 75ff895 to 6b14b70

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 75ff895 6b14b70 change % change
efr32 lighting-app BRD4161A (read only) 729232 729232 0 0.0
(read/write) 119580 119580 0 0.0
.bss 117764 117764 0 0.0
.data 1812 1812 0 0.0
.text 729224 729224 0 0.0
BRD4161A+rpc (read only) 757872 757872 0 0.0
(read/write) 137884 137884 0 0.0
.bss 135964 135964 0 0.0
.data 1920 1920 0 0.0
.text 757864 757864 0 0.0
lock-app BRD4161A (read only) 703092 703092 0 0.0
(read/write) 117284 117284 0 0.0
.bss 115516 115516 0 0.0
.data 1768 1768 0 0.0
.text 703084 703084 0 0.0
window-app BRD4161A (read only) 706204 706204 0 0.0
(read/write) 117708 117708 0 0.0
.bss 115932 115932 0 0.0
.data 1776 1776 0 0.0
.text 706196 706196 0 0.0
esp32 all-clusters-app c3devkit (read only) 839074 839074 0 0.0
(read/write) 1224850 1224850 0 0.0
.dram0.bss 58720 58720 0 0.0
.dram0.data 14028 14028 0 0.0
.flash.rodata 166856 166856 0 0.0
.flash.text 839074 839074 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910511 910511 0 0.0
(read/write) 424096 424096 0 0.0
.dram0.bss 64120 64120 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194696 194696 0 0.0
.flash.text 905127 905127 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 726744 726744 0 0.0
.bss 78956 78956 0 0.0
.data 1844 1844 0 0.0
.text 640144 640144 0 0.0
lock-app k32w061+debug (read/write) 615732 615732 0 0.0
.bss 69396 69396 0 0.0
.data 1808 1808 0 0.0
.text 538728 538728 0 0.0
shell k32w061+debug (read/write) 681552 681552 0 0.0
.bss 80996 80996 0 0.0
.data 1780 1780 0 0.0
.text 592976 592976 0 0.0
linux all-clusters-app debug (read only) 1795545 1795545 0 0.0
(read/write) 125800 125800 0 0.0
.bss 53360 53360 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66032 66032 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145781 145781 0 0.0
.text 1509522 1509522 0 0.0
bridge-app debug+rpc (read only) 1365341 1365341 0 0.0
(read/write) 71888 71888 0 0.0
.bss 35408 35408 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118756 118756 0 0.0
.text 1145749 1145749 0 0.0
chip-tool debug (read only) 6435157 6435157 0 0.0
(read/write) 198512 198512 0 0.0
.bss 33704 33704 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 158216 158216 0 0.0
.dynamic 592 592 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 301208 301208 0 0.0
.text 5730117 5730117 0 0.0
lighting-app debug+rpc (read only) 1649337 1649337 0 0.0
(read/write) 104944 104944 0 0.0
.bss 41072 41072 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138481 138481 0 0.0
.text 1372274 1372274 0 0.0
ota-provider-app debug (read only) 1326169 1326169 0 0.0
(read/write) 70344 70344 0 0.0
.bss 37984 37984 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120232 120232 0 0.0
.text 1104866 1104866 0 0.0
ota-requestor-app debug (read only) 1426257 1426257 0 0.0
(read/write) 74240 74240 0 0.0
.bss 40096 40096 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132144 132144 0 0.0
.text 1189602 1189602 0 0.0
shell debug (read only) 814361 814361 0 0.0
(read/write) 60232 60232 0 0.0
.bss 16872 16872 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83538 83538 0 0.0
.text 624738 624738 0 0.0
tv-app debug (read only) 1942545 1942545 0 0.0
(read/write) 314608 314608 0 0.0
.bss 245464 245464 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168040 168040 0 0.0
.text 1625346 1625346 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298624 2298624 0 0.0
.bss 181788 181788 0 0.0
.data 5168 5168 0 0.0
.heap 849488 849488 0 0.0
.text 1261224 1261224 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283376 2283376 0 0.0
.bss 172816 172816 0 0.0
.data 5480 5480 0 0.0
.heap 858152 858152 0 0.0
.text 1245976 1245976 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2256408 2256408 0 0.0
.bss 171632 171632 0 0.0
.data 5480 5480 0 0.0
.heap 859336 859336 0 0.0
.text 1219008 1219008 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046056 2046056 0 0.0
.bss 156624 156624 0 0.0
.data 4864 4864 0 0.0
.heap 874960 874960 0 0.0
.text 1008656 1008656 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 878863 878863 0 0.0
bss 113316 113316 0 0.0
rodata 97968 97968 0 0.0
text 592028 592028 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 841311 841311 0 0.0
bss 109664 109664 0 0.0
rodata 89328 89328 0 0.0
text 566128 566128 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803862 803862 0 0.0
bss 114688 114688 0 0.0
rodata 93224 93224 0 0.0
text 521480 521480 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 849687 849687 0 0.0
bss 110352 110352 0 0.0
rodata 93704 93704 0 0.0
text 570276 570276 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 774958 774958 0 0.0
bss 111764 111764 0 0.0
rodata 88992 88992 0 0.0
text 499820 499820 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 855699 855699 0 0.0
bss 110488 110488 0 0.0
rodata 95436 95436 0 0.0
text 574340 574340 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 848767 848767 0 0.0
bss 110368 110368 0 0.0
rodata 93576 93576 0 0.0
text 569400 569400 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779359 779359 0 0.0
bss 109616 109616 0 0.0
rodata 73284 73284 0 0.0
text 521952 521952 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694406 694406 0 0.0
bss 110600 110600 0 0.0
rodata 67928 67928 0 0.0
text 442560 442560 0 0.0
p6 all-clusters-app default (read/write) 2320416 2320416 0 0.0
.bss 109872 109872 0 0.0
.data 2464 2464 0 0.0
.heap 921008 921008 0 0.0
.text 1278680 1278680 0 0.0
light-app default (read/write) 2256128 2256128 0 0.0
.bss 97936 97936 0 0.0
.data 2328 2328 0 0.0
.heap 933080 933080 0 0.0
.text 1214392 1214392 0 0.0
lock-app default (read/write) 2231472 2231472 0 0.0
.bss 96592 96592 0 0.0
.data 2288 2288 0 0.0
.heap 934464 934464 0 0.0
.text 1189736 1189736 0 0.0
qpg lighting-app qpg6100+debug (read only) 498628 498628 0 0.0
(read/write) 114144 114144 0 0.0
.bss 79848 79848 0 0.0
.data 944 944 0 0.0
.text 493308 493308 0 0.0
lock-app qpg6100+debug (read only) 471232 471232 0 0.0
(read/write) 114144 114144 0 0.0
.bss 78760 78760 0 0.0
.data 896 896 0 0.0
.text 465912 465912 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 780898 780898 0 0.0
bss 79896 79896 0 0.0
noinit 37160 37160 0 0.0
text 542888 542888 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 2, 2021 •
edited
Loading

PR #12386: Size comparison from 7cba51d to 9184eb7

Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7cba51d 9184eb7 change % change
efr32 lighting-app BRD4161A (read only) 751552 751552 0 0.0
(read/write) 120032 120032 0 0.0
.bss 118200 118200 0 0.0
.data 1828 1828 0 0.0
.text 751544 751544 0 0.0
BRD4161A+rpc (read only) 780216 780216 0 0.0
(read/write) 138336 138336 0 0.0
.bss 136400 136400 0 0.0
.data 1936 1936 0 0.0
.text 780208 780208 0 0.0
lock-app BRD4161A (read only) 725392 725392 0 0.0
(read/write) 117736 117736 0 0.0
.bss 115952 115952 0 0.0
.data 1784 1784 0 0.0
.text 725384 725384 0 0.0
window-app BRD4161A (read only) 728720 728720 0 0.0
(read/write) 118160 118160 0 0.0
.bss 116368 116368 0 0.0
.data 1792 1792 0 0.0
.text 728712 728712 0 0.0
esp32 all-clusters-app c3devkit (read only) 847808 847808 0 0.0
(read/write) 1223826 1223826 0 0.0
.dram0.bss 56576 56576 0 0.0
.dram0.data 14052 14052 0 0.0
.flash.rodata 167744 167744 0 0.0
.flash.text 847808 847808 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 918399 918399 0 0.0
(read/write) 422804 422804 0 0.0
.dram0.bss 61960 61960 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 195548 195548 0 0.0
.flash.text 913015 913015 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 728720 728720 0 0.0
.bss 79304 79304 0 0.0
.data 1860 1860 0 0.0
.text 641756 641756 0 0.0
lock-app k32w061+debug (read/write) 617704 617704 0 0.0
.bss 69744 69744 0 0.0
.data 1824 1824 0 0.0
.text 540336 540336 0 0.0
shell k32w061+debug (read/write) 683604 683604 0 0.0
.bss 81400 81400 0 0.0
.data 1796 1796 0 0.0
.text 594608 594608 0 0.0
linux all-clusters-app debug (read only) 1842697 1842697 0 0.0
(read/write) 124256 124256 0 0.0
.bss 50768 50768 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67088 67088 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146453 146453 0 0.0
.text 1553890 1553890 0 0.0
bridge-app debug+rpc (read only) 1423037 1423037 0 0.0
(read/write) 74416 74416 0 0.0
.bss 36144 36144 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31528 31528 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 119500 119500 0 0.0
.text 1198981 1198981 0 0.0
chip-tool debug (read only) 6618837 6618837 0 0.0
(read/write) 202128 202128 0 0.0
.bss 34440 34440 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 161112 161112 0 0.0
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 307224 307224 0 0.0
.text 5901429 5901429 0 0.0
lighting-app debug+rpc (read only) 1707121 1707121 0 0.0
(read/write) 107408 107408 0 0.0
.bss 41808 41808 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59024 59024 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 139281 139281 0 0.0
.text 1425538 1425538 0 0.0
ota-provider-app debug (read only) 1383857 1383857 0 0.0
(read/write) 72648 72648 0 0.0
.bss 38720 38720 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27880 27880 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120776 120776 0 0.0
.text 1158722 1158722 0 0.0
ota-requestor-app debug (read only) 1483945 1483945 0 0.0
(read/write) 76512 76512 0 0.0
.bss 40832 40832 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29576 29576 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132688 132688 0 0.0
.text 1243458 1243458 0 0.0
shell debug (read only) 818561 818561 0 0.0
(read/write) 60584 60584 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 628418 628418 0 0.0
tv-app debug (read only) 2000921 2000921 0 0.0
(read/write) 317616 317616 0 0.0
.bss 246712 246712 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 63720 63720 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169320 169320 0 0.0
.text 1678722 1678722 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309264 2309264 0 0.0
.bss 179628 179628 0 0.0
.data 5184 5184 0 0.0
.heap 851632 851632 0 0.0
.text 1271840 1271840 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2295592 2295592 0 0.0
.bss 173272 173272 0 0.0
.data 5496 5496 0 0.0
.heap 857680 857680 0 0.0
.text 1258192 1258192 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2268688 2268688 0 0.0
.bss 172088 172088 0 0.0
.data 5496 5496 0 0.0
.heap 858864 858864 0 0.0
.text 1231288 1231288 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046968 2046968 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1009568 1009568 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 891475 891475 0 0.0
bss 113752 113752 0 0.0
rodata 99412 99412 0 0.0
text 602752 602752 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 854835 854835 0 0.0
bss 110100 110100 0 0.0
rodata 90772 90772 0 0.0
text 577748 577748 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 817370 817370 0 0.0
bss 115124 115124 0 0.0
rodata 94668 94668 0 0.0
text 533088 533088 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 862331 862331 0 0.0
bss 110788 110788 0 0.0
rodata 95148 95148 0 0.0
text 581004 581004 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788470 788470 0 0.0
bss 112200 112200 0 0.0
rodata 90440 90440 0 0.0
text 511432 511432 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 868331 868331 0 0.0
bss 110924 110924 0 0.0
rodata 96884 96884 0 0.0
text 585068 585068 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 861411 861411 0 0.0
bss 110804 110804 0 0.0
rodata 95020 95020 0 0.0
text 580128 580128 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779895 779895 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521908 521908 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694938 694938 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442512 442512 0 0.0
p6 all-clusters-app default (read/write) 2339520 2339520 0 0.0
.bss 107820 107820 0 0.0
.data 2456 2456 0 0.0
.heap 923064 923064 0 0.0
.text 1297784 1297784 0 0.0
light-app default (read/write) 2278872 2278872 0 0.0
.bss 98504 98504 0 0.0
.data 2336 2336 0 0.0
.heap 932504 932504 0 0.0
.text 1237136 1237136 0 0.0
lock-app default (read/write) 2254224 2254224 0 0.0
.bss 97160 97160 0 0.0
.data 2296 2296 0 0.0
.heap 933888 933888 0 0.0
.text 1212488 1212488 0 0.0
qpg lighting-app qpg6100+debug (read only) 510496 510496 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80264 80264 0 0.0
.data 964 964 0 0.0
.text 505176 505176 0 0.0
lock-app qpg6100+debug (read only) 483320 483320 0 0.0
(read/write) 122332 122332 0 0.0
.bss 79176 79176 0 0.0
.data 916 916 0 0.0
.text 478000 478000 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 794550 794550 0 0.0
bss 80328 80328 0 0.0
noinit 37160 37160 0 0.0
text 554522 554522 0 0.0

@andy31415 andy31415 merged commit 59ca414 into project-chip:master Dec 3, 2021
billwatersiii pushed a commit to billwatersiii/connectedhomeip that referenced this pull request Dec 3, 2021
@yyzhong-g @restyled-commits @billwatersiii
Add tracing service to example/platform/esp rpc (project-chip#12386)
7053a31 
* Add tracing service to example/platform/esp rpc

* Restyled by clang-format

Co-authored-by: Restyled.io <commits@restyled.io>
yyzhong-g added a commit to yyzhong-g/connectedhomeip that referenced this pull request Dec 6, 2021
@yyzhong-g
Revert "Add tracing service to example/platform/esp rpc (project-chip…
7897682 
…#12386)"

This reverts commit 59ca414.
@yyzhong-g yyzhong-g mentioned this pull request Dec 6, 2021
Closed
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Dec 7, 2021
@andy31415
Revert "Add tracing service to example/platform/esp rpc (project-chip…
1b60b90 
…#12386)"

This reverts commit 59ca414.
andy31415 added a commit that referenced this pull request Dec 7, 2021
@andy31415
Revert "Add tracing service to example/platform/esp rpc (#12386)" (#1…
051685b 
…2686)

This reverts commit 59ca414.
@yyzhong-g yyzhong-g deleted the esp32_trace branch December 13, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@rgoliver rgoliver rgoliver approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yyzhong-g @woody-apple @rgoliver @yunhanw-google @andy31415 @restyled-commits