-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TestCluster] Add a test for a command that takes a single optional argument #12474
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:TestCluster_SimpleOptionalArgumentRequest
Dec 2, 2021
Merged
[TestCluster] Add a test for a command that takes a single optional argument #12474
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:TestCluster_SimpleOptionalArgumentRequest
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #12474: Size comparison from dc10c82 to 2c5592d Increases (4 builds for linux, mbed, p6)
Full report (37 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
380fe84
to
819765f
Compare
819765f
to
a2d70a0
Compare
PR #12474: Size comparison from dc10c82 to a2d70a0 Increases (6 builds for esp32, linux, mbed, p6)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 2, 2021
Fast tracking, given this is adding tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is YAML TestCluster test for a command that takes a top level optional argument.
Change overview
all-clusters-app
Testing
YAML tests have been added.