Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TestCluster] Add a test for a command that takes a single optional argument #12474

Conversation

vivien-apple
Copy link
Contributor

Problem

There is YAML TestCluster test for a command that takes a top level optional argument.

Change overview

  • Add such a command to test cluster
  • Add some YAML tests
  • Enable the command into the all-clusters-app

Testing

YAML tests have been added.

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

PR #12474: Size comparison from dc10c82 to 2c5592d

Increases (4 builds for linux, mbed, p6)
platform target config section dc10c823 2c5592d change % change
linux all-clusters-app debug (read only) 1797065 1798281 1216 0.1
.text 1510818 1512034 1216 0.1
chip-tool debug (read only) 6528285 6534893 6608 0.1
(read/write) 199760 199888 128 0.1
.data.rel.ro 159432 159560 128 0.1
.rodata 304984 305304 320 0.1
.text 5816693 5822693 6000 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2299376 2299504 128 0.0
.text 1261976 1262104 128 0.0
p6 all-clusters-app default (read/write) 2320840 2321000 160 0.0
.text 1279104 1279264 160 0.0
Full report (37 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dc10c823 2c5592d change % change
efr32 lighting-app BRD4161A (read only) 730064 730064 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730056 0 0.0
BRD4161A+rpc (read only) 758704 758704 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758696 0 0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616916 0 0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539856 0 0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1798281 1216 0.1
(read/write) 125992 125992 0 0.0
.bss 53456 53456 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510818 1512034 1216 0.1
bridge-app debug+rpc (read only) 1367285 1367285 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1147589 0 0.0
chip-tool debug (read only) 6528285 6534893 6608 0.1
(read/write) 199760 199888 128 0.1
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159560 128 0.1
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 305304 320 0.1
.text 5816693 5822693 6000 0.1
lighting-app debug+rpc (read only) 1651097 1651097 0 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1373906 0 0.0
ota-provider-app debug (read only) 1327881 1327881 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1106514 0 0.0
ota-requestor-app debug (read only) 1427937 1427937 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1191186 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944817 1944817 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1626946 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299376 2299504 128 0.0
.bss 181892 181892 0 0.0
.data 5168 5168 0 0.0
.heap 849384 849384 0 0.0
.text 1261976 1262104 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284104 2284104 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246704 1246704 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257200 2257200 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219800 1219800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 880507 880507 0 0.0
bss 113396 113396 0 0.0
rodata 98540 98540 0 0.0
text 593036 593036 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 843883 843883 0 0.0
bss 109744 109744 0 0.0
rodata 89900 89900 0 0.0
text 568032 568032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806422 806422 0 0.0
bss 114768 114768 0 0.0
rodata 93800 93800 0 0.0
text 523376 523376 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 851335 851335 0 0.0
bss 110432 110432 0 0.0
rodata 94280 94280 0 0.0
text 571288 571288 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 777518 777518 0 0.0
bss 111844 111844 0 0.0
rodata 89568 89568 0 0.0
text 501720 501720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 857379 857379 0 0.0
bss 110568 110568 0 0.0
rodata 96012 96012 0 0.0
text 575356 575356 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 850459 850459 0 0.0
bss 110448 110448 0 0.0
rodata 94148 94148 0 0.0
text 570416 570416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779903 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521924 521924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694946 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442528 442528 0 0.0
p6 all-clusters-app default (read/write) 2320840 2321000 160 0.0
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1279104 1279264 160 0.0
light-app default (read/write) 2256624 2256624 0 0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214888 1214888 0 0.0
lock-app default (read/write) 2231984 2231984 0 0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1190248 1190248 0 0.0
qpg lighting-app qpg6100+debug (read only) 499800 499800 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494480 494480 0 0.0
lock-app qpg6100+debug (read only) 472612 472612 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467292 467292 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@vivien-apple vivien-apple force-pushed the TestCluster_SimpleOptionalArgumentRequest branch 2 times, most recently from 380fe84 to 819765f Compare December 2, 2021 13:23
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

PR #12474: Size comparison from dc10c82 to 819765f

Full report (1 build for telink)
platform target config section dc10c823 819765f change % change
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 2, 2021

PR #12474: Size comparison from dc10c82 to a2d70a0

Increases (6 builds for esp32, linux, mbed, p6)
platform target config section dc10c823 a2d70a0 change % change
esp32 all-clusters-app c3devkit (read only) 839114 839290 176 0.0
.flash.text 839114 839290 176 0.0
m5stack (read only) 910791 910971 180 0.0
.flash.text 905407 905587 180 0.0
linux all-clusters-app debug (read only) 1797065 1798281 1216 0.1
.text 1510818 1512034 1216 0.1
chip-tool debug (read only) 6528285 6534893 6608 0.1
(read/write) 199760 199888 128 0.1
.data.rel.ro 159432 159560 128 0.1
.rodata 304984 305304 320 0.1
.text 5816693 5822693 6000 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2299376 2299504 128 0.0
.text 1261976 1262104 128 0.0
p6 all-clusters-app default (read/write) 2320840 2321000 160 0.0
.text 1279104 1279264 160 0.0
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section dc10c823 a2d70a0 change % change
efr32 lighting-app BRD4161A (read only) 730064 730064 0 0.0
(read/write) 119660 119660 0 0.0
.bss 117844 117844 0 0.0
.data 1812 1812 0 0.0
.text 730056 730056 0 0.0
BRD4161A+rpc (read only) 758704 758704 0 0.0
(read/write) 137964 137964 0 0.0
.bss 136044 136044 0 0.0
.data 1920 1920 0 0.0
.text 758696 758696 0 0.0
lock-app BRD4161A (read only) 703924 703924 0 0.0
(read/write) 117364 117364 0 0.0
.bss 115596 115596 0 0.0
.data 1768 1768 0 0.0
.text 703916 703916 0 0.0
window-app BRD4161A (read only) 707020 707020 0 0.0
(read/write) 117788 117788 0 0.0
.bss 116012 116012 0 0.0
.data 1776 1776 0 0.0
.text 707012 707012 0 0.0
esp32 all-clusters-app c3devkit (read only) 839114 839290 176 0.0
(read/write) 1225090 1225090 0 0.0
.dram0.bss 58824 58824 0 0.0
.dram0.data 14036 14036 0 0.0
.flash.rodata 166968 166968 0 0.0
.flash.text 839114 839290 176 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 910791 910971 180 0.0
(read/write) 424312 424312 0 0.0
.dram0.bss 64224 64224 0 0.0
.dram0.data 34000 34000 0 0.0
.flash.rodata 194808 194808 0 0.0
.flash.text 905407 905587 180 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 727928 727928 0 0.0
.bss 79012 79012 0 0.0
.data 1844 1844 0 0.0
.text 641272 641272 0 0.0
lock-app k32w061+debug (read/write) 616916 616916 0 0.0
.bss 69452 69452 0 0.0
.data 1808 1808 0 0.0
.text 539856 539856 0 0.0
shell k32w061+debug (read/write) 682804 682804 0 0.0
.bss 81108 81108 0 0.0
.data 1780 1780 0 0.0
.text 594116 594116 0 0.0
linux all-clusters-app debug (read only) 1797065 1798281 1216 0.1
(read/write) 125992 125992 0 0.0
.bss 53456 53456 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 66128 66128 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 145909 145909 0 0.0
.text 1510818 1512034 1216 0.1
bridge-app debug+rpc (read only) 1367285 1367285 0 0.0
(read/write) 71920 71920 0 0.0
.bss 35440 35440 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 29792 29792 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 118860 118860 0 0.0
.text 1147589 1147589 0 0.0
chip-tool debug (read only) 6528285 6534893 6608 0.1
(read/write) 199760 199888 128 0.1
.bss 33736 33736 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 159432 159560 128 0.1
.dynamic 592 592 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 304984 305304 320 0.1
.text 5816693 5822693 6000 0.1
lighting-app debug+rpc (read only) 1651097 1651097 0 0.0
(read/write) 105008 105008 0 0.0
.bss 41136 41136 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 57296 57296 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 138609 138609 0 0.0
.text 1373906 1373906 0 0.0
ota-provider-app debug (read only) 1327881 1327881 0 0.0
(read/write) 70376 70376 0 0.0
.bss 38016 38016 0 0.0
.data 912 912 0 0.0
.data.rel.ro 26328 26328 0 0.0
.dynamic 592 592 0 0.0
.got 4048 4048 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 120296 120296 0 0.0
.text 1106514 1106514 0 0.0
ota-requestor-app debug (read only) 1427937 1427937 0 0.0
(read/write) 74272 74272 0 0.0
.bss 40128 40128 0 0.0
.data 976 976 0 0.0
.data.rel.ro 28040 28040 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 132240 132240 0 0.0
.text 1191186 1191186 0 0.0
shell debug (read only) 812841 812841 0 0.0
(read/write) 60264 60264 0 0.0
.bss 16904 16904 0 0.0
.data 240 240 0 0.0
.data.rel.ro 38656 38656 0 0.0
.dynamic 592 592 0 0.0
.got 3504 3504 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 83506 83506 0 0.0
.text 623250 623250 0 0.0
tv-app debug (read only) 1944817 1944817 0 0.0
(read/write) 314640 314640 0 0.0
.bss 245496 245496 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 61984 61984 0 0.0
.dynamic 592 592 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 168712 168712 0 0.0
.text 1626946 1626946 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2299376 2299504 128 0.0
.bss 181892 181892 0 0.0
.data 5168 5168 0 0.0
.heap 849384 849384 0 0.0
.text 1261976 1262104 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284104 2284104 0 0.0
.bss 172896 172896 0 0.0
.data 5480 5480 0 0.0
.heap 858072 858072 0 0.0
.text 1246704 1246704 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2257200 2257200 0 0.0
.bss 171712 171712 0 0.0
.data 5480 5480 0 0.0
.heap 859256 859256 0 0.0
.text 1219800 1219800 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2046576 2046576 0 0.0
.bss 156704 156704 0 0.0
.data 4864 4864 0 0.0
.heap 874880 874880 0 0.0
.text 1009176 1009176 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 880507 880507 0 0.0
bss 113396 113396 0 0.0
rodata 98540 98540 0 0.0
text 593036 593036 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 843883 843883 0 0.0
bss 109744 109744 0 0.0
rodata 89900 89900 0 0.0
text 568032 568032 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806422 806422 0 0.0
bss 114768 114768 0 0.0
rodata 93800 93800 0 0.0
text 523376 523376 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 851335 851335 0 0.0
bss 110432 110432 0 0.0
rodata 94280 94280 0 0.0
text 571288 571288 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 777518 777518 0 0.0
bss 111844 111844 0 0.0
rodata 89568 89568 0 0.0
text 501720 501720 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 857379 857379 0 0.0
bss 110568 110568 0 0.0
rodata 96012 96012 0 0.0
text 575356 575356 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 850459 850459 0 0.0
bss 110448 110448 0 0.0
rodata 94148 94148 0 0.0
text 570416 570416 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779903 779903 0 0.0
bss 109696 109696 0 0.0
rodata 73796 73796 0 0.0
text 521924 521924 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694946 694946 0 0.0
bss 110680 110680 0 0.0
rodata 68436 68436 0 0.0
text 442528 442528 0 0.0
p6 all-clusters-app default (read/write) 2320840 2321000 160 0.0
.bss 110072 110072 0 0.0
.data 2464 2464 0 0.0
.heap 920808 920808 0 0.0
.text 1279104 1279264 160 0.0
light-app default (read/write) 2256624 2256624 0 0.0
.bss 98112 98112 0 0.0
.data 2328 2328 0 0.0
.heap 932904 932904 0 0.0
.text 1214888 1214888 0 0.0
lock-app default (read/write) 2231984 2231984 0 0.0
.bss 96768 96768 0 0.0
.data 2288 2288 0 0.0
.heap 934288 934288 0 0.0
.text 1190248 1190248 0 0.0
qpg lighting-app qpg6100+debug (read only) 499800 499800 0 0.0
(read/write) 114140 114140 0 0.0
.bss 79904 79904 0 0.0
.data 948 948 0 0.0
.text 494480 494480 0 0.0
lock-app qpg6100+debug (read only) 472612 472612 0 0.0
(read/write) 114140 114140 0 0.0
.bss 78816 78816 0 0.0
.data 900 900 0 0.0
.text 467292 467292 0 0.0
persistent-storage-app qpg6100+debug (read only) 108208 108208 0 0.0
(read/write) 114140 114140 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102888 102888 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 782734 782734 0 0.0
bss 79976 79976 0 0.0
noinit 37160 37160 0 0.0
text 543976 543976 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given this is adding tests

@woody-apple woody-apple merged commit 3888258 into project-chip:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants