-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to chip-tool for sending the null value for nullable arguments. #12653
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nullable-chip-tool-arg
Dec 7, 2021
Merged
Add support to chip-tool for sending the null value for nullable arguments. #12653
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:nullable-chip-tool-arg
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments. It's represented as "null" on the command line. Warning: this might make it difficult to send the string value "null" for a nullable char string.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
December 7, 2021 04:57
pullapprove
bot
requested review from
selissia,
tecimovic,
vijs,
wbschiller and
woody-apple
December 7, 2021 04:57
PR #12653: Size comparison from 7871953 to 0932cd9 Increases above 0.2%:
Increases (1 build for linux)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given this is updating a test tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's represented as "null" on the command line.
Warning: this might make it difficult to send the string value "null"
for a nullable char string.
Problem
Can't set attributes to null via chip-tool command line, or set null for nullable command arguments.
Change overview
See above.
Testing
Manually tested that I can set the nullable-boolean and nullable-char-string attributes of TestCluster to both null and non-null values.