Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IM] Fabric filtered read #12710

Merged
merged 2 commits into from
Dec 9, 2021
Merged

[IM] Fabric filtered read #12710

merged 2 commits into from
Dec 9, 2021

Conversation

erjiaqing
Copy link
Contributor

Problem

Fabric filtered read is not supported.

Change overview

Implement IsFabricScoped

Testing

  • Updated unit tests for attribute value encoder.

erjiaqing added a commit to erjiaqing/connectedhomeip that referenced this pull request Dec 8, 2021
@erjiaqing
Update ZAP for project-chip#12710
15efd59
yunhanw-google pushed a commit that referenced this pull request Dec 8, 2021
@erjiaqing
Update ZAP for #12710 (#12713)
aeaed72
@erjiaqing erjiaqing force-pushed the im/fabric-filter-read branch from 9097e3b to c7bc7d2 Compare December 8, 2021 10:23
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12710: Size comparison from b9d8ef1 to c7bc7d2

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b9d8ef1 c7bc7d2 change % change
efr32 lighting-app BRD4161A (read only) 794704 794704 0 0.0
(read/write) 122992 122992 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 794696 794696 0 0.0
BRD4161A+rpc (read only) 782316 782316 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 782308 782308 0 0.0
window-app BRD4161A (read only) 771640 771640 0 0.0
(read/write) 121128 121128 0 0.0
.bss 119344 119344 0 0.0
.data 1784 1784 0 0.0
.text 771632 771632 0 0.0
esp32 all-clusters-app c3devkit (read only) 855576 855576 0 0.0
(read/write) 1305994 1305994 0 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171192 171192 0 0.0
.flash.text 855576 855576 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958283 958283 0 0.0
(read/write) 450236 450236 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209400 209400 0 0.0
.flash.text 952899 952899 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731932 731932 0 0.0
.bss 81240 81240 0 0.0
.data 1852 1852 0 0.0
.text 643040 643040 0 0.0
lock-app k32w061+debug (read/write) 622516 622516 0 0.0
.bss 71904 71904 0 0.0
.data 1820 1820 0 0.0
.text 542992 542992 0 0.0
shell k32w061+debug (read/write) 685608 685608 0 0.0
.bss 81604 81604 0 0.0
.data 1792 1792 0 0.0
.text 596412 596412 0 0.0
linux all-clusters-app debug (read only) 1903833 1903833 0 0.0
(read/write) 131584 131584 0 0.0
.bss 56688 56688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 68240 68240 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155812 155812 0 0.0
.text 1602258 1602258 0 0.0
bridge-app debug+rpc (read only) 1447629 1447629 0 0.0
(read/write) 77712 77712 0 0.0
.bss 39120 39120 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 31800 31800 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123580 123580 0 0.0
.text 1218837 1218837 0 0.0
chip-tool debug (read only) 6689749 6689749 0 0.0
(read/write) 202336 202336 0 0.0
.bss 35272 35272 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160360 160360 0 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 335753 335753 0 0.0
.text 5944901 5944901 0 0.0
lighting-app debug+rpc (read only) 1735377 1735377 0 0.0
(read/write) 110776 110776 0 0.0
.bss 44816 44816 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 59312 59312 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144444 144444 0 0.0
.text 1447954 1447954 0 0.0
ota-provider-app debug (read only) 1412041 1412041 0 0.0
(read/write) 75688 75688 0 0.0
.bss 41600 41600 0 0.0
.data 896 896 0 0.0
.data.rel.ro 28008 28008 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124990 124990 0 0.0
.text 1182146 1182146 0 0.0
ota-requestor-app debug (read only) 1516793 1516793 0 0.0
(read/write) 80704 80704 0 0.0
.bss 44768 44768 0 0.0
.data 960 960 0 0.0
.data.rel.ro 29768 29768 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137711 137711 0 0.0
.text 1270274 1270274 0 0.0
shell debug (read only) 828497 828497 0 0.0
(read/write) 60608 60608 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39000 39000 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 86226 86226 0 0.0
.text 635170 635170 0 0.0
tv-app debug (read only) 2044049 2044049 0 0.0
(read/write) 324120 324120 0 0.0
.bss 251160 251160 0 0.0
.data 2736 2736 0 0.0
.data.rel.ro 64408 64408 0 0.0
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 176572 176572 0 0.0
.text 1712450 1712450 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316008 2316008 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1278584 1278584 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298656 2298656 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1261256 1261256 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271568 2271568 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1234168 1234168 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896763 896763 0 0.0
bss 116176 116176 0 0.0
rodata 100132 100132 0 0.0
text 604900 604900 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 859803 0 0.0
bss 112524 112524 0 0.0
rodata 91428 91428 0 0.0
text 579628 579628 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822706 0 0.0
bss 117552 117552 0 0.0
rodata 95388 95388 0 0.0
text 535272 535272 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869199 869199 0 0.0
bss 113440 113440 0 0.0
rodata 96248 96248 0 0.0
text 584156 584156 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795386 795386 0 0.0
bss 114848 114848 0 0.0
rodata 91540 91540 0 0.0
text 514620 514620 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874099 0 0.0
bss 113352 113352 0 0.0
rodata 97604 97604 0 0.0
text 587672 587672 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867323 0 0.0
bss 113228 113228 0 0.0
rodata 95740 95740 0 0.0
text 582892 582892 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2349776 2349776 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1308040 1308040 0 0.0
light-app default (read/write) 2281080 2281080 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1239344 1239344 0 0.0
lock-app default (read/write) 2257168 2257168 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1215432 1215432 0 0.0
qpg lighting-app qpg6100+debug (read only) 511764 511764 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 506444 506444 0 0.0
lock-app qpg6100+debug (read only) 485948 485948 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 480628 480628 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800086 800086 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 557192 557192 0 0.0

@erjiaqing erjiaqing force-pushed the im/fabric-filter-read branch from c7bc7d2 to 7edbfc6 Compare December 8, 2021 15:04
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12710: Size comparison from a7dd25e to 7edbfc6

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a7dd25e 7edbfc6 change % change
efr32 lighting-app BRD4161A (read only) 794800 794800 0 0.0
(read/write) 122992 122992 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 794792 794792 0 0.0
BRD4161A+rpc (read only) 782412 782412 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 782404 782404 0 0.0
window-app BRD4161A (read only) 771736 771736 0 0.0
(read/write) 121128 121128 0 0.0
.bss 119344 119344 0 0.0
.data 1784 1784 0 0.0
.text 771728 771728 0 0.0
esp32 all-clusters-app c3devkit (read only) 855744 855744 0 0.0
(read/write) 1305994 1305994 0 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171192 171192 0 0.0
.flash.text 855744 855744 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958591 958591 0 0.0
(read/write) 450220 450220 0 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209392 209392 0 0.0
.flash.text 953207 953207 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731980 731980 0 0.0
.bss 81240 81240 0 0.0
.data 1852 1852 0 0.0
.text 643088 643088 0 0.0
lock-app k32w061+debug (read/write) 622564 622564 0 0.0
.bss 71904 71904 0 0.0
.data 1820 1820 0 0.0
.text 543040 543040 0 0.0
shell k32w061+debug (read/write) 685656 685656 0 0.0
.bss 81604 81604 0 0.0
.data 1792 1792 0 0.0
.text 596460 596460 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6664644 6664644 0 0.0
(read/write) 305201 305201 0 0.0
.bss 51649 51649 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 201888 201888 0 0.0
.dynamic 560 560 0 0.0
.got 46984 46984 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 338532 338532 0 0.0
.text 5681828 5681828 0 0.0
thermostat-no-ble arm64 (read only) 1905756 1905756 0 0.0
(read/write) 135825 135825 0 0.0
.bss 59457 59457 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69280 69280 0 0.0
.dynamic 560 560 0 0.0
.got 3456 3456 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 123932 123932 0 0.0
.text 1576976 1576976 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316200 2316200 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1278776 1278776 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298656 2298656 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1261256 1261256 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271632 2271632 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1234232 1234232 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896827 896827 0 0.0
bss 116176 116176 0 0.0
rodata 100132 100132 0 0.0
text 604956 604956 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859851 859851 0 0.0
bss 112524 112524 0 0.0
rodata 91428 91428 0 0.0
text 579684 579684 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822770 822770 0 0.0
bss 117552 117552 0 0.0
rodata 95388 95388 0 0.0
text 535328 535328 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869263 869263 0 0.0
bss 113440 113440 0 0.0
rodata 96248 96248 0 0.0
text 584208 584208 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795450 795450 0 0.0
bss 114848 114848 0 0.0
rodata 91540 91540 0 0.0
text 514676 514676 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874147 874147 0 0.0
bss 113352 113352 0 0.0
rodata 97604 97604 0 0.0
text 587728 587728 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867371 867371 0 0.0
bss 113228 113228 0 0.0
rodata 95740 95740 0 0.0
text 582944 582944 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523264 523264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443904 443904 0 0.0
p6 all-clusters-app default (read/write) 2350096 2350096 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1308360 1308360 0 0.0
light-app default (read/write) 2281176 2281176 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1239440 1239440 0 0.0
lock-app default (read/write) 2257264 2257264 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1215528 1215528 0 0.0
qpg lighting-app qpg6100+debug (read only) 511812 511812 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 506492 506492 0 0.0
lock-app qpg6100+debug (read only) 486004 486004 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 480684 480684 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800142 800142 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 557242 557242 0 0.0

mrjerryjohns
mrjerryjohns reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@mrjerryjohns mrjerryjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but otherwise, looking really good!

zzz_generated/app-common/app-common/zap-generated/cluster-objects.h Outdated Show resolved Hide resolved
src/app/data-model/FabricScoped.h Outdated Show resolved Hide resolved
src/app/tests/TestAttributeValueEncoder.cpp Show resolved Hide resolved
src/app/AttributeAccessInterface.h Outdated Show resolved Hide resolved
@erjiaqing erjiaqing force-pushed the im/fabric-filter-read branch from 7edbfc6 to 6468763 Compare December 9, 2021 03:20
@todo
Copy link

todo bot commented Dec 9, 2021

This unit tests contains hard code TLV data, they should be replaced with some decoding code to improve readability.

connectedhomeip/src/app/tests/TestAttributeValueEncoder.cpp

Lines 36 to 40 in 6468763

// TODO: This unit tests contains hard code TLV data, they should be replaced with some decoding code to improve readability.
namespace {
// These values are easier to be recognized in the encoded buffer

This comment was generated by todo based on a TODO comment in 6468763 in #12710. cc @erjiaqing.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12710: Size comparison from 1423df5 to 6468763

Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1423df5 6468763 change % change
efr32 lighting-app BRD4161A (read only) 804004 804004 0 0.0
(read/write) 122988 122988 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 803996 803996 0 0.0
BRD4161A+rpc (read only) 791616 791616 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 791608 791608 0 0.0
window-app BRD4161A (read only) 780716 780716 0 0.0
(read/write) 121120 121120 0 0.0
.bss 119336 119336 0 0.0
.data 1784 1784 0 0.0
.text 780708 780708 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724636 724636 0 0.0
.bss 81232 81232 0 0.0
.data 1852 1852 0 0.0
.text 635752 635752 0 0.0
lock-app k32w061+debug (read/write) 615796 615796 0 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 536280 536280 0 0.0
shell k32w061+debug (read/write) 679052 679052 0 0.0
.bss 81596 81596 0 0.0
.data 1792 1792 0 0.0
.text 589864 589864 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6786156 6786156 0 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342396 342396 0 0.0
.text 5782116 5782116 0 0.0
thermostat-no-ble arm64 (read only) 1931972 1931972 0 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124820 0 0.0
.text 1601424 1601424 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320136 2320136 0 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1282712 1282712 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305992 2305992 0 0.0
.bss 175696 175696 0 0.0
.data 5488 5488 0 0.0
.heap 855264 855264 0 0.0
.text 1268592 1268592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174736 174736 0 0.0
.data 5488 5488 0 0.0
.heap 856224 856224 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903283 903283 0 0.0
bss 116168 116168 0 0.0
rodata 101164 101164 0 0.0
text 610380 610380 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866307 866307 0 0.0
bss 112516 112516 0 0.0
rodata 92460 92460 0 0.0
text 585108 585108 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829274 829274 0 0.0
bss 117544 117544 0 0.0
rodata 96420 96420 0 0.0
text 540808 540808 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875527 0 0.0
bss 113432 113432 0 0.0
rodata 97280 97280 0 0.0
text 589440 589440 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801758 801758 0 0.0
bss 114840 114840 0 0.0
rodata 92568 92568 0 0.0
text 519964 519964 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880455 0 0.0
bss 113344 113344 0 0.0
rodata 98632 98632 0 0.0
text 593032 593032 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873651 873651 0 0.0
bss 113220 113220 0 0.0
rodata 96772 96772 0 0.0
text 588192 588192 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2356216 2356216 0 0.0
.bss 113116 113116 0 0.0
.data 2512 2512 0 0.0
.heap 917712 917712 0 0.0
.text 1314480 1314480 0 0.0
light-app default (read/write) 2290512 2290512 0 0.0
.bss 100888 100888 0 0.0
.data 2328 2328 0 0.0
.heap 930128 930128 0 0.0
.text 1248776 1248776 0 0.0
lock-app default (read/write) 2266376 2266376 0 0.0
.bss 99768 99768 0 0.0
.data 2288 2288 0 0.0
.heap 931288 931288 0 0.0
.text 1224640 1224640 0 0.0
qpg lighting-app qpg6100+debug (read only) 517944 517944 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 512624 512624 0 0.0
lock-app qpg6100+debug (read only) 491944 491944 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 486624 486624 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807470 807470 0 0.0
bss 82748 82748 0 0.0
noinit 37160 37160 0 0.0
text 563534 563534 0 0.0

@erjiaqing erjiaqing force-pushed the im/fabric-filter-read branch from 6468763 to 5434b82 Compare December 9, 2021 06:42
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12710: Size comparison from 6ea2c90 to 5434b82

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6ea2c90 5434b82 change % change
efr32 lighting-app BRD4161A (read only) 804092 804092 0 0.0
(read/write) 122988 122988 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 804084 804084 0 0.0
BRD4161A+rpc (read only) 791696 791696 0 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 791688 791688 0 0.0
window-app BRD4161A (read only) 780804 780804 0 0.0
(read/write) 121120 121120 0 0.0
.bss 119336 119336 0 0.0
.data 1784 1784 0 0.0
.text 780796 780796 0 0.0
esp32 all-clusters-app c3devkit (read only) 859206 859206 0 0.0
(read/write) 1306706 1306706 0 0.0
.dram0.bss 67632 67632 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171920 171920 0 0.0
.flash.text 859206 859206 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962535 962535 0 0.0
(read/write) 450980 450980 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210144 210144 0 0.0
.flash.text 957151 957151 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724652 724652 0 0.0
.bss 81232 81232 0 0.0
.data 1852 1852 0 0.0
.text 635768 635768 0 0.0
lock-app k32w061+debug (read/write) 615812 615812 0 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 536296 536296 0 0.0
shell k32w061+debug (read/write) 679068 679068 0 0.0
.bss 81596 81596 0 0.0
.data 1792 1792 0 0.0
.text 589880 589880 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6786172 6786172 0 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342396 342396 0 0.0
.text 5782132 5782132 0 0.0
thermostat-no-ble arm64 (read only) 1931988 1931988 0 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124820 0 0.0
.text 1601440 1601440 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320200 2320200 0 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1282776 1282776 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305992 2305992 0 0.0
.bss 175696 175696 0 0.0
.data 5488 5488 0 0.0
.heap 855264 855264 0 0.0
.text 1268592 1268592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174736 174736 0 0.0
.data 5488 5488 0 0.0
.heap 856224 856224 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903299 903299 0 0.0
bss 116168 116168 0 0.0
rodata 101164 101164 0 0.0
text 610392 610392 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866323 866323 0 0.0
bss 112516 112516 0 0.0
rodata 92460 92460 0 0.0
text 585120 585120 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829290 829290 0 0.0
bss 117544 117544 0 0.0
rodata 96420 96420 0 0.0
text 540820 540820 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875527 0 0.0
bss 113432 113432 0 0.0
rodata 97280 97280 0 0.0
text 589452 589452 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801774 801774 0 0.0
bss 114840 114840 0 0.0
rodata 92568 92568 0 0.0
text 519976 519976 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880455 0 0.0
bss 113344 113344 0 0.0
rodata 98632 98632 0 0.0
text 593044 593044 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873667 873667 0 0.0
bss 113220 113220 0 0.0
rodata 96772 96772 0 0.0
text 588204 588204 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2356232 2356232 0 0.0
.bss 113116 113116 0 0.0
.data 2512 2512 0 0.0
.heap 917712 917712 0 0.0
.text 1314496 1314496 0 0.0
light-app default (read/write) 2290528 2290528 0 0.0
.bss 100888 100888 0 0.0
.data 2328 2328 0 0.0
.heap 930128 930128 0 0.0
.text 1248792 1248792 0 0.0
lock-app default (read/write) 2266392 2266392 0 0.0
.bss 99768 99768 0 0.0
.data 2288 2288 0 0.0
.heap 931288 931288 0 0.0
.text 1224656 1224656 0 0.0
qpg lighting-app qpg6100+debug (read only) 517960 517960 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 512640 512640 0 0.0
lock-app qpg6100+debug (read only) 491960 491960 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 486640 486640 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807478 0 0.0
bss 82748 82748 0 0.0
noinit 37160 37160 0 0.0
text 563540 563540 0 0.0

@mrjerryjohns mrjerryjohns merged commit f2e7df8 into project-chip:master Dec 9, 2021
@todo todo bot mentioned this pull request Dec 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns mrjerryjohns left review comments

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

Assignees
No one assigned
Labels
app lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erjiaqing @andy31415 @msandstedt @mrjerryjohns @yunhanw-google @woody-apple