-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing Humidity sensor device type definition and fix typo in Contact sensor definition #12720
Merged
andy31415
merged 4 commits into
project-chip:master
from
fessehaeve:pull-request/fix-contactsensor-devicetype-name
Dec 9, 2021
Merged
Add missing Humidity sensor device type definition and fix typo in Contact sensor definition #12720
andy31415
merged 4 commits into
project-chip:master
from
fessehaeve:pull-request/fix-contactsensor-devicetype-name
Dec 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
approved these changes
Dec 8, 2021
PR #12720: Size comparison from b9d8ef1 to 6d00ad8 Full report (36 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
6d00ad8
to
5be6704
Compare
yunhanw-google
approved these changes
Dec 8, 2021
PR #12720: Size comparison from 1f4024a to 5be6704 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Dec 8, 2021
fast track: xml changes only |
woody-apple
approved these changes
Dec 9, 2021
5be6704
to
b74fbb8
Compare
PR #12720: Size comparison from 8adecf7 to b74fbb8 Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing
This does not affect any existing code as the contact sensor device type doesn't exist in any example application.