Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Add various Requestor API declarations #12755

Merged
merged 10 commits into from
Dec 10, 2021
Merged

[OTA] Add various Requestor API declarations #12755

merged 10 commits into from
Dec 10, 2021

Conversation

selissia
Copy link
Contributor

@selissia selissia commented Dec 8, 2021 •
edited
Loading

Problem

Several Requestor APIs need to be defined

Change overview

  • Added several application APIs to the OTARequestor and OTARequestorDriver class
  • Make TriggerImmediateQuery() return a result
  • Put all Requestor classes into the chip namespace

Note: As the download resumption functionality will not be delivered in 1.0 the TSG has requested that the corresponding API declarations are not committed. The download resumption API declarations are commented out in this PR.

Testing

Tested image download in a single Linux node:
rm -r /tmp/chip_*
./out/debug/chip-ota-provider-app -f /tmp/ota.txt
./out/chip-tool pairing onnetwork 1 20202021
./out/debug/chip-ota-requestor-app -u 5560 -d 42 -i ::1
./out/chip-tool pairing onnetwork-long 2 20202021 42
./out/chip-tool otasoftwareupdaterequestor announce-ota-provider 1 0 0 2 0

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12755: Size comparison from a5f849c to 0e65776

Full report (30 builds for efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section a5f849c 0e65776 change % change
efr32 lighting-app BRD4161A (read only) 803916 803916 0 0.0
(read/write) 122996 122996 0 0.0
.bss 121176 121176 0 0.0
.data 1820 1820 0 0.0
.text 803908 803908 0 0.0
BRD4161A+rpc (read only) 791528 791528 0 0.0
(read/write) 139680 139680 0 0.0
.bss 137752 137752 0 0.0
.data 1928 1928 0 0.0
.text 791520 791520 0 0.0
window-app BRD4161A (read only) 780868 780868 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 780860 780860 0 0.0
esp32 all-clusters-app c3devkit (read only) 858572 858572 0 0.0
(read/write) 1306658 1306658 0 0.0
.dram0.bss 67648 67648 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171856 171856 0 0.0
.flash.text 858572 858572 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 961799 961799 0 0.0
(read/write) 450948 450948 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210112 210112 0 0.0
.flash.text 956415 956415 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724500 724500 0 0.0
.bss 81248 81248 0 0.0
.data 1852 1852 0 0.0
.text 635600 635600 0 0.0
lock-app k32w061+debug (read/write) 615852 615852 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 536320 536320 0 0.0
shell k32w061+debug (read/write) 679108 679108 0 0.0
.bss 81612 81612 0 0.0
.data 1792 1792 0 0.0
.text 589904 589904 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319536 2319536 0 0.0
.bss 186900 186900 0 0.0
.data 5232 5232 0 0.0
.heap 844312 844312 0 0.0
.text 1282112 1282112 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305736 2305736 0 0.0
.bss 175712 175712 0 0.0
.data 5488 5488 0 0.0
.heap 855248 855248 0 0.0
.text 1268336 1268336 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278720 0 0.0
.bss 174752 174752 0 0.0
.data 5488 5488 0 0.0
.heap 856208 856208 0 0.0
.text 1241320 1241320 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903071 903071 0 0.0
bss 116184 116184 0 0.0
rodata 101208 101208 0 0.0
text 610132 610132 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 866111 866111 0 0.0
bss 112532 112532 0 0.0
rodata 92504 92504 0 0.0
text 584860 584860 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829078 829078 0 0.0
bss 117560 117560 0 0.0
rodata 96464 96464 0 0.0
text 540560 540560 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875539 875539 0 0.0
bss 113448 113448 0 0.0
rodata 97324 97324 0 0.0
text 589388 589388 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801786 801786 0 0.0
bss 114856 114856 0 0.0
rodata 92612 92612 0 0.0
text 519912 519912 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880403 880403 0 0.0
bss 113360 113360 0 0.0
rodata 98676 98676 0 0.0
text 592908 592908 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873631 873631 0 0.0
bss 113236 113236 0 0.0
rodata 96816 96816 0 0.0
text 588124 588124 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2355640 2355640 0 0.0
.bss 113132 113132 0 0.0
.data 2512 2512 0 0.0
.heap 917696 917696 0 0.0
.text 1313904 1313904 0 0.0
light-app default (read/write) 2290440 2290440 0 0.0
.bss 100904 100904 0 0.0
.data 2328 2328 0 0.0
.heap 930112 930112 0 0.0
.text 1248704 1248704 0 0.0
lock-app default (read/write) 2266528 2266528 0 0.0
.bss 99784 99784 0 0.0
.data 2288 2288 0 0.0
.heap 931272 931272 0 0.0
.text 1224792 1224792 0 0.0
qpg lighting-app qpg6100+debug (read only) 517776 517776 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82624 82624 0 0.0
.data 956 956 0 0.0
.text 512456 512456 0 0.0
lock-app qpg6100+debug (read only) 491976 491976 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81760 81760 0 0.0
.data 912 912 0 0.0
.text 486656 486656 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807106 807106 0 0.0
bss 82764 82764 0 0.0
noinit 37160 37160 0 0.0
text 563112 563112 0 0.0

@restyled-io restyled-io bot mentioned this pull request Dec 9, 2021
Closed
@selissia selissia changed the title Work In progress, Please ignore. Add various OTA Requestor API declarations Dec 9, 2021
@selissia selissia changed the title Add various OTA Requestor API declarations [OTA] Add various Requestor API declarations Dec 9, 2021
@selissia selissia marked this pull request as ready for review December 9, 2021 00:34
@boring-cyborg boring-cyborg bot added the lib label Dec 9, 2021
@restyled-io restyled-io bot mentioned this pull request Dec 9, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12755: Size comparison from a8b7f4b to 83a6ecf

Increases (1 build for linux)
platform target config section a8b7f4b 83a6ecf change % change
linux thermostat-no-ble arm64 (read only) 1935956 1935988 32 0.0
.text 1604944 1604976 32 0.0
Decreases (2 builds for k32w)
platform target config section a8b7f4b 83a6ecf change % change
k32w lighting-app k32w061+se05x+release (read/write) 726284 667856 -58428 -8.0
.bss 81248 73768 -7480 -9.2
.text 637384 586436 -50948 -8.0
shell k32w061+debug (read/write) 680684 622528 -58156 -8.5
.bss 81612 74132 -7480 -9.2
.text 591480 540804 -50676 -8.6
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section a8b7f4b 83a6ecf change % change
efr32 lighting-app BRD4161A (read only) 806372 806372 0 0.0
(read/write) 123004 123004 0 0.0
.bss 121184 121184 0 0.0
.data 1820 1820 0 0.0
.text 806364 806364 0 0.0
BRD4161A+rpc (read only) 794008 794008 0 0.0
(read/write) 139688 139688 0 0.0
.bss 137760 137760 0 0.0
.data 1928 1928 0 0.0
.text 794000 794000 0 0.0
window-app BRD4161A (read only) 783124 783124 0 0.0
(read/write) 121136 121136 0 0.0
.bss 119352 119352 0 0.0
.data 1784 1784 0 0.0
.text 783116 783116 0 0.0
esp32 all-clusters-app c3devkit (read only) 860328 860328 0 0.0
(read/write) 1307034 1307034 0 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172232 172232 0 0.0
.flash.text 860328 860328 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964299 964299 0 0.0
(read/write) 451332 451332 0 0.0
.dram0.bss 75008 75008 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210488 210488 0 0.0
.flash.text 958915 958915 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 726284 667856 -58428 -8.0
.bss 81248 73768 -7480 -9.2
.data 1852 1852 0 0.0
.text 637384 586436 -50948 -8.0
lock-app k32w061+debug (read/write) 617444 617444 0 0.0
.bss 71912 71912 0 0.0
.data 1820 1820 0 0.0
.text 537912 537912 0 0.0
shell k32w061+debug (read/write) 680684 622528 -58156 -8.5
.bss 81612 74132 -7480 -9.2
.data 1792 1792 0 0.0
.text 591480 540804 -50676 -8.6
linux chip-tool-ipv6only arm64 (read only) 6765708 6765708 0 0.0
(read/write) 317057 317057 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207832 207832 0 0.0
.dynamic 560 560 0 0.0
.got 52912 52912 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363372 363372 0 0.0
.text 5726612 5726612 0 0.0
thermostat-no-ble arm64 (read only) 1935956 1935988 32 0.0
(read/write) 136401 136401 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69800 69800 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 125092 125092 0 0.0
.text 1604944 1604976 32 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321408 2321408 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1283984 1283984 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307200 2307200 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1269800 1269800 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279992 2279992 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1242592 1242592 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047904 2047904 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010504 1010504 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904895 904895 0 0.0
bss 116184 116184 0 0.0
rodata 101448 101448 0 0.0
text 611708 611708 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 867919 867919 0 0.0
bss 112532 112532 0 0.0
rodata 92744 92744 0 0.0
text 586436 586436 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830886 830886 0 0.0
bss 117560 117560 0 0.0
rodata 96704 96704 0 0.0
text 542136 542136 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 877171 877171 0 0.0
bss 113448 113448 0 0.0
rodata 97564 97564 0 0.0
text 590768 590768 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803406 803406 0 0.0
bss 114856 114856 0 0.0
rodata 92856 92856 0 0.0
text 521288 521288 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 882087 882087 0 0.0
bss 113360 113360 0 0.0
rodata 98920 98920 0 0.0
text 594356 594356 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875263 875263 0 0.0
bss 113236 113236 0 0.0
rodata 97056 97056 0 0.0
text 589520 589520 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782067 782067 0 0.0
bss 109560 109560 0 0.0
rodata 74288 74288 0 0.0
text 523708 523708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697146 697146 0 0.0
bss 110540 110540 0 0.0
rodata 68932 68932 0 0.0
text 444352 444352 0 0.0
p6 all-clusters-app default (read/write) 2357576 2357576 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1315840 1315840 0 0.0
light-app default (read/write) 2291856 2291856 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1250120 1250120 0 0.0
lock-app default (read/write) 2267728 2267728 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1225992 1225992 0 0.0
qpg lighting-app qpg6100+debug (read only) 519580 519580 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82632 82632 0 0.0
.data 956 956 0 0.0
.text 514260 514260 0 0.0
lock-app qpg6100+debug (read only) 493572 493572 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81768 81768 0 0.0
.data 912 912 0 0.0
.text 488252 488252 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808882 808882 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 564614 564614 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12755: Size comparison from a8b7f4b to 1605e8a

Decreases (10 builds for nrfconnect, telink)
platform target config section a8b7f4b 1605e8a change % change
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904895 904791 -104 -0.0
bss 116184 116168 -16 -0.0
rodata 101448 101440 -8 -0.0
text 611708 611608 -100 -0.0
nrf52840dk_nrf52840+rpc (read/write) 867919 867819 -100 -0.0
bss 112532 112516 -16 -0.0
rodata 92744 92740 -4 -0.0
text 586436 586336 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830886 830786 -100 -0.0
bss 117560 117544 -16 -0.0
rodata 96704 96700 -4 -0.0
text 542136 542036 -100 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 877171 877023 -148 -0.0
bss 113448 113432 -16 -0.0
rodata 97564 97560 -4 -0.0
text 590768 590668 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803406 803270 -136 -0.0
bss 114856 114840 -16 -0.0
rodata 92856 92848 -8 -0.0
text 521288 521188 -100 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 882087 881951 -136 -0.0
bss 113360 113344 -16 -0.0
rodata 98920 98912 -8 -0.0
text 594356 594256 -100 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875263 875159 -104 -0.0
bss 113236 113220 -16 -0.0
rodata 97056 97048 -8 -0.0
text 589520 589420 -100 -0.0
shell nrf52840dk_nrf52840 (read/write) 782067 781947 -120 -0.0
bss 109560 109544 -16 -0.0
rodata 74288 74280 -8 -0.0
text 523708 523604 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697146 696994 -152 -0.0
bss 110540 110524 -16 -0.0
rodata 68932 68924 -8 -0.0
text 444352 444244 -108 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808882 808702 -180 -0.0
bss 82756 82736 -20 -0.0
text 564614 564470 -144 -0.0
Full report (11 builds for nrfconnect, telink)
platform target config section a8b7f4b 1605e8a change % change
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904895 904791 -104 -0.0
bss 116184 116168 -16 -0.0
rodata 101448 101440 -8 -0.0
text 611708 611608 -100 -0.0
nrf52840dk_nrf52840+rpc (read/write) 867919 867819 -100 -0.0
bss 112532 112516 -16 -0.0
rodata 92744 92740 -4 -0.0
text 586436 586336 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830886 830786 -100 -0.0
bss 117560 117544 -16 -0.0
rodata 96704 96700 -4 -0.0
text 542136 542036 -100 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 877171 877023 -148 -0.0
bss 113448 113432 -16 -0.0
rodata 97564 97560 -4 -0.0
text 590768 590668 -100 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803406 803270 -136 -0.0
bss 114856 114840 -16 -0.0
rodata 92856 92848 -8 -0.0
text 521288 521188 -100 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 882087 881951 -136 -0.0
bss 113360 113344 -16 -0.0
rodata 98920 98912 -8 -0.0
text 594356 594256 -100 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875263 875159 -104 -0.0
bss 113236 113220 -16 -0.0
rodata 97056 97048 -8 -0.0
text 589520 589420 -100 -0.0
shell nrf52840dk_nrf52840 (read/write) 782067 781947 -120 -0.0
bss 109560 109544 -16 -0.0
rodata 74288 74280 -8 -0.0
text 523708 523604 -104 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697146 696994 -152 -0.0
bss 110540 110524 -16 -0.0
rodata 68932 68924 -8 -0.0
text 444352 444244 -108 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808882 808702 -180 -0.0
bss 82756 82736 -20 -0.0
noinit 37160 37160 0 0.0
text 564614 564470 -144 -0.0

@restyled-io restyled-io bot mentioned this pull request Dec 9, 2021
Closed
@woody-apple woody-apple merged commit bd74dcd into project-chip:master Dec 10, 2021
@selissia selissia mentioned this pull request Dec 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@shubhamdp shubhamdp shubhamdp approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@selissia @tcarmelveilleux @shubhamdp @woody-apple @Damian-Nordic @restyled-commits