Update Matter TV clusters & TV app per latest spec. #12757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazarkov
changed the title
|
PR #12757: Size comparison from 4584707 to 4aeaff2 Increases above 0.2%:
Increases (3 builds for linux, mbed, p6)
Decreases (20 builds for efr32, esp32, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 9, 2021
woody-apple
approved these changes
Dec 9, 2021
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
3 times, most recently
from
ad40581 to
1671f17
Compare
pullapprove
bot
requested review from
andy31415,
austinh0,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
saurabhst and
selissia
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
from
5860883 to
2df1741
Compare
|
PR #12757: Size comparison from 83aac59 to 2df1741 Increases above 0.2%:
Increases (3 builds for linux, mbed, p6)
Decreases (5 builds for esp32, linux, mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
from
2df1741 to
d4b1578
Compare
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
from
d4b1578 to
cd90c60
Compare
|
PR #12757: Size comparison from 39a97d1 to cd90c60 Increases above 0.2%:
Increases (3 builds for linux, mbed, p6)
Decreases (5 builds for esp32, linux, mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
from
cd90c60 to
11ca777
Compare
|
PR #12757: Size comparison from b9baddc to 11ca777 Increases above 0.2%:
Increases (2 builds for linux, p6)
Decreases (2 builds for linux, p6)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
2 times, most recently
from
4d652ea to
4b5ef25
Compare
|
PR #12757: Size comparison from d27ac43 to 4b5ef25 Increases above 0.2%:
Increases (3 builds for linux, p6)
Decreases (8 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
from
4b5ef25 to
a86f6d0
Compare
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
2 times, most recently
from
9e74be6 to
2171635
Compare
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
2 times, most recently
from
d480b91 to
54f35e5
Compare
|
PR #12757: Size comparison from 572e168 to 54f35e5 Increases above 0.2%:
Increases (3 builds for linux, mbed, p6)
Decreases (3 builds for linux, mbed, p6)
Full report (17 builds for k32w, linux, mbed, p6, qpg, telink)
|
Fixed application launcher cluster Restyle fix Fixed tests Restyle fix Updated allowed vendor list attribute Restyle fix Disabled application basic cluster - allowed vendor list Run zap tool regen Restyle fix Re-Run of zap regen script Restyle fix Enable current navigator attribute in all cluster app. Restyle fix Re-run zap regen Restyle fix Updated tests per comments Added zap_regen Restyle fix Run zap regen tool Restyle fix Re-run zap regen code, to resolve conflicts Restyle fix Re-run zap regen code, to resolve conflicts Restyle fix Re-run zap regen code, to resolve conflicts Restyle fix Re-run zap regen code, to resolve conflicts Restyle fix Run zap regen code & restyle Run zap regen code & restyle
lazarkov
force-pushed
the
feature/update-clusters-per-spec
branch
from
54f35e5 to
f311b53
Compare
|
PR #12757: Size comparison from e76d65b to f311b53 Increases above 0.2%:
Increases (3 builds for linux, mbed, p6)
Decreases (5 builds for esp32, linux, mbed, p6)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
TV clusters were not updated per latest spec:
Change overview
see above
Testing
Run
./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "